)]}'
{"id":"openvpn~492","triplet_id":"openvpn~master~Iaef904ee2448dc0b9ad396d3ad9ae21b9dd6281e","project":"openvpn","branch":"master","topic":"coverity-fixes","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2024-01-09 12:30:03.000000000","reason":"Change was abandoned"},"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2024-01-09 12:29:46.000000000","reason":"\u003cGERRIT_ACCOUNT_1000001\u003e replied on the change","reason_account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}}},"hashtags":[],"change_id":"Iaef904ee2448dc0b9ad396d3ad9ae21b9dd6281e","subject":"adjust_payload_max_cbc: Fix Coverity issue \"Division or modulo by zero\"","status":"ABANDONED","created":"2024-01-09 11:08:56.000000000","updated":"2024-01-09 12:30:03.000000000","total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"29140eb668f6705e07bb40f7477238b4e3ac8a91","_number":492,"virtual_id_number":492,"owner":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-01-09 11:08:57.000000000","updated_by":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2024-01-09 11:08:57.000000000","updated_by":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"}],"messages":[{"id":"c591e08b08db8afc8a5647c6b6fa2a05d5ac28da","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2024-01-09 11:08:56.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"876e7ea44644309c3b97e5e6c6ebba5cb6c29f18","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2024-01-09 11:24:30.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"b6fd9e60efa89217b55adc9732bc40942e86f03f","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2024-01-09 12:29:46.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"29140eb668f6705e07bb40f7477238b4e3ac8a91","tag":"autogenerated:gerrit:abandon","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2024-01-09 12:30:03.000000000","message":"Abandoned\n\nCosmetic change only","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"742eb10f1d7254db24ce5e3b7898605c71303ce7","revisions":{"742eb10f1d7254db24ce5e3b7898605c71303ce7":{"kind":"REWORK","_number":1,"created":"2024-01-09 11:08:56.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/92/492/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/92/492/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/92/492/1 \u0026\u0026 git checkout -b change-492 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/92/492/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/92/492/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/92/492/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/92/492/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/92/492/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"0dffb9edac25f59c5f49b71d3e8902707e80e337","subject":"buf_string_match_head_str: Fix Coverity issue \"Unsigned compared against 0\""}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2024-01-09 11:02:59.000000000","tz":60},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2024-01-09 11:08:26.000000000","tz":60},"subject":"adjust_payload_max_cbc: Fix Coverity issue \"Division or modulo by zero\"","message":"adjust_payload_max_cbc: Fix Coverity issue \"Division or modulo by zero\"\n\nIn error cases cipher_kt_block_size can return 0.\nThis would lead to a divison by zero in round_down_uint.\nBy reordering the conditional we can make sure we only\ntake this path if we have a valid cipher to begin with.\n\nChange-Id: Iaef904ee2448dc0b9ad396d3ad9ae21b9dd6281e\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}