)]}'
{"id":"openvpn~497","triplet_id":"openvpn~master~Iefa4930cb1e8c4135056a17ceb4283fc13cc75c8","project":"openvpn","branch":"master","full_branch":"refs/heads/master","topic":"ntlm-v2","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2024-01-17 13:32:18.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2024-01-17 13:32:18.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Iefa4930cb1e8c4135056a17ceb4283fc13cc75c8","subject":"NTLM: increase size of phase 2 response we can handle","status":"MERGED","created":"2024-01-12 14:13:59.000000000","updated":"2024-01-17 13:32:18.000000000","submitted":"2024-01-17 13:32:18.000000000","submitter":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"497-ntlm-v2","meta_rev_id":"ccac54fa9aeb7d3c009d20568daf7a58e48ae528","_number":497,"virtual_id_number":497,"owner":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"reviewers":{"REVIEWER":[{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-01-12 14:13:59.000000000","updated_by":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"real_updated_by":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2024-01-12 14:13:59.000000000","updated_by":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"real_updated_by":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2024-01-17 09:08:19.000000000","updated_by":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"real_updated_by":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"state":"REVIEWER"}],"messages":[{"id":"20fbbb85c3129b65b40462a512adfca605f5f34e","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2024-01-12 14:13:59.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"979ef84b64d5896501027068894a7ebb8ad8d769","author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2024-01-17 09:08:19.000000000","message":"Patch Set 1: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"ccac54fa9aeb7d3c009d20568daf7a58e48ae528","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2024-01-17 13:32:18.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"6e010d4824b7251d817cf1770e80f186000b99ae","revisions":{"85ad1530ca411a07d67be532e3c62f6c9e0155e5":{"kind":"REWORK","_number":1,"created":"2024-01-12 14:13:59.000000000","uploader":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/97/497/1","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/97/497/1","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/97/497/1 \u0026\u0026 git checkout -b change-497 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/97/497/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/97/497/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/97/497/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/97/497/1","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/97/497/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"5a09f843d9355ddd8f313e38895b3cb151f817e3","subject":"NTLM: add length check to add_security_buffer"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2024-01-10 14:21:12.000000000","tz":60},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2024-01-10 14:50:21.000000000","tz":60},"subject":"NTLM: increase size of phase 2 response we can handle","message":"NTLM: increase size of phase 2 response we can handle\n\nWith NTLMv2 the target information buffer can be rather large\neven with normal domain setups.\n\nIn my test setup it was 152 bytes starting at offset 71.\nOverall the base64 encode phase 2 response was 300 byte long.\nThe linked documentation has 98 bytes at offset 60. 128 byte\nis clearly too low.\n\nWhile here improve the error messaging, so that if the buffer\nis too small at least one can determine that in the log.\n\nChange-Id: Iefa4930cb1e8c4135056a17ceb4283fc13cc75c8\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"6e010d4824b7251d817cf1770e80f186000b99ae":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":2,"created":"2024-01-17 13:32:18.000000000","uploader":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/97/497/2","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/97/497/2","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/97/497/2 \u0026\u0026 git checkout -b change-497 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/97/497/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/97/497/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/97/497/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/97/497/2","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/97/497/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"a021de2aabb21a24c7b69aaae1c710a9b6fee429","subject":"NTLM: add length check to add_security_buffer"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2024-01-17 09:08:39.000000000","tz":60},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2024-01-17 09:52:01.000000000","tz":60},"subject":"NTLM: increase size of phase 2 response we can handle","message":"NTLM: increase size of phase 2 response we can handle\n\nWith NTLMv2 the target information buffer can be rather large\neven with normal domain setups.\n\nIn my test setup it was 152 bytes starting at offset 71.\nOverall the base64 encode phase 2 response was 300 byte long.\nThe linked documentation has 98 bytes at offset 60. 128 byte\nis clearly too low.\n\nWhile here improve the error messaging, so that if the buffer\nis too small at least one can determine that in the log.\n\nChange-Id: Iefa4930cb1e8c4135056a17ceb4283fc13cc75c8\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\nAcked-by: Gert Doering \u003cgert@greenie.muc.de\u003e\nMessage-Id: \u003c20240117090840.32621-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg28040.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[]}
