)]}'
{"id":"openvpn~500","triplet_id":"openvpn~master~Iec74e88f86cd15328f993b6cdd0317ebda81563c","project":"openvpn","branch":"master","topic":"ntlm-v2","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2024-01-18 13:31:06.000000000","reason":"removed on reply"},"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2024-01-18 17:49:29.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Iec74e88f86cd15328f993b6cdd0317ebda81563c","subject":"NTLM: when NTLMv1 is requested, try NTLMv2 instead","status":"MERGED","created":"2024-01-12 14:13:59.000000000","updated":"2024-01-18 17:49:29.000000000","submitted":"2024-01-18 17:49:29.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"498-ntlm-v2","meta_rev_id":"6c153abf5da1fc4d1fcdeb34df369739eecfecd7","_number":500,"virtual_id_number":500,"owner":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-01-12 14:14:00.000000000","updated_by":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2024-01-12 14:14:00.000000000","updated_by":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"}],"messages":[{"id":"ae11bc782cbf79ecc6ba61769a2dcc2110a07dba","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2024-01-12 14:13:59.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"5ae6fce626c09c449ad8657e8ede61177257aa95","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2024-01-18 13:31:06.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"6c153abf5da1fc4d1fcdeb34df369739eecfecd7","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2024-01-18 17:49:29.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"b541a86948d7e9866b33e876fcf070fad00b3dce","revisions":{"3c52e6fd757d42e8d8ce8f7e12c86079c17d203a":{"kind":"REWORK","_number":1,"created":"2024-01-12 14:13:59.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/00/500/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/00/500/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/00/500/1 \u0026\u0026 git checkout -b change-500 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/00/500/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/00/500/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/00/500/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/00/500/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/00/500/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"1b8687656ed025625235df1cae08dde851cf5c8c","subject":"--http-proxy-user-pass: allow to specify in either order with --http-proxy"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2024-01-12 13:50:11.000000000","tz":60},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2024-01-12 13:58:39.000000000","tz":60},"subject":"NTLM: when NTLMv1 is requested, try NTLMv2 instead","message":"NTLM: when NTLMv1 is requested, try NTLMv2 instead\n\nCommit 21910ebc2ee8a6138eb2af8d38056d2b94e59f9c removed\nsupport for NTLMv1 authentication. This adjusts the\nbehavior for existing configurations that specify\n\"ntlm\" keyword.\n\nDo not error out hard, instead just try to upgrade. This\nshould work fine in many cases and will avoid breaking\nuser configs unnecessarily on upgrade.\n\nIn addition it fixes an issue with the mentioned patch\nwhere \"auto\" wasn\u0027t working correctly for NTLM anymore.\n\nChange-Id: Iec74e88f86cd15328f993b6cdd0317ebda81563c\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"b541a86948d7e9866b33e876fcf070fad00b3dce":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":2,"created":"2024-01-18 17:49:29.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/00/500/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/00/500/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/00/500/2 \u0026\u0026 git checkout -b change-500 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/00/500/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/00/500/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/00/500/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/00/500/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/00/500/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"d3f84afedd33734416704d5d92e8d3ac639ef491","subject":"proxy-options.rst: Add proper documentation for --http-proxy-user-pass"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2024-01-18 15:12:42.000000000","tz":60},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2024-01-18 17:07:06.000000000","tz":60},"subject":"NTLM: when NTLMv1 is requested, try NTLMv2 instead","message":"NTLM: when NTLMv1 is requested, try NTLMv2 instead\n\nCommit 21910ebc2ee8a6138eb2af8d38056d2b94e59f9c removed\nsupport for NTLMv1 authentication. This adjusts the\nbehavior for existing configurations that specify\n\"ntlm\" keyword.\n\nDo not error out hard, instead just try to upgrade. This\nshould work fine in many cases and will avoid breaking\nuser configs unnecessarily on upgrade.\n\nIn addition it fixes an issue with the mentioned patch\nwhere \"auto\" wasn\u0027t working correctly for NTLM anymore.\n\nChange-Id: Iec74e88f86cd15328f993b6cdd0317ebda81563c\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\nAcked-by: Arne Schwabe \u003carne-openvpn@rfc2549.org\u003e\nMessage-Id: \u003c20240118151242.12169-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/search?l\u003dmid\u0026q\u003d20240118151242.12169-1-gert@greenie.muc.de\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
