)]}'
{"id":"openvpn~501","triplet_id":"openvpn~master~Ib1a5c788269949d8de95d1da2cb0c32a65bf13f2","project":"openvpn","branch":"master","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2024-01-17 14:02:45.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2024-01-17 14:02:45.000000000","reason":"Change was submitted"},"1000006":{"account":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"last_update":"2024-01-17 14:02:45.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Ib1a5c788269949d8de95d1da2cb0c32a65bf13f2","subject":"cmake: symlink whole build dir not just .json file","status":"MERGED","created":"2024-01-17 03:49:56.000000000","updated":"2024-01-17 14:02:45.000000000","submitted":"2024-01-17 14:02:45.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"501","meta_rev_id":"1e73ec5867b36565edac68efff68a77b346beb20","_number":501,"virtual_id_number":501,"owner":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"value":0,"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}],"reviewers":{"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}],"REVIEWER":[{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-01-17 03:49:57.000000000","updated_by":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2024-01-17 03:49:57.000000000","updated_by":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"reviewer":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"state":"REVIEWER"},{"updated":"2024-01-17 03:49:57.000000000","updated_by":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2024-01-17 09:23:58.000000000","updated_by":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"reviewer":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"state":"REVIEWER"},{"updated":"2024-01-17 13:38:15.000000000","updated_by":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"state":"REVIEWER"}],"messages":[{"id":"04a6170f978070cd5e8d20443e643394772ed1db","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"date":"2024-01-17 03:49:56.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"c1252bac42b23820fa0271714b62d7a02d702153","author":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"date":"2024-01-17 09:23:58.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"be9d798d09d5aed7b0d94fb3853dcf83a01c58ad","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2024-01-17 13:38:15.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"e2131453ec7f4c5aff15ec8f631d52dcccb30692","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2024-01-17 13:48:33.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"1e73ec5867b36565edac68efff68a77b346beb20","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2024-01-17 14:02:45.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"4bcb38c42ae62a3c3511511eb4ffe0d66b8e32eb","revisions":{"534826e894c53b2bdcd335e2dc3d79c70eb85b3c":{"kind":"REWORK","_number":1,"created":"2024-01-17 03:49:56.000000000","uploader":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"ref":"refs/changes/01/501/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/01/501/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/01/501/1 \u0026\u0026 git checkout -b change-501 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/01/501/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/01/501/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/01/501/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/01/501/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/01/501/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"60fa86049f67d9bb39f27f0f1bdf7d4275f41ceb","subject":"cmake: create and link compile_commands.json file"}],"author":{"name":"Heiko Hund","email":"heiko@ist.eigentlich.net","date":"2024-01-16 14:19:55.000000000","tz":60},"committer":{"name":"Heiko Hund","email":"heiko@ist.eigentlich.net","date":"2024-01-17 03:46:15.000000000","tz":60},"subject":"cmake: symlink whole build dir not just .json file","message":"cmake: symlink whole build dir not just .json file\n\nIt turned out that symlinking compile_commands.json from the top level\nsource dir has some issues:\n  * file is not created on Windows and symlinking may cause an error\n  * some IDEs create their own json and error out b/c a file exists\n\nSince clangd also looks for the json in build/ directories by default,\nwe now symlink the whole build directory instead, not just the json file.\n\nThis approach requires for the existing build/ dir in the repo to\nvanish. Luckily it only contains one automake include file, which is\nmoved to the top level source dir.\n\nLastly, make this an opt-in feature, so that the default configuration\nof the buildsystem never causes a build failure because of this.\n\nChange-Id: Ib1a5c788269949d8de95d1da2cb0c32a65bf13f2\nSigned-off-by: Heiko Hund \u003cheiko@ist.eigentlich.net\u003e\n"},"branch":"refs/heads/master"},"4bcb38c42ae62a3c3511511eb4ffe0d66b8e32eb":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":2,"created":"2024-01-17 14:02:45.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/01/501/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/01/501/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/01/501/2 \u0026\u0026 git checkout -b change-501 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/01/501/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/01/501/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/01/501/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/01/501/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/01/501/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"6e010d4824b7251d817cf1770e80f186000b99ae","subject":"NTLM: increase size of phase 2 response we can handle"}],"author":{"name":"Heiko Hund","email":"heiko@ist.eigentlich.net","date":"2024-01-17 13:49:29.000000000","tz":60},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2024-01-17 14:01:54.000000000","tz":60},"subject":"cmake: symlink whole build dir not just .json file","message":"cmake: symlink whole build dir not just .json file\n\nIt turned out that symlinking compile_commands.json from the top level\nsource dir has some issues:\n  * file is not created on Windows and symlinking may cause an error\n  * some IDEs create their own json and error out b/c a file exists\n\nSince clangd also looks for the json in build/ directories by default,\nwe now symlink the whole build directory instead, not just the json file.\n\nThis approach requires for the existing build/ dir in the repo to\nvanish. Luckily it only contains one automake include file, which is\nmoved to the top level source dir.\n\nLastly, make this an opt-in feature, so that the default configuration\nof the buildsystem never causes a build failure because of this.\n\nChange-Id: Ib1a5c788269949d8de95d1da2cb0c32a65bf13f2\nSigned-off-by: Heiko Hund \u003cheiko@ist.eigentlich.net\u003e\nAcked-by: Gert Doering \u003cgert@greenie.muc.de\u003e\nMessage-Id: \u003c20240117134929.5317-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg28061.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}