)]}'
{"id":"openvpn~504","triplet_id":"openvpn~master~I5c06dc13e9d8ab73997f79b13c30ee8949e5e993","project":"openvpn","branch":"master","full_branch":"refs/heads/master","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2024-01-23 18:53:24.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2024-01-23 10:39:42.000000000","reason":"removed on reply"}},"hashtags":[],"change_id":"I5c06dc13e9d8ab73997f79b13c30ee8949e5e993","subject":"Ensure that all unit tests use unbuffered stdout and stderr","status":"MERGED","created":"2024-01-22 12:45:09.000000000","updated":"2024-01-23 18:53:24.000000000","submitted":"2024-01-23 18:53:24.000000000","submitter":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"504","meta_rev_id":"eab6bebeb2a706a96ce17a5ca72aa4eac03330b6","_number":504,"virtual_id_number":504,"owner":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"value":0,"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-01-22 12:45:09.000000000","updated_by":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"real_updated_by":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2024-01-22 12:45:09.000000000","updated_by":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"real_updated_by":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"reviewer":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"state":"REVIEWER"}],"messages":[{"id":"71b511e47c2f4e210e4a56548f159d1536b9d2a5","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2024-01-22 12:45:09.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"57d4c63f8b5127928714738ff4ef346d8ecfe775","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2024-01-22 12:50:24.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"566acce01df4b38747c99ce40971df0129e562ed","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2024-01-22 13:07:38.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"c5ba55c6a3b6bc81c2ec4e21721c902b9caf50c1","author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2024-01-22 13:21:43.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"d2fabcd795ccbf4a91687841fc03743e0cf35322","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2024-01-22 15:38:56.000000000","message":"Uploaded patch set 4.\n\nOutdated Votes:\n* Code-Review+2 (copy condition: \"changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR is:MIN\")\n","accounts_in_message":[],"_revision_number":4},{"id":"2b3063ffb5c094d8b2991688e803c811a1f19aee","author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2024-01-23 10:39:42.000000000","message":"Patch Set 4: Code-Review+2","accounts_in_message":[],"_revision_number":4},{"id":"eab6bebeb2a706a96ce17a5ca72aa4eac03330b6","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2024-01-23 18:53:24.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":5}],"current_revision_number":5,"current_revision":"7869617a0f85089fb5e6fbe2db6f03542a8f33f4","revisions":{"3ccfa5260413d37f9852e9fa37d0a15071fb7cb3":{"kind":"REWORK","_number":1,"created":"2024-01-22 12:45:09.000000000","uploader":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"ref":"refs/changes/04/504/1","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/04/504/1","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/04/504/1 \u0026\u0026 git checkout -b change-504 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/04/504/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/04/504/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/04/504/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/04/504/1","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/04/504/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"841932620435b89f4cb8955264525dc467600e28","subject":"Fix ssl unit tests on OpenSSL 1.0.2"}],"author":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2024-01-22 12:40:46.000000000","tz":60},"committer":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2024-01-22 12:44:17.000000000","tz":60},"subject":"Ensure that all unit tests use unbuffered stdout and stderr","message":"Ensure that all unit tests use unbuffered stdout and stderr\n\nstderr is normally always unbuffered but stdout can be buffered. Especially,\nwhen stdout is redirected it will become buffered while it is normally\nunbuffered when connected to a terminal. This mean that if the unit exits\nprematurely, the output in the buffered output will be lost.\n\nAs the unit test x_msg mock implementation prints even fatal on stdout\nwe ensure with this setup method that stdout is also unbuffered.\n\nChange-Id: I5c06dc13e9d8ab73997f79b13c30ee8949e5e993\n"},"branch":"refs/heads/master"},"fca77e0910cde848d84dd158e274e82c2c204668":{"kind":"REWORK","_number":2,"created":"2024-01-22 12:50:24.000000000","uploader":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"ref":"refs/changes/04/504/2","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/04/504/2","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/04/504/2 \u0026\u0026 git checkout -b change-504 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/04/504/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/04/504/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/04/504/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/04/504/2","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/04/504/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"841932620435b89f4cb8955264525dc467600e28","subject":"Fix ssl unit tests on OpenSSL 1.0.2"}],"author":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2024-01-22 12:40:46.000000000","tz":60},"committer":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2024-01-22 12:50:16.000000000","tz":60},"subject":"Ensure that all unit tests use unbuffered stdout and stderr","message":"Ensure that all unit tests use unbuffered stdout and stderr\n\nstderr is normally always unbuffered but stdout can be buffered. Especially,\nwhen stdout is redirected it will become buffered while it is normally\nunbuffered when connected to a terminal. This mean that if the unit exits\nprematurely, the output in the buffered output will be lost.\n\nAs the unit test x_msg mock implementation prints even fatal on stdout\nwe ensure with this setup method that stdout is also unbuffered.\n\nChange-Id: I5c06dc13e9d8ab73997f79b13c30ee8949e5e993\n"},"branch":"refs/heads/master"},"81aaaba7bef9cd1fa2b76b73235d00c26aefe7c4":{"kind":"REWORK","_number":3,"created":"2024-01-22 13:07:38.000000000","uploader":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"ref":"refs/changes/04/504/3","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/04/504/3","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/04/504/3 \u0026\u0026 git checkout -b change-504 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/04/504/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/04/504/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/04/504/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/04/504/3","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/04/504/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"841932620435b89f4cb8955264525dc467600e28","subject":"Fix ssl unit tests on OpenSSL 1.0.2"}],"author":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2024-01-22 12:40:46.000000000","tz":60},"committer":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2024-01-22 13:06:38.000000000","tz":60},"subject":"Ensure that all unit tests use unbuffered stdout and stderr","message":"Ensure that all unit tests use unbuffered stdout and stderr\n\nstderr is normally always unbuffered but stdout can be buffered. Especially,\nwhen stdout is redirected it will become buffered while it is normally\nunbuffered when connected to a terminal. This mean that if the unit exits\nprematurely, the output in the buffered output will be lost.\n\nAs the unit test x_msg mock implementation prints even fatal on stdout\nwe ensure with this setup method that stdout is also unbuffered.\n\nChange-Id: I5c06dc13e9d8ab73997f79b13c30ee8949e5e993\n"},"branch":"refs/heads/master"},"25d2f54073e9ac88b047873348ac43d76a3c32a5":{"kind":"REWORK","_number":4,"created":"2024-01-22 15:38:56.000000000","uploader":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"ref":"refs/changes/04/504/4","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/04/504/4","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/04/504/4 \u0026\u0026 git checkout -b change-504 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/04/504/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/04/504/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/04/504/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/04/504/4","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/04/504/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"dc4fde8052639ffbc29ccc87130a0ce25f6dcd6c","subject":"Fix ssl unit tests on OpenSSL 1.0.2"}],"author":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2024-01-22 12:40:46.000000000","tz":60},"committer":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2024-01-22 15:38:45.000000000","tz":60},"subject":"Ensure that all unit tests use unbuffered stdout and stderr","message":"Ensure that all unit tests use unbuffered stdout and stderr\n\nstderr is normally always unbuffered but stdout can be buffered. Especially,\nwhen stdout is redirected it will become buffered while it is normally\nunbuffered when connected to a terminal. This mean that if the unit exits\nprematurely, the output in the buffered output will be lost.\n\nAs the unit test x_msg mock implementation prints even fatal on stdout\nwe ensure with this setup method that stdout is also unbuffered.\n\nChange-Id: I5c06dc13e9d8ab73997f79b13c30ee8949e5e993\n"},"branch":"refs/heads/master"},"7869617a0f85089fb5e6fbe2db6f03542a8f33f4":{"kind":"NO_CODE_CHANGE","_number":5,"created":"2024-01-23 18:53:24.000000000","uploader":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/04/504/5","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/04/504/5","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/04/504/5 \u0026\u0026 git checkout -b change-504 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/04/504/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/04/504/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/04/504/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/04/504/5","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/04/504/5 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"dc4fde8052639ffbc29ccc87130a0ce25f6dcd6c","subject":"Fix ssl unit tests on OpenSSL 1.0.2"}],"author":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2024-01-23 10:43:58.000000000","tz":60},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2024-01-23 15:34:50.000000000","tz":60},"subject":"Ensure that all unit tests use unbuffered stdout and stderr","message":"Ensure that all unit tests use unbuffered stdout and stderr\n\nstderr is normally always unbuffered but stdout can be buffered. Especially,\nwhen stdout is redirected it will become buffered while it is normally\nunbuffered when connected to a terminal. This mean that if the unit exits\nprematurely, the output in the buffered output will be lost.\n\nAs the unit test x_msg mock implementation prints even fatal on stdout\nwe ensure with this setup method that stdout is also unbuffered.\n\nChange-Id: I5c06dc13e9d8ab73997f79b13c30ee8949e5e993\nAcked-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\nMessage-Id: \u003c20240123104358.495517-1-frank@lichtenheld.com\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg28122.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[]}
