)]}'
{"id":"openvpn~522","triplet_id":"openvpn~master~I8a67b82eb4afdc8d82c5a879c18457b41e77cbe7","project":"openvpn","branch":"master","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2024-09-17 10:40:42.000000000","reason":"Change was submitted"},"1000034":{"account":{"_account_id":1000034,"name":"its_Giaan","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"last_update":"2024-09-17 10:40:42.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2024-02-20 13:32:23.000000000","reason":"removed on reply"}},"hashtags":["mailsubmitted"],"change_id":"I8a67b82eb4afdc8d82c5a879c18457b41e77cbe7","subject":"Route: remove incorrect routes on exit","status":"MERGED","created":"2024-02-15 08:48:52.000000000","updated":"2024-09-17 10:40:42.000000000","submitted":"2024-09-17 10:40:42.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"522","meta_rev_id":"4cc89578cc616a5526fab920e0872fddae02549d","_number":522,"virtual_id_number":522,"owner":{"_account_id":1000034,"name":"its_Giaan","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"value":0,"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"default_value":0}},"removable_reviewers":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-02-15 08:48:53.000000000","updated_by":{"_account_id":1000034,"name":"its_Giaan","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2024-02-15 08:48:53.000000000","updated_by":{"_account_id":1000034,"name":"its_Giaan","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"reviewer":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"state":"REVIEWER"},{"updated":"2024-02-15 08:48:53.000000000","updated_by":{"_account_id":1000034,"name":"its_Giaan","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"}],"messages":[{"id":"2e55b166ccd58e66824b9c2cd8dedaec79b1ce94","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000034,"name":"its_Giaan","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"date":"2024-02-15 08:48:52.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"96d845ea40dde021de40d2af0234c19ebcacc258","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2024-02-16 15:32:14.000000000","message":"Patch Set 1: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"5e8608f0a84866168dc58c3a0f31465ee8de45d8","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000034,"name":"its_Giaan","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"date":"2024-02-19 12:46:00.000000000","message":"Uploaded patch set 2: Commit message was updated.\n\nOutdated Votes:\n* Code-Review+2 (copy condition: \"changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR is:MIN\")\n","accounts_in_message":[],"_revision_number":2},{"id":"3d86870e03bc8885178128d2b347224d31b152c8","author":{"_account_id":1000034,"name":"its_Giaan","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"date":"2024-02-20 09:20:46.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"c53df794293ac58e48b749da499e3f1b00585716","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2024-02-20 13:32:23.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"f5c37c8d850492e23082e87ea381134e6df836d8","tag":"autogenerated:gerrit:setHashtag","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2024-02-21 11:18:26.000000000","message":"Hashtag added: mailsubmitted","accounts_in_message":[],"_revision_number":2},{"id":"4cc89578cc616a5526fab920e0872fddae02549d","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2024-09-17 10:40:42.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"14d2db6cd41fb6414992869caf109972d7a8275e","revisions":{"02fb435466741845d2448d35b99938d663c4d3b0":{"kind":"REWORK","_number":1,"created":"2024-02-15 08:48:52.000000000","uploader":{"_account_id":1000034,"name":"its_Giaan","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"ref":"refs/changes/22/522/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/22/522/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/22/522/1 \u0026\u0026 git checkout -b change-522 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/22/522/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/22/522/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/22/522/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/22/522/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/22/522/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"7869617a0f85089fb5e6fbe2db6f03542a8f33f4","subject":"Ensure that all unit tests use unbuffered stdout and stderr"}],"author":{"name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","date":"2023-04-07 11:05:15.000000000","tz":120},"committer":{"name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","date":"2024-02-15 08:46:57.000000000","tz":60},"subject":"Route: remove uncorrect routes on exit.","message":"Route: remove uncorrect routes on exit.\n\nImplemented a safeguard to verify the returned value\nfrom add_route3() when the default gateway is not a local\nremote host.\n\nPrior to this implementation, RT_DID_LOCAL flag was\nerroneously set even in case of add_route3() failure.\nThis problem typically occurs when there\u0027s no default\nroute and the --redirect-gateway def1 option is specified,\nand in case of reconnection makes it impossible for the client\nto reobtain the route to the server.\nThis fix ensures OpenVPN accurately deletes the appropriate\nroute on exit by properly handling add_route3() return value.\n\nFixes: Trac #1457\nChange-Id: I8a67b82eb4afdc8d82c5a879c18457b41e77cbe7\nSigned-off-by: Gianmarco De Gregori \u003cgianmarco@mandelbit.com\u003e\n"},"branch":"refs/heads/master"},"bdb7c7f9538cc3cdb6cc861a25a37c51484092bc":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2024-02-19 12:46:00.000000000","uploader":{"_account_id":1000034,"name":"its_Giaan","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"ref":"refs/changes/22/522/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/22/522/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/22/522/2 \u0026\u0026 git checkout -b change-522 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/22/522/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/22/522/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/22/522/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/22/522/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/22/522/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"7869617a0f85089fb5e6fbe2db6f03542a8f33f4","subject":"Ensure that all unit tests use unbuffered stdout and stderr"}],"author":{"name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","date":"2023-04-07 11:05:15.000000000","tz":120},"committer":{"name":"itsGiaan","email":"gianmarcod95@outlook.com","date":"2024-02-19 12:44:24.000000000","tz":60},"subject":"Route: remove incorrect routes on exit","message":"Route: remove incorrect routes on exit\n\nImplemented a safeguard to verify the returned value\nfrom add_route3() when the default gateway is not a local\nremote host.\n\nPrior to this implementation, RT_DID_LOCAL flag was\nerroneously set even in case of add_route3() failure.\nThis problem typically occurs when there\u0027s no default\nroute and the --redirect-gateway def1 option is specified,\nand in case of reconnection makes it impossible for the client\nto reobtain the route to the server.\nThis fix ensures OpenVPN accurately deletes the appropriate\nroute on exit by properly handling add_route3() return value.\n\nFixes: Trac #1457\nChange-Id: I8a67b82eb4afdc8d82c5a879c18457b41e77cbe7\nSigned-off-by: Gianmarco De Gregori \u003cgianmarco@mandelbit.com\u003e\n"},"branch":"refs/heads/master"},"14d2db6cd41fb6414992869caf109972d7a8275e":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":3,"created":"2024-09-17 10:40:42.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/22/522/3","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/22/522/3","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/22/522/3 \u0026\u0026 git checkout -b change-522 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/22/522/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/22/522/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/22/522/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/22/522/3","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/22/522/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"7d345b19e20f30cb2ecbea71682b5a41e6cff454","subject":"Fix check_addr_clash argument order"}],"author":{"name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","date":"2024-02-21 11:18:14.000000000","tz":60},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2024-09-17 10:24:37.000000000","tz":120},"subject":"Route: remove incorrect routes on exit","message":"Route: remove incorrect routes on exit\n\nImplemented a safeguard to verify the returned value\nfrom add_route3() when the default gateway is not a local\nremote host.\n\nPrior to this implementation, RT_DID_LOCAL flag was\nerroneously set even in case of add_route3() failure.\nThis problem typically occurs when there\u0027s no default\nroute and the --redirect-gateway def1 option is specified,\nand in case of reconnection makes it impossible for the client\nto reobtain the route to the server.\nThis fix ensures OpenVPN accurately deletes the appropriate\nroute on exit by properly handling add_route3() return value.\n\nTrac: #1457\nChange-Id: I8a67b82eb4afdc8d82c5a879c18457b41e77cbe7\nSigned-off-by: Gianmarco De Gregori \u003cgianmarco@mandelbit.com\u003e\nAcked-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\nMessage-Id: \u003c20240221111814.942965-1-frank@lichtenheld.com\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg28290.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}