)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"c603438e3793f0cd38b3bbfeff13c07f910c5941","unresolved":true,"context_lines":[{"line_number":18,"context_line":"every time."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"The nocache member has been added to the struct"},{"line_number":21,"context_line":"http_proxy_options and also a getter method to retrieve"},{"line_number":22,"context_line":"that option from ssl has been added, by doing this"},{"line_number":23,"context_line":"we\u0027re able to erase previous queried user credentials"},{"line_number":24,"context_line":"to ensure correct operation."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"0095e7d0_7032f979","line":21,"updated":"2024-03-11 14:45:37.000000000","message":"The man page for --auth-nocache still says it has no effect on --http-proxy. This needs to be updated.","commit_id":"a945ed1982428dc7c04ceffe1df160685d72bb0c"},{"author":{"_account_id":1000034,"name":"its_Giaan","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"change_message_id":"88b1f09ddf5020ba5af6961fe55e189cf2a21016","unresolved":false,"context_lines":[{"line_number":18,"context_line":"every time."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"The nocache member has been added to the struct"},{"line_number":21,"context_line":"http_proxy_options and also a getter method to retrieve"},{"line_number":22,"context_line":"that option from ssl has been added, by doing this"},{"line_number":23,"context_line":"we\u0027re able to erase previous queried user credentials"},{"line_number":24,"context_line":"to ensure correct operation."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"87905ca4_736be2e0","line":21,"in_reply_to":"0095e7d0_7032f979","updated":"2024-03-12 08:36:36.000000000","message":"Done","commit_id":"a945ed1982428dc7c04ceffe1df160685d72bb0c"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"77fd9c96c5b0d6ce30c0ad5b2766ae2d1a8459b4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"2f32f1af_1fee89dc","updated":"2024-02-16 16:01:38.000000000","message":"Definitely has issues","commit_id":"f08955c33218a3ab0aee7215199c595202ac9f71"},{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"9a704c5c90476d340780542c30a03373d9e53ed6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"6f4b8921_dd4780c2","updated":"2024-03-11 12:29:43.000000000","message":"Tried to test this change but my tests failed to produce the desired behavior. Should figure out the problem before merging.","commit_id":"a945ed1982428dc7c04ceffe1df160685d72bb0c"},{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"ad31d45d8d2d94a5a795bd6da8b73294014c76d8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"36a452b8_7ca56d47","updated":"2024-03-12 13:36:07.000000000","message":"almost there...","commit_id":"b9b05b775767f860653452173f9c2d7ec6db7cf2"},{"author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"08bb0b66d2adaa484806f3ea00bb45a936fcb6a2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"6e0f778f_8961affa","updated":"2024-06-19 10:17:14.000000000","message":"Minor nitpick: function call and prototype having empty brackets `()` instead of proper `(void)`.  This needs to be fixed, and I can\u0027t do code changes on merge.","commit_id":"826e38c434439f9c4dd12261391a84314ee7fb06"},{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"75e765006023cf355024676b08a7e30d8e36e10c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"0ed2619b_9c34d4b8","updated":"2024-03-12 16:36:48.000000000","message":"Tested with \"stdin ntlm\" and \"auto\" against the community NTLM proxy. With and without --auth-nocache.","commit_id":"826e38c434439f9c4dd12261391a84314ee7fb06"}],"src/openvpn/options.c":[{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"77fd9c96c5b0d6ce30c0ad5b2766ae2d1a8459b4","unresolved":true,"context_lines":[{"line_number":1858,"context_line":"    SHOW_BOOL(persist_local_ip);"},{"line_number":1859,"context_line":"    SHOW_BOOL(persist_remote_ip);"},{"line_number":1860,"context_line":"    SHOW_BOOL(persist_key);"},{"line_number":1861,"context_line":"    SHOW_BOOL(ce.http_proxy_options-\u003enocache);"},{"line_number":1862,"context_line":""},{"line_number":1863,"context_line":"#if PASSTOS_CAPABILITY"},{"line_number":1864,"context_line":"    SHOW_BOOL(passtos);"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"a2ced5bd_47c89245","line":1861,"updated":"2024-02-16 16:01:38.000000000","message":"This belongs into show_connection_entry like the other o-\u003ece options","commit_id":"f08955c33218a3ab0aee7215199c595202ac9f71"},{"author":{"_account_id":1000034,"name":"its_Giaan","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"change_message_id":"e2a873df6dc61c2598310c0d4e289c5df865f674","unresolved":false,"context_lines":[{"line_number":1858,"context_line":"    SHOW_BOOL(persist_local_ip);"},{"line_number":1859,"context_line":"    SHOW_BOOL(persist_remote_ip);"},{"line_number":1860,"context_line":"    SHOW_BOOL(persist_key);"},{"line_number":1861,"context_line":"    SHOW_BOOL(ce.http_proxy_options-\u003enocache);"},{"line_number":1862,"context_line":""},{"line_number":1863,"context_line":"#if PASSTOS_CAPABILITY"},{"line_number":1864,"context_line":"    SHOW_BOOL(passtos);"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"2fba2993_384c818e","line":1861,"in_reply_to":"a2ced5bd_47c89245","updated":"2024-02-26 18:29:07.000000000","message":"Acknowledged","commit_id":"f08955c33218a3ab0aee7215199c595202ac9f71"},{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"c603438e3793f0cd38b3bbfeff13c07f910c5941","unresolved":true,"context_lines":[{"line_number":3123,"context_line":"        if (ce-\u003eproto \u003d\u003d PROTO_TCP)"},{"line_number":3124,"context_line":"        {"},{"line_number":3125,"context_line":"            ce-\u003eproto \u003d PROTO_TCP_CLIENT;"},{"line_number":3126,"context_line":"            if (ce-\u003ehttp_proxy_options)"},{"line_number":3127,"context_line":"            {"},{"line_number":3128,"context_line":"                ce-\u003ehttp_proxy_options-\u003enocache \u003d ssl_get_auth_nocache();"},{"line_number":3129,"context_line":"            }"}],"source_content_type":"text/x-csrc","patch_set":5,"id":"10c5ad5e_1e39dee3","line":3126,"updated":"2024-03-11 14:45:37.000000000","message":"This needs to be moved one level up. E.g. when using \"--proto tcp4-client\" currently --auth-nocache is ignored, since proto is already PROTO_TCP_CLIENT.\nThere should be no issue with always setting this independently of ce-\u003eproto.","commit_id":"a945ed1982428dc7c04ceffe1df160685d72bb0c"},{"author":{"_account_id":1000034,"name":"its_Giaan","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"change_message_id":"88b1f09ddf5020ba5af6961fe55e189cf2a21016","unresolved":false,"context_lines":[{"line_number":3123,"context_line":"        if (ce-\u003eproto \u003d\u003d PROTO_TCP)"},{"line_number":3124,"context_line":"        {"},{"line_number":3125,"context_line":"            ce-\u003eproto \u003d PROTO_TCP_CLIENT;"},{"line_number":3126,"context_line":"            if (ce-\u003ehttp_proxy_options)"},{"line_number":3127,"context_line":"            {"},{"line_number":3128,"context_line":"                ce-\u003ehttp_proxy_options-\u003enocache \u003d ssl_get_auth_nocache();"},{"line_number":3129,"context_line":"            }"}],"source_content_type":"text/x-csrc","patch_set":5,"id":"3b08b487_e3fc606d","line":3126,"in_reply_to":"10c5ad5e_1e39dee3","updated":"2024-03-12 08:36:36.000000000","message":"Done","commit_id":"a945ed1982428dc7c04ceffe1df160685d72bb0c"}],"src/openvpn/proxy.c":[{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"77fd9c96c5b0d6ce30c0ad5b2766ae2d1a8459b4","unresolved":true,"context_lines":[{"line_number":272,"context_line":"        flags |\u003d GET_USER_PASS_INLINE_CREDS;"},{"line_number":273,"context_line":"    }"},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"    if (!static_proxy_user_pass.defined || (is_first_time \u0026\u0026 !p-\u003eoptions.nocache) )"},{"line_number":276,"context_line":"    {"},{"line_number":277,"context_line":"        get_user_pass(\u0026static_proxy_user_pass,"},{"line_number":278,"context_line":"                      p-\u003eoptions.auth_file,"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"99f3b845_b241aa5b","line":275,"updated":"2024-02-16 16:01:38.000000000","message":"This condition feels wrong to me. As I understand the code this should never be true when p-\u003eoptions.nocache is true. Or do I understand the code wrong?","commit_id":"f08955c33218a3ab0aee7215199c595202ac9f71"},{"author":{"_account_id":1000034,"name":"its_Giaan","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"change_message_id":"e2a873df6dc61c2598310c0d4e289c5df865f674","unresolved":false,"context_lines":[{"line_number":272,"context_line":"        flags |\u003d GET_USER_PASS_INLINE_CREDS;"},{"line_number":273,"context_line":"    }"},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"    if (!static_proxy_user_pass.defined || (is_first_time \u0026\u0026 !p-\u003eoptions.nocache) )"},{"line_number":276,"context_line":"    {"},{"line_number":277,"context_line":"        get_user_pass(\u0026static_proxy_user_pass,"},{"line_number":278,"context_line":"                      p-\u003eoptions.auth_file,"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"0fc15362_dde1eff3","line":275,"in_reply_to":"99f3b845_b241aa5b","updated":"2024-02-26 18:29:07.000000000","message":"Acknowledged","commit_id":"f08955c33218a3ab0aee7215199c595202ac9f71"},{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"77fd9c96c5b0d6ce30c0ad5b2766ae2d1a8459b4","unresolved":true,"context_lines":[{"line_number":275,"context_line":"    if (!static_proxy_user_pass.defined || (is_first_time \u0026\u0026 !p-\u003eoptions.nocache) )"},{"line_number":276,"context_line":"    {"},{"line_number":277,"context_line":"        get_user_pass(\u0026static_proxy_user_pass,"},{"line_number":278,"context_line":"                      p-\u003eoptions.auth_file,"},{"line_number":279,"context_line":"                      UP_TYPE_PROXY,"},{"line_number":280,"context_line":"                      flags);"},{"line_number":281,"context_line":"        is_first_time \u003d false;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"67ae3287_17906ea3","line":278,"updated":"2024-02-16 16:01:38.000000000","message":"I think you messed up a rebase on top of a634cc5eccd55f1d14197da7376bb819bdf72cb6 here. Your code ignores auth_file_up again.","commit_id":"f08955c33218a3ab0aee7215199c595202ac9f71"},{"author":{"_account_id":1000034,"name":"its_Giaan","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"change_message_id":"e2a873df6dc61c2598310c0d4e289c5df865f674","unresolved":false,"context_lines":[{"line_number":275,"context_line":"    if (!static_proxy_user_pass.defined || (is_first_time \u0026\u0026 !p-\u003eoptions.nocache) )"},{"line_number":276,"context_line":"    {"},{"line_number":277,"context_line":"        get_user_pass(\u0026static_proxy_user_pass,"},{"line_number":278,"context_line":"                      p-\u003eoptions.auth_file,"},{"line_number":279,"context_line":"                      UP_TYPE_PROXY,"},{"line_number":280,"context_line":"                      flags);"},{"line_number":281,"context_line":"        is_first_time \u003d false;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"eda88547_5919fdf8","line":278,"in_reply_to":"67ae3287_17906ea3","updated":"2024-02-26 18:29:07.000000000","message":"Acknowledged","commit_id":"f08955c33218a3ab0aee7215199c595202ac9f71"},{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"77fd9c96c5b0d6ce30c0ad5b2766ae2d1a8459b4","unresolved":true,"context_lines":[{"line_number":543,"context_line":"     * we know whether we need any. */"},{"line_number":544,"context_line":"    if (p-\u003eauth_method \u003d\u003d HTTP_AUTH_BASIC || p-\u003eauth_method \u003d\u003d HTTP_AUTH_NTLM2)"},{"line_number":545,"context_line":"    {"},{"line_number":546,"context_line":"        get_user_pass_http(p);"},{"line_number":547,"context_line":"    }"},{"line_number":548,"context_line":""},{"line_number":549,"context_line":"#if !NTLM"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"3303fbc3_b1eee104","line":546,"updated":"2024-02-16 16:01:38.000000000","message":"So previously this forced a reset of the credentials. This you removed. Are you sure this is correct? If yes, why?","commit_id":"f08955c33218a3ab0aee7215199c595202ac9f71"},{"author":{"_account_id":1000034,"name":"its_Giaan","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"change_message_id":"e2a873df6dc61c2598310c0d4e289c5df865f674","unresolved":false,"context_lines":[{"line_number":543,"context_line":"     * we know whether we need any. */"},{"line_number":544,"context_line":"    if (p-\u003eauth_method \u003d\u003d HTTP_AUTH_BASIC || p-\u003eauth_method \u003d\u003d HTTP_AUTH_NTLM2)"},{"line_number":545,"context_line":"    {"},{"line_number":546,"context_line":"        get_user_pass_http(p);"},{"line_number":547,"context_line":"    }"},{"line_number":548,"context_line":""},{"line_number":549,"context_line":"#if !NTLM"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"607aa2a9_08aea895","line":546,"in_reply_to":"3303fbc3_b1eee104","updated":"2024-02-26 18:29:07.000000000","message":"Acknowledged","commit_id":"f08955c33218a3ab0aee7215199c595202ac9f71"},{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"6b416826cdf50712d5a0a84b68a886f520e35b8d","unresolved":true,"context_lines":[{"line_number":552,"context_line":"     * we know whether we need any. */"},{"line_number":553,"context_line":"    if (p-\u003eauth_method \u003d\u003d HTTP_AUTH_BASIC || p-\u003eauth_method \u003d\u003d HTTP_AUTH_NTLM2)"},{"line_number":554,"context_line":"    {"},{"line_number":555,"context_line":"        get_user_pass_http(p, p-\u003eoptions.first_time);"},{"line_number":556,"context_line":"    }"},{"line_number":557,"context_line":""},{"line_number":558,"context_line":"#if !NTLM"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"e27428fc_b097b77f","line":555,"updated":"2024-02-27 13:24:26.000000000","message":"get_user_pass_http uses p-\u003eoptions.nocache but that is only set below. Is that intentional?","commit_id":"9ddf64878cbdb63f1a4d74c1b803e1a702c10b48"},{"author":{"_account_id":1000034,"name":"its_Giaan","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"change_message_id":"61ae9eb08af31aff985c977a498d3746ca858030","unresolved":false,"context_lines":[{"line_number":552,"context_line":"     * we know whether we need any. */"},{"line_number":553,"context_line":"    if (p-\u003eauth_method \u003d\u003d HTTP_AUTH_BASIC || p-\u003eauth_method \u003d\u003d HTTP_AUTH_NTLM2)"},{"line_number":554,"context_line":"    {"},{"line_number":555,"context_line":"        get_user_pass_http(p, p-\u003eoptions.first_time);"},{"line_number":556,"context_line":"    }"},{"line_number":557,"context_line":""},{"line_number":558,"context_line":"#if !NTLM"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"07dbbffd_a306e8c1","line":555,"in_reply_to":"e27428fc_b097b77f","updated":"2024-02-27 13:54:25.000000000","message":"@frank@lichtenheld.com, not at all, actually the p-\u003eoptions are setted little bit before the get_user_pass_http() through p-\u003eoptions \u003d *o, so setting it below is something useless that I left during the last clean-up.","commit_id":"9ddf64878cbdb63f1a4d74c1b803e1a702c10b48"},{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"c603438e3793f0cd38b3bbfeff13c07f910c5941","unresolved":true,"context_lines":[{"line_number":666,"context_line":"        || p-\u003eauth_method \u003d\u003d HTTP_AUTH_NTLM2)"},{"line_number":667,"context_line":"    {"},{"line_number":668,"context_line":"        get_user_pass_http(p, false);"},{"line_number":669,"context_line":"        if (p-\u003eup.nocache)"},{"line_number":670,"context_line":"        {"},{"line_number":671,"context_line":"            clear_user_pass_http();"},{"line_number":672,"context_line":"        }"}],"source_content_type":"text/x-csrc","patch_set":5,"id":"663d790d_11843add","line":669,"updated":"2024-03-11 14:45:37.000000000","message":"wouldn\u0027t it be better to move this clearing into get_user_pass_http?","commit_id":"a945ed1982428dc7c04ceffe1df160685d72bb0c"},{"author":{"_account_id":1000034,"name":"its_Giaan","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"change_message_id":"88b1f09ddf5020ba5af6961fe55e189cf2a21016","unresolved":false,"context_lines":[{"line_number":666,"context_line":"        || p-\u003eauth_method \u003d\u003d HTTP_AUTH_NTLM2)"},{"line_number":667,"context_line":"    {"},{"line_number":668,"context_line":"        get_user_pass_http(p, false);"},{"line_number":669,"context_line":"        if (p-\u003eup.nocache)"},{"line_number":670,"context_line":"        {"},{"line_number":671,"context_line":"            clear_user_pass_http();"},{"line_number":672,"context_line":"        }"}],"source_content_type":"text/x-csrc","patch_set":5,"id":"f7da0dee_13ae81ae","line":669,"in_reply_to":"663d790d_11843add","updated":"2024-03-12 08:36:36.000000000","message":"Done","commit_id":"a945ed1982428dc7c04ceffe1df160685d72bb0c"},{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"7f90a3b96321c6e3585d5291d79812434101056d","unresolved":true,"context_lines":[{"line_number":296,"context_line":"    /*"},{"line_number":297,"context_line":"     * Using cached credentials"},{"line_number":298,"context_line":"     */"},{"line_number":299,"context_line":"    else if (!static_proxy_user_pass.nocache)"},{"line_number":300,"context_line":"    {"},{"line_number":301,"context_line":"        p-\u003equeried_creds \u003d true;"},{"line_number":302,"context_line":"        p-\u003eup \u003d static_proxy_user_pass;"}],"source_content_type":"text/x-csrc","patch_set":6,"id":"5c0d5864_4b0d142a","line":299,"updated":"2024-03-12 11:04:43.000000000","message":"Do not actually need to check for nocache here. Since it will never be defined when nocache is set. So the check is redundant. You can even remove the else completely then and just always use static_proxy_user_pass at this point in the function.","commit_id":"2a9882cf45f2da58cc60380d5ee3e2faaa3607db"},{"author":{"_account_id":1000034,"name":"its_Giaan","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"change_message_id":"7c7dc53c2ac227f030acfcf4a0253a5794fda57d","unresolved":false,"context_lines":[{"line_number":296,"context_line":"    /*"},{"line_number":297,"context_line":"     * Using cached credentials"},{"line_number":298,"context_line":"     */"},{"line_number":299,"context_line":"    else if (!static_proxy_user_pass.nocache)"},{"line_number":300,"context_line":"    {"},{"line_number":301,"context_line":"        p-\u003equeried_creds \u003d true;"},{"line_number":302,"context_line":"        p-\u003eup \u003d static_proxy_user_pass;"}],"source_content_type":"text/x-csrc","patch_set":6,"id":"42ea2ef6_c71a07f0","line":299,"in_reply_to":"5c0d5864_4b0d142a","updated":"2024-03-12 11:27:31.000000000","message":"Acknowledged","commit_id":"2a9882cf45f2da58cc60380d5ee3e2faaa3607db"},{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"7f90a3b96321c6e3585d5291d79812434101056d","unresolved":true,"context_lines":[{"line_number":301,"context_line":"        p-\u003equeried_creds \u003d true;"},{"line_number":302,"context_line":"        p-\u003eup \u003d static_proxy_user_pass;"},{"line_number":303,"context_line":"    }"},{"line_number":304,"context_line":"    else if (static_proxy_user_pass.nocache \u0026\u0026 !force)"},{"line_number":305,"context_line":"    {"},{"line_number":306,"context_line":"        clear_user_pass_http();"},{"line_number":307,"context_line":"    }"}],"source_content_type":"text/x-csrc","patch_set":6,"id":"b8aa24f7_cae22dbf","line":304,"updated":"2024-03-12 11:04:43.000000000","message":"I think this condition is too complicated. What does this have to do with force? Also why the \"else\"? Just always delete it when nocache is true... Or am I missing something?","commit_id":"2a9882cf45f2da58cc60380d5ee3e2faaa3607db"},{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"0740e67a021632e9fcfb0c27f9119629b31a8034","unresolved":true,"context_lines":[{"line_number":301,"context_line":"        p-\u003equeried_creds \u003d true;"},{"line_number":302,"context_line":"        p-\u003eup \u003d static_proxy_user_pass;"},{"line_number":303,"context_line":"    }"},{"line_number":304,"context_line":"    else if (static_proxy_user_pass.nocache \u0026\u0026 !force)"},{"line_number":305,"context_line":"    {"},{"line_number":306,"context_line":"        clear_user_pass_http();"},{"line_number":307,"context_line":"    }"}],"source_content_type":"text/x-csrc","patch_set":6,"id":"a8be4b5f_3cc2fa9a","line":304,"in_reply_to":"19fd5e77_9975a90f","updated":"2024-03-12 12:38:35.000000000","message":"You\u0027re right about the force. I didn\u0027t really think about the fact that when you don\u0027t use \"auto\" get_user_pass_http is going to be always called twice. But that also invalidates my other suggestion about the \"else\". The test for force is not enough since on restart force will be false for the first call. And it that case we should not clear it. I think we should go back to the previous iteration in this case. Move it out of the function again after the second get_user_pass_http. We really only want to delete it there after all.","commit_id":"2a9882cf45f2da58cc60380d5ee3e2faaa3607db"},{"author":{"_account_id":1000034,"name":"its_Giaan","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"change_message_id":"9d7cb98dd6ba1d1b33638c8977c334d8837418d9","unresolved":false,"context_lines":[{"line_number":301,"context_line":"        p-\u003equeried_creds \u003d true;"},{"line_number":302,"context_line":"        p-\u003eup \u003d static_proxy_user_pass;"},{"line_number":303,"context_line":"    }"},{"line_number":304,"context_line":"    else if (static_proxy_user_pass.nocache \u0026\u0026 !force)"},{"line_number":305,"context_line":"    {"},{"line_number":306,"context_line":"        clear_user_pass_http();"},{"line_number":307,"context_line":"    }"}],"source_content_type":"text/x-csrc","patch_set":6,"id":"00ff12bf_f5ff24b0","line":304,"in_reply_to":"a8be4b5f_3cc2fa9a","updated":"2024-03-12 13:08:53.000000000","message":"Done","commit_id":"2a9882cf45f2da58cc60380d5ee3e2faaa3607db"},{"author":{"_account_id":1000034,"name":"its_Giaan","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"change_message_id":"7c7dc53c2ac227f030acfcf4a0253a5794fda57d","unresolved":true,"context_lines":[{"line_number":301,"context_line":"        p-\u003equeried_creds \u003d true;"},{"line_number":302,"context_line":"        p-\u003eup \u003d static_proxy_user_pass;"},{"line_number":303,"context_line":"    }"},{"line_number":304,"context_line":"    else if (static_proxy_user_pass.nocache \u0026\u0026 !force)"},{"line_number":305,"context_line":"    {"},{"line_number":306,"context_line":"        clear_user_pass_http();"},{"line_number":307,"context_line":"    }"}],"source_content_type":"text/x-csrc","patch_set":6,"id":"19fd5e77_9975a90f","line":304,"in_reply_to":"b8aa24f7_cae22dbf","updated":"2024-03-12 11:27:31.000000000","message":"I think we need it otherwise in case of nocache true creds would be wiped at the first call of the get_user_pass() and then asked again at the second call (the one with force \u003d\u003d false), by checking force we know that we\u0027re at the second call of the function so we can clear previous creds since we don\u0027t need them anymore. \nTotally agree about the \"else\".","commit_id":"2a9882cf45f2da58cc60380d5ee3e2faaa3607db"},{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"ad31d45d8d2d94a5a795bd6da8b73294014c76d8","unresolved":true,"context_lines":[{"line_number":290,"context_line":"                      flags);"},{"line_number":291,"context_line":"        static_proxy_user_pass.nocache \u003d p-\u003eoptions.nocache;"},{"line_number":292,"context_line":"        p-\u003equeried_creds \u003d true;"},{"line_number":293,"context_line":"        p-\u003eup \u003d static_proxy_user_pass;"},{"line_number":294,"context_line":"    }"},{"line_number":295,"context_line":""},{"line_number":296,"context_line":"    /*"}],"source_content_type":"text/x-csrc","patch_set":7,"id":"0285cd49_4660ab6b","line":293,"updated":"2024-03-12 13:36:07.000000000","message":"These two lines are redundant now. Please remove them.","commit_id":"b9b05b775767f860653452173f9c2d7ec6db7cf2"},{"author":{"_account_id":1000034,"name":"its_Giaan","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"change_message_id":"12542a2eb5eff9b8e388c6be2f9daa6c83e83c78","unresolved":false,"context_lines":[{"line_number":290,"context_line":"                      flags);"},{"line_number":291,"context_line":"        static_proxy_user_pass.nocache \u003d p-\u003eoptions.nocache;"},{"line_number":292,"context_line":"        p-\u003equeried_creds \u003d true;"},{"line_number":293,"context_line":"        p-\u003eup \u003d static_proxy_user_pass;"},{"line_number":294,"context_line":"    }"},{"line_number":295,"context_line":""},{"line_number":296,"context_line":"    /*"}],"source_content_type":"text/x-csrc","patch_set":7,"id":"07861da3_4c72dba0","line":293,"in_reply_to":"0285cd49_4660ab6b","updated":"2024-03-12 13:43:13.000000000","message":"Done","commit_id":"b9b05b775767f860653452173f9c2d7ec6db7cf2"}],"src/openvpn/proxy.h":[{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"c603438e3793f0cd38b3bbfeff13c07f910c5941","unresolved":true,"context_lines":[{"line_number":58,"context_line":"    struct http_custom_header custom_headers[MAX_CUSTOM_HTTP_HEADER];"},{"line_number":59,"context_line":"    bool inline_creds; /* auth_file_up is inline credentials */"},{"line_number":60,"context_line":"    bool first_time; /* indicates if we need to wipe user creds at the first iteration of the main loop */"},{"line_number":61,"context_line":"    bool nocache;"},{"line_number":62,"context_line":"};"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"struct http_proxy_options_simple {"}],"source_content_type":"text/x-csrc","patch_set":5,"id":"2c3993c2_e1173cce","line":61,"updated":"2024-03-11 14:45:37.000000000","message":"Please update \"show_http_proxy_options\" in options.c to show value of nocache.","commit_id":"a945ed1982428dc7c04ceffe1df160685d72bb0c"},{"author":{"_account_id":1000034,"name":"its_Giaan","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"change_message_id":"88b1f09ddf5020ba5af6961fe55e189cf2a21016","unresolved":false,"context_lines":[{"line_number":58,"context_line":"    struct http_custom_header custom_headers[MAX_CUSTOM_HTTP_HEADER];"},{"line_number":59,"context_line":"    bool inline_creds; /* auth_file_up is inline credentials */"},{"line_number":60,"context_line":"    bool first_time; /* indicates if we need to wipe user creds at the first iteration of the main loop */"},{"line_number":61,"context_line":"    bool nocache;"},{"line_number":62,"context_line":"};"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"struct http_proxy_options_simple {"}],"source_content_type":"text/x-csrc","patch_set":5,"id":"0c4157a3_109dd1dc","line":61,"in_reply_to":"2c3993c2_e1173cce","updated":"2024-03-12 08:36:36.000000000","message":"Done","commit_id":"a945ed1982428dc7c04ceffe1df160685d72bb0c"}],"src/openvpn/ssl.c":[{"author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"08bb0b66d2adaa484806f3ea00bb45a936fcb6a2","unresolved":true,"context_lines":[{"line_number":338,"context_line":" * Get the password caching"},{"line_number":339,"context_line":" */"},{"line_number":340,"context_line":"bool"},{"line_number":341,"context_line":"ssl_get_auth_nocache()"},{"line_number":342,"context_line":"{"},{"line_number":343,"context_line":"    return passbuf.nocache;"},{"line_number":344,"context_line":"}"}],"source_content_type":"text/x-csrc","patch_set":8,"id":"7c301b9f_a12ccb3f","line":341,"updated":"2024-06-19 10:17:14.000000000","message":"this needs to have a `(void)` there.","commit_id":"826e38c434439f9c4dd12261391a84314ee7fb06"},{"author":{"_account_id":1000034,"name":"its_Giaan","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"change_message_id":"5d0f49040eb22edcfdb301789984328d48d1d760","unresolved":false,"context_lines":[{"line_number":338,"context_line":" * Get the password caching"},{"line_number":339,"context_line":" */"},{"line_number":340,"context_line":"bool"},{"line_number":341,"context_line":"ssl_get_auth_nocache()"},{"line_number":342,"context_line":"{"},{"line_number":343,"context_line":"    return passbuf.nocache;"},{"line_number":344,"context_line":"}"}],"source_content_type":"text/x-csrc","patch_set":8,"id":"31872d63_557ff8df","line":341,"in_reply_to":"7c301b9f_a12ccb3f","updated":"2024-06-19 11:59:35.000000000","message":"Done","commit_id":"826e38c434439f9c4dd12261391a84314ee7fb06"}],"src/openvpn/ssl.h":[{"author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"08bb0b66d2adaa484806f3ea00bb45a936fcb6a2","unresolved":true,"context_lines":[{"line_number":399,"context_line":"/*"},{"line_number":400,"context_line":" * Getter method for retrieving the auth-nocache option."},{"line_number":401,"context_line":" */"},{"line_number":402,"context_line":"bool ssl_get_auth_nocache();"},{"line_number":403,"context_line":""},{"line_number":404,"context_line":"/*"},{"line_number":405,"context_line":" * Purge any stored authentication information, both for key files and tunnel"}],"source_content_type":"text/x-csrc","patch_set":8,"id":"5680c4c5_ce81e31d","line":402,"updated":"2024-06-19 10:17:14.000000000","message":"this needs to have a `(void)` there.","commit_id":"826e38c434439f9c4dd12261391a84314ee7fb06"},{"author":{"_account_id":1000034,"name":"its_Giaan","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"change_message_id":"5d0f49040eb22edcfdb301789984328d48d1d760","unresolved":false,"context_lines":[{"line_number":399,"context_line":"/*"},{"line_number":400,"context_line":" * Getter method for retrieving the auth-nocache option."},{"line_number":401,"context_line":" */"},{"line_number":402,"context_line":"bool ssl_get_auth_nocache();"},{"line_number":403,"context_line":""},{"line_number":404,"context_line":"/*"},{"line_number":405,"context_line":" * Purge any stored authentication information, both for key files and tunnel"}],"source_content_type":"text/x-csrc","patch_set":8,"id":"7670fb94_a3d3d05d","line":402,"in_reply_to":"5680c4c5_ce81e31d","updated":"2024-06-19 11:59:35.000000000","message":"Done","commit_id":"826e38c434439f9c4dd12261391a84314ee7fb06"}]}