)]}'
{"id":"openvpn~523","triplet_id":"openvpn~master~Ia3e06c0832c4ca0ab868c845279fb71c01a1a78a","project":"openvpn","branch":"master","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2024-06-26 09:18:21.000000000","reason":"Change was submitted"},"1000034":{"account":{"_account_id":1000034,"name":"its_Giaan","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"last_update":"2024-06-26 09:18:21.000000000","reason":"Change was submitted"},"1000002":{"account":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"last_update":"2024-06-23 20:05:16.000000000","reason":"\u003cGERRIT_ACCOUNT_1000002\u003e replied on the change","reason_account":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}},"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2024-06-26 09:18:21.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Ia3e06c0832c4ca0ab868c845279fb71c01a1a78a","subject":"Http-proxy: fix bug preventing proxy credentials caching","status":"MERGED","created":"2024-02-15 10:01:29.000000000","updated":"2024-06-26 09:18:21.000000000","submitted":"2024-06-26 09:18:21.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":35,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"523","meta_rev_id":"e879d75a7e0b29ec39040a88684420472b304400","_number":523,"virtual_id_number":523,"owner":{"_account_id":1000034,"name":"its_Giaan","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"value":0,"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"default_value":0}},"removable_reviewers":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-02-15 10:01:29.000000000","updated_by":{"_account_id":1000034,"name":"its_Giaan","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2024-02-15 10:01:29.000000000","updated_by":{"_account_id":1000034,"name":"its_Giaan","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"reviewer":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"state":"REVIEWER"},{"updated":"2024-02-15 10:01:29.000000000","updated_by":{"_account_id":1000034,"name":"its_Giaan","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2024-06-19 10:17:14.000000000","updated_by":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"state":"REVIEWER"}],"messages":[{"id":"f87adbc265ad2df93e50f4992803dba431f657b2","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000034,"name":"its_Giaan","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"date":"2024-02-15 10:01:29.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"77fd9c96c5b0d6ce30c0ad5b2766ae2d1a8459b4","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2024-02-16 16:01:38.000000000","message":"Patch Set 1: Code-Review-2\n\n(5 comments)","accounts_in_message":[],"_revision_number":1},{"id":"6bf7e0bedc10a71f08679f2e3664a0b6b5eb6d64","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000034,"name":"its_Giaan","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"date":"2024-02-26 18:28:29.000000000","message":"Uploaded patch set 2.\n\nCopied Votes:\n* Code-Review-2 (copy condition: \"changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR **is:MIN**\")\n","accounts_in_message":[],"_revision_number":2},{"id":"e2a873df6dc61c2598310c0d4e289c5df865f674","author":{"_account_id":1000034,"name":"its_Giaan","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"date":"2024-02-26 18:29:07.000000000","message":"Patch Set 2:\n\n(4 comments)","accounts_in_message":[],"_revision_number":2},{"id":"17c0d435cb234a896798daf7b63d7343a69b642a","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000034,"name":"its_Giaan","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"date":"2024-02-27 07:56:26.000000000","message":"Uploaded patch set 3: Commit message was updated.\n\nCopied Votes:\n* Code-Review-2 (copy condition: \"changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR **is:MIN**\")\n","accounts_in_message":[],"_revision_number":3},{"id":"6b416826cdf50712d5a0a84b68a886f520e35b8d","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2024-02-27 13:24:26.000000000","message":"Patch Set 3: -Code-Review\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"61ae9eb08af31aff985c977a498d3746ca858030","author":{"_account_id":1000034,"name":"its_Giaan","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"date":"2024-02-27 13:54:25.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"2f0d5e128d5259e96c8989cda0482e595d2dea22","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000034,"name":"its_Giaan","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"date":"2024-02-27 14:00:44.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"47cecd7da39d1dfd7af09eec3b82d2a77421df47","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000034,"name":"its_Giaan","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"date":"2024-03-07 11:06:14.000000000","message":"Uploaded patch set 5: New patch set was added with same tree, parent tree, and commit message as Patch Set 4.","accounts_in_message":[],"_revision_number":5},{"id":"9a704c5c90476d340780542c30a03373d9e53ed6","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2024-03-11 12:29:43.000000000","message":"Patch Set 5: Code-Review-2\n\n(1 comment)","accounts_in_message":[],"_revision_number":5},{"id":"c603438e3793f0cd38b3bbfeff13c07f910c5941","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2024-03-11 14:45:37.000000000","message":"Patch Set 5:\n\n(4 comments)","accounts_in_message":[],"_revision_number":5},{"id":"88b1f09ddf5020ba5af6961fe55e189cf2a21016","author":{"_account_id":1000034,"name":"its_Giaan","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"date":"2024-03-12 08:36:36.000000000","message":"Patch Set 5:\n\n(4 comments)","accounts_in_message":[],"_revision_number":5},{"id":"11bedd62bdb9a0f5c8b262978b1b9d44c09cb5e3","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000034,"name":"its_Giaan","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"date":"2024-03-12 08:42:14.000000000","message":"Uploaded patch set 6.\n\nCopied Votes:\n* Code-Review-2 (copy condition: \"changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR **is:MIN**\")\n","accounts_in_message":[],"_revision_number":6},{"id":"7f90a3b96321c6e3585d5291d79812434101056d","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2024-03-12 11:04:43.000000000","message":"Patch Set 6: Code-Review-2\n\n(2 comments)","accounts_in_message":[],"_revision_number":6},{"id":"7c7dc53c2ac227f030acfcf4a0253a5794fda57d","author":{"_account_id":1000034,"name":"its_Giaan","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"date":"2024-03-12 11:27:31.000000000","message":"Patch Set 6:\n\n(2 comments)","accounts_in_message":[],"_revision_number":6},{"id":"0740e67a021632e9fcfb0c27f9119629b31a8034","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2024-03-12 12:38:35.000000000","message":"Patch Set 6:\n\n(1 comment)","accounts_in_message":[],"_revision_number":6},{"id":"08b1ca0e26122076c89017d626b642317c7381a0","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000034,"name":"its_Giaan","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"date":"2024-03-12 13:08:07.000000000","message":"Uploaded patch set 7.\n\nCopied Votes:\n* Code-Review-2 (copy condition: \"changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR **is:MIN**\")\n","accounts_in_message":[],"_revision_number":7},{"id":"9d7cb98dd6ba1d1b33638c8977c334d8837418d9","author":{"_account_id":1000034,"name":"its_Giaan","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"date":"2024-03-12 13:08:53.000000000","message":"Patch Set 7:\n\n(1 comment)","accounts_in_message":[],"_revision_number":7},{"id":"ad31d45d8d2d94a5a795bd6da8b73294014c76d8","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2024-03-12 13:36:07.000000000","message":"Patch Set 7: Code-Review-1\n\n(2 comments)","accounts_in_message":[],"_revision_number":7},{"id":"12542a2eb5eff9b8e388c6be2f9daa6c83e83c78","author":{"_account_id":1000034,"name":"its_Giaan","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"date":"2024-03-12 13:43:13.000000000","message":"Patch Set 7:\n\n(1 comment)","accounts_in_message":[],"_revision_number":7},{"id":"769be1dd7c2d68440a4b7cacf7bc974dae37e3c3","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000034,"name":"its_Giaan","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"date":"2024-03-12 13:43:23.000000000","message":"Uploaded patch set 8.\n\nOutdated Votes:\n* Code-Review-1 (copy condition: \"changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR is:MIN\")\n","accounts_in_message":[],"_revision_number":8},{"id":"75e765006023cf355024676b08a7e30d8e36e10c","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2024-03-12 16:36:48.000000000","message":"Patch Set 8: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":8},{"id":"308063570d2f9b9bca2f795e94d9a25790949c73","tag":"autogenerated:gerrit:setHashtag","author":{"_account_id":1000034,"name":"its_Giaan","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"date":"2024-03-12 17:25:25.000000000","message":"Hashtag added: mailsubmitted","accounts_in_message":[],"_revision_number":8},{"id":"08bb0b66d2adaa484806f3ea00bb45a936fcb6a2","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2024-06-19 10:17:14.000000000","message":"Patch Set 8: Code-Review-1\n\n(3 comments)","accounts_in_message":[],"_revision_number":8},{"id":"f6e180da04b63d3416372287636e856b8266eba3","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000034,"name":"its_Giaan","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"date":"2024-06-19 11:58:29.000000000","message":"Uploaded patch set 9.\n\nOutdated Votes:\n* Code-Review+2, Code-Review-1 (copy condition: \"changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR is:MIN\")\n","accounts_in_message":[],"_revision_number":9},{"id":"5faa136e9af677c201de96508f0e2290bc9ef569","tag":"autogenerated:gerrit:setHashtag","author":{"_account_id":1000034,"name":"its_Giaan","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"date":"2024-06-19 11:59:19.000000000","message":"Hashtag removed: mailsubmitted","accounts_in_message":[],"_revision_number":9},{"id":"5d0f49040eb22edcfdb301789984328d48d1d760","author":{"_account_id":1000034,"name":"its_Giaan","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"date":"2024-06-19 11:59:35.000000000","message":"Patch Set 9:\n\n(2 comments)","accounts_in_message":[],"_revision_number":9},{"id":"4a007444e8a55c0533f02e26ed70061f078dbbb6","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000034,"name":"its_Giaan","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"date":"2024-06-20 10:47:26.000000000","message":"Uploaded patch set 10.","accounts_in_message":[],"_revision_number":10},{"id":"40cb626e5eabe6fbaf35ea3737c2a2664a085b0e","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2024-06-23 20:05:16.000000000","message":"Patch Set 10: Code-Review+2","accounts_in_message":[],"_revision_number":10},{"id":"e879d75a7e0b29ec39040a88684420472b304400","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2024-06-26 09:18:21.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":11}],"current_revision_number":11,"current_revision":"3cfd6f961d5c92bec283ac3616e1633b4e16760c","revisions":{"f08955c33218a3ab0aee7215199c595202ac9f71":{"kind":"REWORK","_number":1,"created":"2024-02-15 10:01:29.000000000","uploader":{"_account_id":1000034,"name":"its_Giaan","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"ref":"refs/changes/23/523/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/23/523/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/23/523/1 \u0026\u0026 git checkout -b change-523 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/23/523/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/23/523/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/23/523/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/23/523/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/23/523/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"7869617a0f85089fb5e6fbe2db6f03542a8f33f4","subject":"Ensure that all unit tests use unbuffered stdout and stderr"}],"author":{"name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","date":"2023-04-17 08:18:28.000000000","tz":120},"committer":{"name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","date":"2024-02-15 10:00:33.000000000","tz":60},"subject":"Http-proxy: Fix bug preventing proxy credentials caching.","message":"Http-proxy: Fix bug preventing proxy credentials caching.\n\nPreviously, the caching of proxy credentials was not working\ndue to the missing of handling already defined creds in\nget_user_pass_http(), which prevented the caching from working correctly.\n\nThis issue has been solved by rewriting the get_user_pass_http().\nThis method now sets the appropriate flags based on whether\ncredentials are defined, have been queried before, or are inline.\nIt then calls the get_user_pass() to retrieve the credentials\nand store them in a static variable, \u0027static_proxy_user_pass\u0027,\nwhich will be used for subsequent requests. If credentials\nwere not previously defined, or caching is not allowed, creds\nare queried again.\n\nFixes: Trac #1187\nChange-Id: Ia3e06c0832c4ca0ab868c845279fb71c01a1a78a\nSigned-off-by: Gianmarco De Gregori \u003cgianmarco@mandelbit.com\u003e\n"},"branch":"refs/heads/master"},"53f1ec8a6f4d0bc9faf52b3756fc6d9442e1e760":{"kind":"REWORK","_number":2,"created":"2024-02-26 18:28:29.000000000","uploader":{"_account_id":1000034,"name":"its_Giaan","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"ref":"refs/changes/23/523/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/23/523/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/23/523/2 \u0026\u0026 git checkout -b change-523 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/23/523/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/23/523/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/23/523/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/23/523/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/23/523/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"fad2d7017eee366317bb18b34416e7788cbe2372","subject":"Document that auth-user-pass may be inlined"}],"author":{"name":"itsGiaan","email":"gianmarcod95@outlook.com","date":"2024-02-26 10:11:33.000000000","tz":60},"committer":{"name":"Gianmarco De Gregori","email":"gianmarcod95@outlook.com","date":"2024-02-26 18:26:33.000000000","tz":60},"subject":"Http-proxy: fix bug preventing proxy credentials caching","message":"Http-proxy: fix bug preventing proxy credentials caching\n\nPreviously, the caching of proxy credentials was not working\ndue to the missing of handling already defined creds in\nget_user_pass(), which prevented the caching from working\nproperly.\n\nThis issue has been solved by getting the c-\u003efirst_time\nparameter that indicates if we\u0027re at the first iteration\nof the main loop and use it as second argument of the\nget_user_pass_http() otherwise on SIGUSR1 or SIGHUP at\nthe restart of the context instance credentials would be erase.\n\nThe nocache option has been added to the struct\nhttp_proxy_options and also a getter method to retrieve\nthat option from ssl has been added, by doing this\nwe\u0027re able to erase previous queried user credentials\nto ensure correct operation.\n\nFixes: Trac #1187\nSigned-off-by: Gianmarco De Gregori \u003cgianmarco@mandelbit.com\u003e\nChange-Id: Ia3e06c0832c4ca0ab868c845279fb71c01a1a78a\n"},"branch":"refs/heads/master"},"9ddf64878cbdb63f1a4d74c1b803e1a702c10b48":{"kind":"NO_CODE_CHANGE","_number":3,"created":"2024-02-27 07:56:26.000000000","uploader":{"_account_id":1000034,"name":"its_Giaan","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"ref":"refs/changes/23/523/3","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/23/523/3","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/23/523/3 \u0026\u0026 git checkout -b change-523 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/23/523/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/23/523/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/23/523/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/23/523/3","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/23/523/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"fad2d7017eee366317bb18b34416e7788cbe2372","subject":"Document that auth-user-pass may be inlined"}],"author":{"name":"itsGiaan","email":"gianmarcod95@outlook.com","date":"2024-02-26 10:11:33.000000000","tz":60},"committer":{"name":"Gianmarco De Gregori","email":"gianmarcod95@outlook.com","date":"2024-02-27 07:46:51.000000000","tz":60},"subject":"Http-proxy: fix bug preventing proxy credentials caching","message":"Http-proxy: fix bug preventing proxy credentials caching\n\nCaching proxy credentials was not working due to the\nlack of handling already defined creds in get_user_pass(),\nwhich prevented the caching from working properly.\n\nFix this issue by getting the value of c-\u003efirst_time,\nthat indicates if we\u0027re at the first iteration\nof the main loop and use it as second argument of the\nget_user_pass_http(). Otherwise, on SIGUSR1 or SIGHUP\nupon instance context restart credentials would be erased\nevery time.\n\nThe nocache member has been added to the struct\nhttp_proxy_options and also a getter method to retrieve\nthat option from ssl has been added, by doing this\nwe\u0027re able to erase previous queried user credentials\nto ensure correct operation.\n\nFixes: Trac #1187\nSigned-off-by: Gianmarco De Gregori \u003cgianmarco@mandelbit.com\u003e\nChange-Id: Ia3e06c0832c4ca0ab868c845279fb71c01a1a78a\n"},"branch":"refs/heads/master"},"d48bd0ccc0acd3769fcaf6231c7d7f408df35aee":{"kind":"REWORK","_number":4,"created":"2024-02-27 14:00:44.000000000","uploader":{"_account_id":1000034,"name":"its_Giaan","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"ref":"refs/changes/23/523/4","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/23/523/4","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/23/523/4 \u0026\u0026 git checkout -b change-523 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/23/523/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/23/523/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/23/523/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/23/523/4","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/23/523/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"fad2d7017eee366317bb18b34416e7788cbe2372","subject":"Document that auth-user-pass may be inlined"}],"author":{"name":"itsGiaan","email":"gianmarcod95@outlook.com","date":"2024-02-26 10:11:33.000000000","tz":60},"committer":{"name":"Gianmarco De Gregori","email":"gianmarcod95@outlook.com","date":"2024-02-27 13:58:51.000000000","tz":60},"subject":"Http-proxy: fix bug preventing proxy credentials caching","message":"Http-proxy: fix bug preventing proxy credentials caching\n\nCaching proxy credentials was not working due to the\nlack of handling already defined creds in get_user_pass(),\nwhich prevented the caching from working properly.\n\nFix this issue by getting the value of c-\u003efirst_time,\nthat indicates if we\u0027re at the first iteration\nof the main loop and use it as second argument of the\nget_user_pass_http(). Otherwise, on SIGUSR1 or SIGHUP\nupon instance context restart credentials would be erased\nevery time.\n\nThe nocache member has been added to the struct\nhttp_proxy_options and also a getter method to retrieve\nthat option from ssl has been added, by doing this\nwe\u0027re able to erase previous queried user credentials\nto ensure correct operation.\n\nFixes: Trac #1187\nSigned-off-by: Gianmarco De Gregori \u003cgianmarco@mandelbit.com\u003e\nChange-Id: Ia3e06c0832c4ca0ab868c845279fb71c01a1a78a\n"},"branch":"refs/heads/master"},"a945ed1982428dc7c04ceffe1df160685d72bb0c":{"kind":"NO_CHANGE","_number":5,"created":"2024-03-07 11:06:14.000000000","uploader":{"_account_id":1000034,"name":"its_Giaan","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"ref":"refs/changes/23/523/5","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/23/523/5","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/23/523/5 \u0026\u0026 git checkout -b change-523 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/23/523/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/23/523/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/23/523/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/23/523/5","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/23/523/5 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"fad2d7017eee366317bb18b34416e7788cbe2372","subject":"Document that auth-user-pass may be inlined"}],"author":{"name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","date":"2024-03-07 11:04:16.000000000","tz":60},"committer":{"name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","date":"2024-03-07 11:04:16.000000000","tz":60},"subject":"Http-proxy: fix bug preventing proxy credentials caching","message":"Http-proxy: fix bug preventing proxy credentials caching\n\nCaching proxy credentials was not working due to the\nlack of handling already defined creds in get_user_pass(),\nwhich prevented the caching from working properly.\n\nFix this issue by getting the value of c-\u003efirst_time,\nthat indicates if we\u0027re at the first iteration\nof the main loop and use it as second argument of the\nget_user_pass_http(). Otherwise, on SIGUSR1 or SIGHUP\nupon instance context restart credentials would be erased\nevery time.\n\nThe nocache member has been added to the struct\nhttp_proxy_options and also a getter method to retrieve\nthat option from ssl has been added, by doing this\nwe\u0027re able to erase previous queried user credentials\nto ensure correct operation.\n\nFixes: Trac #1187\nSigned-off-by: Gianmarco De Gregori \u003cgianmarco@mandelbit.com\u003e\nChange-Id: Ia3e06c0832c4ca0ab868c845279fb71c01a1a78a\n"},"branch":"refs/heads/master"},"2a9882cf45f2da58cc60380d5ee3e2faaa3607db":{"kind":"REWORK","_number":6,"created":"2024-03-12 08:42:14.000000000","uploader":{"_account_id":1000034,"name":"its_Giaan","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"ref":"refs/changes/23/523/6","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/23/523/6","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/23/523/6 \u0026\u0026 git checkout -b change-523 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/23/523/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/23/523/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/23/523/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/23/523/6","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/23/523/6 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"f65c656ac034a99cca09557eeb9337e7c00a7e73","subject":"Update documentation references in systemd unit files"}],"author":{"name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","date":"2024-03-12 08:31:55.000000000","tz":60},"committer":{"name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","date":"2024-03-12 08:37:21.000000000","tz":60},"subject":"Http-proxy: fix bug preventing proxy credentials caching","message":"Http-proxy: fix bug preventing proxy credentials caching\n\nCaching proxy credentials was not working due to the\nlack of handling already defined creds in get_user_pass(),\nwhich prevented the caching from working properly.\n\nFix this issue by getting the value of c-\u003efirst_time,\nthat indicates if we\u0027re at the first iteration\nof the main loop and use it as second argument of the\nget_user_pass_http(). Otherwise, on SIGUSR1 or SIGHUP\nupon instance context restart credentials would be erased\nevery time.\n\nThe nocache member has been added to the struct\nhttp_proxy_options and also a getter method to retrieve\nthat option from ssl has been added, by doing this\nwe\u0027re able to erase previous queried user credentials\nto ensure correct operation.\n\nFixes: Trac #1187\nSigned-off-by: Gianmarco De Gregori \u003cgianmarco@mandelbit.com\u003e\nChange-Id: Ia3e06c0832c4ca0ab868c845279fb71c01a1a78a\n"},"branch":"refs/heads/master"},"b9b05b775767f860653452173f9c2d7ec6db7cf2":{"kind":"REWORK","_number":7,"created":"2024-03-12 13:08:07.000000000","uploader":{"_account_id":1000034,"name":"its_Giaan","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"ref":"refs/changes/23/523/7","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/23/523/7","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/23/523/7 \u0026\u0026 git checkout -b change-523 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/23/523/7 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/23/523/7 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/23/523/7 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/23/523/7","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/23/523/7 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"f65c656ac034a99cca09557eeb9337e7c00a7e73","subject":"Update documentation references in systemd unit files"}],"author":{"name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","date":"2024-03-12 08:31:55.000000000","tz":60},"committer":{"name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","date":"2024-03-12 13:00:21.000000000","tz":60},"subject":"Http-proxy: fix bug preventing proxy credentials caching","message":"Http-proxy: fix bug preventing proxy credentials caching\n\nCaching proxy credentials was not working due to the\nlack of handling already defined creds in get_user_pass(),\nwhich prevented the caching from working properly.\n\nFix this issue by getting the value of c-\u003efirst_time,\nthat indicates if we\u0027re at the first iteration\nof the main loop and use it as second argument of the\nget_user_pass_http(). Otherwise, on SIGUSR1 or SIGHUP\nupon instance context restart credentials would be erased\nevery time.\n\nThe nocache member has been added to the struct\nhttp_proxy_options and also a getter method to retrieve\nthat option from ssl has been added, by doing this\nwe\u0027re able to erase previous queried user credentials\nto ensure correct operation.\n\nFixes: Trac #1187\nSigned-off-by: Gianmarco De Gregori \u003cgianmarco@mandelbit.com\u003e\nChange-Id: Ia3e06c0832c4ca0ab868c845279fb71c01a1a78a\n"},"branch":"refs/heads/master"},"826e38c434439f9c4dd12261391a84314ee7fb06":{"kind":"REWORK","_number":8,"created":"2024-03-12 13:43:23.000000000","uploader":{"_account_id":1000034,"name":"its_Giaan","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"ref":"refs/changes/23/523/8","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/23/523/8","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/23/523/8 \u0026\u0026 git checkout -b change-523 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/23/523/8 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/23/523/8 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/23/523/8 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/23/523/8","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/23/523/8 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"f65c656ac034a99cca09557eeb9337e7c00a7e73","subject":"Update documentation references in systemd unit files"}],"author":{"name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","date":"2024-03-12 08:31:55.000000000","tz":60},"committer":{"name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","date":"2024-03-12 13:41:31.000000000","tz":60},"subject":"Http-proxy: fix bug preventing proxy credentials caching","message":"Http-proxy: fix bug preventing proxy credentials caching\n\nCaching proxy credentials was not working due to the\nlack of handling already defined creds in get_user_pass(),\nwhich prevented the caching from working properly.\n\nFix this issue by getting the value of c-\u003efirst_time,\nthat indicates if we\u0027re at the first iteration\nof the main loop and use it as second argument of the\nget_user_pass_http(). Otherwise, on SIGUSR1 or SIGHUP\nupon instance context restart credentials would be erased\nevery time.\n\nThe nocache member has been added to the struct\nhttp_proxy_options and also a getter method to retrieve\nthat option from ssl has been added, by doing this\nwe\u0027re able to erase previous queried user credentials\nto ensure correct operation.\n\nFixes: Trac #1187\nSigned-off-by: Gianmarco De Gregori \u003cgianmarco@mandelbit.com\u003e\nChange-Id: Ia3e06c0832c4ca0ab868c845279fb71c01a1a78a\n"},"branch":"refs/heads/master"},"54a61e8b1f283c2001e67fcb52f82615161d060e":{"kind":"REWORK","_number":9,"created":"2024-06-19 11:58:29.000000000","uploader":{"_account_id":1000034,"name":"its_Giaan","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"ref":"refs/changes/23/523/9","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/23/523/9","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/23/523/9 \u0026\u0026 git checkout -b change-523 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/23/523/9 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/23/523/9 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/23/523/9 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/23/523/9","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/23/523/9 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"b3a68b85a729628ca8b97f9f0c2813f795289cfc","subject":"Implement server_poll_timeout for socks"}],"author":{"name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","date":"2024-03-07 11:04:16.000000000","tz":60},"committer":{"name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","date":"2024-06-19 11:57:29.000000000","tz":120},"subject":"Http-proxy: fix bug preventing proxy credentials caching","message":"Http-proxy: fix bug preventing proxy credentials caching\n\nCaching proxy credentials was not working due to the\nlack of handling already defined creds in get_user_pass(),\nwhich prevented the caching from working properly.\n\nFix this issue by getting the value of c-\u003efirst_time,\nthat indicates if we\u0027re at the first iteration\nof the main loop and use it as second argument of the\nget_user_pass_http(). Otherwise, on SIGUSR1 or SIGHUP\nupon instance context restart credentials would be erased\nevery time.\n\nThe nocache member has been added to the struct\nhttp_proxy_options and also a getter method to retrieve\nthat option from ssl has been added, by doing this\nwe\u0027re able to erase previous queried user credentials\nto ensure correct operation.\n\nFixes: Trac #1187\nSigned-off-by: Gianmarco De Gregori \u003cgianmarco@mandelbit.com\u003e\nChange-Id: Ia3e06c0832c4ca0ab868c845279fb71c01a1a78a\n"},"branch":"refs/heads/master"},"7574d0472028b571e94c4f2e1a4b78afa0e2808c":{"kind":"REWORK","_number":10,"created":"2024-06-20 10:47:26.000000000","uploader":{"_account_id":1000034,"name":"its_Giaan","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"ref":"refs/changes/23/523/10","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/23/523/10","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/23/523/10 \u0026\u0026 git checkout -b change-523 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/23/523/10 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/23/523/10 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/23/523/10 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/23/523/10","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/23/523/10 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"b3a68b85a729628ca8b97f9f0c2813f795289cfc","subject":"Implement server_poll_timeout for socks"}],"author":{"name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","date":"2024-03-12 08:31:55.000000000","tz":60},"committer":{"name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","date":"2024-06-20 10:45:08.000000000","tz":120},"subject":"Http-proxy: fix bug preventing proxy credentials caching","message":"Http-proxy: fix bug preventing proxy credentials caching\n\nCaching proxy credentials was not working due to the\nlack of handling already defined creds in get_user_pass(),\nwhich prevented the caching from working properly.\n\nFix this issue by getting the value of c-\u003efirst_time,\nthat indicates if we\u0027re at the first iteration\nof the main loop and use it as second argument of the\nget_user_pass_http(). Otherwise, on SIGUSR1 or SIGHUP\nupon instance context restart credentials would be erased\nevery time.\n\nThe nocache member has been added to the struct\nhttp_proxy_options and also a getter method to retrieve\nthat option from ssl has been added, by doing this\nwe\u0027re able to erase previous queried user credentials\nto ensure correct operation.\n\nFixes: Trac #1187\nSigned-off-by: Gianmarco De Gregori \u003cgianmarco@mandelbit.com\u003e\nChange-Id: Ia3e06c0832c4ca0ab868c845279fb71c01a1a78a\n"},"branch":"refs/heads/master"},"3cfd6f961d5c92bec283ac3616e1633b4e16760c":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":11,"created":"2024-06-26 09:18:21.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/23/523/11","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/23/523/11","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/23/523/11 \u0026\u0026 git checkout -b change-523 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/23/523/11 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/23/523/11 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/23/523/11 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/23/523/11","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/23/523/11 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"56355924b4945ec808500b18c714c111387697f9","subject":"configure: Add -Wstrict-prototypes and -Wold-style-definition"}],"author":{"name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","date":"2024-06-23 20:05:51.000000000","tz":120},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2024-06-25 20:22:48.000000000","tz":120},"subject":"Http-proxy: fix bug preventing proxy credentials caching","message":"Http-proxy: fix bug preventing proxy credentials caching\n\nCaching proxy credentials was not working due to the\nlack of handling already defined creds in get_user_pass(),\nwhich prevented the caching from working properly.\n\nFix this issue by getting the value of c-\u003efirst_time,\nthat indicates if we\u0027re at the first iteration\nof the main loop and use it as second argument of the\nget_user_pass_http(). Otherwise, on SIGUSR1 or SIGHUP\nupon instance context restart credentials would be erased\nevery time.\n\nThe nocache member has been added to the struct\nhttp_proxy_options and also a getter method to retrieve\nthat option from ssl has been added, by doing this\nwe\u0027re able to erase previous queried user credentials\nto ensure correct operation.\n\nFixes: Trac #1187\nSigned-off-by: Gianmarco De Gregori \u003cgianmarco@mandelbit.com\u003e\nAcked-by: Gert Doering \u003cgert@greenie.muc.de\u003e\nChange-Id: Ia3e06c0832c4ca0ab868c845279fb71c01a1a78a\nAcked-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\nMessage-Id: \u003c20240623200551.20092-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg28835.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}