)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"169a4d4f2db2c99fa0efc170ef875ab048ffa719","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ccf1c296_420156cb","updated":"2024-02-16 16:35:10.000000000","message":"Functionality might be fine, but could use some polish","commit_id":"29e2c24f556de8e0c83907ba483ee2af149514e6"},{"author":{"_account_id":1000034,"name":"Gianmarco De Gregori","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"change_message_id":"3bb97539d6fed783b7cf4e88f4fde742bf6b3f12","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"4733028d_870e79da","updated":"2024-02-19 15:52:50.000000000","message":"I defined it but not set it to make sure that when retrieving the whitelist of pullable options in pull_permission_mask() the pull were not allowed but rather it printed an options error.","commit_id":"29e2c24f556de8e0c83907ba483ee2af149514e6"},{"author":{"_account_id":1000034,"name":"Gianmarco De Gregori","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"change_message_id":"3ccd3f792f884ce2372ca4f83e0dd899757ef314","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"2ec49631_a8a32535","updated":"2024-02-20 13:33:18.000000000","message":"What about \"Table_id is supported only on Linux when SITNL is built-in\" so we know that in case we\u0027re on Linux but there\u0027s not SITNL -\u003e \"SITNL is required\", on the other hand if we\u0027re not on Linux -\u003e \"this is Linux only\"","commit_id":"29e2c24f556de8e0c83907ba483ee2af149514e6"},{"author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"a3a2795c2ec98a5fbfd817d5e5c3f12ec16ae904","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"d7884ba9_01c290e0","updated":"2024-06-19 09:13:14.000000000","message":"Sorry for being late to the party - I have looked at it, and while the general code works, I find it a bit excessive in lines of code.  Namely, I would opt for \"do not support route-table as an extra argument to `route`\", as this + the checks really makes up half the code - for little value.  Since it\u0027s not supposed to be pushable, routes-with-table need to be in the client config, and in that case, I could just put\n\n```\nroute-table 123\nroute\nroute\nroute-table 456\nroute\nroute\nroute-table 999\n# for everything that comes in pushed\n```\n\ninto my config.  If I ever really need more than 1-2 route tables.\n\nAlso, we shouldn\u0027t have `#ifdef ENABLE_SITNL` in the parser for `route` and `route-ipv6`...\n\nFurther, the hunk\n\n```\n+    int table_id \u003d 0; /* unspec table */\n...\n+    if (options-\u003eroute_default_table_id)\n+    {\n+        table_id \u003d options-\u003eroute_default_table_id;\n+    }\n```\n\nis sort of semi-useful - if route_default_table_id is 0, we do not assign it to table_id, which is also 0.  Why bother with an extra variable here that will have the same value as the `options` variable, at all times?  I\u0027d just pass `options-\u003eroute_default_table_id` downwards, and be done with it.\n\nThe `do_init_route_ipv6_list()` code also does the `table_id \u003d ...` dance, but then passes NULL towards `add_route_ipv6_to_option_list()`, which does not look intentional...","commit_id":"efc37341d479f67ef76e90c6b0a3b1b410990f11"},{"author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"4067f2c037ac1d1c05b8e9942a2e44b5bceefade","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"cf4a2e1e_ca2aad09","updated":"2024-03-13 13:08:44.000000000","message":"Tested --route-table 42 and --route-table 0 for full t_client suite)\n(don\u0027t forget ip rule)\nTested t_client 2a with --route-ipv6 fd00:abcd:194::/48 default default 42","commit_id":"efc37341d479f67ef76e90c6b0a3b1b410990f11"},{"author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"bb3a5ea4582eb7c1631713135b0438cabc0abb4c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"b5217c2b_3443fa74","updated":"2024-07-19 13:43:19.000000000","message":"Retested with tclient, LGTM","commit_id":"dbcb809ce11be2507548129a8cc7bc089b47de9f"},{"author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"834cb3fdf6ce7b5c307debbc87dc4184bb6c0833","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"e6df0a0e_68402e55","updated":"2024-09-19 10:40:05.000000000","message":"Still not there - I think the code in `route.c` is much more complex than it needs to be.  So with the new patch to `options.c`, we pass the to-be-used routing table ID to `add_route_to_option_list()`, so every route option always(!) has a routing-table to be used (or 0).  This should be sufficient.\n\nBut then, we have a default table_id added in `init_route()`, a number of extra flags (`RT_TABLE_DEFINED` for `r-\u003eflags`) etc., which is all not used in the end because even without the flag, `table_id` would become 0 in `add_route()` (by means of `r-\u003etable_id` being 0)...?\n\nSo.. can we do this with half the code?  Getting rid of all new DEFINEs, all new arguments and flags to `route_list` things, just storing the table id in `struct route_ipv4` and `struct route_ipv6`)\u003d","commit_id":"dbcb809ce11be2507548129a8cc7bc089b47de9f"},{"author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"9bca6cf5193be45146057d503ab86ff45059cd5f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"f67dbd5f_2d283889","updated":"2025-06-18 16:28:34.000000000","message":"Got left out in the sun too long, so now it needs polish... (sorry)","commit_id":"7af41191f4e49f4197daed9819fa241050903e45"},{"author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"1afd09fb58c62477ff4fd7a6d931471c2a47df02","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"aa72bb99_a5540273","updated":"2025-06-22 11:02:51.000000000","message":"Tested this on gentoo, with\n\n```... --client --route-table 77 --route 10.195.0.0 255.255.0.0 --route-table 78```\n\nwhich does what I expected - 10.195.0.0/16 shows up in table 77, and all pushed routes show up in table 78\n\n```\n2025-06-22 13:00:15 net_route_v4_del: 10.195.0.0/16 via 10.194.2.169 dev [NULL] table 77 metric -1\n2025-06-22 13:00:15 net_route_v4_del: 10.194.0.0/16 via 10.194.2.169 dev [NULL] table 78 metric -1\n2025-06-22 13:00:15 net_route_v4_del: 10.194.2.1/32 via 10.194.2.169 dev [NULL] table 78 metric -1\n```\n\n(and \"ip route list table 77 / 78\" confirms that).\n\nIt claims to do the right thing for IPv6\n\n```\n2025-06-22 13:00:15 net_route_v6_del: fd00:abcd:194::/48 via :: dev tun8 table 78 metric -1\n```\n\nbut `ip route -6 list` shows no table (but the same holds for ipv6 routes added via `ip route add -6 ... table 78` so this looks more like a linux weirdness than an OpenVPN/SITNL issue to me).","commit_id":"3982fb0de7d4d7bd07dffacb3fb73f07c62d869b"}],"doc/man-sections/vpn-network-options.rst":[{"author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"169a4d4f2db2c99fa0efc170ef875ab048ffa719","unresolved":true,"context_lines":[{"line_number":404,"context_line":"        default taken from ``--route-metric`` if set, otherwise :code:`0`."},{"line_number":405,"context_line":""},{"line_number":406,"context_line":"  ``table-id`` (Supported on Linux only, on other platforms this is a no-op)."},{"line_number":407,"context_line":"\tdefault taken from ``--route-table`` if set, otherwise :code:`0`."},{"line_number":408,"context_line":""},{"line_number":409,"context_line":"  The default can be specified by leaving an option blank or setting it to"},{"line_number":410,"context_line":"  :code:`default`."}],"source_content_type":"text/x-rst","patch_set":1,"id":"22a0a3ac_de6d8584","line":407,"updated":"2024-02-16 16:35:10.000000000","message":"Please change tab to spaces","commit_id":"29e2c24f556de8e0c83907ba483ee2af149514e6"},{"author":{"_account_id":1000034,"name":"Gianmarco De Gregori","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"change_message_id":"a484972a1e60038799604a916578b7b5d10fd364","unresolved":false,"context_lines":[{"line_number":404,"context_line":"        default taken from ``--route-metric`` if set, otherwise :code:`0`."},{"line_number":405,"context_line":""},{"line_number":406,"context_line":"  ``table-id`` (Supported on Linux only, on other platforms this is a no-op)."},{"line_number":407,"context_line":"\tdefault taken from ``--route-table`` if set, otherwise :code:`0`."},{"line_number":408,"context_line":""},{"line_number":409,"context_line":"  The default can be specified by leaving an option blank or setting it to"},{"line_number":410,"context_line":"  :code:`default`."}],"source_content_type":"text/x-rst","patch_set":1,"id":"8ef327d5_482e958e","line":407,"in_reply_to":"22a0a3ac_de6d8584","updated":"2024-02-20 13:58:11.000000000","message":"Done","commit_id":"29e2c24f556de8e0c83907ba483ee2af149514e6"},{"author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"169a4d4f2db2c99fa0efc170ef875ab048ffa719","unresolved":true,"context_lines":[{"line_number":405,"context_line":""},{"line_number":406,"context_line":"  ``table-id`` (Supported on Linux only, on other platforms this is a no-op)."},{"line_number":407,"context_line":"\tdefault taken from ``--route-table`` if set, otherwise :code:`0`."},{"line_number":408,"context_line":""},{"line_number":409,"context_line":"  The default can be specified by leaving an option blank or setting it to"},{"line_number":410,"context_line":"  :code:`default`."},{"line_number":411,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"f27813f8_b24586f4","line":408,"updated":"2024-02-16 16:35:10.000000000","message":"Should document that table-id can\u0027t be pushed.","commit_id":"29e2c24f556de8e0c83907ba483ee2af149514e6"},{"author":{"_account_id":1000034,"name":"Gianmarco De Gregori","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"change_message_id":"a484972a1e60038799604a916578b7b5d10fd364","unresolved":false,"context_lines":[{"line_number":405,"context_line":""},{"line_number":406,"context_line":"  ``table-id`` (Supported on Linux only, on other platforms this is a no-op)."},{"line_number":407,"context_line":"\tdefault taken from ``--route-table`` if set, otherwise :code:`0`."},{"line_number":408,"context_line":""},{"line_number":409,"context_line":"  The default can be specified by leaving an option blank or setting it to"},{"line_number":410,"context_line":"  :code:`default`."},{"line_number":411,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"9c8be01e_92c07a0f","line":408,"in_reply_to":"f27813f8_b24586f4","updated":"2024-02-20 13:58:11.000000000","message":"Done","commit_id":"29e2c24f556de8e0c83907ba483ee2af149514e6"},{"author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"169a4d4f2db2c99fa0efc170ef875ab048ffa719","unresolved":true,"context_lines":[{"line_number":461,"context_line":"  The gateway parameter is only used for IPv6 routes across *tap* devices,"},{"line_number":462,"context_line":"  and if missing, the ``ipv6remote`` field from ``--ifconfig-ipv6`` or"},{"line_number":463,"context_line":"  ``--route-ipv6-gateway`` is used."},{"line_number":464,"context_line":""},{"line_number":465,"context_line":"  (table-id supported on Linux only, on other platforms this is a no-op)."},{"line_number":466,"context_line":""},{"line_number":467,"context_line":"--route-gateway arg"}],"source_content_type":"text/x-rst","patch_set":1,"id":"a3b9a424_093b4876","line":464,"updated":"2024-02-16 16:35:10.000000000","message":"might be a good opportunity to make the description of --route-ipv6 more consistent with --route? Currently the descriptions are of a very different format and verbosity even though the options are very similar","commit_id":"29e2c24f556de8e0c83907ba483ee2af149514e6"},{"author":{"_account_id":1000034,"name":"Gianmarco De Gregori","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"change_message_id":"a484972a1e60038799604a916578b7b5d10fd364","unresolved":false,"context_lines":[{"line_number":461,"context_line":"  The gateway parameter is only used for IPv6 routes across *tap* devices,"},{"line_number":462,"context_line":"  and if missing, the ``ipv6remote`` field from ``--ifconfig-ipv6`` or"},{"line_number":463,"context_line":"  ``--route-ipv6-gateway`` is used."},{"line_number":464,"context_line":""},{"line_number":465,"context_line":"  (table-id supported on Linux only, on other platforms this is a no-op)."},{"line_number":466,"context_line":""},{"line_number":467,"context_line":"--route-gateway arg"}],"source_content_type":"text/x-rst","patch_set":1,"id":"2891fff7_f030a0a0","line":464,"in_reply_to":"a3b9a424_093b4876","updated":"2024-02-20 13:58:11.000000000","message":"Done","commit_id":"29e2c24f556de8e0c83907ba483ee2af149514e6"},{"author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"cfee8be6851782f9ab7ef99a21c4b670303d21bb","unresolved":true,"context_lines":[{"line_number":371,"context_line":"  Specify a default table id for use with --route."},{"line_number":372,"context_line":"  By default, OpenVPN installs routes in the main routing"},{"line_number":373,"context_line":"  table of the operating system, but with this option,"},{"line_number":374,"context_line":"  a user defined routing table can be used instead."},{"line_number":375,"context_line":""},{"line_number":376,"context_line":"  (Supported on Linux only, on other platforms this is a no-op)."},{"line_number":377,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"29fafc4d_019065e1","line":374,"updated":"2024-03-12 17:11:24.000000000","message":"\"an user\"","commit_id":"18f11fe84357352a76137985233fee3377111c5c"},{"author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"e197a5bc1244645e497515a4758e0666513e090e","unresolved":false,"context_lines":[{"line_number":371,"context_line":"  Specify a default table id for use with --route."},{"line_number":372,"context_line":"  By default, OpenVPN installs routes in the main routing"},{"line_number":373,"context_line":"  table of the operating system, but with this option,"},{"line_number":374,"context_line":"  a user defined routing table can be used instead."},{"line_number":375,"context_line":""},{"line_number":376,"context_line":"  (Supported on Linux only, on other platforms this is a no-op)."},{"line_number":377,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"07a1a344_6d18a9c3","line":374,"in_reply_to":"28a9b0d7_797a7b8f","updated":"2024-03-13 10:25:43.000000000","message":"Acknowledged","commit_id":"18f11fe84357352a76137985233fee3377111c5c"},{"author":{"_account_id":1000034,"name":"Gianmarco De Gregori","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"change_message_id":"d7c72dff9c2091d9ac07dddd41e975bb2ed339be","unresolved":true,"context_lines":[{"line_number":371,"context_line":"  Specify a default table id for use with --route."},{"line_number":372,"context_line":"  By default, OpenVPN installs routes in the main routing"},{"line_number":373,"context_line":"  table of the operating system, but with this option,"},{"line_number":374,"context_line":"  a user defined routing table can be used instead."},{"line_number":375,"context_line":""},{"line_number":376,"context_line":"  (Supported on Linux only, on other platforms this is a no-op)."},{"line_number":377,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"28a9b0d7_797a7b8f","line":374,"in_reply_to":"29fafc4d_019065e1","updated":"2024-03-13 08:38:05.000000000","message":"Since \"user\" begins with a consonant sound \"y\" (as in \"you\"), \"a\" is the appropriate article to use. You would say \"a unicorn\" instead of \"an unicorn\" imho.","commit_id":"18f11fe84357352a76137985233fee3377111c5c"},{"author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"cfee8be6851782f9ab7ef99a21c4b670303d21bb","unresolved":true,"context_lines":[{"line_number":404,"context_line":"        default taken from ``--route-metric`` if set, otherwise :code:`0`."},{"line_number":405,"context_line":""},{"line_number":406,"context_line":"  ``table-id`` (Supported on Linux only, on other platforms this is a no-op)."},{"line_number":407,"context_line":"        Since this option must be an entirely local choice, won\u0027t be pushable."},{"line_number":408,"context_line":"\t      default taken from ``--route-table`` if set, otherwise :code:`0`."},{"line_number":409,"context_line":""},{"line_number":410,"context_line":"  The default can be specified by leaving an option blank or setting it to"}],"source_content_type":"text/x-rst","patch_set":3,"id":"cfaf208a_43bb3e07","line":407,"updated":"2024-03-12 17:11:24.000000000","message":"Time seems weird to me, would change to \"it isn\u0027t pushable\"","commit_id":"18f11fe84357352a76137985233fee3377111c5c"},{"author":{"_account_id":1000034,"name":"Gianmarco De Gregori","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"change_message_id":"d7c72dff9c2091d9ac07dddd41e975bb2ed339be","unresolved":false,"context_lines":[{"line_number":404,"context_line":"        default taken from ``--route-metric`` if set, otherwise :code:`0`."},{"line_number":405,"context_line":""},{"line_number":406,"context_line":"  ``table-id`` (Supported on Linux only, on other platforms this is a no-op)."},{"line_number":407,"context_line":"        Since this option must be an entirely local choice, won\u0027t be pushable."},{"line_number":408,"context_line":"\t      default taken from ``--route-table`` if set, otherwise :code:`0`."},{"line_number":409,"context_line":""},{"line_number":410,"context_line":"  The default can be specified by leaving an option blank or setting it to"}],"source_content_type":"text/x-rst","patch_set":3,"id":"fc3149bd_56ee7cdc","line":407,"in_reply_to":"cfaf208a_43bb3e07","updated":"2024-03-13 08:38:05.000000000","message":"Done","commit_id":"18f11fe84357352a76137985233fee3377111c5c"},{"author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"cfee8be6851782f9ab7ef99a21c4b670303d21bb","unresolved":true,"context_lines":[{"line_number":405,"context_line":""},{"line_number":406,"context_line":"  ``table-id`` (Supported on Linux only, on other platforms this is a no-op)."},{"line_number":407,"context_line":"        Since this option must be an entirely local choice, won\u0027t be pushable."},{"line_number":408,"context_line":"\t      default taken from ``--route-table`` if set, otherwise :code:`0`."},{"line_number":409,"context_line":""},{"line_number":410,"context_line":"  The default can be specified by leaving an option blank or setting it to"},{"line_number":411,"context_line":"  :code:`default`."}],"source_content_type":"text/x-rst","patch_set":3,"id":"c5dce9cb_c194c9e8","line":408,"updated":"2024-03-12 17:11:24.000000000","message":"please change tab to space","commit_id":"18f11fe84357352a76137985233fee3377111c5c"},{"author":{"_account_id":1000034,"name":"Gianmarco De Gregori","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"change_message_id":"d7c72dff9c2091d9ac07dddd41e975bb2ed339be","unresolved":false,"context_lines":[{"line_number":405,"context_line":""},{"line_number":406,"context_line":"  ``table-id`` (Supported on Linux only, on other platforms this is a no-op)."},{"line_number":407,"context_line":"        Since this option must be an entirely local choice, won\u0027t be pushable."},{"line_number":408,"context_line":"\t      default taken from ``--route-table`` if set, otherwise :code:`0`."},{"line_number":409,"context_line":""},{"line_number":410,"context_line":"  The default can be specified by leaving an option blank or setting it to"},{"line_number":411,"context_line":"  :code:`default`."}],"source_content_type":"text/x-rst","patch_set":3,"id":"293941ea_2c34e0eb","line":408,"in_reply_to":"c5dce9cb_c194c9e8","updated":"2024-03-13 08:38:05.000000000","message":"Done","commit_id":"18f11fe84357352a76137985233fee3377111c5c"},{"author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"cfee8be6851782f9ab7ef99a21c4b670303d21bb","unresolved":true,"context_lines":[{"line_number":458,"context_line":"  ::"},{"line_number":459,"context_line":""},{"line_number":460,"context_line":"     route-ipv6 ipv6addr/bits"},{"line_number":461,"context_line":"     route-ipv6 ipv6addr/bits [gateway]"},{"line_number":462,"context_line":"     route-ipv6 ipv6addr/bits [gateway] [metric]"},{"line_number":463,"context_line":"     route-ipv6 ipv6addr/bits [gateway] [metric] [table-id]"},{"line_number":464,"context_line":"  "}],"source_content_type":"text/x-rst","patch_set":3,"id":"186800fb_289c2ebc","line":461,"updated":"2024-03-12 17:11:24.000000000","message":"when listing all possible choices, you can leave off the \"[\" optional markers","commit_id":"18f11fe84357352a76137985233fee3377111c5c"},{"author":{"_account_id":1000034,"name":"Gianmarco De Gregori","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"change_message_id":"d7c72dff9c2091d9ac07dddd41e975bb2ed339be","unresolved":false,"context_lines":[{"line_number":458,"context_line":"  ::"},{"line_number":459,"context_line":""},{"line_number":460,"context_line":"     route-ipv6 ipv6addr/bits"},{"line_number":461,"context_line":"     route-ipv6 ipv6addr/bits [gateway]"},{"line_number":462,"context_line":"     route-ipv6 ipv6addr/bits [gateway] [metric]"},{"line_number":463,"context_line":"     route-ipv6 ipv6addr/bits [gateway] [metric] [table-id]"},{"line_number":464,"context_line":"  "}],"source_content_type":"text/x-rst","patch_set":3,"id":"d10bebfd_142729b1","line":461,"in_reply_to":"186800fb_289c2ebc","updated":"2024-03-13 08:38:05.000000000","message":"Done","commit_id":"18f11fe84357352a76137985233fee3377111c5c"},{"author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"cfee8be6851782f9ab7ef99a21c4b670303d21bb","unresolved":true,"context_lines":[{"line_number":461,"context_line":"     route-ipv6 ipv6addr/bits [gateway]"},{"line_number":462,"context_line":"     route-ipv6 ipv6addr/bits [gateway] [metric]"},{"line_number":463,"context_line":"     route-ipv6 ipv6addr/bits [gateway] [metric] [table-id]"},{"line_number":464,"context_line":"  "},{"line_number":465,"context_line":"  ``gateway``"},{"line_number":466,"context_line":"        Only used for IPv6 routes across *tap* devices,"},{"line_number":467,"context_line":"        and if missing, the ``ipv6remote`` field from ``--ifconfig-ipv6`` or"}],"source_content_type":"text/x-rst","patch_set":3,"id":"dc32db5a_b03f8605","line":464,"updated":"2024-03-12 17:11:24.000000000","message":"trailing whitespace","commit_id":"18f11fe84357352a76137985233fee3377111c5c"},{"author":{"_account_id":1000034,"name":"Gianmarco De Gregori","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"change_message_id":"d7c72dff9c2091d9ac07dddd41e975bb2ed339be","unresolved":false,"context_lines":[{"line_number":461,"context_line":"     route-ipv6 ipv6addr/bits [gateway]"},{"line_number":462,"context_line":"     route-ipv6 ipv6addr/bits [gateway] [metric]"},{"line_number":463,"context_line":"     route-ipv6 ipv6addr/bits [gateway] [metric] [table-id]"},{"line_number":464,"context_line":"  "},{"line_number":465,"context_line":"  ``gateway``"},{"line_number":466,"context_line":"        Only used for IPv6 routes across *tap* devices,"},{"line_number":467,"context_line":"        and if missing, the ``ipv6remote`` field from ``--ifconfig-ipv6`` or"}],"source_content_type":"text/x-rst","patch_set":3,"id":"a4df0975_2ea65b9f","line":464,"in_reply_to":"dc32db5a_b03f8605","updated":"2024-03-13 08:38:05.000000000","message":"Done","commit_id":"18f11fe84357352a76137985233fee3377111c5c"},{"author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"cfee8be6851782f9ab7ef99a21c4b670303d21bb","unresolved":true,"context_lines":[{"line_number":472,"context_line":""},{"line_number":473,"context_line":"  ``table-id`` (Supported on Linux only, on other platforms this is a no-op)."},{"line_number":474,"context_line":"        Since this option must be an entirely local choice, won\u0027t be pushable."},{"line_number":475,"context_line":"\t      default taken from ``--route-table`` if set, otherwise :code:`0`."},{"line_number":476,"context_line":""},{"line_number":477,"context_line":"--route-gateway arg"},{"line_number":478,"context_line":"  Specify a default *gateway* for use with ``--route``."}],"source_content_type":"text/x-rst","patch_set":3,"id":"c7665500_392297ff","line":475,"updated":"2024-03-12 17:11:24.000000000","message":"same comments apply here as for --route (tab, won\u0027t-\u003eit isn\u0027t)","commit_id":"18f11fe84357352a76137985233fee3377111c5c"},{"author":{"_account_id":1000034,"name":"Gianmarco De Gregori","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"change_message_id":"d7c72dff9c2091d9ac07dddd41e975bb2ed339be","unresolved":false,"context_lines":[{"line_number":472,"context_line":""},{"line_number":473,"context_line":"  ``table-id`` (Supported on Linux only, on other platforms this is a no-op)."},{"line_number":474,"context_line":"        Since this option must be an entirely local choice, won\u0027t be pushable."},{"line_number":475,"context_line":"\t      default taken from ``--route-table`` if set, otherwise :code:`0`."},{"line_number":476,"context_line":""},{"line_number":477,"context_line":"--route-gateway arg"},{"line_number":478,"context_line":"  Specify a default *gateway* for use with ``--route``."}],"source_content_type":"text/x-rst","patch_set":3,"id":"1d25817b_bf7cb0e6","line":475,"in_reply_to":"c7665500_392297ff","updated":"2024-03-13 08:38:05.000000000","message":"Done","commit_id":"18f11fe84357352a76137985233fee3377111c5c"}],"src/openvpn/options.c":[{"author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"169a4d4f2db2c99fa0efc170ef875ab048ffa719","unresolved":true,"context_lines":[{"line_number":202,"context_line":"    \"--ifconfig-nowarn : Don\u0027t warn if the --ifconfig option on this side of the\\n\""},{"line_number":203,"context_line":"    \"                    connection doesn\u0027t match the remote side.\\n\""},{"line_number":204,"context_line":"#ifdef TARGET_LINUX"},{"line_number":205,"context_line":"    \"--route-table [table_id] : Specify a custom routing table for use with --route(-ipv6).\\n\""},{"line_number":206,"context_line":"    \"                           If not specified, the id of the default routing table will be used.\\n\""},{"line_number":207,"context_line":"#endif"},{"line_number":208,"context_line":"    \"--route network [netmask] [gateway] [metric] :\\n\""}],"source_content_type":"text/x-csrc","patch_set":1,"id":"ca4f68fc_2a1a10c0","line":205,"updated":"2024-02-16 16:35:10.000000000","message":"table_id is not optional, so don\u0027t use brackets here","commit_id":"29e2c24f556de8e0c83907ba483ee2af149514e6"},{"author":{"_account_id":1000034,"name":"Gianmarco De Gregori","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"change_message_id":"a484972a1e60038799604a916578b7b5d10fd364","unresolved":false,"context_lines":[{"line_number":202,"context_line":"    \"--ifconfig-nowarn : Don\u0027t warn if the --ifconfig option on this side of the\\n\""},{"line_number":203,"context_line":"    \"                    connection doesn\u0027t match the remote side.\\n\""},{"line_number":204,"context_line":"#ifdef TARGET_LINUX"},{"line_number":205,"context_line":"    \"--route-table [table_id] : Specify a custom routing table for use with --route(-ipv6).\\n\""},{"line_number":206,"context_line":"    \"                           If not specified, the id of the default routing table will be used.\\n\""},{"line_number":207,"context_line":"#endif"},{"line_number":208,"context_line":"    \"--route network [netmask] [gateway] [metric] :\\n\""}],"source_content_type":"text/x-csrc","patch_set":1,"id":"0ca031f1_18cfb87a","line":205,"in_reply_to":"ca4f68fc_2a1a10c0","updated":"2024-02-20 13:58:11.000000000","message":"Done","commit_id":"29e2c24f556de8e0c83907ba483ee2af149514e6"},{"author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"169a4d4f2db2c99fa0efc170ef875ab048ffa719","unresolved":true,"context_lines":[{"line_number":6989,"context_line":"    else if (streq(p[0], \"route-table\") \u0026\u0026 p[1] \u0026\u0026 !p[2])"},{"line_number":6990,"context_line":"    {"},{"line_number":6991,"context_line":"#ifndef ENABLE_SITNL"},{"line_number":6992,"context_line":"        msg(M_WARN, \"NOTE: --route-table specified, but not supported on this platform\");"},{"line_number":6993,"context_line":"#endif"},{"line_number":6994,"context_line":"        VERIFY_PERMISSION(OPT_P_ROUTE_TABLE);"},{"line_number":6995,"context_line":"        options-\u003eroute_default_table_id \u003d positive_atoi(p[1]);"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"a60bb82d_c3d5db58","line":6992,"updated":"2024-02-16 16:35:10.000000000","message":"This warning would be confusing with a Linux build with --enable-iproute2. Maybe those should be two separate warnings?","commit_id":"29e2c24f556de8e0c83907ba483ee2af149514e6"},{"author":{"_account_id":1000034,"name":"Gianmarco De Gregori","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"change_message_id":"a484972a1e60038799604a916578b7b5d10fd364","unresolved":false,"context_lines":[{"line_number":6989,"context_line":"    else if (streq(p[0], \"route-table\") \u0026\u0026 p[1] \u0026\u0026 !p[2])"},{"line_number":6990,"context_line":"    {"},{"line_number":6991,"context_line":"#ifndef ENABLE_SITNL"},{"line_number":6992,"context_line":"        msg(M_WARN, \"NOTE: --route-table specified, but not supported on this platform\");"},{"line_number":6993,"context_line":"#endif"},{"line_number":6994,"context_line":"        VERIFY_PERMISSION(OPT_P_ROUTE_TABLE);"},{"line_number":6995,"context_line":"        options-\u003eroute_default_table_id \u003d positive_atoi(p[1]);"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"e912ffc8_22f4e21d","line":6992,"in_reply_to":"3d97c488_535a77ac","updated":"2024-02-20 13:58:11.000000000","message":"Done","commit_id":"29e2c24f556de8e0c83907ba483ee2af149514e6"},{"author":{"_account_id":1000034,"name":"Gianmarco De Gregori","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"change_message_id":"3ccd3f792f884ce2372ca4f83e0dd899757ef314","unresolved":true,"context_lines":[{"line_number":6989,"context_line":"    else if (streq(p[0], \"route-table\") \u0026\u0026 p[1] \u0026\u0026 !p[2])"},{"line_number":6990,"context_line":"    {"},{"line_number":6991,"context_line":"#ifndef ENABLE_SITNL"},{"line_number":6992,"context_line":"        msg(M_WARN, \"NOTE: --route-table specified, but not supported on this platform\");"},{"line_number":6993,"context_line":"#endif"},{"line_number":6994,"context_line":"        VERIFY_PERMISSION(OPT_P_ROUTE_TABLE);"},{"line_number":6995,"context_line":"        options-\u003eroute_default_table_id \u003d positive_atoi(p[1]);"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"d372a561_90367367","line":6992,"in_reply_to":"a60bb82d_c3d5db58","updated":"2024-02-20 13:33:18.000000000","message":"What about \"Table_id is supported only on Linux when SITNL is built-in\" so we know that in case we\u0027re on Linux but there\u0027s not SITNL -\u003e \"SITNL is required\", on the other hand if we\u0027re not on Linux -\u003e \"this is Linux only\"","commit_id":"29e2c24f556de8e0c83907ba483ee2af149514e6"},{"author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"a20332bd564d3cc37b658dcd288b942819f625f1","unresolved":true,"context_lines":[{"line_number":6989,"context_line":"    else if (streq(p[0], \"route-table\") \u0026\u0026 p[1] \u0026\u0026 !p[2])"},{"line_number":6990,"context_line":"    {"},{"line_number":6991,"context_line":"#ifndef ENABLE_SITNL"},{"line_number":6992,"context_line":"        msg(M_WARN, \"NOTE: --route-table specified, but not supported on this platform\");"},{"line_number":6993,"context_line":"#endif"},{"line_number":6994,"context_line":"        VERIFY_PERMISSION(OPT_P_ROUTE_TABLE);"},{"line_number":6995,"context_line":"        options-\u003eroute_default_table_id \u003d positive_atoi(p[1]);"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"3d97c488_535a77ac","line":6992,"in_reply_to":"d372a561_90367367","updated":"2024-02-20 13:44:42.000000000","message":"Sounds good to me.","commit_id":"29e2c24f556de8e0c83907ba483ee2af149514e6"},{"author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"9bca6cf5193be45146057d503ab86ff45059cd5f","unresolved":true,"context_lines":[{"line_number":7017,"context_line":"        msg(M_WARN, \"NOTE: --route-table is supported only on Linux when SITNL is built-in\");"},{"line_number":7018,"context_line":"#endif"},{"line_number":7019,"context_line":"        VERIFY_PERMISSION(OPT_P_ROUTE_TABLE);"},{"line_number":7020,"context_line":"        options-\u003eroute_default_table_id \u003d positive_atoi(p[1]);"},{"line_number":7021,"context_line":"    }"},{"line_number":7022,"context_line":"    else if (streq(p[0], \"route\") \u0026\u0026 p[1] \u0026\u0026 !p[5])"},{"line_number":7023,"context_line":"    {"}],"source_content_type":"text/x-csrc","patch_set":8,"id":"5ca01c93_caaa3aa2","line":7020,"updated":"2025-06-18 16:28:34.000000000","message":"Unfortunately, `positive_atoi()` now wants 2 arguments... (`msglevel`).  So this needs a rebase \u0026 fixup.","commit_id":"7af41191f4e49f4197daed9819fa241050903e45"},{"author":{"_account_id":1000034,"name":"Gianmarco De Gregori","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"change_message_id":"cdf194529faaf05664c3367c2bbfb62c8e849c52","unresolved":false,"context_lines":[{"line_number":7017,"context_line":"        msg(M_WARN, \"NOTE: --route-table is supported only on Linux when SITNL is built-in\");"},{"line_number":7018,"context_line":"#endif"},{"line_number":7019,"context_line":"        VERIFY_PERMISSION(OPT_P_ROUTE_TABLE);"},{"line_number":7020,"context_line":"        options-\u003eroute_default_table_id \u003d positive_atoi(p[1]);"},{"line_number":7021,"context_line":"    }"},{"line_number":7022,"context_line":"    else if (streq(p[0], \"route\") \u0026\u0026 p[1] \u0026\u0026 !p[5])"},{"line_number":7023,"context_line":"    {"}],"source_content_type":"text/x-csrc","patch_set":8,"id":"4a43f18d_49c13bde","line":7020,"in_reply_to":"5ca01c93_caaa3aa2","updated":"2025-06-19 16:04:36.000000000","message":"Done","commit_id":"7af41191f4e49f4197daed9819fa241050903e45"}],"src/openvpn/options.h":[{"author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"169a4d4f2db2c99fa0efc170ef875ab048ffa719","unresolved":true,"context_lines":[{"line_number":742,"context_line":"#define OPT_P_PEER_ID         (1\u003c\u003c28)"},{"line_number":743,"context_line":"#define OPT_P_INLINE          (1\u003c\u003c29)"},{"line_number":744,"context_line":"#define OPT_P_PUSH_MTU        (1\u003c\u003c30)"},{"line_number":745,"context_line":"#define OPT_P_ROUTE_TABLE     (1\u003c\u003c31)"},{"line_number":746,"context_line":""},{"line_number":747,"context_line":"#define OPT_P_DEFAULT   (~(OPT_P_INSTANCE|OPT_P_PULL_MODE))"},{"line_number":748,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":1,"id":"f5eb20b0_42a87049","line":745,"updated":"2024-02-16 16:35:10.000000000","message":"it is not clear to my why you need a separate permission entry here? Should maybe add a comment about this.","commit_id":"29e2c24f556de8e0c83907ba483ee2af149514e6"},{"author":{"_account_id":1000034,"name":"Gianmarco De Gregori","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"change_message_id":"3bb97539d6fed783b7cf4e88f4fde742bf6b3f12","unresolved":false,"context_lines":[{"line_number":742,"context_line":"#define OPT_P_PEER_ID         (1\u003c\u003c28)"},{"line_number":743,"context_line":"#define OPT_P_INLINE          (1\u003c\u003c29)"},{"line_number":744,"context_line":"#define OPT_P_PUSH_MTU        (1\u003c\u003c30)"},{"line_number":745,"context_line":"#define OPT_P_ROUTE_TABLE     (1\u003c\u003c31)"},{"line_number":746,"context_line":""},{"line_number":747,"context_line":"#define OPT_P_DEFAULT   (~(OPT_P_INSTANCE|OPT_P_PULL_MODE))"},{"line_number":748,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":1,"id":"81e9279e_e04fe802","line":745,"in_reply_to":"f5eb20b0_42a87049","updated":"2024-02-19 15:52:50.000000000","message":"Acknowledged","commit_id":"29e2c24f556de8e0c83907ba483ee2af149514e6"}],"src/openvpn/route.c":[{"author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"9bca6cf5193be45146057d503ab86ff45059cd5f","unresolved":true,"context_lines":[{"line_number":329,"context_line":"    CLEAR(*r);"},{"line_number":330,"context_line":"    r-\u003eoption \u003d ro;"},{"line_number":331,"context_line":""},{"line_number":332,"context_line":"    /* network */"},{"line_number":333,"context_line":""},{"line_number":334,"context_line":"    if (!is_route_parm_defined(ro-\u003enetwork))"},{"line_number":335,"context_line":"    {"}],"source_content_type":"text/x-csrc","patch_set":8,"id":"2f114621_8e4ffe35","side":"PARENT","line":332,"updated":"2025-06-18 16:28:34.000000000","message":"spurious blank line removal... if you want to remove one, I think removing the one after the `/* network */` comment makes more sense, and maybe one of the 2 blank lines further down (337).  But removing this one does no good.","commit_id":"d8490738e64a5bbf00d6f08af03fef58f7488140"},{"author":{"_account_id":1000034,"name":"Gianmarco De Gregori","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"change_message_id":"cdf194529faaf05664c3367c2bbfb62c8e849c52","unresolved":false,"context_lines":[{"line_number":329,"context_line":"    CLEAR(*r);"},{"line_number":330,"context_line":"    r-\u003eoption \u003d ro;"},{"line_number":331,"context_line":""},{"line_number":332,"context_line":"    /* network */"},{"line_number":333,"context_line":""},{"line_number":334,"context_line":"    if (!is_route_parm_defined(ro-\u003enetwork))"},{"line_number":335,"context_line":"    {"}],"source_content_type":"text/x-csrc","patch_set":8,"id":"c62432ad_b77f46d7","side":"PARENT","line":332,"in_reply_to":"2f114621_8e4ffe35","updated":"2025-06-19 16:04:36.000000000","message":"Done","commit_id":"d8490738e64a5bbf00d6f08af03fef58f7488140"}],"src/openvpn/route.h":[{"author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"cfee8be6851782f9ab7ef99a21c4b670303d21bb","unresolved":true,"context_lines":[{"line_number":95,"context_line":""},{"line_number":96,"context_line":"struct route_option_list {"},{"line_number":97,"context_line":"    unsigned int flags; /* RG_x flags */"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    struct route_option *routes;"},{"line_number":100,"context_line":"    struct gc_arena *gc;"},{"line_number":101,"context_line":"};"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"f42523ea_da5a7db8","line":98,"updated":"2024-03-12 17:11:24.000000000","message":"spurious whitespace?","commit_id":"18f11fe84357352a76137985233fee3377111c5c"},{"author":{"_account_id":1000034,"name":"Gianmarco De Gregori","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"change_message_id":"d7c72dff9c2091d9ac07dddd41e975bb2ed339be","unresolved":false,"context_lines":[{"line_number":95,"context_line":""},{"line_number":96,"context_line":"struct route_option_list {"},{"line_number":97,"context_line":"    unsigned int flags; /* RG_x flags */"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    struct route_option *routes;"},{"line_number":100,"context_line":"    struct gc_arena *gc;"},{"line_number":101,"context_line":"};"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"4897ce61_2c46962d","line":98,"in_reply_to":"f42523ea_da5a7db8","updated":"2024-03-13 08:38:05.000000000","message":"Done","commit_id":"18f11fe84357352a76137985233fee3377111c5c"}]}
