)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"c8bf06fec7faf6a787943ed3ff498f43ac5ec890","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Persist-key: enable persist-key option by default"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This commit changes the default behavior of the OpenVPN"},{"line_number":10,"context_line":"configuration to enable the persist-key option by default."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This means that all the key file content will be kept"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"99bc33fe_177eba51","line":9,"updated":"2024-02-20 13:42:54.000000000","message":"Nitpick: just use \"Change the default behavior\". \"This commit\" is redundant and clunky.","commit_id":"a0acb6539b20a43f38e48162674f0d238a207085"},{"author":{"_account_id":1000034,"name":"its_Giaan","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"change_message_id":"480a8242752b7c35233db18c76417ab5f35ddba4","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Persist-key: enable persist-key option by default"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This commit changes the default behavior of the OpenVPN"},{"line_number":10,"context_line":"configuration to enable the persist-key option by default."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This means that all the key file content will be kept"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"e10934a7_2866e37f","line":9,"in_reply_to":"99bc33fe_177eba51","updated":"2024-02-20 14:10:50.000000000","message":"Done","commit_id":"a0acb6539b20a43f38e48162674f0d238a207085"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"c8bf06fec7faf6a787943ed3ff498f43ac5ec890","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f1d88452_7788c182","updated":"2024-02-20 13:42:54.000000000","message":"Functionally looks good to me. Some documentation improvements suggested.","commit_id":"a0acb6539b20a43f38e48162674f0d238a207085"},{"author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"6472d57e9f512a33ae5be7646c290b201cd10c28","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c7239d22_84a7af24","updated":"2024-03-04 16:31:36.000000000","message":"An entry in Changes.rst is missing.","commit_id":"96b96026594a8f0a5a221521fff6f1e694bec074"},{"author":{"_account_id":1000034,"name":"its_Giaan","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"change_message_id":"6ee799ff4697b0f8de3275fdc886b35acae829f0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"9f052b2e_8851d3b8","in_reply_to":"c7239d22_84a7af24","updated":"2024-03-05 08:30:52.000000000","message":"Acknowledged","commit_id":"96b96026594a8f0a5a221521fff6f1e694bec074"}],"doc/man-sections/signals.rst":[{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"c8bf06fec7faf6a787943ed3ff498f43ac5ec890","unresolved":true,"context_lines":[{"line_number":10,"context_line":"    Like :code:`SIGHUP``, except don\u0027t re-read configuration file, and"},{"line_number":11,"context_line":"    possibly don\u0027t close and reopen TUN/TAP device, re-read key files,"},{"line_number":12,"context_line":"    preserve local IP address/port, or preserve most recently authenticated"},{"line_number":13,"context_line":"    remote IP address/port based on ``--persist-tun``, ``--persist-local-ip`` "},{"line_number":14,"context_line":"    and ``--persist-remote-ip`` options respectively (see above)."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"    This signal may also be internally generated by a timeout condition,"}],"source_content_type":"text/x-rst","patch_set":1,"id":"4c986d46_e82cde2f","line":13,"updated":"2024-02-20 13:42:54.000000000","message":"Trailing whitespace","commit_id":"a0acb6539b20a43f38e48162674f0d238a207085"},{"author":{"_account_id":1000034,"name":"its_Giaan","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"change_message_id":"480a8242752b7c35233db18c76417ab5f35ddba4","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    Like :code:`SIGHUP``, except don\u0027t re-read configuration file, and"},{"line_number":11,"context_line":"    possibly don\u0027t close and reopen TUN/TAP device, re-read key files,"},{"line_number":12,"context_line":"    preserve local IP address/port, or preserve most recently authenticated"},{"line_number":13,"context_line":"    remote IP address/port based on ``--persist-tun``, ``--persist-local-ip`` "},{"line_number":14,"context_line":"    and ``--persist-remote-ip`` options respectively (see above)."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"    This signal may also be internally generated by a timeout condition,"}],"source_content_type":"text/x-rst","patch_set":1,"id":"cd5281ba_35c80d22","line":13,"in_reply_to":"4c986d46_e82cde2f","updated":"2024-02-20 14:10:50.000000000","message":"Done","commit_id":"a0acb6539b20a43f38e48162674f0d238a207085"}],"doc/man-sections/unsupported-options.rst":[{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"c8bf06fec7faf6a787943ed3ff498f43ac5ec890","unresolved":true,"context_lines":[{"line_number":44,"context_line":"  Removed in OpenVPN 2.6.  We now always use the PRNG of the SSL library."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"--persist-key"},{"line_number":47,"context_line":"  Removed in OpenVPN 2.7. Corresponding behavior is now always enabled."}],"source_content_type":"text/x-rst","patch_set":1,"id":"8164c8c9_a1ae98fb","line":47,"updated":"2024-02-20 13:42:54.000000000","message":"\"Corresponding behavior\" is very vague. Let\u0027s write \"Keys are now always persisted across restarts\" or something like that.","commit_id":"a0acb6539b20a43f38e48162674f0d238a207085"},{"author":{"_account_id":1000034,"name":"its_Giaan","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"change_message_id":"480a8242752b7c35233db18c76417ab5f35ddba4","unresolved":false,"context_lines":[{"line_number":44,"context_line":"  Removed in OpenVPN 2.6.  We now always use the PRNG of the SSL library."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"--persist-key"},{"line_number":47,"context_line":"  Removed in OpenVPN 2.7. Corresponding behavior is now always enabled."}],"source_content_type":"text/x-rst","patch_set":1,"id":"ffcf9cec_929ec0cd","line":47,"in_reply_to":"8164c8c9_a1ae98fb","updated":"2024-02-20 14:10:50.000000000","message":"Done","commit_id":"a0acb6539b20a43f38e48162674f0d238a207085"},{"author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"6472d57e9f512a33ae5be7646c290b201cd10c28","unresolved":true,"context_lines":[{"line_number":44,"context_line":"  Removed in OpenVPN 2.6.  We now always use the PRNG of the SSL library."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"--persist-key"},{"line_number":47,"context_line":"  Removed in OpenVPN 2.7. Keys are now always persisted across restarts."}],"source_content_type":"text/x-rst","patch_set":2,"id":"eb5579c0_cf2fe0e5","line":47,"updated":"2024-03-04 16:31:36.000000000","message":"Maybe use \"Ignored\" since OpenVPN 2.7?","commit_id":"96b96026594a8f0a5a221521fff6f1e694bec074"},{"author":{"_account_id":1000034,"name":"its_Giaan","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"change_message_id":"6ee799ff4697b0f8de3275fdc886b35acae829f0","unresolved":false,"context_lines":[{"line_number":44,"context_line":"  Removed in OpenVPN 2.6.  We now always use the PRNG of the SSL library."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"--persist-key"},{"line_number":47,"context_line":"  Removed in OpenVPN 2.7. Keys are now always persisted across restarts."}],"source_content_type":"text/x-rst","patch_set":2,"id":"3e92e860_85f89117","line":47,"in_reply_to":"eb5579c0_cf2fe0e5","updated":"2024-03-05 08:30:52.000000000","message":"Acknowledged","commit_id":"96b96026594a8f0a5a221521fff6f1e694bec074"}],"sample/sample-config-files/server.conf":[{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"c8bf06fec7faf6a787943ed3ff498f43ac5ec890","unresolved":true,"context_lines":[{"line_number":274,"context_line":";user openvpn"},{"line_number":275,"context_line":";group openvpn"},{"line_number":276,"context_line":""},{"line_number":277,"context_line":"# The persist options will try to avoid"},{"line_number":278,"context_line":"# accessing certain resources on restart"},{"line_number":279,"context_line":"# that may no longer be accessible because"},{"line_number":280,"context_line":"# of the privilege downgrade."}],"source_content_type":"text/plain","patch_set":1,"id":"910d57b4_d0613104","line":277,"updated":"2024-02-20 13:42:54.000000000","message":"Nitpick: \"The persist options\" not correct anymore, since it is only one option now 😊","commit_id":"a0acb6539b20a43f38e48162674f0d238a207085"},{"author":{"_account_id":1000034,"name":"its_Giaan","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"change_message_id":"480a8242752b7c35233db18c76417ab5f35ddba4","unresolved":false,"context_lines":[{"line_number":274,"context_line":";user openvpn"},{"line_number":275,"context_line":";group openvpn"},{"line_number":276,"context_line":""},{"line_number":277,"context_line":"# The persist options will try to avoid"},{"line_number":278,"context_line":"# accessing certain resources on restart"},{"line_number":279,"context_line":"# that may no longer be accessible because"},{"line_number":280,"context_line":"# of the privilege downgrade."}],"source_content_type":"text/plain","patch_set":1,"id":"4fe0fe2f_2a0c3f24","line":277,"in_reply_to":"910d57b4_d0613104","updated":"2024-02-20 14:10:50.000000000","message":"Done","commit_id":"a0acb6539b20a43f38e48162674f0d238a207085"}],"src/openvpn/init.c":[{"author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"6472d57e9f512a33ae5be7646c290b201cd10c28","unresolved":true,"context_lines":[{"line_number":3627,"context_line":"    }"},{"line_number":3628,"context_line":"}"},{"line_number":3629,"context_line":""},{"line_number":3630,"context_line":""},{"line_number":3631,"context_line":"struct context_buffers *"},{"line_number":3632,"context_line":"init_context_buffers(const struct frame *frame)"},{"line_number":3633,"context_line":"{"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"cab1614e_ebf8f6bc","line":3630,"updated":"2024-03-04 16:31:36.000000000","message":"random whitespace change","commit_id":"96b96026594a8f0a5a221521fff6f1e694bec074"},{"author":{"_account_id":1000034,"name":"its_Giaan","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"change_message_id":"6ee799ff4697b0f8de3275fdc886b35acae829f0","unresolved":false,"context_lines":[{"line_number":3627,"context_line":"    }"},{"line_number":3628,"context_line":"}"},{"line_number":3629,"context_line":""},{"line_number":3630,"context_line":""},{"line_number":3631,"context_line":"struct context_buffers *"},{"line_number":3632,"context_line":"init_context_buffers(const struct frame *frame)"},{"line_number":3633,"context_line":"{"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"5d665ab1_8651ae42","line":3630,"in_reply_to":"cab1614e_ebf8f6bc","updated":"2024-03-05 08:30:52.000000000","message":"Acknowledged","commit_id":"96b96026594a8f0a5a221521fff6f1e694bec074"}],"src/openvpn/options.c":[{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"c8bf06fec7faf6a787943ed3ff498f43ac5ec890","unresolved":true,"context_lines":[{"line_number":6960,"context_line":"    {"},{"line_number":6961,"context_line":"        VERIFY_PERMISSION(OPT_P_PERSIST);"},{"line_number":6962,"context_line":"        msg(M_WARN, \"DEPRECATED: --persist-key option ignored.\""},{"line_number":6963,"context_line":"            \"The corresponding behavior is now always enabled.\""},{"line_number":6964,"context_line":"            \"This option will be removed in a future version, \""},{"line_number":6965,"context_line":"            \"please remove it from your configuration.\");"},{"line_number":6966,"context_line":"    }"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"a6f6455c_7e115ef1","line":6963,"updated":"2024-02-20 13:42:54.000000000","message":"Same comment about \"corresponding behavior\"","commit_id":"a0acb6539b20a43f38e48162674f0d238a207085"},{"author":{"_account_id":1000034,"name":"its_Giaan","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"change_message_id":"480a8242752b7c35233db18c76417ab5f35ddba4","unresolved":false,"context_lines":[{"line_number":6960,"context_line":"    {"},{"line_number":6961,"context_line":"        VERIFY_PERMISSION(OPT_P_PERSIST);"},{"line_number":6962,"context_line":"        msg(M_WARN, \"DEPRECATED: --persist-key option ignored.\""},{"line_number":6963,"context_line":"            \"The corresponding behavior is now always enabled.\""},{"line_number":6964,"context_line":"            \"This option will be removed in a future version, \""},{"line_number":6965,"context_line":"            \"please remove it from your configuration.\");"},{"line_number":6966,"context_line":"    }"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"489e0245_c52b6bdb","line":6963,"in_reply_to":"a6f6455c_7e115ef1","updated":"2024-02-20 14:10:50.000000000","message":"Done","commit_id":"a0acb6539b20a43f38e48162674f0d238a207085"},{"author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"6472d57e9f512a33ae5be7646c290b201cd10c28","unresolved":true,"context_lines":[{"line_number":6962,"context_line":"        msg(M_WARN, \"DEPRECATED: --persist-key option ignored.\""},{"line_number":6963,"context_line":"            \"Keys are now always persisted across restarts.\""},{"line_number":6964,"context_line":"            \"This option will be removed in a future version, \""},{"line_number":6965,"context_line":"            \"please remove it from your configuration.\");"},{"line_number":6966,"context_line":"    }"},{"line_number":6967,"context_line":"    else if (streq(p[0], \"persist-local-ip\") \u0026\u0026 !p[1])"},{"line_number":6968,"context_line":"    {"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"6f595c78_b2ccf3fe","line":6965,"updated":"2024-03-04 16:31:36.000000000","message":"I don\u0027t think we should/warn or threaten to remove that option. That just makes configuration files incompatible in the future without a good reason to do so. For other options like max-routes, we also just ignore them.","commit_id":"96b96026594a8f0a5a221521fff6f1e694bec074"},{"author":{"_account_id":1000034,"name":"its_Giaan","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"change_message_id":"c6d6aa00ed947cc2a3308138f7153286d17b792e","unresolved":false,"context_lines":[{"line_number":6962,"context_line":"        msg(M_WARN, \"DEPRECATED: --persist-key option ignored.\""},{"line_number":6963,"context_line":"            \"Keys are now always persisted across restarts.\""},{"line_number":6964,"context_line":"            \"This option will be removed in a future version, \""},{"line_number":6965,"context_line":"            \"please remove it from your configuration.\");"},{"line_number":6966,"context_line":"    }"},{"line_number":6967,"context_line":"    else if (streq(p[0], \"persist-local-ip\") \u0026\u0026 !p[1])"},{"line_number":6968,"context_line":"    {"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"e97d1f12_d1a2e525","line":6965,"in_reply_to":"3677f02f_e3f89e35","updated":"2024-03-05 12:55:11.000000000","message":"Done","commit_id":"96b96026594a8f0a5a221521fff6f1e694bec074"},{"author":{"_account_id":1000034,"name":"its_Giaan","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"change_message_id":"6ee799ff4697b0f8de3275fdc886b35acae829f0","unresolved":true,"context_lines":[{"line_number":6962,"context_line":"        msg(M_WARN, \"DEPRECATED: --persist-key option ignored.\""},{"line_number":6963,"context_line":"            \"Keys are now always persisted across restarts.\""},{"line_number":6964,"context_line":"            \"This option will be removed in a future version, \""},{"line_number":6965,"context_line":"            \"please remove it from your configuration.\");"},{"line_number":6966,"context_line":"    }"},{"line_number":6967,"context_line":"    else if (streq(p[0], \"persist-local-ip\") \u0026\u0026 !p[1])"},{"line_number":6968,"context_line":"    {"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"3677f02f_e3f89e35","line":6965,"in_reply_to":"6f595c78_b2ccf3fe","updated":"2024-03-05 08:30:52.000000000","message":"We do exactly the same with max-routes, the only difference is that with persist-key we check for permission.","commit_id":"96b96026594a8f0a5a221521fff6f1e694bec074"}]}