)]}'
{"id":"openvpn~532","triplet_id":"openvpn~master~I1a36651c0dea52259533ffc00bccb9b03bf82e26","project":"openvpn","branch":"master","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2024-03-25 01:15:40.000000000","reason":"removed on reply"},"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2024-03-25 12:55:10.000000000","reason":"Change was submitted"},"1000007":{"account":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"last_update":"2024-03-25 12:55:10.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I1a36651c0dea52259533ffc00bccb9b03bf82e26","subject":"samples: Update sample configurations","status":"MERGED","created":"2024-03-04 13:01:41.000000000","updated":"2024-03-25 12:55:10.000000000","submitted":"2024-03-25 12:55:10.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"532","meta_rev_id":"08d6a48552d200ae8c11033b591d9efb276c7fca","_number":532,"virtual_id_number":532,"owner":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"value":0,"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-03-04 13:01:43.000000000","updated_by":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2024-03-04 13:01:43.000000000","updated_by":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2024-03-04 13:15:23.000000000","updated_by":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"reviewer":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"state":"REVIEWER"}],"messages":[{"id":"d3793bbb8eeef52d164aebc7ff2c0654f1e7012d","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2024-03-04 13:01:41.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"783e1d0f83c152a2e7150274f8c7663e5277c11a","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2024-03-04 13:02:52.000000000","message":"Uploaded patch set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"9162b98d257e9e12907c401af032331dca9a17e1","author":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"date":"2024-03-04 13:15:23.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"9c98fefa0c0179df507886f8edf58a1071df4a71","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2024-03-04 15:46:40.000000000","message":"Uploaded patch set 3.\n\nOutdated Votes:\n* Code-Review+2 (copy condition: \"changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR is:MIN\")\n","accounts_in_message":[],"_revision_number":3},{"id":"c2af8edf7d4487964830abddc82cf395be33e583","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2024-03-12 16:59:32.000000000","message":"Uploaded patch set 4: Patch Set 3 was rebased.","accounts_in_message":[],"_revision_number":4},{"id":"85219d1a0e1b9818dc23e27f74ec41f347c69193","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2024-03-25 01:15:40.000000000","message":"Patch Set 4: Code-Review+2","accounts_in_message":[],"_revision_number":4},{"id":"08d6a48552d200ae8c11033b591d9efb276c7fca","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2024-03-25 12:55:10.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":5}],"current_revision_number":5,"current_revision":"b0fc10abd06fa2307e95c8a60fa94f7ccc08d2ac","revisions":{"685ffac0423207fe35dbd44a106a80394777b196":{"kind":"REWORK","_number":1,"created":"2024-03-04 13:01:41.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/32/532/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/32/532/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/32/532/1 \u0026\u0026 git checkout -b change-532 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/32/532/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/32/532/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/32/532/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/32/532/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/32/532/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"35718fc74d5be61c1cc6adb5648fd5cec8692250","subject":"samples: Remove tls-*.conf"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2024-03-04 12:58:37.000000000","tz":60},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2024-03-04 13:00:26.000000000","tz":60},"subject":"samples: Update sample configurations","message":"samples: Update sample configurations\n\n- Remove compression settings. Not recommended anymore.\n- Remove old cipher setting. Replaced by data-cipher with sane defaults.\n- Remove/reword some old comments. e.g. no need to reference\n  OpenVPN 1.x anymore.\n- Mention peer-fingerprint alternative.\n\nChange-Id: I1a36651c0dea52259533ffc00bccb9b03bf82e26\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"3cc1aad42199be43c16bec70f99d1e05a7d45759":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2024-03-04 13:02:52.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/32/532/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/32/532/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/32/532/2 \u0026\u0026 git checkout -b change-532 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/32/532/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/32/532/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/32/532/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/32/532/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/32/532/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"35718fc74d5be61c1cc6adb5648fd5cec8692250","subject":"samples: Remove tls-*.conf"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2024-03-04 12:58:37.000000000","tz":60},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2024-03-04 13:02:00.000000000","tz":60},"subject":"samples: Update sample configurations","message":"samples: Update sample configurations\n\n- Remove compression settings. Not recommended anymore.\n- Remove old cipher setting. Replaced by data-cipher with sane defaults.\n- Remove/reword some old comments. e.g. no need to reference\n  OpenVPN 1.x anymore.\n- Mention peer-fingerprint alternative.\n\nGithub: #511\nChange-Id: I1a36651c0dea52259533ffc00bccb9b03bf82e26\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"b6ca8887b25496a1fec09e24d9b617af715d69a7":{"kind":"REWORK","_number":3,"created":"2024-03-04 15:46:40.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/32/532/3","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/32/532/3","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/32/532/3 \u0026\u0026 git checkout -b change-532 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/32/532/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/32/532/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/32/532/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/32/532/3","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/32/532/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"35718fc74d5be61c1cc6adb5648fd5cec8692250","subject":"samples: Remove tls-*.conf"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2024-03-04 12:58:37.000000000","tz":60},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2024-03-04 15:45:13.000000000","tz":60},"subject":"samples: Update sample configurations","message":"samples: Update sample configurations\n\n- Remove compression settings. Not recommended anymore.\n- Remove old cipher setting. Replaced by data-ciphers negotiation.\n- Add comment how to set data-ciphers for very old clients.\n- Remove/reword some old comments. e.g. no need to reference\n  OpenVPN 1.x anymore.\n- Mention peer-fingerprint alternative.\n\nGithub: #511\nChange-Id: I1a36651c0dea52259533ffc00bccb9b03bf82e26\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"538112d4fa8b1d7c5b28bedf789735041938e354":{"kind":"TRIVIAL_REBASE","_number":4,"created":"2024-03-12 16:59:32.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/32/532/4","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/32/532/4","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/32/532/4 \u0026\u0026 git checkout -b change-532 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/32/532/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/32/532/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/32/532/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/32/532/4","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/32/532/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"f65c656ac034a99cca09557eeb9337e7c00a7e73","subject":"Update documentation references in systemd unit files"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2024-03-04 12:58:37.000000000","tz":60},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2024-03-12 16:59:13.000000000","tz":60},"subject":"samples: Update sample configurations","message":"samples: Update sample configurations\n\n- Remove compression settings. Not recommended anymore.\n- Remove old cipher setting. Replaced by data-ciphers negotiation.\n- Add comment how to set data-ciphers for very old clients.\n- Remove/reword some old comments. e.g. no need to reference\n  OpenVPN 1.x anymore.\n- Mention peer-fingerprint alternative.\n\nGithub: #511\nChange-Id: I1a36651c0dea52259533ffc00bccb9b03bf82e26\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"b0fc10abd06fa2307e95c8a60fa94f7ccc08d2ac":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":5,"created":"2024-03-25 12:55:10.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/32/532/5","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/32/532/5","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/32/532/5 \u0026\u0026 git checkout -b change-532 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/32/532/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/32/532/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/32/532/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/32/532/5","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/32/532/5 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"fd6b8395f6cee8a61111c28f335ec25ed6db11f7","subject":"Disable DCO if proxy is set via management"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2024-03-25 07:13:20.000000000","tz":60},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2024-03-25 12:53:39.000000000","tz":60},"subject":"samples: Update sample configurations","message":"samples: Update sample configurations\n\n- Remove compression settings. Not recommended anymore.\n- Remove old cipher setting. Replaced by data-ciphers negotiation.\n- Add comment how to set data-ciphers for very old clients.\n- Remove/reword some old comments. e.g. no need to reference\n  OpenVPN 1.x anymore.\n- Mention peer-fingerprint alternative.\n- comment out \"tls-auth\" as that is not needed for a bare-bones VPN config\n  and needs additional setup.\n\nGithub: #511\nChange-Id: I1a36651c0dea52259533ffc00bccb9b03bf82e26\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\nAcked-by: Arne Schwabe \u003carne-openvpn@rfc2549.org\u003e\nMessage-Id: \u003c20240325071320.11348-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg28451.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
