)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"0b6b02d19594faeb07f7e6d732a39536a9d11d2e","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Arne Schwabe \u003carne@rfc2549.org\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-03-04 15:54:24 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Avoid SIGUR1 to SIGHUP when the configuration is read from stdin"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If the configuration is read from stdin, we cannot reread the configuration"},{"line_number":10,"context_line":"as stdin provides the configuration only once. So whenever we hit the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"2cfbe3af_29c12353","line":7,"updated":"2024-03-12 16:38:50.000000000","message":"Typo -\u003e \"SIGUSR1\"","commit_id":"76c9dfa92f6744e7e7e370daac3a624cbd148fc5"},{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"32999b5c5ec97fdeb5b15568fcfffd470203ea58","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Arne Schwabe \u003carne@rfc2549.org\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-03-04 15:54:24 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Avoid SIGUR1 to SIGHUP when the configuration is read from stdin"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If the configuration is read from stdin, we cannot reread the configuration"},{"line_number":10,"context_line":"as stdin provides the configuration only once. So whenever we hit the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"0584d87f_10f34ade","line":7,"in_reply_to":"2cfbe3af_29c12353","updated":"2024-07-19 13:09:06.000000000","message":"Done","commit_id":"76c9dfa92f6744e7e7e370daac3a624cbd148fc5"},{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"146e8085c52507619c71291b6ed54d30eea0abc4","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If the configuration is read from stdin, we cannot reread the configuration"},{"line_number":10,"context_line":"as stdin provides the configuration only once. So whenever we hit the"},{"line_number":11,"context_line":"\"close_context usr1 to hup\" logic, the OpenVPN process will fail as tries"},{"line_number":12,"context_line":"to restart with an empty configuration."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Icfc179490d6821e22d14817941fb0bad667c713f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"8488b519_2420d9dd","line":11,"updated":"2024-03-11 15:09:52.000000000","message":"Please add a short explanation of when this logic might be hit. It is completely unclear to me from the code how you might hit this (especially since both HUP and USR1 are blocked during init_instance). Something with management?","commit_id":"76c9dfa92f6744e7e7e370daac3a624cbd148fc5"},{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"32999b5c5ec97fdeb5b15568fcfffd470203ea58","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If the configuration is read from stdin, we cannot reread the configuration"},{"line_number":10,"context_line":"as stdin provides the configuration only once. So whenever we hit the"},{"line_number":11,"context_line":"\"close_context usr1 to hup\" logic, the OpenVPN process will fail as tries"},{"line_number":12,"context_line":"to restart with an empty configuration."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Icfc179490d6821e22d14817941fb0bad667c713f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"457ac179_ec7f95d4","line":11,"in_reply_to":"8488b519_2420d9dd","updated":"2024-07-19 13:09:06.000000000","message":"Done","commit_id":"76c9dfa92f6744e7e7e370daac3a624cbd148fc5"}]}