)]}'
{"id":"openvpn~533","triplet_id":"openvpn~master~Icfc179490d6821e22d14817941fb0bad667c713f","project":"openvpn","branch":"master","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2024-09-17 11:00:41.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2024-07-10 16:14:10.000000000","reason":"removed on reply"}},"hashtags":["mailsubmitted"],"change_id":"Icfc179490d6821e22d14817941fb0bad667c713f","subject":"Avoid SIGUSR1 to SIGHUP remapping when the configuration is read from stdin","status":"MERGED","created":"2024-03-04 14:54:33.000000000","updated":"2024-09-17 11:00:41.000000000","submitted":"2024-09-17 11:00:41.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":4,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"533","meta_rev_id":"1f6f7177756d3cf388eedc3ccf0c524d5ae7a88a","_number":533,"virtual_id_number":533,"owner":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"value":0,"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-03-04 14:54:34.000000000","updated_by":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2024-03-04 14:54:34.000000000","updated_by":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"reviewer":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"state":"REVIEWER"}],"messages":[{"id":"76e16bd302f9f6933f7d4ed077d90dd6fee9c991","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2024-03-04 14:54:33.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"146e8085c52507619c71291b6ed54d30eea0abc4","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2024-03-11 15:09:52.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"0b6b02d19594faeb07f7e6d732a39536a9d11d2e","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2024-03-12 16:38:50.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"e9245928b1137c58795f28a3c5532598b162debf","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2024-05-06 13:50:28.000000000","message":"Uploaded patch set 2.\n\nOutdated Votes:\n* Code-Review-1 (copy condition: \"changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR is:MIN\")\n","accounts_in_message":[],"_revision_number":2},{"id":"fe32e768fc9299d13b0561f44def1c8c46a2e9d4","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"real_author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2024-07-10 16:12:44.000000000","message":"Patch Set 3: Patch Set 2 was rebased on behalf of \u003cGERRIT_ACCOUNT_1000003\u003e","accounts_in_message":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"_revision_number":3},{"id":"e703053e8f3a8bec4b1205f1d84cc0b515502a3b","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2024-07-10 16:14:10.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"32999b5c5ec97fdeb5b15568fcfffd470203ea58","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2024-07-19 13:09:06.000000000","message":"Patch Set 3:\n\n(2 comments)","accounts_in_message":[],"_revision_number":3},{"id":"28c2c986b5322340e24f8006207c8c6e5edd8aa2","tag":"autogenerated:gerrit:setHashtag","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2024-07-19 13:10:28.000000000","message":"Hashtag added: mailsubmitted","accounts_in_message":[],"_revision_number":3},{"id":"1f6f7177756d3cf388eedc3ccf0c524d5ae7a88a","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2024-09-17 11:00:41.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"b620025b9570a3d66ad3598dc22aa1b07c90fa31","revisions":{"76c9dfa92f6744e7e7e370daac3a624cbd148fc5":{"kind":"REWORK","_number":1,"created":"2024-03-04 14:54:33.000000000","uploader":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"ref":"refs/changes/33/533/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/33/533/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/33/533/1 \u0026\u0026 git checkout -b change-533 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/33/533/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/33/533/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/33/533/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/33/533/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/33/533/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"fad2d7017eee366317bb18b34416e7788cbe2372","subject":"Document that auth-user-pass may be inlined"}],"author":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2024-03-04 14:42:50.000000000","tz":60},"committer":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2024-03-04 14:54:24.000000000","tz":60},"subject":"Avoid SIGUR1 to SIGHUP when the configuration is read from stdin","message":"Avoid SIGUR1 to SIGHUP when the configuration is read from stdin\n\nIf the configuration is read from stdin, we cannot reread the configuration\nas stdin provides the configuration only once. So whenever we hit the\n\"close_context usr1 to hup\" logic, the OpenVPN process will fail as tries\nto restart with an empty configuration.\n\nChange-Id: Icfc179490d6821e22d14817941fb0bad667c713f\nSigned-off-by: Arne Schwabe \u003carne@rfc2549.org\u003e\n"},"branch":"refs/heads/master"},"9a22692369a890804487da0f49eef021e727d2d1":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":2,"created":"2024-05-06 13:50:28.000000000","uploader":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"ref":"refs/changes/33/533/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/33/533/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/33/533/2 \u0026\u0026 git checkout -b change-533 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/33/533/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/33/533/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/33/533/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/33/533/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/33/533/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"9d92221eb4e773cae913752af6d70082ae305fe8","subject":"Fix \u0027binary or\u0027 vs \u0027boolean or\u0027 related to server_bridge_proxy_dhcp"}],"author":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2024-03-04 14:42:50.000000000","tz":60},"committer":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2024-05-06 13:50:06.000000000","tz":120},"subject":"Avoid SIGUSR1 to SIGHUP when the configuration is read from stdin","message":"Avoid SIGUSR1 to SIGHUP when the configuration is read from stdin\n\nIf the configuration is read from stdin, we cannot reread the configuration\nas stdin provides the configuration only once. So whenever we hit the\n\"close_context usr1 to hup\" logic, the OpenVPN process will fail as tries\nto restart with an empty configuration.\n\nWhile OpenVPN tries to block  USR1 from normal unix signal, I have observed\ncases in my app which sends USR1 from management interface where the\nCC_HARD_USR1_TO_HUP logic is trigger and breaking the OpenVPN process.\n\nChange-Id: Icfc179490d6821e22d14817941fb0bad667c713f\nSigned-off-by: Arne Schwabe \u003carne@rfc2549.org\u003e\n"},"branch":"refs/heads/master"},"741bdf768a6103599d52ae7c73eea92960c5896d":{"kind":"TRIVIAL_REBASE","_number":3,"created":"2024-07-10 16:12:44.000000000","uploader":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"real_uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/33/533/3","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/33/533/3","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/33/533/3 \u0026\u0026 git checkout -b change-533 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/33/533/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/33/533/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/33/533/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/33/533/3","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/33/533/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"f8f477139804b06183b515a529c982f524547d18","subject":"t_server_null: multiple improvements and fixes"}],"author":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2024-03-04 14:42:50.000000000","tz":60},"committer":{"name":"plaisthos","email":"arne-openvpn@rfc2549.org","date":"2024-07-10 16:12:44.000000000","tz":0},"subject":"Avoid SIGUSR1 to SIGHUP when the configuration is read from stdin","message":"Avoid SIGUSR1 to SIGHUP when the configuration is read from stdin\n\nIf the configuration is read from stdin, we cannot reread the configuration\nas stdin provides the configuration only once. So whenever we hit the\n\"close_context usr1 to hup\" logic, the OpenVPN process will fail as tries\nto restart with an empty configuration.\n\nWhile OpenVPN tries to block  USR1 from normal unix signal, I have observed\ncases in my app which sends USR1 from management interface where the\nCC_HARD_USR1_TO_HUP logic is trigger and breaking the OpenVPN process.\n\nChange-Id: Icfc179490d6821e22d14817941fb0bad667c713f\nSigned-off-by: Arne Schwabe \u003carne@rfc2549.org\u003e\n"},"branch":"refs/heads/master","description":"Rebase"},"b620025b9570a3d66ad3598dc22aa1b07c90fa31":{"kind":"REWORK","_number":4,"created":"2024-09-17 11:00:41.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/33/533/4","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/33/533/4","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/33/533/4 \u0026\u0026 git checkout -b change-533 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/33/533/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/33/533/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/33/533/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/33/533/4","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/33/533/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"14d2db6cd41fb6414992869caf109972d7a8275e","subject":"Route: remove incorrect routes on exit"}],"author":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2024-07-19 13:10:16.000000000","tz":120},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2024-09-17 10:56:08.000000000","tz":120},"subject":"Avoid SIGUSR1 to SIGHUP remapping when the configuration is read from stdin","message":"Avoid SIGUSR1 to SIGHUP remapping when the configuration is read from stdin\n\nIf the configuration is read from stdin, we cannot reread the configuration\nas stdin provides the configuration only once. So whenever we hit the\n\"close_context usr1 to hup\" logic, the OpenVPN process will fail as tries\nto restart with an empty configuration.\n\nWhile OpenVPN tries to block  USR1 from normal unix signal, I have observed\ncases in my app which sends USR1 from management interface where the\nCC_HARD_USR1_TO_HUP logic is trigger and breaking the OpenVPN process.\n\nChange-Id: Icfc179490d6821e22d14817941fb0bad667c713f\nSigned-off-by: Arne Schwabe \u003carne@rfc2549.org\u003e\nAcked-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\nMessage-Id: \u003c20240719131016.75042-1-frank@lichtenheld.com\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg28941.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}