)]}'
{"src/openvpn/ssl_mbedtls.c":[{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"a5ed917e69d63b68928a5c0298031a75696ae4d1","unresolved":true,"context_lines":[{"line_number":1614,"context_line":"{"},{"line_number":1615,"context_line":"    static char mbedtls_version[30];"},{"line_number":1616,"context_line":"    unsigned int pv \u003d mbedtls_version_get_number();"},{"line_number":1617,"context_line":"    snprintf(mbedtls_version, sizeof(mbedtls_version), \"mbed TLS %d.%d.%d\","},{"line_number":1618,"context_line":"             (pv\u003e\u003e24)\u00260xff, (pv\u003e\u003e16)\u00260xff, (pv\u003e\u003e8)\u00260xff );"},{"line_number":1619,"context_line":"    return mbedtls_version;"},{"line_number":1620,"context_line":"}"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"655ebb20_a5900f83","line":1617,"updated":"2024-03-22 17:40:56.000000000","message":"Do we want to use openvpn_snprintf here?","commit_id":"0600ccb71ea7595b7d8e864b635468948ae6eaf2"},{"author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"6fe4585d3fcaa3541f8c88e4d7c8b3fe41760bc3","unresolved":true,"context_lines":[{"line_number":1614,"context_line":"{"},{"line_number":1615,"context_line":"    static char mbedtls_version[30];"},{"line_number":1616,"context_line":"    unsigned int pv \u003d mbedtls_version_get_number();"},{"line_number":1617,"context_line":"    snprintf(mbedtls_version, sizeof(mbedtls_version), \"mbed TLS %d.%d.%d\","},{"line_number":1618,"context_line":"             (pv\u003e\u003e24)\u00260xff, (pv\u003e\u003e16)\u00260xff, (pv\u003e\u003e8)\u00260xff );"},{"line_number":1619,"context_line":"    return mbedtls_version;"},{"line_number":1620,"context_line":"}"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"7c92da42_95f3de4f","line":1617,"in_reply_to":"655ebb20_a5900f83","updated":"2024-03-22 18:39:44.000000000","message":"I think we probably want to get rid of openvpn_snprintf instead. I will prepare a patch to remove it and add unit tests to check if it behaves correctly according to https://en.cppreference.com/w/c/io/snprintf it actually guarantees the behaviour that we expect.","commit_id":"0600ccb71ea7595b7d8e864b635468948ae6eaf2"},{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"a9d7a4aed805f2185e4afc592a85eb23e8b19606","unresolved":false,"context_lines":[{"line_number":1614,"context_line":"{"},{"line_number":1615,"context_line":"    static char mbedtls_version[30];"},{"line_number":1616,"context_line":"    unsigned int pv \u003d mbedtls_version_get_number();"},{"line_number":1617,"context_line":"    snprintf(mbedtls_version, sizeof(mbedtls_version), \"mbed TLS %d.%d.%d\","},{"line_number":1618,"context_line":"             (pv\u003e\u003e24)\u00260xff, (pv\u003e\u003e16)\u00260xff, (pv\u003e\u003e8)\u00260xff );"},{"line_number":1619,"context_line":"    return mbedtls_version;"},{"line_number":1620,"context_line":"}"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"d36b1b05_0b5bc893","line":1617,"in_reply_to":"7c92da42_95f3de4f","updated":"2024-03-25 12:42:39.000000000","message":"Acknowledged","commit_id":"0600ccb71ea7595b7d8e864b635468948ae6eaf2"}]}