)]}'
{"id":"openvpn~547","triplet_id":"openvpn~master~I07096977e3b562bcb5d2c6f11673a4175b8e12ac","project":"openvpn","branch":"master","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2024-05-06 15:28:01.000000000","reason":"Change was submitted"},"1000002":{"account":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"last_update":"2024-05-06 15:28:01.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2024-05-06 10:00:53.000000000","reason":"\u003cGERRIT_ACCOUNT_1000001\u003e replied on the change","reason_account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}},"1000007":{"account":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"last_update":"2024-05-06 15:28:01.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I07096977e3b562bcb5d2c6f11673a4175b8e12ac","subject":"Remove openvpn_snprintf and similar functions","status":"MERGED","created":"2024-03-25 01:05:43.000000000","updated":"2024-05-06 15:28:01.000000000","submitted":"2024-05-06 15:28:01.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":22,"unresolved_comment_count":1,"has_review_started":true,"submission_id":"547","meta_rev_id":"f1f70465d8bb4fe3b6fb082f65540823f4f4e0da","_number":547,"virtual_id_number":547,"owner":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"value":0,"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},{"value":0,"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-03-25 01:05:44.000000000","updated_by":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2024-03-25 01:05:44.000000000","updated_by":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"reviewer":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"state":"REVIEWER"},{"updated":"2024-03-25 01:15:22.000000000","updated_by":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"reviewer":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"state":"REVIEWER"},{"updated":"2024-04-08 08:22:27.000000000","updated_by":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"state":"REVIEWER"}],"messages":[{"id":"36ae580c897077049c1d0e6403449fe20c595d63","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2024-03-25 01:05:43.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"e535f96b24b5b4abbceee6c0e62abb3d5b84dddf","author":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"date":"2024-03-25 01:15:22.000000000","message":"Patch Set 1: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"7f2eae44a57e1c9fb8fbe78765462f135308af92","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2024-03-25 11:14:07.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"89ee13542bd52b855d27cc5ed77c0aa023049d85","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2024-03-25 18:04:47.000000000","message":"Uploaded patch set 2.\n\nOutdated Votes:\n* Code-Review+2, Code-Review-1 (copy condition: \"changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR is:MIN\")\n","accounts_in_message":[],"_revision_number":2},{"id":"b926fc73dded566d0ca6a2cc1db0843feff402b3","author":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"date":"2024-03-27 10:48:48.000000000","message":"Patch Set 2:\n\n(5 comments)","accounts_in_message":[],"_revision_number":2},{"id":"e482ee922a6ed74d8587e2f73195653fc11aef75","author":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"date":"2024-04-08 06:59:00.000000000","message":"Patch Set 2: Code-Review+2\n\n(4 comments)","accounts_in_message":[],"_revision_number":2},{"id":"030e46e8d57edd744de5187cf6b22e6e636b0e96","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2024-04-08 08:22:27.000000000","message":"Patch Set 2: Code-Review-1\n\n(3 comments)","accounts_in_message":[],"_revision_number":2},{"id":"6384cecf7bfff2a1f27f71c222ea624ceeceb508","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2024-05-02 17:42:47.000000000","message":"Uploaded patch set 3.\n\nOutdated Votes:\n* Code-Review+2, Code-Review-1 (copy condition: \"changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR is:MIN\")\n","accounts_in_message":[],"_revision_number":3},{"id":"96ce3a879193bb988892213859af5ba28690a51d","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2024-05-02 17:44:24.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"128f97e7f321527953e76a49a778b5e0fb793937","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2024-05-02 17:44:31.000000000","message":"Patch Set 3:\n\n(2 comments)","accounts_in_message":[],"_revision_number":3},{"id":"af31415528c2be476303a77f921f82b3b8471dde","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2024-05-03 15:49:05.000000000","message":"Patch Set 4: Code-Review-1\n\n(2 comments)","accounts_in_message":[],"_revision_number":4},{"id":"c544ca439d111604dd6d09d6db22264ccb56d646","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2024-05-03 16:44:39.000000000","message":"Patch Set 4:\n\n(2 comments)","accounts_in_message":[],"_revision_number":4},{"id":"aa045dde17c76f781161380cf28c37db5c252e27","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2024-05-03 16:47:06.000000000","message":"Uploaded patch set 5.\n\nOutdated Votes:\n* Code-Review-1 (copy condition: \"changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR is:MIN\")\n","accounts_in_message":[],"_revision_number":5},{"id":"ea088217c8fd9805efca543f9a0c695c1bba8f2d","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2024-05-03 16:48:06.000000000","message":"Patch Set 5:\n\n(1 comment)","accounts_in_message":[],"_revision_number":5},{"id":"1fef64a6886b8c1e3a0791b291219763c8a67228","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2024-05-06 10:00:53.000000000","message":"Patch Set 5:\n\n(1 comment)","accounts_in_message":[],"_revision_number":5},{"id":"e9c96b6e4ac19635939965589c646353fa53b750","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2024-05-06 10:18:07.000000000","message":"Patch Set 5: Code-Review+2","accounts_in_message":[],"_revision_number":5},{"id":"f1f70465d8bb4fe3b6fb082f65540823f4f4e0da","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2024-05-06 15:28:01.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":6}],"current_revision_number":6,"current_revision":"130548fe4d23afac5d2948d4e5ee164eef635cfd","revisions":{"7370194dc6e9d3f13dca37814b19dcd16cce2ced":{"kind":"REWORK","_number":1,"created":"2024-03-25 01:05:43.000000000","uploader":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"ref":"refs/changes/47/547/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/47/547/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/47/547/1 \u0026\u0026 git checkout -b change-547 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/47/547/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/47/547/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/47/547/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/47/547/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/47/547/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"fd6b8395f6cee8a61111c28f335ec25ed6db11f7","subject":"Disable DCO if proxy is set via management"}],"author":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2024-03-23 00:01:40.000000000","tz":-240},"committer":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2024-03-25 01:03:16.000000000","tz":60},"subject":"Remove openvpn_snprintf and similar functions","message":"Remove openvpn_snprintf and similar functions\n\nOld Microsoft versions did strange behaviour but according to the\nnewly added unit test and\nhttps://stackoverflow.com/questions/7706936/is-snprintf-always-null-terminating\nthis is now standard conforming and we can use the normal snprintf\nmethod.\n\nMicrosoft own documentation to swprintf also says you nowadays need to\ndefine _CRT_NON_CONFORMING_SWPRINTFS to get to non-standard behaviour.\n\nChange-Id: I07096977e3b562bcb5d2c6f11673a4175b8e12ac\n"},"branch":"refs/heads/master"},"54e5d7fe487cc2453c949140f3dff95e819130cc":{"kind":"REWORK","_number":2,"created":"2024-03-25 18:04:47.000000000","uploader":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"ref":"refs/changes/47/547/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/47/547/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/47/547/2 \u0026\u0026 git checkout -b change-547 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/47/547/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/47/547/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/47/547/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/47/547/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/47/547/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"2ec996f7e33e26b2a806c2474a55a15cf1c55b0f","subject":"Fix snprintf/swnprintf related compiler warnings"}],"author":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2024-03-23 00:01:40.000000000","tz":-240},"committer":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2024-03-25 18:04:43.000000000","tz":60},"subject":"Remove openvpn_snprintf and similar functions","message":"Remove openvpn_snprintf and similar functions\n\nOld Microsoft versions did strange behaviour but according to the\nnewly added unit test and\nhttps://stackoverflow.com/questions/7706936/is-snprintf-always-null-terminating\nthis is now standard conforming and we can use the normal snprintf\nmethod.\n\nMicrosoft own documentation to swprintf also says you nowadays need to\ndefine _CRT_NON_CONFORMING_SWPRINTFS to get to non-standard behaviour.\n\nChange-Id: I07096977e3b562bcb5d2c6f11673a4175b8e12ac\nSigned-off-by: Arne Schwabe \u003carne@rfc2549.org\u003e\n"},"branch":"refs/heads/master"},"922b707f642ca6534ed87f82a0eca3f2a3ef7f45":{"kind":"REWORK","_number":3,"created":"2024-05-02 17:42:47.000000000","uploader":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"ref":"refs/changes/47/547/3","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/47/547/3","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/47/547/3 \u0026\u0026 git checkout -b change-547 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/47/547/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/47/547/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/47/547/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/47/547/3","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/47/547/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"9d92221eb4e773cae913752af6d70082ae305fe8","subject":"Fix \u0027binary or\u0027 vs \u0027boolean or\u0027 related to server_bridge_proxy_dhcp"}],"author":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2024-03-23 00:01:40.000000000","tz":-240},"committer":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2024-05-02 17:42:43.000000000","tz":120},"subject":"Remove openvpn_snprintf and similar functions","message":"Remove openvpn_snprintf and similar functions\n\nOld Microsoft versions did strange behaviour but according to the\nnewly added unit test and\nhttps://stackoverflow.com/questions/7706936/is-snprintf-always-null-terminating\nthis is now standard conforming and we can use the normal snprintf\nmethod.\n\nMicrosoft own documentation to swprintf also says you nowadays need to\ndefine _CRT_NON_CONFORMING_SWPRINTFS to get to non-standard behaviour.\n\nChange-Id: I07096977e3b562bcb5d2c6f11673a4175b8e12ac\nSigned-off-by: Arne Schwabe \u003carne@rfc2549.org\u003e\n"},"branch":"refs/heads/master"},"85ce1b1d22d792b1e597f698e3f875e24109ac3b":{"kind":"REWORK","_number":4,"created":"2024-05-02 17:44:24.000000000","uploader":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"ref":"refs/changes/47/547/4","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/47/547/4","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/47/547/4 \u0026\u0026 git checkout -b change-547 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/47/547/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/47/547/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/47/547/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/47/547/4","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/47/547/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"9d92221eb4e773cae913752af6d70082ae305fe8","subject":"Fix \u0027binary or\u0027 vs \u0027boolean or\u0027 related to server_bridge_proxy_dhcp"}],"author":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2024-03-23 00:01:40.000000000","tz":-240},"committer":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2024-05-02 17:44:18.000000000","tz":120},"subject":"Remove openvpn_snprintf and similar functions","message":"Remove openvpn_snprintf and similar functions\n\nOld Microsoft versions did strange behaviour but according to the\nnewly added unit test and\nhttps://stackoverflow.com/questions/7706936/is-snprintf-always-null-terminating\nthis is now standard conforming and we can use the normal snprintf\nmethod.\n\nMicrosoft own documentation to swprintf also says you nowadays need to\ndefine _CRT_NON_CONFORMING_SWPRINTFS to get to non-standard behaviour.\n\nChange-Id: I07096977e3b562bcb5d2c6f11673a4175b8e12ac\nSigned-off-by: Arne Schwabe \u003carne@rfc2549.org\u003e\n"},"branch":"refs/heads/master"},"3b600758e4da9550cfa0239e59140d5cb4a5436f":{"kind":"REWORK","_number":5,"created":"2024-05-03 16:47:06.000000000","uploader":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"ref":"refs/changes/47/547/5","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/47/547/5","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/47/547/5 \u0026\u0026 git checkout -b change-547 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/47/547/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/47/547/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/47/547/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/47/547/5","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/47/547/5 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"9d92221eb4e773cae913752af6d70082ae305fe8","subject":"Fix \u0027binary or\u0027 vs \u0027boolean or\u0027 related to server_bridge_proxy_dhcp"}],"author":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2024-03-23 00:01:40.000000000","tz":-240},"committer":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2024-05-03 16:46:53.000000000","tz":120},"subject":"Remove openvpn_snprintf and similar functions","message":"Remove openvpn_snprintf and similar functions\n\nOld Microsoft versions did strange behaviour but according to the\nnewly added unit test and\nhttps://stackoverflow.com/questions/7706936/is-snprintf-always-null-terminating\nthis is now standard conforming and we can use the normal snprintf\nmethod.\n\nMicrosoft own documentation to swprintf also says you nowadays need to\ndefine _CRT_NON_CONFORMING_SWPRINTFS to get to non-standard behaviour.\n\nChange-Id: I07096977e3b562bcb5d2c6f11673a4175b8e12ac\nSigned-off-by: Arne Schwabe \u003carne@rfc2549.org\u003e\n"},"branch":"refs/heads/master"},"130548fe4d23afac5d2948d4e5ee164eef635cfd":{"kind":"REWORK","_number":6,"created":"2024-05-06 15:28:01.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/47/547/6","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/47/547/6","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/47/547/6 \u0026\u0026 git checkout -b change-547 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/47/547/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/47/547/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/47/547/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/47/547/6","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/47/547/6 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"9d92221eb4e773cae913752af6d70082ae305fe8","subject":"Fix \u0027binary or\u0027 vs \u0027boolean or\u0027 related to server_bridge_proxy_dhcp"}],"author":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2024-05-06 10:27:10.000000000","tz":120},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2024-05-06 14:56:24.000000000","tz":120},"subject":"Remove openvpn_snprintf and similar functions","message":"Remove openvpn_snprintf and similar functions\n\nOld Microsoft versions did strange behaviour but according to the\nnewly added unit test and\nhttps://stackoverflow.com/questions/7706936/is-snprintf-always-null-terminating\nthis is now standard conforming and we can use the normal snprintf\nmethod.\n\nMicrosoft own documentation to swprintf also says you nowadays need to\ndefine _CRT_NON_CONFORMING_SWPRINTFS to get to non-standard behaviour.\n\nChange-Id: I07096977e3b562bcb5d2c6f11673a4175b8e12ac\nSigned-off-by: Arne Schwabe \u003carne@rfc2549.org\u003e\nAcked-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\nMessage-Id: \u003c20240506102710.8976-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg28617.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}