)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"4153f101bdf9650eb6a4b900e7f5a321814105ac","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"cf419994_3a7f53ec","updated":"2024-03-27 09:30:02.000000000","message":"I would rather have a typedef in crypto_mbedtls.h and crypto_openssl.h that does something like\n\ntypedef mbedtls_operation_t encryption_operation_t;\n\nand then use that type consistently in the API. Do you want to take a stab at that or should I take over?","commit_id":"13faa309cb58b658cae5c62b03e8ecaa1324e19e"},{"author":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"change_message_id":"ae7ce70e7a8be8d5101c39ec07601b5f0a77be84","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"e89a27e4_990a6ad0","updated":"2024-03-27 13:24:24.000000000","message":"Thanks for introducing the typedef - this looks much cleaner, as Arne also suggested. However, I have a nit pick about the arg naming.","commit_id":"2c88d90a881fdbf7227a5db63570bed274634a21"}],"src/openvpn/crypto_mbedtls.c":[{"author":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"change_message_id":"ae7ce70e7a8be8d5101c39ec07601b5f0a77be84","unresolved":true,"context_lines":[{"line_number":566,"context_line":""},{"line_number":567,"context_line":"void"},{"line_number":568,"context_line":"cipher_ctx_init(mbedtls_cipher_context_t *ctx, const uint8_t *key,"},{"line_number":569,"context_line":"                const char *ciphername, crypto_operation_t enc)"},{"line_number":570,"context_line":"{"},{"line_number":571,"context_line":"    ASSERT(NULL !\u003d ciphername \u0026\u0026 NULL !\u003d ctx);"},{"line_number":572,"context_line":"    CLEAR(*ctx);"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"f5ffc802_2b16c413","line":569,"updated":"2024-03-27 13:24:24.000000000","message":"may I argue that the name \"operation\" (or just \"op\") is more appropriate as this is not a bool (encrypt or not encrypt), but rather an enum being assigned some op?","commit_id":"2c88d90a881fdbf7227a5db63570bed274634a21"},{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"677d30cda8a2c61b7edfbcda6812ddbc59d40f77","unresolved":true,"context_lines":[{"line_number":566,"context_line":""},{"line_number":567,"context_line":"void"},{"line_number":568,"context_line":"cipher_ctx_init(mbedtls_cipher_context_t *ctx, const uint8_t *key,"},{"line_number":569,"context_line":"                const char *ciphername, crypto_operation_t enc)"},{"line_number":570,"context_line":"{"},{"line_number":571,"context_line":"    ASSERT(NULL !\u003d ciphername \u0026\u0026 NULL !\u003d ctx);"},{"line_number":572,"context_line":"    CLEAR(*ctx);"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"dc2be5d0_47f83eb9","line":569,"in_reply_to":"4014ab83_686bac9b","updated":"2024-03-27 15:19:32.000000000","message":"Also, in practice it is a boolean. The third state is only for indicating error when used as a return value.","commit_id":"2c88d90a881fdbf7227a5db63570bed274634a21"},{"author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"252ded3fd407e6e79bb221974c96677fcd186b6b","unresolved":false,"context_lines":[{"line_number":566,"context_line":""},{"line_number":567,"context_line":"void"},{"line_number":568,"context_line":"cipher_ctx_init(mbedtls_cipher_context_t *ctx, const uint8_t *key,"},{"line_number":569,"context_line":"                const char *ciphername, crypto_operation_t enc)"},{"line_number":570,"context_line":"{"},{"line_number":571,"context_line":"    ASSERT(NULL !\u003d ciphername \u0026\u0026 NULL !\u003d ctx);"},{"line_number":572,"context_line":"    CLEAR(*ctx);"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"997ae8f4_a9d0ede6","line":569,"in_reply_to":"54a6d210_d1fef5e2","updated":"2024-03-27 18:44:04.000000000","message":"There is a -1 state in OpenSSL that mean \"don\u0027t change when reinitialising\" that we do not use.","commit_id":"2c88d90a881fdbf7227a5db63570bed274634a21"},{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"84171a7db6e8572536eb9d92d36ee33e782b55f9","unresolved":false,"context_lines":[{"line_number":566,"context_line":""},{"line_number":567,"context_line":"void"},{"line_number":568,"context_line":"cipher_ctx_init(mbedtls_cipher_context_t *ctx, const uint8_t *key,"},{"line_number":569,"context_line":"                const char *ciphername, crypto_operation_t enc)"},{"line_number":570,"context_line":"{"},{"line_number":571,"context_line":"    ASSERT(NULL !\u003d ciphername \u0026\u0026 NULL !\u003d ctx);"},{"line_number":572,"context_line":"    CLEAR(*ctx);"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"54a6d210_d1fef5e2","line":569,"in_reply_to":"c7af8f42_1c7d88cd","updated":"2024-03-27 16:25:43.000000000","message":"Acknowledged","commit_id":"2c88d90a881fdbf7227a5db63570bed274634a21"},{"author":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"change_message_id":"afc91616b55f73b168ab3df14c952b8bd661d305","unresolved":true,"context_lines":[{"line_number":566,"context_line":""},{"line_number":567,"context_line":"void"},{"line_number":568,"context_line":"cipher_ctx_init(mbedtls_cipher_context_t *ctx, const uint8_t *key,"},{"line_number":569,"context_line":"                const char *ciphername, crypto_operation_t enc)"},{"line_number":570,"context_line":"{"},{"line_number":571,"context_line":"    ASSERT(NULL !\u003d ciphername \u0026\u0026 NULL !\u003d ctx);"},{"line_number":572,"context_line":"    CLEAR(*ctx);"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"c7af8f42_1c7d88cd","line":569,"in_reply_to":"dc2be5d0_47f83eb9","updated":"2024-03-27 15:25:50.000000000","message":"still dirty if you ask me, but it\u0027s a nit pick","commit_id":"2c88d90a881fdbf7227a5db63570bed274634a21"},{"author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"ef4b20b9593c8f2dac52c82b4aab0a9487bd2e55","unresolved":true,"context_lines":[{"line_number":566,"context_line":""},{"line_number":567,"context_line":"void"},{"line_number":568,"context_line":"cipher_ctx_init(mbedtls_cipher_context_t *ctx, const uint8_t *key,"},{"line_number":569,"context_line":"                const char *ciphername, crypto_operation_t enc)"},{"line_number":570,"context_line":"{"},{"line_number":571,"context_line":"    ASSERT(NULL !\u003d ciphername \u0026\u0026 NULL !\u003d ctx);"},{"line_number":572,"context_line":"    CLEAR(*ctx);"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"4014ab83_686bac9b","line":569,"in_reply_to":"f5ffc802_2b16c413","updated":"2024-03-27 13:34:00.000000000","message":"It matches the OpenSSL API, it also uses int enc ...","commit_id":"2c88d90a881fdbf7227a5db63570bed274634a21"}]}