)]}'
{"id":"openvpn~548","triplet_id":"openvpn~master~If0dcdde30879fd6185efb2ad31399c1629c04d22","project":"openvpn","branch":"master","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2024-03-27 18:44:04.000000000","reason":"\u003cGERRIT_ACCOUNT_1000003\u003e replied on the change","reason_account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}},"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2024-03-31 14:17:50.000000000","reason":"Change was submitted"},"1000007":{"account":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"last_update":"2024-03-31 14:17:50.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"If0dcdde30879fd6185efb2ad31399c1629c04d22","subject":"crypto_backend: fix type of enc parameter","status":"MERGED","created":"2024-03-25 14:30:47.000000000","updated":"2024-03-31 14:17:50.000000000","submitted":"2024-03-31 14:17:50.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":8,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"548","meta_rev_id":"93c122aa60b1ea3466a078589bb14b03f39151a4","_number":548,"virtual_id_number":548,"owner":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-03-25 14:30:48.000000000","updated_by":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2024-03-25 14:30:48.000000000","updated_by":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2024-03-27 13:24:24.000000000","updated_by":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"reviewer":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"state":"CC"}],"messages":[{"id":"90e35658f30966f47a0dbddb4609fdf16a204894","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2024-03-25 14:30:47.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"4153f101bdf9650eb6a4b900e7f5a321814105ac","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2024-03-27 09:30:02.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"078d6eb7ac328dd03f435133cf3aeedaf487bf52","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2024-03-27 11:05:07.000000000","message":"Uploaded patch set 2.\n\nOutdated Votes:\n* Code-Review-1 (copy condition: \"changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR is:MIN\")\n","accounts_in_message":[],"_revision_number":2},{"id":"98ed16a482ffc310e1dc2e6fce94d7c3e0f3f281","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2024-03-27 13:18:33.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"ae7ce70e7a8be8d5101c39ec07601b5f0a77be84","author":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"date":"2024-03-27 13:24:24.000000000","message":"Patch Set 3:\n\n(2 comments)","accounts_in_message":[],"_revision_number":3},{"id":"c52753f43049a80c20bc31eda7071f02ff99d29e","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2024-03-27 13:32:50.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"ef4b20b9593c8f2dac52c82b4aab0a9487bd2e55","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2024-03-27 13:34:00.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"677d30cda8a2c61b7edfbcda6812ddbc59d40f77","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2024-03-27 15:19:32.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"afc91616b55f73b168ab3df14c952b8bd661d305","author":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"date":"2024-03-27 15:25:50.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"84171a7db6e8572536eb9d92d36ee33e782b55f9","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2024-03-27 16:25:43.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"252ded3fd407e6e79bb221974c96677fcd186b6b","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2024-03-27 18:44:04.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"93c122aa60b1ea3466a078589bb14b03f39151a4","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2024-03-31 14:17:50.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"4d907bf46a470ccbd2940b9ecb64d6502d9d86bf","revisions":{"13faa309cb58b658cae5c62b03e8ecaa1324e19e":{"kind":"REWORK","_number":1,"created":"2024-03-25 14:30:47.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/48/548/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/48/548/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/48/548/1 \u0026\u0026 git checkout -b change-548 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/48/548/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/48/548/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/48/548/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/48/548/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/48/548/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"b0fc10abd06fa2307e95c8a60fa94f7ccc08d2ac","subject":"samples: Update sample configurations"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2024-03-25 14:27:47.000000000","tz":60},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2024-03-25 14:27:47.000000000","tz":60},"subject":"mbedtls: avoid warning with GCC 13+","message":"mbedtls: avoid warning with GCC 13+\n\ncrypto_mbedtls.c:568:1: error:\nconflicting types for ‘cipher_ctx_init’ due to enum/integer mismatch;\nhave ‘void(mbedtls_cipher_context_t *, const uint8_t *, const char *, const mbedtls_operation_t)’\n[...] [-Werror\u003denum-int-mismatch]\ncrypto_backend.h:341:6: note:\nprevious declaration of ‘cipher_ctx_init’ with type\n‘void(cipher_ctx_t *, const uint8_t *, const char *, int)’ [...]\n\nPrevious compiler versions did not complain.\n\nChange-Id: If0dcdde30879fd6185efb2ad31399c1629c04d22\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"6f06b25132cb756cc6d6482f7965e565bf007a59":{"kind":"REWORK","_number":2,"created":"2024-03-27 11:05:07.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/48/548/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/48/548/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/48/548/2 \u0026\u0026 git checkout -b change-548 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/48/548/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/48/548/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/48/548/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/48/548/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/48/548/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"b0fc10abd06fa2307e95c8a60fa94f7ccc08d2ac","subject":"samples: Update sample configurations"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2024-03-25 14:27:47.000000000","tz":60},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2024-03-27 11:03:55.000000000","tz":60},"subject":"crypto_backend: fix type of enc parameter","message":"crypto_backend: fix type of enc parameter\n\nWe had parts of a abstraction, but it wasn\u0027t consistent.\nGCC 13 now complains about the type mismatch with mbedtls now:\n\ncrypto_mbedtls.c:568:1: error:\nconflicting types for ‘cipher_ctx_init’ due to enum/integer mismatch;\nhave ‘void(mbedtls_cipher_context_t *, const uint8_t *, const char *, const mbedtls_operation_t)’\n[...] [-Werror\u003denum-int-mismatch]\ncrypto_backend.h:341:6: note:\nprevious declaration of ‘cipher_ctx_init’ with type\n‘void(cipher_ctx_t *, const uint8_t *, const char *, int)’ [...]\n\nPrevious compiler versions did not complain.\n\nChange-Id: If0dcdde30879fd6185efb2ad31399c1629c04d22\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"2c88d90a881fdbf7227a5db63570bed274634a21":{"kind":"REWORK","_number":3,"created":"2024-03-27 13:18:33.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/48/548/3","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/48/548/3","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/48/548/3 \u0026\u0026 git checkout -b change-548 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/48/548/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/48/548/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/48/548/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/48/548/3","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/48/548/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"b0fc10abd06fa2307e95c8a60fa94f7ccc08d2ac","subject":"samples: Update sample configurations"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2024-03-25 14:27:47.000000000","tz":60},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2024-03-27 13:17:49.000000000","tz":60},"subject":"crypto_backend: fix type of enc parameter","message":"crypto_backend: fix type of enc parameter\n\nWe had parts of a abstraction, but it wasn\u0027t consistent.\nGCC 13 now complains about the type mismatch with mbedtls now:\n\ncrypto_mbedtls.c:568:1: error:\nconflicting types for ‘cipher_ctx_init’ due to enum/integer mismatch;\nhave ‘void(mbedtls_cipher_context_t *, const uint8_t *, const char *, const mbedtls_operation_t)’\n[...] [-Werror\u003denum-int-mismatch]\ncrypto_backend.h:341:6: note:\nprevious declaration of ‘cipher_ctx_init’ with type\n‘void(cipher_ctx_t *, const uint8_t *, const char *, int)’ [...]\n\nPrevious compiler versions did not complain.\n\nv2:\n - clean solution instead of quick solution. Fix the actual API\n   definition\n\nChange-Id: If0dcdde30879fd6185efb2ad31399c1629c04d22\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"4d907bf46a470ccbd2940b9ecb64d6502d9d86bf":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":4,"created":"2024-03-31 14:17:50.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/48/548/4","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/48/548/4","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/48/548/4 \u0026\u0026 git checkout -b change-548 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/48/548/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/48/548/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/48/548/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/48/548/4","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/48/548/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"4c71e816031f564f834df695b3fa717ea22720d2","subject":"misc.c: remove unused code"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2024-03-27 16:26:21.000000000","tz":60},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2024-03-31 13:59:47.000000000","tz":120},"subject":"crypto_backend: fix type of enc parameter","message":"crypto_backend: fix type of enc parameter\n\nWe had parts of a abstraction, but it wasn\u0027t consistent.\nGCC 13 now complains about the type mismatch with mbedtls now:\n\ncrypto_mbedtls.c:568:1: error:\nconflicting types for ‘cipher_ctx_init’ due to enum/integer mismatch;\nhave ‘void(mbedtls_cipher_context_t *, const uint8_t *, const char *, const mbedtls_operation_t)’\n[...] [-Werror\u003denum-int-mismatch]\ncrypto_backend.h:341:6: note:\nprevious declaration of ‘cipher_ctx_init’ with type\n‘void(cipher_ctx_t *, const uint8_t *, const char *, int)’ [...]\n\nPrevious compiler versions did not complain.\n\nv2:\n - clean solution instead of quick solution. Fix the actual API\n   definition\n\nChange-Id: If0dcdde30879fd6185efb2ad31399c1629c04d22\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\nAcked-by: Arne Schwabe \u003carne-openvpn@rfc2549.org\u003e\nMessage-Id: \u003c20240327162621.1792414-1-frank@lichtenheld.com\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg28498.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}