)]}'
{"id":"openvpn~549","triplet_id":"openvpn~master~If23988a05dd53a519c5e57f2aa3b2d10bd29df1d","project":"openvpn","branch":"master","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2024-03-26 11:28:36.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2024-03-26 10:28:44.000000000","reason":"\u003cGERRIT_ACCOUNT_1000001\u003e replied on the change","reason_account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}}},"hashtags":["mailsubmitted"],"change_id":"If23988a05dd53a519c5e57f2aa3b2d10bd29df1d","subject":"Fix snprintf/swnprintf related compiler warnings","status":"MERGED","created":"2024-03-25 18:04:47.000000000","updated":"2024-03-26 11:28:36.000000000","submitted":"2024-03-26 11:28:36.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":2,"unresolved_comment_count":1,"has_review_started":true,"submission_id":"549","meta_rev_id":"33be386a6fe9088a164e43693c2ad81d590d228b","_number":549,"virtual_id_number":549,"owner":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"value":0,"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-03-25 18:04:48.000000000","updated_by":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2024-03-25 18:04:48.000000000","updated_by":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"reviewer":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"state":"REVIEWER"}],"messages":[{"id":"7992ea15b4c7e2d69a34f05f82f11124db0013f6","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2024-03-25 18:04:47.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"e33256abfc30d6ef4b69768bb14cbccc20356c52","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2024-03-26 10:28:44.000000000","message":"Patch Set 1: Code-Review+2\n\n(2 comments)","accounts_in_message":[],"_revision_number":1},{"id":"9fd858e78666d495cd4706329fed1515fe789405","tag":"autogenerated:gerrit:setHashtag","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2024-03-26 10:41:15.000000000","message":"Hashtag added: mailsubmitted","accounts_in_message":[],"_revision_number":1},{"id":"33be386a6fe9088a164e43693c2ad81d590d228b","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2024-03-26 11:28:36.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"6889d9e2f1458272ded4c035df40378ace3d7395","revisions":{"2ec996f7e33e26b2a806c2474a55a15cf1c55b0f":{"kind":"REWORK","_number":1,"created":"2024-03-25 18:04:47.000000000","uploader":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"ref":"refs/changes/49/549/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/49/549/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/49/549/1 \u0026\u0026 git checkout -b change-549 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/49/549/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/49/549/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/49/549/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/49/549/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/49/549/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"e8c629fe64c67ea0a8454753be99db44df7ce53e","subject":"phase2_tcp_server: fix Coverity issue \u0027Dereference after null check\u0027"}],"author":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2024-03-25 01:45:14.000000000","tz":60},"committer":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2024-03-25 18:04:43.000000000","tz":60},"subject":"Fix snprintf/swnprintf related compiler warnings","message":"Fix snprintf/swnprintf related compiler warnings\n\nWhen openvpn_snprintf is replaced by snprintf the GCC/MSVC compiler\nwill perform additional checks that the result is not truncated.\n\nThis warning can be avoid by either explicitly the return value\nof snprintf (proxy) or ensuring that it is never truncated(tls crypt)\n\nChange-Id: If23988a05dd53a519c5e57f2aa3b2d10bd29df1d\nSigned-off-by: Arne Schwabe \u003carne@rfc2549.org\u003e\n"},"branch":"refs/heads/master"},"6889d9e2f1458272ded4c035df40378ace3d7395":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2024-03-26 11:28:36.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/49/549/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/49/549/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/49/549/2 \u0026\u0026 git checkout -b change-549 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/49/549/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/49/549/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/49/549/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/49/549/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/49/549/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"e8c629fe64c67ea0a8454753be99db44df7ce53e","subject":"phase2_tcp_server: fix Coverity issue \u0027Dereference after null check\u0027"}],"author":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2024-03-26 10:41:01.000000000","tz":60},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2024-03-26 11:03:00.000000000","tz":60},"subject":"Fix snprintf/swnprintf related compiler warnings","message":"Fix snprintf/swnprintf related compiler warnings\n\nWhen openvpn_snprintf is replaced by snprintf the GCC/MSVC compiler\nwill perform additional checks that the result is not truncated.\n\nThis warning can be avoid by either explicitly checking the return value\nof snprintf (proxy) or ensuring that it is never truncated(tls crypt)\n\nChange-Id: If23988a05dd53a519c5e57f2aa3b2d10bd29df1d\nSigned-off-by: Arne Schwabe \u003carne@rfc2549.org\u003e\nAcked-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\nMessage-Id: \u003c20240326104101.531291-1-frank@lichtenheld.com\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg28475.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}