)]}'
{"id":"openvpn~552","triplet_id":"openvpn~master~I911e25949a8647b567fd4178683534d4404ab469","project":"openvpn","branch":"master","full_branch":"refs/heads/master","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2024-04-02 14:56:50.000000000","reason":"Change was submitted"},"1000002":{"account":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"last_update":"2024-04-02 13:48:48.000000000","reason":"\u003cGERRIT_ACCOUNT_1000002\u003e replied on the change","reason_account":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}},"1000001":{"account":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2024-04-02 14:56:50.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I911e25949a8647b567fd4178683534d4404ab469","subject":"Remove/combine redundant call of EVP_CipherInit before EVP_CipherInit_Ex","status":"MERGED","created":"2024-04-02 00:21:57.000000000","updated":"2024-04-02 14:56:50.000000000","submitted":"2024-04-02 14:56:50.000000000","submitter":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":3,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"552","meta_rev_id":"794d6bd3d5dc26a7a40c7153a87405581c2fee0a","_number":552,"virtual_id_number":552,"owner":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-04-02 00:21:58.000000000","updated_by":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"real_updated_by":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2024-04-02 00:21:58.000000000","updated_by":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"real_updated_by":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"reviewer":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"state":"REVIEWER"},{"updated":"2024-04-02 12:21:44.000000000","updated_by":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"real_updated_by":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"state":"REVIEWER"}],"messages":[{"id":"cf43383b912d1246172c54add78a0ac85bdf6283","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2024-04-02 00:21:57.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"d22bb297ac56742769d031bb3975852c18264ab9","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2024-04-02 12:15:12.000000000","message":"Uploaded patch set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"d03441332c301f7ba10fd9c7b8deed70973e97ba","author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2024-04-02 12:21:44.000000000","message":"Patch Set 2: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"a24f46d1a5498e85ec8445723c03f3358632d2fb","author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2024-04-02 12:47:19.000000000","message":"Patch Set 2: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"91611df18fe69f0342fceb20855598b6fea3f633","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2024-04-02 12:56:41.000000000","message":"Uploaded patch set 3.\n\nOutdated Votes:\n* Code-Review-1 (copy condition: \"changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR is:MIN\")\n","accounts_in_message":[],"_revision_number":3},{"id":"ef2c6b74e0aa63d8d430d77e0488894321b46f21","author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2024-04-02 13:48:48.000000000","message":"Patch Set 3: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"794d6bd3d5dc26a7a40c7153a87405581c2fee0a","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2024-04-02 14:56:50.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"e81e3eb1a4322148b06f353eaa22b0a803fd74f4","revisions":{"987b4d3efc1ad185a980b6a9b74091ab4a56df17":{"kind":"REWORK","_number":1,"created":"2024-04-02 00:21:57.000000000","uploader":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"ref":"refs/changes/52/552/1","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/52/552/1","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/52/552/1 \u0026\u0026 git checkout -b change-552 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/52/552/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/52/552/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/52/552/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/52/552/1","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/52/552/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"d2f88be7b72779fac83e748b297605d9d29fc4e3","subject":"Match ifdef for get_sigtype function with if ifdef of caller"}],"author":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2024-03-27 09:49:36.000000000","tz":60},"committer":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2024-04-02 00:21:45.000000000","tz":120},"subject":"Remove redundant call of EVP_CipherInit before EVP_CipherInit_Ex","message":"Remove redundant call of EVP_CipherInit before EVP_CipherInit_Ex\n\nEVP_CipherInit basically is the same EVP_CipherInit_ex except that it\nin some instances it resets/inits the ctx parameter first. We already\ncall EVP_CIPHER_CTX_reset to reset/init the ctx before so this call does\nnot do anything useful\n\nChange-Id: I911e25949a8647b567fd4178683534d4404ab469\nSigned-off-by: Arne Schwabe \u003carne@rfc2549.org\u003e\n"},"branch":"refs/heads/master"},"3394fa446e274681d179432f194e8a784cc878af":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2024-04-02 12:15:12.000000000","uploader":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"ref":"refs/changes/52/552/2","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/52/552/2","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/52/552/2 \u0026\u0026 git checkout -b change-552 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/52/552/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/52/552/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/52/552/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/52/552/2","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/52/552/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"d2f88be7b72779fac83e748b297605d9d29fc4e3","subject":"Match ifdef for get_sigtype function with if ifdef of caller"}],"author":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2024-03-27 09:49:36.000000000","tz":60},"committer":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2024-04-02 12:10:51.000000000","tz":120},"subject":"Remove redundant call of EVP_CipherInit before EVP_CipherInit_Ex","message":"Remove redundant call of EVP_CipherInit before EVP_CipherInit_Ex\n\nEVP_CipherInit basically is the same EVP_CipherInit_ex except that it\nin some instances it resets/inits the ctx parameter first. We already\ncall EVP_CIPHER_CTX_reset to reset/init the ctx before so this call does\nnot do anything useful.\n\nOpenSSL 1.0.2:\n\nhttps://github.com/openssl/openssl/blob/OpenSSL_1_0_2-stable/crypto/evp/evp_enc.c#L94\n\nEVP_CipherInit calls first EVP_CIPHER_CTX_init and then EVP_CipherInit_ex\n\nOur openssl_compat.h has\n\nfor these older OpenSSL versions\n\nOpenSSL 3.0:\n\nhttps://github.com/openssl/openssl/blob/openssl-3.2/crypto/evp/evp_enc.c#L450\n\nbasically the same as 1.0.2. Just that method names have been changed.\n\nChange-Id: I911e25949a8647b567fd4178683534d4404ab469\nSigned-off-by: Arne Schwabe \u003carne@rfc2549.org\u003e\n"},"branch":"refs/heads/master"},"abfefe206c805c7c22c86ea99c159af50a9eaf14":{"kind":"REWORK","_number":3,"created":"2024-04-02 12:56:41.000000000","uploader":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"ref":"refs/changes/52/552/3","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/52/552/3","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/52/552/3 \u0026\u0026 git checkout -b change-552 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/52/552/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/52/552/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/52/552/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/52/552/3","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/52/552/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"d2f88be7b72779fac83e748b297605d9d29fc4e3","subject":"Match ifdef for get_sigtype function with if ifdef of caller"}],"author":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2024-03-27 09:49:36.000000000","tz":60},"committer":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2024-04-02 12:54:47.000000000","tz":120},"subject":"Remove/combine redundant call of EVP_CipherInit before EVP_CipherInit_Ex","message":"Remove/combine redundant call of EVP_CipherInit before EVP_CipherInit_Ex\n\nEVP_CipherInit basically is the same EVP_CipherInit_ex except that it\nin some instances it resets/inits the ctx parameter first. We already\ncall EVP_CIPHER_CTX_reset to reset/init the ctx before. Also ensure that\nEVP_CipherInit_Ex gets the cipher to actually be able to initialise the\ncontext.\n\nOpenSSL 1.0.2:\n\nhttps://github.com/openssl/openssl/blob/OpenSSL_1_0_2-stable/crypto/evp/evp_enc.c#L94\n\nEVP_CipherInit calls first EVP_CIPHER_CTX_init and then EVP_CipherInit_ex\n\nOur openssl_compat.h has\n\nfor these older OpenSSL versions\n\nOpenSSL 3.0:\n\nhttps://github.com/openssl/openssl/blob/openssl-3.2/crypto/evp/evp_enc.c#L450\n\nbasically the same as 1.0.2. Just that method names have been changed.\n\nChange-Id: I911e25949a8647b567fd4178683534d4404ab469\nSigned-off-by: Arne Schwabe \u003carne@rfc2549.org\u003e\n"},"branch":"refs/heads/master"},"e81e3eb1a4322148b06f353eaa22b0a803fd74f4":{"kind":"NO_CODE_CHANGE","_number":4,"created":"2024-04-02 14:56:50.000000000","uploader":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/52/552/4","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/52/552/4","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/52/552/4 \u0026\u0026 git checkout -b change-552 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/52/552/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/52/552/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/52/552/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/52/552/4","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/52/552/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"ff402c7c2fbc49ff6d352ebdc3cdc4c27c2bbcbb","subject":"Match ifdef for get_sigtype function with if ifdef of caller"}],"author":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2024-04-02 13:49:09.000000000","tz":120},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2024-04-02 14:26:25.000000000","tz":120},"subject":"Remove/combine redundant call of EVP_CipherInit before EVP_CipherInit_Ex","message":"Remove/combine redundant call of EVP_CipherInit before EVP_CipherInit_Ex\n\nEVP_CipherInit basically is the same EVP_CipherInit_ex except that it\nin some instances it resets/inits the ctx parameter first. We already\ncall EVP_CIPHER_CTX_reset to reset/init the ctx before. Also ensure that\nEVP_CipherInit_Ex gets the cipher to actually be able to initialise the\ncontext.\n\nOpenSSL 1.0.2:\n\nhttps://github.com/openssl/openssl/blob/OpenSSL_1_0_2-stable/crypto/evp/evp_enc.c#L94\n\nEVP_CipherInit calls first EVP_CIPHER_CTX_init and then EVP_CipherInit_ex\n\nOur openssl_compat.h has\n\nfor these older OpenSSL versions\n\nOpenSSL 3.0:\n\nhttps://github.com/openssl/openssl/blob/openssl-3.2/crypto/evp/evp_enc.c#L450\n\nbasically the same as 1.0.2. Just that method names have been changed.\n\nChange-Id: I911e25949a8647b567fd4178683534d4404ab469\nSigned-off-by: Arne Schwabe \u003carne@rfc2549.org\u003e\nAcked-by: Gert Doering \u003cgert@greenie.muc.de\u003e\nMessage-Id: \u003c20240402134909.6340-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg28523.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[]}
