)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"eca79d7b41caa6fb5cced3dea6721c19f764262b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"9d754b60_9f1e35a6","updated":"2024-04-30 10:48:24.000000000","message":"pkg-config check missed","commit_id":"bb1fd12731ea2a09adb55e9aef251fab504c21ac"},{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"84f6edd085ba16c429a1ca91ee665d8900d8f7ce","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"61296d09_9eae5e80","updated":"2024-05-08 10:44:06.000000000","message":"Note that the build failures on CentOS 7 and FreeBSD 7.4 are expected. But the build failures on OpenBSD and Solaris still need to be investigated.","commit_id":"c49c2ae752ba856d7e63d1d7b5b8ac4a76a17a74"},{"author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"9f41c481647739ff86ed8ff261581092591fa54f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"75184a3f_3367df69","updated":"2024-05-14 14:15:00.000000000","message":"Went through the code, the #ifdefs all look good (there is one LibreSSL fix that is strictly speaking \"not 1.0.2 removal related\" but also makes sense).\n\nI expect some conflicts with the recent LibreSSL crash fix patch, but can handle that on commit.  So, let\u0027s go :-)","commit_id":"638639a3eaa8f620cf34b94f7afe2eff44a385f8"}],"configure.ac":[{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"eca79d7b41caa6fb5cced3dea6721c19f764262b","unresolved":true,"context_lines":[{"line_number":888,"context_line":"\t\t# if the user did not explicitly specify flags, try to autodetect"},{"line_number":889,"context_line":"\t\tPKG_CHECK_MODULES("},{"line_number":890,"context_line":"\t\t\t[OPENSSL],"},{"line_number":891,"context_line":"\t\t\t[openssl \u003e\u003d 1.0.2],"},{"line_number":892,"context_line":"\t\t\t[have_openssl\u003d\"yes\"],"},{"line_number":893,"context_line":"\t\t\t[AC_MSG_WARN([OpenSSL not found by pkg-config ${pkg_config_found}])] # If this fails, we will do another test next"},{"line_number":894,"context_line":"\t\t)"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"30de7ebf_8c06630a","line":891,"updated":"2024-04-30 10:48:24.000000000","message":"Check needs update","commit_id":"bb1fd12731ea2a09adb55e9aef251fab504c21ac"},{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"83780e38a971b7e43a34c70bccd0dabc0df80f01","unresolved":false,"context_lines":[{"line_number":888,"context_line":"\t\t# if the user did not explicitly specify flags, try to autodetect"},{"line_number":889,"context_line":"\t\tPKG_CHECK_MODULES("},{"line_number":890,"context_line":"\t\t\t[OPENSSL],"},{"line_number":891,"context_line":"\t\t\t[openssl \u003e\u003d 1.0.2],"},{"line_number":892,"context_line":"\t\t\t[have_openssl\u003d\"yes\"],"},{"line_number":893,"context_line":"\t\t\t[AC_MSG_WARN([OpenSSL not found by pkg-config ${pkg_config_found}])] # If this fails, we will do another test next"},{"line_number":894,"context_line":"\t\t)"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"40e81107_9a4502e6","line":891,"in_reply_to":"30de7ebf_8c06630a","updated":"2024-04-30 16:02:59.000000000","message":"Done","commit_id":"bb1fd12731ea2a09adb55e9aef251fab504c21ac"},{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"eca79d7b41caa6fb5cced3dea6721c19f764262b","unresolved":true,"context_lines":[{"line_number":903,"context_line":"\t# If pkgconfig check failed or OPENSSL_CFLAGS/OPENSSL_LIBS env vars"},{"line_number":904,"context_line":"\t# are used, check the version directly in the OpenSSL include file"},{"line_number":905,"context_line":"\tif test \"${have_openssl}\" !\u003d \"yes\"; then"},{"line_number":906,"context_line":"\t\tAC_MSG_CHECKING([additionally if OpenSSL is available and version \u003e\u003d 1.0.2])"},{"line_number":907,"context_line":"\t\tAC_COMPILE_IFELSE("},{"line_number":908,"context_line":"\t\t\t[AC_LANG_PROGRAM("},{"line_number":909,"context_line":"\t\t\t\t[["}],"source_content_type":"application/octet-stream","patch_set":1,"id":"fa0067eb_6f78ba03","line":906,"updated":"2024-04-30 10:48:24.000000000","message":"Message needs update","commit_id":"bb1fd12731ea2a09adb55e9aef251fab504c21ac"},{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"83780e38a971b7e43a34c70bccd0dabc0df80f01","unresolved":false,"context_lines":[{"line_number":903,"context_line":"\t# If pkgconfig check failed or OPENSSL_CFLAGS/OPENSSL_LIBS env vars"},{"line_number":904,"context_line":"\t# are used, check the version directly in the OpenSSL include file"},{"line_number":905,"context_line":"\tif test \"${have_openssl}\" !\u003d \"yes\"; then"},{"line_number":906,"context_line":"\t\tAC_MSG_CHECKING([additionally if OpenSSL is available and version \u003e\u003d 1.0.2])"},{"line_number":907,"context_line":"\t\tAC_COMPILE_IFELSE("},{"line_number":908,"context_line":"\t\t\t[AC_LANG_PROGRAM("},{"line_number":909,"context_line":"\t\t\t\t[["}],"source_content_type":"application/octet-stream","patch_set":1,"id":"cc8507eb_d5b5257b","line":906,"in_reply_to":"fa0067eb_6f78ba03","updated":"2024-04-30 16:02:59.000000000","message":"Done","commit_id":"bb1fd12731ea2a09adb55e9aef251fab504c21ac"},{"author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"21e05e68e805313a6fef371d96f739dc505e2992","unresolved":true,"context_lines":[{"line_number":912,"context_line":"\t\t\t\t[["},{"line_number":913,"context_line":"/*\t     Version encoding: MNNFFPPS - see opensslv.h for details */"},{"line_number":914,"context_line":"#if OPENSSL_VERSION_NUMBER \u003c 0x10100000L"},{"line_number":915,"context_line":"#error OpenSSL too old"},{"line_number":916,"context_line":"#endif"},{"line_number":917,"context_line":"\t\t\t\t]]"},{"line_number":918,"context_line":"\t\t\t)],"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"3c1dbe9f_996b70a0","line":915,"updated":"2024-04-30 11:07:25.000000000","message":"This check is not working - the centos and fbsd74 buildbots pass the configure stage just fine, and later fail compilation.","commit_id":"bb1fd12731ea2a09adb55e9aef251fab504c21ac"},{"author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"b60bcb72d048cc2f8ed12c1db5acd90384b3a0f5","unresolved":false,"context_lines":[{"line_number":912,"context_line":"\t\t\t\t[["},{"line_number":913,"context_line":"/*\t     Version encoding: MNNFFPPS - see opensslv.h for details */"},{"line_number":914,"context_line":"#if OPENSSL_VERSION_NUMBER \u003c 0x10100000L"},{"line_number":915,"context_line":"#error OpenSSL too old"},{"line_number":916,"context_line":"#endif"},{"line_number":917,"context_line":"\t\t\t\t]]"},{"line_number":918,"context_line":"\t\t\t)],"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"455e902e_26d171b3","line":915,"in_reply_to":"2b8eb205_9e5b647f","updated":"2024-04-30 15:48:14.000000000","message":"Done","commit_id":"bb1fd12731ea2a09adb55e9aef251fab504c21ac"},{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"043ca9b387bf7616d022afd274edfd8595eeaf7c","unresolved":true,"context_lines":[{"line_number":912,"context_line":"\t\t\t\t[["},{"line_number":913,"context_line":"/*\t     Version encoding: MNNFFPPS - see opensslv.h for details */"},{"line_number":914,"context_line":"#if OPENSSL_VERSION_NUMBER \u003c 0x10100000L"},{"line_number":915,"context_line":"#error OpenSSL too old"},{"line_number":916,"context_line":"#endif"},{"line_number":917,"context_line":"\t\t\t\t]]"},{"line_number":918,"context_line":"\t\t\t)],"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"2b8eb205_9e5b647f","line":915,"in_reply_to":"3c1dbe9f_996b70a0","updated":"2024-04-30 11:25:32.000000000","message":"In the case of CentOS 7 this is because it uses the pkg-config check instead which was not updated. On FreeBSD 7.4 the checks works correctly if you look at the build logs.","commit_id":"bb1fd12731ea2a09adb55e9aef251fab504c21ac"}],"src/openvpn/ssl_openssl.c":[{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"40f1d19092cdcbe0c4e1a8101002ad36248aca28","unresolved":true,"context_lines":[{"line_number":514,"context_line":"tls_ctx_set_cert_profile(struct tls_root_ctx *ctx, const char *profile)"},{"line_number":515,"context_line":"{"},{"line_number":516,"context_line":"#if OPENSSL_VERSION_NUMBER \u003e 0x10100000L    \\"},{"line_number":517,"context_line":"    || (defined(LIBRESSL_VERSION_NUMBER) \u0026\u0026 LIBRESSL_VERSION_NUMBER \u003e  0x3060000fL)"},{"line_number":518,"context_line":"    /* OpenSSL does not have certificate profiles, but a complex set of"},{"line_number":519,"context_line":"     * callbacks that we could try to implement to achieve something similar."},{"line_number":520,"context_line":"     * For now, use OpenSSL\u0027s security levels to achieve similar (but not equal)"}],"source_content_type":"text/x-csrc","patch_set":6,"id":"aac34a0b_7c36dab9","line":517,"updated":"2024-05-08 10:54:10.000000000","message":"This check does not seem to be correct, see OpenBSD builds.","commit_id":"c49c2ae752ba856d7e63d1d7b5b8ac4a76a17a74"},{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"dceb5c26d5ac685f0a971046b6f019e3340fb870","unresolved":false,"context_lines":[{"line_number":514,"context_line":"tls_ctx_set_cert_profile(struct tls_root_ctx *ctx, const char *profile)"},{"line_number":515,"context_line":"{"},{"line_number":516,"context_line":"#if OPENSSL_VERSION_NUMBER \u003e 0x10100000L    \\"},{"line_number":517,"context_line":"    || (defined(LIBRESSL_VERSION_NUMBER) \u0026\u0026 LIBRESSL_VERSION_NUMBER \u003e  0x3060000fL)"},{"line_number":518,"context_line":"    /* OpenSSL does not have certificate profiles, but a complex set of"},{"line_number":519,"context_line":"     * callbacks that we could try to implement to achieve something similar."},{"line_number":520,"context_line":"     * For now, use OpenSSL\u0027s security levels to achieve similar (but not equal)"}],"source_content_type":"text/x-csrc","patch_set":6,"id":"cd3177a8_b7d98c56","line":517,"in_reply_to":"7129c68c_2dd6ee9e","updated":"2024-05-13 10:52:34.000000000","message":"Done","commit_id":"c49c2ae752ba856d7e63d1d7b5b8ac4a76a17a74"},{"author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"602abc9f877ecabf7f1f91472d858d4297534c1f","unresolved":true,"context_lines":[{"line_number":514,"context_line":"tls_ctx_set_cert_profile(struct tls_root_ctx *ctx, const char *profile)"},{"line_number":515,"context_line":"{"},{"line_number":516,"context_line":"#if OPENSSL_VERSION_NUMBER \u003e 0x10100000L    \\"},{"line_number":517,"context_line":"    || (defined(LIBRESSL_VERSION_NUMBER) \u0026\u0026 LIBRESSL_VERSION_NUMBER \u003e  0x3060000fL)"},{"line_number":518,"context_line":"    /* OpenSSL does not have certificate profiles, but a complex set of"},{"line_number":519,"context_line":"     * callbacks that we could try to implement to achieve something similar."},{"line_number":520,"context_line":"     * For now, use OpenSSL\u0027s security levels to achieve similar (but not equal)"}],"source_content_type":"text/x-csrc","patch_set":6,"id":"7129c68c_2dd6ee9e","line":517,"in_reply_to":"aac34a0b_7c36dab9","updated":"2024-05-13 10:44:45.000000000","message":"https://ftp.openbsd.org/pub/OpenBSD/LibreSSL/libressl-3.6.0-relnotes.txt\n\n   - The security level API (SSL_{,CTX}_{get,set}_security_level()) is\n     now available. Callbacks and ex_data are not supported. Sane\n     software will not be using this.\n     \nbut the version check needs to be different as OpenSSL version is too high on LibreSSL","commit_id":"c49c2ae752ba856d7e63d1d7b5b8ac4a76a17a74"}]}