)]}'
{"id":"openvpn~586","triplet_id":"openvpn~master~Ia08a9697d0ff41721fb0acf17ccb4cfa23cb3934","project":"openvpn","branch":"master","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2024-05-13 10:52:18.000000000","reason":"\u003cGERRIT_ACCOUNT_1000003\u003e replied on the change","reason_account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}},"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2024-05-13 15:24:13.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Ia08a9697d0ff41721fb0acf17ccb4cfa23cb3934","subject":"Workaround issue in LibreSSL crashing when enumerating digests/ciphers","status":"MERGED","created":"2024-05-08 18:09:42.000000000","updated":"2024-05-13 15:24:13.000000000","submitted":"2024-05-13 15:24:13.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"586","meta_rev_id":"820b5ea9f9005e6e5d226a5397591081899638a8","_number":586,"virtual_id_number":586,"owner":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"default_value":0}},"removable_reviewers":[{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-05-08 18:09:42.000000000","updated_by":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2024-05-08 18:09:42.000000000","updated_by":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"reviewer":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"state":"REVIEWER"},{"updated":"2024-05-08 18:15:52.000000000","updated_by":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"state":"REVIEWER"}],"messages":[{"id":"1a440a6fd930f6776b12ad23212680b9537fe3e5","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2024-05-08 18:09:42.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"165d6d47b15e57f9095493606b11684168d8b55c","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2024-05-08 18:15:52.000000000","message":"Patch Set 1: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"7c073af107d59cdba748ea7316ce1c32649a9bf7","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2024-05-13 10:52:18.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"820b5ea9f9005e6e5d226a5397591081899638a8","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2024-05-13 15:24:13.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"b3a271b11723cbe520ad4ce6b4b0459de57ade06","revisions":{"405a5d36f13d87666dd5f4fe9f4a4903c6a16538":{"kind":"REWORK","_number":1,"created":"2024-05-08 18:09:42.000000000","uploader":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"ref":"refs/changes/86/586/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/86/586/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/86/586/1 \u0026\u0026 git checkout -b change-586 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/86/586/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/86/586/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/86/586/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/86/586/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/86/586/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"badedc780925f8337a9589f9f23194b37a2ff73d","subject":"Support OpenBSD with cmake"}],"author":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2024-05-08 18:08:41.000000000","tz":120},"committer":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2024-05-08 18:09:32.000000000","tz":120},"subject":"Workaround issue in LibreSSL crashing when enumerating digests/ciphers","message":"Workaround issue in LibreSSL crashing when enumerating digests/ciphers\n\nOpenBSD/LibreSSL reimplemented EVP_get_cipherbyname/EVP_get_digestbyname\nand broke calling EVP_get_cipherbynid/EVP_get_digestbyname with an\ninvalid nid in the process so that it would segfault.\n\nWorkaround but doing that NULL check in OpenVPN instead of leaving it\nto the library.\n\nChange-Id: Ia08a9697d0ff41721fb0acf17ccb4cfa23cb3934\nSigned-off-by: Arne Schwabe \u003carne@rfc2549.org\u003e\n"},"branch":"refs/heads/master"},"b3a271b11723cbe520ad4ce6b4b0459de57ade06":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2024-05-13 15:24:13.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/86/586/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/86/586/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/86/586/2 \u0026\u0026 git checkout -b change-586 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/86/586/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/86/586/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/86/586/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/86/586/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/86/586/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"d5ba4acc297a6041bb45f7aa1c9a99b37b7d5e44","subject":"Support OpenBSD with cmake"}],"author":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2024-05-08 22:05:40.000000000","tz":120},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2024-05-13 15:18:20.000000000","tz":120},"subject":"Workaround issue in LibreSSL crashing when enumerating digests/ciphers","message":"Workaround issue in LibreSSL crashing when enumerating digests/ciphers\n\nOpenBSD/LibreSSL reimplemented EVP_get_cipherbyname/EVP_get_digestbyname\nand broke calling EVP_get_cipherbynid/EVP_get_digestbyname with an\ninvalid nid in the process so that it would segfault.\n\nWorkaround but doing that NULL check in OpenVPN instead of leaving it\nto the library.\n\nGithub: see also https://github.com/libressl/openbsd/issues/150\n\nChange-Id: Ia08a9697d0ff41721fb0acf17ccb4cfa23cb3934\nSigned-off-by: Arne Schwabe \u003carne@rfc2549.org\u003e\nAcked-by: Gert Doering \u003cgert@greenie.muc.de\u003e\nMessage-Id: \u003c20240508220540.12554-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg28649.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}