)]}'
{"id":"openvpn~588","triplet_id":"openvpn~master~I1ef5f6f21f0135a628a63553c39515fa4549ce87","project":"openvpn","branch":"master","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2024-09-12 15:02:26.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2024-07-10 16:02:15.000000000","reason":"removed on reply"}},"hashtags":["mailsubmitted"],"change_id":"I1ef5f6f21f0135a628a63553c39515fa4549ce87","subject":"Remove check for anonymous unions from configure and cmake config","status":"MERGED","created":"2024-05-15 09:48:05.000000000","updated":"2024-09-12 15:02:26.000000000","submitted":"2024-09-12 15:02:26.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"588","meta_rev_id":"a522316f7d5a1751b2a9c63c63219e16be65ad71","_number":588,"virtual_id_number":588,"owner":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"value":0,"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-05-15 09:48:05.000000000","updated_by":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2024-05-15 09:48:05.000000000","updated_by":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"reviewer":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"state":"REVIEWER"}],"messages":[{"id":"944635e52b8b9d4b60356aba199f7592fd200eb8","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2024-05-15 09:48:05.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"4d07485bc68a505ce3647766d3debe6725d07376","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"real_author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2024-05-15 13:18:31.000000000","message":"Patch Set 2: Patch Set 1 was rebased on behalf of \u003cGERRIT_ACCOUNT_1000003\u003e","accounts_in_message":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"_revision_number":2},{"id":"716f1db4f561849222f2ad21ee21b86707ba2c09","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"real_author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2024-07-09 15:53:53.000000000","message":"Patch Set 3: Patch Set 2 was rebased on behalf of \u003cGERRIT_ACCOUNT_1000003\u003e","accounts_in_message":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"_revision_number":3},{"id":"2d105b7dc6f8dfa1cc0c25998064fdc4bc8a713b","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2024-07-10 16:02:15.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"e66de98886e6d1a68b19029d6bdb570546b3dbfe","tag":"autogenerated:gerrit:setHashtag","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2024-07-10 16:02:46.000000000","message":"Hashtag added: mailsubmitted","accounts_in_message":[],"_revision_number":3},{"id":"a522316f7d5a1751b2a9c63c63219e16be65ad71","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2024-09-12 15:02:26.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"b8b2d17f473e80b1a0b66e49cc1f34ce88d9502d","revisions":{"461a2fb5eb5e4b60ddcd84300e655e4a4df93040":{"kind":"REWORK","_number":1,"created":"2024-05-15 09:48:05.000000000","uploader":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"ref":"refs/changes/88/588/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/88/588/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/88/588/1 \u0026\u0026 git checkout -b change-588 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/88/588/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/88/588/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/88/588/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/88/588/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/88/588/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"51f80db910eb48e720ce106b5b9b5ec96d8e0e23","subject":"Remove OpenSSL 1.0.2 support"}],"author":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2023-11-18 13:47:26.000000000","tz":120},"committer":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2024-05-15 09:47:51.000000000","tz":120},"subject":"Remove check for anonymous unions from configure and cmake config","message":"Remove check for anonymous unions from configure and cmake config\n\nAnonymous unions/structs are technically a custom GNU C99 feature but\nwas already widely supported by other compilers. With C11 this feature\nhas become a standard feature so all compilers nowadays support it.\n\nChange-Id: I1ef5f6f21f0135a628a63553c39515fa4549ce87\nSigned-off-by: Arne Schwabe \u003carne@rfc2549.org\u003e\n"},"branch":"refs/heads/master"},"db5a4e94e297e9af4bf1b206ce9a2a33d0797032":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2024-05-15 13:18:31.000000000","uploader":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"real_uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/88/588/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/88/588/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/88/588/2 \u0026\u0026 git checkout -b change-588 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/88/588/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/88/588/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/88/588/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/88/588/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/88/588/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"763b35f652b1913ddd01e6c548b3e6a57076ba42","subject":"Remove custom TLS 1.0 PRF implementation only used by LibreSSL/wolfSSL"}],"author":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2023-11-18 13:47:26.000000000","tz":120},"committer":{"name":"plaisthos","email":"arne-openvpn@rfc2549.org","date":"2024-05-15 13:18:31.000000000","tz":0},"subject":"Remove check for anonymous unions from configure and cmake config","message":"Remove check for anonymous unions from configure and cmake config\n\nAnonymous unions/structs are technically a custom GNU C99 feature but\nwas already widely supported by other compilers. With C11 this feature\nhas become a standard feature so all compilers nowadays support it.\n\nChange-Id: I1ef5f6f21f0135a628a63553c39515fa4549ce87\nSigned-off-by: Arne Schwabe \u003carne@rfc2549.org\u003e\n"},"branch":"refs/heads/master","description":"Rebase"},"04c45dcb518eb208a7dbf8323b287958de977f78":{"kind":"TRIVIAL_REBASE","_number":3,"created":"2024-07-09 15:53:53.000000000","uploader":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"real_uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/88/588/3","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/88/588/3","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/88/588/3 \u0026\u0026 git checkout -b change-588 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/88/588/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/88/588/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/88/588/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/88/588/3","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/88/588/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"f8f477139804b06183b515a529c982f524547d18","subject":"t_server_null: multiple improvements and fixes"}],"author":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2023-11-18 13:47:26.000000000","tz":120},"committer":{"name":"plaisthos","email":"arne-openvpn@rfc2549.org","date":"2024-07-09 15:53:53.000000000","tz":0},"subject":"Remove check for anonymous unions from configure and cmake config","message":"Remove check for anonymous unions from configure and cmake config\n\nAnonymous unions/structs are technically a custom GNU C99 feature but\nwas already widely supported by other compilers. With C11 this feature\nhas become a standard feature so all compilers nowadays support it.\n\nChange-Id: I1ef5f6f21f0135a628a63553c39515fa4549ce87\nSigned-off-by: Arne Schwabe \u003carne@rfc2549.org\u003e\n"},"branch":"refs/heads/master","description":"Rebase"},"b8b2d17f473e80b1a0b66e49cc1f34ce88d9502d":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":4,"created":"2024-09-12 15:02:26.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/88/588/4","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/88/588/4","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/88/588/4 \u0026\u0026 git checkout -b change-588 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/88/588/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/88/588/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/88/588/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/88/588/4","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/88/588/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"992da812ad56d2cff44fd4f171dd85c808e1ed50","subject":"tun: removed unnecessary route installations"}],"author":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2024-07-10 16:02:38.000000000","tz":120},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2024-09-12 14:59:43.000000000","tz":120},"subject":"Remove check for anonymous unions from configure and cmake config","message":"Remove check for anonymous unions from configure and cmake config\n\nAnonymous unions/structs are technically a custom GNU C99 feature but\nwas already widely supported by other compilers. With C11 this feature\nhas become a standard feature so all compilers nowadays support it.\n\nChange-Id: I1ef5f6f21f0135a628a63553c39515fa4549ce87\nSigned-off-by: Arne Schwabe \u003carne@rfc2549.org\u003e\nAcked-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\nMessage-Id: \u003c20240710160238.190189-1-frank@lichtenheld.com\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg28914.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}