)]}'
{"id":"openvpn~621","triplet_id":"openvpn~master~Ia2c3e4c5c83ecccce1618c43b489dbe811de5351","project":"openvpn","branch":"master","full_branch":"refs/heads/master","attention_set":{},"removed_from_attention_set":{"1000009":{"account":{"_account_id":1000009,"name":"Selva Nair","display_name":"Selva Nair","email":"selva.nair@gmail.com","username":"selvanair"},"last_update":"2024-06-06 11:33:44.000000000","reason":"Change was submitted"},"1000037":{"account":{"_account_id":1000037,"name":"ssbssa","display_name":"Hannes Domani","email":"ssbssa@yahoo.de","username":"ssbssa"},"last_update":"2024-06-03 14:35:28.000000000","reason":"\u003cGERRIT_ACCOUNT_1000037\u003e replied on the change","reason_account":{"_account_id":1000037,"name":"ssbssa","display_name":"Hannes Domani","email":"ssbssa@yahoo.de","username":"ssbssa"}},"1000003":{"account":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2024-06-06 11:33:44.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2024-06-06 11:33:44.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Ia2c3e4c5c83ecccce1618c43b489dbe811de5351","subject":"Implement Windows CA template match for Crypto-API selector","status":"MERGED","created":"2024-05-28 17:28:00.000000000","updated":"2024-06-06 11:33:44.000000000","submitted":"2024-06-06 11:33:44.000000000","submitter":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":13,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"642","meta_rev_id":"1d3942f9482a9fc2dccbd71cddcfc2d995ac82d4","_number":621,"virtual_id_number":621,"owner":{"_account_id":1000037,"name":"ssbssa","display_name":"Hannes Domani","email":"ssbssa@yahoo.de","username":"ssbssa"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000009,"name":"Selva Nair","display_name":"Selva Nair","email":"selva.nair@gmail.com","username":"selvanair"},{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-05-28 17:28:01.000000000","updated_by":{"_account_id":1000037,"name":"ssbssa","display_name":"Hannes Domani","email":"ssbssa@yahoo.de","username":"ssbssa"},"real_updated_by":{"_account_id":1000037,"name":"ssbssa","display_name":"Hannes Domani","email":"ssbssa@yahoo.de","username":"ssbssa"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2024-05-28 17:28:01.000000000","updated_by":{"_account_id":1000037,"name":"ssbssa","display_name":"Hannes Domani","email":"ssbssa@yahoo.de","username":"ssbssa"},"real_updated_by":{"_account_id":1000037,"name":"ssbssa","display_name":"Hannes Domani","email":"ssbssa@yahoo.de","username":"ssbssa"},"reviewer":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"state":"REVIEWER"},{"updated":"2024-05-28 17:28:01.000000000","updated_by":{"_account_id":1000037,"name":"ssbssa","display_name":"Hannes Domani","email":"ssbssa@yahoo.de","username":"ssbssa"},"real_updated_by":{"_account_id":1000037,"name":"ssbssa","display_name":"Hannes Domani","email":"ssbssa@yahoo.de","username":"ssbssa"},"reviewer":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2024-06-03 03:04:01.000000000","updated_by":{"_account_id":1000009,"name":"Selva Nair","display_name":"Selva Nair","email":"selva.nair@gmail.com","username":"selvanair"},"real_updated_by":{"_account_id":1000009,"name":"Selva Nair","display_name":"Selva Nair","email":"selva.nair@gmail.com","username":"selvanair"},"reviewer":{"_account_id":1000009,"name":"Selva Nair","display_name":"Selva Nair","email":"selva.nair@gmail.com","username":"selvanair"},"state":"CC"}],"messages":[{"id":"f20b78b106bf4e8575afe0462ac233fb72704155","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000037,"name":"ssbssa","display_name":"Hannes Domani","email":"ssbssa@yahoo.de","username":"ssbssa"},"date":"2024-05-28 17:28:00.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"421eaeac5309f614b8a6dd19e2df6a0f1512bba0","author":{"_account_id":1000037,"name":"ssbssa","display_name":"Hannes Domani","email":"ssbssa@yahoo.de","username":"ssbssa"},"date":"2024-05-28 17:43:34.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"2bd78e8fe192563a135fa0fedcf0ef62a2509ade","author":{"_account_id":1000009,"name":"Selva Nair","display_name":"Selva Nair","email":"selva.nair@gmail.com","username":"selvanair"},"date":"2024-06-03 03:04:01.000000000","message":"Patch Set 1:\n\n(6 comments)","accounts_in_message":[],"_revision_number":1},{"id":"b48347b78816e10488e99dd1bb29ab454cf85731","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000037,"name":"ssbssa","display_name":"Hannes Domani","email":"ssbssa@yahoo.de","username":"ssbssa"},"date":"2024-06-03 14:33:15.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"1c43eb315e089099b7b5341b27633b1fb177ada4","author":{"_account_id":1000037,"name":"ssbssa","display_name":"Hannes Domani","email":"ssbssa@yahoo.de","username":"ssbssa"},"date":"2024-06-03 14:35:28.000000000","message":"Patch Set 2:\n\n(6 comments)","accounts_in_message":[],"_revision_number":2},{"id":"1d3942f9482a9fc2dccbd71cddcfc2d995ac82d4","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2024-06-06 11:33:44.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"13ee7f902f18e27b981f8e440facd2e6515c6c83","revisions":{"2b1e725d8ed5905abdb0f518cb851a9c814c8f6a":{"kind":"REWORK","_number":1,"created":"2024-05-28 17:28:00.000000000","uploader":{"_account_id":1000037,"name":"ssbssa","display_name":"Hannes Domani","email":"ssbssa@yahoo.de","username":"ssbssa"},"ref":"refs/changes/21/621/1","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/21/621/1","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/21/621/1 \u0026\u0026 git checkout -b change-621 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/21/621/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/21/621/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/21/621/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/21/621/1","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/21/621/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"55bb3260c12bae33b6a8eac73cbb6972f8517411","subject":"Only schedule_exit() once"}],"author":{"name":"Heiko Wundram","email":"heiko.wundram@gehrkens.it","date":"2021-05-25 09:25:10.000000000","tz":120},"committer":{"name":"Hannes Domani","email":"ssbssa@yahoo.de","date":"2024-05-28 17:27:26.000000000","tz":120},"subject":"Implement Windows CA template match for Crypto-API selector","message":"Implement Windows CA template match for Crypto-API selector\n\nThe certificate selection process for the Crypto API certificates\nis currently fixed to match on subject or identifier. Especially\nif certificates that are used for OpenVPN are managed by a Windows CA,\nit is appropriate to select the certificate to use by the template\nthat it is generated from, especially on domain-joined clients which\nautomatically acquire/renew the corresponding certificate.\n\nThe attached match implements the match on TMPL: with either a template\nname (which is looked up through CryptFindOIDInfo) or by specifying the\nOID of the template directly, which then is matched against the\ncorresponding X509 extensions specifying the template that the certificate\nwas generated from.\n\nThe logic requires to walk all certificates in the underlying store and\nto match the certificate extensions directly. The hook which is\nimplemented in the certificate selection logic is generic to allow\nother Crypto-API certificate matches to also be implemented at some\npoint in the future.\n\nThe logic to match the certificate template is taken from the\nimplementation in the .NET core runtime, see Pal.Windows/FindPal.cs in\nin the implementation of System.Security.Cryptography.X509Certificates.\n\nChange-Id: Ia2c3e4c5c83ecccce1618c43b489dbe811de5351\nSigned-off-by: Heiko Wundram \u003cheiko.wundram@gehrkens.it\u003e\nSigned-off-by: Hannes Domani \u003cssbssa@yahoo.de\u003e\n"},"branch":"refs/heads/master"},"7776e7f7988e245b05b2a20d9f48377872ab7c4c":{"kind":"REWORK","_number":2,"created":"2024-06-03 14:33:15.000000000","uploader":{"_account_id":1000037,"name":"ssbssa","display_name":"Hannes Domani","email":"ssbssa@yahoo.de","username":"ssbssa"},"ref":"refs/changes/21/621/2","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/21/621/2","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/21/621/2 \u0026\u0026 git checkout -b change-621 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/21/621/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/21/621/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/21/621/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/21/621/2","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/21/621/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"82036c17c45d45c3fe8725f64b33720cb9c94dad","subject":"Allow to set ifmode for existing DCO interfaces in FreeBSD"}],"author":{"name":"Heiko Wundram","email":"heiko.wundram@gehrkens.it","date":"2021-05-25 09:25:10.000000000","tz":120},"committer":{"name":"Hannes Domani","email":"ssbssa@yahoo.de","date":"2024-06-03 14:32:34.000000000","tz":120},"subject":"Implement Windows CA template match for Crypto-API selector","message":"Implement Windows CA template match for Crypto-API selector\n\nThe certificate selection process for the Crypto API certificates\nis currently fixed to match on subject or identifier. Especially\nif certificates that are used for OpenVPN are managed by a Windows CA,\nit is appropriate to select the certificate to use by the template\nthat it is generated from, especially on domain-joined clients which\nautomatically acquire/renew the corresponding certificate.\n\nThe attached match implements the match on TMPL: with either a template\nname (which is looked up through CryptFindOIDInfo) or by specifying the\nOID of the template directly, which then is matched against the\ncorresponding X509 extensions specifying the template that the certificate\nwas generated from.\n\nThe logic requires to walk all certificates in the underlying store and\nto match the certificate extensions directly. The hook which is\nimplemented in the certificate selection logic is generic to allow\nother Crypto-API certificate matches to also be implemented at some\npoint in the future.\n\nThe logic to match the certificate template is taken from the\nimplementation in the .NET core runtime, see Pal.Windows/FindPal.cs in\nin the implementation of System.Security.Cryptography.X509Certificates.\n\nChange-Id: Ia2c3e4c5c83ecccce1618c43b489dbe811de5351\nSigned-off-by: Heiko Wundram \u003cheiko.wundram@gehrkens.it\u003e\nSigned-off-by: Hannes Domani \u003cssbssa@yahoo.de\u003e\n"},"branch":"refs/heads/master"},"13ee7f902f18e27b981f8e440facd2e6515c6c83":{"kind":"REWORK","_number":3,"created":"2024-06-06 11:33:44.000000000","uploader":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/21/621/3","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/21/621/3","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/21/621/3 \u0026\u0026 git checkout -b change-621 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/21/621/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/21/621/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/21/621/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/21/621/3","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/21/621/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"bf887c95e46c6892ac1f68be5559525f8d975530","subject":"Windows: enforce \u0027block-local\u0027 with WFP filters"}],"author":{"name":"Heiko Wundram","email":"heiko.wundram@gehrkens.it","date":"2024-06-06 10:34:41.000000000","tz":120},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2024-06-06 11:19:17.000000000","tz":120},"subject":"Implement Windows CA template match for Crypto-API selector","message":"Implement Windows CA template match for Crypto-API selector\n\nThe certificate selection process for the Crypto API certificates\nis currently fixed to match on subject or identifier. Especially\nif certificates that are used for OpenVPN are managed by a Windows CA,\nit is appropriate to select the certificate to use by the template\nthat it is generated from, especially on domain-joined clients which\nautomatically acquire/renew the corresponding certificate.\n\nThe attached match implements the match on TMPL: with either a template\nname (which is looked up through CryptFindOIDInfo) or by specifying the\nOID of the template directly, which then is matched against the\ncorresponding X509 extensions specifying the template that the certificate\nwas generated from.\n\nThe logic requires to walk all certificates in the underlying store and\nto match the certificate extensions directly. The hook which is\nimplemented in the certificate selection logic is generic to allow\nother Crypto-API certificate matches to also be implemented at some\npoint in the future.\n\nThe logic to match the certificate template is taken from the\nimplementation in the .NET core runtime, see Pal.Windows/FindPal.cs in\nin the implementation of System.Security.Cryptography.X509Certificates.\n\nChange-Id: Ia2c3e4c5c83ecccce1618c43b489dbe811de5351\nSigned-off-by: Heiko Wundram \u003cheiko.wundram@gehrkens.it\u003e\nSigned-off-by: Hannes Domani \u003cssbssa@yahoo.de\u003e\nAcked-by: Selva Nair \u003cselva.nair@gmail.com\u003e\nMessage-Id: \u003c20240606103441.26598-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg28726.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[]}
