)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"79e7cc3c9a096e4388d7dcb86edd498285625601","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"1fcc1cda_36dddc7d","updated":"2024-06-26 16:58:21.000000000","message":"A few small nitpicks","commit_id":"8cbf4d63502bbe5fb26e8cf9c7694b6f2e07a228"},{"author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"a17e07ee313b4a7a3db16690b0735dca701f8f7b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ab13c02b_c1ef18c4","updated":"2024-07-29 11:33:54.000000000","message":"Summing up the intermediate discussions on IRC\n\n13:32 \u003c@cron2\u003e ordex, gianm: wrt https://gerrit.openvpn.net/c/openvpn/+/662 - \n               do I remember correctly that we went for \"we will at some point \n               do a cut-over, and who wants to use dco_v2 needs to use 2.6, and \n               master will only support dco_v3 / ovpn\"?\n13:32 \u003c@ordex\u003e Giaan: ^\n13:33 \u003c@ordex\u003e cron2: correct\n13:33 \u003c@ordex\u003e that\u0027s the final decision\n13:33 \u003c@cron2\u003e in that case, I think 662 can be abandoned and we\u0027ll see a new \n               patch that does the renaming + code change, but no if() and no \n               function pointers :-)\n13:33 \u003c@ordex\u003e so we don\u0027t need abstraction layers or function pointers anymore\n13:33 \u003c@cron2\u003e \\o/\n13:33 \u003c@ordex\u003e correct\n13:33 \u003c@ordex\u003e Giaan will publish that patch later on, once v3 will be ready \n               for dev use","commit_id":"8cbf4d63502bbe5fb26e8cf9c7694b6f2e07a228"}],"src/openvpn/dco_linux.h":[{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"79e7cc3c9a096e4388d7dcb86edd498285625601","unresolved":true,"context_lines":[{"line_number":126,"context_line":" *"},{"line_number":127,"context_line":" * The method will also free nl_msg"},{"line_number":128,"context_line":" * @param dco       The dco context to use"},{"line_number":129,"context_line":" * @param nl_msg    the message to use"},{"line_number":130,"context_line":" * @param cb        An optional callback if the caller expects an answer"},{"line_number":131,"context_line":" * @param cb_arg    An optional param to pass to the callback"},{"line_number":132,"context_line":" * @param prefix    A prefix to report in the error message to give the user context"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"23d9dd04_2e8af958","line":129,"updated":"2024-06-26 16:58:21.000000000","message":"\"The\"","commit_id":"8cbf4d63502bbe5fb26e8cf9c7694b6f2e07a228"},{"author":{"_account_id":1000034,"name":"its_Giaan","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"change_message_id":"bb4562982bca06530779c44c9365247229bc375b","unresolved":false,"context_lines":[{"line_number":126,"context_line":" *"},{"line_number":127,"context_line":" * The method will also free nl_msg"},{"line_number":128,"context_line":" * @param dco       The dco context to use"},{"line_number":129,"context_line":" * @param nl_msg    the message to use"},{"line_number":130,"context_line":" * @param cb        An optional callback if the caller expects an answer"},{"line_number":131,"context_line":" * @param cb_arg    An optional param to pass to the callback"},{"line_number":132,"context_line":" * @param prefix    A prefix to report in the error message to give the user context"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"86f99d7c_43678f20","line":129,"in_reply_to":"23d9dd04_2e8af958","updated":"2024-06-27 08:44:04.000000000","message":"Acknowledged","commit_id":"8cbf4d63502bbe5fb26e8cf9c7694b6f2e07a228"},{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"79e7cc3c9a096e4388d7dcb86edd498285625601","unresolved":true,"context_lines":[{"line_number":171,"context_line":"/**"},{"line_number":172,"context_line":" * Lookup the multicast id for OpenVPN. This method and its help method currently"},{"line_number":173,"context_line":" * hardcode the lookup to OVPN_NL_NAME and OVPN_NL_MULTICAST_GROUP_PEERS but"},{"line_number":174,"context_line":" * extended in the future if we need to lookup more than one mcast id."},{"line_number":175,"context_line":" */"},{"line_number":176,"context_line":"int ovpn_get_mcast_id(dco_context_t *dco);"},{"line_number":177,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":1,"id":"e8c66910_d887f4a2","line":174,"updated":"2024-06-26 16:58:21.000000000","message":"\"can be extended\" ?","commit_id":"8cbf4d63502bbe5fb26e8cf9c7694b6f2e07a228"},{"author":{"_account_id":1000034,"name":"its_Giaan","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"change_message_id":"bb4562982bca06530779c44c9365247229bc375b","unresolved":false,"context_lines":[{"line_number":171,"context_line":"/**"},{"line_number":172,"context_line":" * Lookup the multicast id for OpenVPN. This method and its help method currently"},{"line_number":173,"context_line":" * hardcode the lookup to OVPN_NL_NAME and OVPN_NL_MULTICAST_GROUP_PEERS but"},{"line_number":174,"context_line":" * extended in the future if we need to lookup more than one mcast id."},{"line_number":175,"context_line":" */"},{"line_number":176,"context_line":"int ovpn_get_mcast_id(dco_context_t *dco);"},{"line_number":177,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":1,"id":"88a96579_919aab40","line":174,"in_reply_to":"e8c66910_d887f4a2","updated":"2024-06-27 08:44:04.000000000","message":"Acknowledged","commit_id":"8cbf4d63502bbe5fb26e8cf9c7694b6f2e07a228"}],"src/openvpn/forward.c":[{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"79e7cc3c9a096e4388d7dcb86edd498285625601","unresolved":true,"context_lines":[{"line_number":1230,"context_line":"process_incoming_dco(struct context *c)"},{"line_number":1231,"context_line":"{"},{"line_number":1232,"context_line":"#if defined(ENABLE_DCO) \u0026\u0026 (defined(TARGET_LINUX) || defined(TARGET_FREEBSD))"},{"line_number":1233,"context_line":"    int cmd_del_peer \u003d OVPN_CMD_DEL_PEER;"},{"line_number":1234,"context_line":"    int cmd_swap_keys \u003d OVPN_CMD_SWAP_KEYS;"},{"line_number":1235,"context_line":""},{"line_number":1236,"context_line":"    dco_context_t *dco \u003d \u0026c-\u003ec1.tuntap-\u003edco;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"7b654a13_31b82c62","line":1233,"updated":"2024-06-26 16:58:21.000000000","message":"Why is this indirection required?","commit_id":"8cbf4d63502bbe5fb26e8cf9c7694b6f2e07a228"},{"author":{"_account_id":1000034,"name":"its_Giaan","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"change_message_id":"bb4562982bca06530779c44c9365247229bc375b","unresolved":true,"context_lines":[{"line_number":1230,"context_line":"process_incoming_dco(struct context *c)"},{"line_number":1231,"context_line":"{"},{"line_number":1232,"context_line":"#if defined(ENABLE_DCO) \u0026\u0026 (defined(TARGET_LINUX) || defined(TARGET_FREEBSD))"},{"line_number":1233,"context_line":"    int cmd_del_peer \u003d OVPN_CMD_DEL_PEER;"},{"line_number":1234,"context_line":"    int cmd_swap_keys \u003d OVPN_CMD_SWAP_KEYS;"},{"line_number":1235,"context_line":""},{"line_number":1236,"context_line":"    dco_context_t *dco \u003d \u0026c-\u003ec1.tuntap-\u003edco;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"2f02c26a_4ad35d7f","line":1233,"in_reply_to":"7b654a13_31b82c62","updated":"2024-06-27 08:44:04.000000000","message":"Because with the next commit that will introduce support for dco_v3, the commands will be completely different (the names will be shared between dco_v3 linux and bsd while dco_v2 will use the *current* commands with the addition of the acronym v2 (i.e. OVPN_V2_CMD_GET_PEER) and since the commands that will be used will change based on the platform and the version of dco loaded, that differentiation must be made via #if defined","commit_id":"8cbf4d63502bbe5fb26e8cf9c7694b6f2e07a228"}]}