)]}'
{"id":"openvpn~662","triplet_id":"openvpn~master~I6662605b60d4859949970cfe256c55cbcbd4a672","project":"openvpn","branch":"master","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2024-07-29 11:35:05.000000000","reason":"Change was abandoned"},"1000034":{"account":{"_account_id":1000034,"name":"its_Giaan","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"last_update":"2024-07-29 11:35:05.000000000","reason":"Change was abandoned"},"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2024-07-29 11:35:05.000000000","reason":"Change was abandoned"}},"hashtags":[],"change_id":"I6662605b60d4859949970cfe256c55cbcbd4a672","subject":"Lay the foundation to support both old and new versions of DCO","status":"ABANDONED","created":"2024-06-06 11:33:32.000000000","updated":"2024-07-29 11:35:05.000000000","total_comment_count":8,"unresolved_comment_count":1,"has_review_started":true,"meta_rev_id":"b7f05a9ba34c1b10b83e09bc6d107b96e304cebe","_number":662,"virtual_id_number":662,"owner":{"_account_id":1000034,"name":"its_Giaan","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"actions":{},"labels":{"Code-Review":{"disliked":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"all":[{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"value":-1,"date":"2024-06-26 16:58:21.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"value":-1,"default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-06-06 11:33:35.000000000","updated_by":{"_account_id":1000034,"name":"its_Giaan","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2024-06-06 11:33:35.000000000","updated_by":{"_account_id":1000034,"name":"its_Giaan","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"reviewer":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"state":"REVIEWER"},{"updated":"2024-06-06 11:33:35.000000000","updated_by":{"_account_id":1000034,"name":"its_Giaan","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2024-07-29 11:33:54.000000000","updated_by":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"state":"CC"}],"messages":[{"id":"8178ff31a872b48dd72239708bbed44dd07829f5","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000034,"name":"its_Giaan","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"date":"2024-06-06 11:33:32.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"79e7cc3c9a096e4388d7dcb86edd498285625601","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2024-06-26 16:58:21.000000000","message":"Patch Set 1: Code-Review-1\n\n(4 comments)","accounts_in_message":[],"_revision_number":1},{"id":"bb4562982bca06530779c44c9365247229bc375b","author":{"_account_id":1000034,"name":"its_Giaan","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"date":"2024-06-27 08:44:04.000000000","message":"Patch Set 1:\n\n(3 comments)","accounts_in_message":[],"_revision_number":1},{"id":"a17e07ee313b4a7a3db16690b0735dca701f8f7b","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2024-07-29 11:33:54.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"b7f05a9ba34c1b10b83e09bc6d107b96e304cebe","tag":"autogenerated:gerrit:abandon","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2024-07-29 11:35:05.000000000","message":"Abandoned\n\nit was decided that DCO_v2 and DCO_v3 (aka \"in upstream kernel\" or \"ovpn\") will not be supported at the same time, so this infrastructure is no longer needed or desirable","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"8cbf4d63502bbe5fb26e8cf9c7694b6f2e07a228","revisions":{"8cbf4d63502bbe5fb26e8cf9c7694b6f2e07a228":{"kind":"REWORK","_number":1,"created":"2024-06-06 11:33:32.000000000","uploader":{"_account_id":1000034,"name":"its_Giaan","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"ref":"refs/changes/62/662/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/62/662/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/62/662/1 \u0026\u0026 git checkout -b change-662 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/62/662/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/62/662/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/62/662/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/62/662/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/62/662/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"bf887c95e46c6892ac1f68be5559525f8d975530","subject":"Windows: enforce \u0027block-local\u0027 with WFP filters"}],"author":{"name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","date":"2024-05-28 09:20:48.000000000","tz":120},"committer":{"name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","date":"2024-06-06 09:10:30.000000000","tz":120},"subject":"Lay the foundation to support both old and new versions of DCO","message":"Lay the foundation to support both old and new versions of DCO\n\nAdded a new abstraction layer based on the `struct dco_ops`,\na structure of function pointers that ensures the appropriate\nAPIs at runtime are used for DCO communication between kernel\nand user space, selection is based on the available module\u0027s\nfamily name.\n\nThe old version, referred to as \"ovpn_dco_v2\", and its related\ncommands and functions, will be distinguished with the \"v2\" suffix.\n\nChange-Id: I6662605b60d4859949970cfe256c55cbcbd4a672\nSigned-off-by: Gianmarco De Gregori \u003cgianmarco@mandelbit.com\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}