)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000009,"name":"selvanair","display_name":"Selva Nair","email":"selva.nair@gmail.com","username":"selvanair"},"change_message_id":"f463cad20de4f00ced5c8063718492d89e21cc2b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"3e908a07_685e80c3","updated":"2024-07-09 13:22:02.000000000","message":"Thanks for the review.","commit_id":"b90cf4cc06752b85e3b03db4c0d70824809dc205"},{"author":{"_account_id":1000009,"name":"selvanair","display_name":"Selva Nair","email":"selva.nair@gmail.com","username":"selvanair"},"change_message_id":"c5260ce625f0fe3542c0a4bd0da48fe40a3c72e2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"c609cd86_c7ae5cb2","updated":"2024-07-10 20:08:47.000000000","message":"A bit confused about the gerrit workflow. The status says it\u0027s my turn now, but it seems one needs some special privilege to click \"SUBMIT\". Am I supposed to do a \"git-send-email\" the patch to the list at this point?","commit_id":"a6dabe5ba38405ecb3039b25697e043f771e4022"},{"author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"319e11457fee0a85029db9934c61bb6f7ae7e19f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"d36addf8_074659ee","updated":"2024-07-10 20:20:34.000000000","message":"You *can* send it to the mailing list, if you want (using the `dev-tools/gerrit-send-mail.py` script to get the threading halfway right, and add the acked-by: headers according to the +2 in gerrit).\n\nUsually Frank or I do this on behalf of the original submitter (because it\u0027s easy to do when the +2 comes by).  I\u0027m travelling so things take a bit longer.","commit_id":"a6dabe5ba38405ecb3039b25697e043f771e4022"}],"doc/man-sections/client-options.rst":[{"author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"36850b4a3e4d616d38d9fa9e9f105147350429b6","unresolved":true,"context_lines":[{"line_number":549,"context_line":"  :code:`0` or :code:`1`. The optional ``format`` flag indicates whether"},{"line_number":550,"context_line":"  the password and response should be combined using the SCRV1 protocol"},{"line_number":551,"context_line":"  (``format`` \u003d :code: `0`) or simply concatenated (``format`` \u003d :code: `1`)."},{"line_number":552,"context_line":"  :code: `0` is the default."},{"line_number":553,"context_line":""},{"line_number":554,"context_line":"  See management-notes.txt in the OpenVPN distribution for a description of"},{"line_number":555,"context_line":"  the OpenVPN challenge/response protocol."}],"source_content_type":"text/x-rst","patch_set":1,"id":"87a2fe54_bda4864d","line":552,"updated":"2024-06-18 11:56:44.000000000","message":"I am not a big fan of this option but I will not block it. But I rather would see \"scrv1\" (as default) and \"concat\" as option for the configuration option rather than 0/1. The internal code can still use the flag but I feel 0/1 as option is rather clumsy.","commit_id":"765ec88e549b142f64ea179f7d06e2d82b121123"},{"author":{"_account_id":1000009,"name":"selvanair","display_name":"Selva Nair","email":"selva.nair@gmail.com","username":"selvanair"},"change_message_id":"b8acbcb75aff9963c27289dcbd327faf8890e4d4","unresolved":false,"context_lines":[{"line_number":549,"context_line":"  :code:`0` or :code:`1`. The optional ``format`` flag indicates whether"},{"line_number":550,"context_line":"  the password and response should be combined using the SCRV1 protocol"},{"line_number":551,"context_line":"  (``format`` \u003d :code: `0`) or simply concatenated (``format`` \u003d :code: `1`)."},{"line_number":552,"context_line":"  :code: `0` is the default."},{"line_number":553,"context_line":""},{"line_number":554,"context_line":"  See management-notes.txt in the OpenVPN distribution for a description of"},{"line_number":555,"context_line":"  the OpenVPN challenge/response protocol."}],"source_content_type":"text/x-rst","patch_set":1,"id":"46ddef1b_f7400222","line":552,"in_reply_to":"87a2fe54_bda4864d","updated":"2024-06-19 01:56:33.000000000","message":"I share that sentiment, but some GUI users want something like this. It feels better to have this defined in the core than invent it in the GUI.\n\nChanged 0/1 to scrv1/concat.","commit_id":"765ec88e549b142f64ea179f7d06e2d82b121123"}],"doc/management-notes.txt":[{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"42e41c11f9bd78c27cdf2df33a167d19083ce785","unresolved":true,"context_lines":[{"line_number":1330,"context_line":""},{"line_number":1331,"context_line":"  flags: a bit field describing the ECHO and FORMAT flags"},{"line_number":1332,"context_line":"         ECHO \u003d bit 1 \u003d 1 if response should be echoed, 0 to not echo"},{"line_number":1333,"context_line":"         FORMAT \u003d bit 2 \u003d 1 if response should be concatenated with password"},{"line_number":1334,"context_line":"         as plain text, 0 if response and password should be encoded"},{"line_number":1335,"context_line":"         as described below"},{"line_number":1336,"context_line":"  TEXT: challenge text that should be shown to the user to"}],"source_content_type":"text/plain","patch_set":2,"id":"bf183267_3d352506","line":1333,"updated":"2024-07-09 12:57:25.000000000","message":"Honestly it is not clear to me from this documentation on how these flags combine. Concatenate them? Binary addition? Please include an example.","commit_id":"b90cf4cc06752b85e3b03db4c0d70824809dc205"},{"author":{"_account_id":1000009,"name":"selvanair","display_name":"Selva Nair","email":"selva.nair@gmail.com","username":"selvanair"},"change_message_id":"6a978ec4a9cd386794f7cf0fa86e33ac83d57cdf","unresolved":false,"context_lines":[{"line_number":1330,"context_line":""},{"line_number":1331,"context_line":"  flags: a bit field describing the ECHO and FORMAT flags"},{"line_number":1332,"context_line":"         ECHO \u003d bit 1 \u003d 1 if response should be echoed, 0 to not echo"},{"line_number":1333,"context_line":"         FORMAT \u003d bit 2 \u003d 1 if response should be concatenated with password"},{"line_number":1334,"context_line":"         as plain text, 0 if response and password should be encoded"},{"line_number":1335,"context_line":"         as described below"},{"line_number":1336,"context_line":"  TEXT: challenge text that should be shown to the user to"}],"source_content_type":"text/plain","patch_set":2,"id":"3e068024_aebfdec6","line":1333,"in_reply_to":"16c4a9ba_0d8e0e6a","updated":"2024-07-09 21:40:21.000000000","message":"Done","commit_id":"b90cf4cc06752b85e3b03db4c0d70824809dc205"},{"author":{"_account_id":1000009,"name":"selvanair","display_name":"Selva Nair","email":"selva.nair@gmail.com","username":"selvanair"},"change_message_id":"f463cad20de4f00ced5c8063718492d89e21cc2b","unresolved":true,"context_lines":[{"line_number":1330,"context_line":""},{"line_number":1331,"context_line":"  flags: a bit field describing the ECHO and FORMAT flags"},{"line_number":1332,"context_line":"         ECHO \u003d bit 1 \u003d 1 if response should be echoed, 0 to not echo"},{"line_number":1333,"context_line":"         FORMAT \u003d bit 2 \u003d 1 if response should be concatenated with password"},{"line_number":1334,"context_line":"         as plain text, 0 if response and password should be encoded"},{"line_number":1335,"context_line":"         as described below"},{"line_number":1336,"context_line":"  TEXT: challenge text that should be shown to the user to"}],"source_content_type":"text/plain","patch_set":2,"id":"16c4a9ba_0d8e0e6a","line":1333,"in_reply_to":"bf183267_3d352506","updated":"2024-07-09 13:22:02.000000000","message":"v2 is coming.","commit_id":"b90cf4cc06752b85e3b03db4c0d70824809dc205"}],"src/openvpn/misc.h":[{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"42e41c11f9bd78c27cdf2df33a167d19083ce785","unresolved":true,"context_lines":[{"line_number":118,"context_line":"#define GET_USER_PASS_STATIC_CHALLENGE_ECHO  (1\u003c\u003c9) /* SCRV1 protocol -- echo response */"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"#define GET_USER_PASS_INLINE_CREDS (1\u003c\u003c10)  /* indicates that auth_file is actually inline creds */"},{"line_number":121,"context_line":"#define GET_USER_PASS_STATIC_CHALLENGE_CONCAT (1\u003c\u003c11)  /* indicates password and response should be concatenated */"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"/**"},{"line_number":124,"context_line":" * Retrieves the user credentials from various sources depending on the flags."}],"source_content_type":"text/x-csrc","patch_set":2,"id":"49006d0b_8f0cea84","line":121,"updated":"2024-07-09 12:57:25.000000000","message":"Please add a test to the UT suite test_get_user_pass_static_challenge","commit_id":"b90cf4cc06752b85e3b03db4c0d70824809dc205"},{"author":{"_account_id":1000009,"name":"selvanair","display_name":"Selva Nair","email":"selva.nair@gmail.com","username":"selvanair"},"change_message_id":"6a978ec4a9cd386794f7cf0fa86e33ac83d57cdf","unresolved":false,"context_lines":[{"line_number":118,"context_line":"#define GET_USER_PASS_STATIC_CHALLENGE_ECHO  (1\u003c\u003c9) /* SCRV1 protocol -- echo response */"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"#define GET_USER_PASS_INLINE_CREDS (1\u003c\u003c10)  /* indicates that auth_file is actually inline creds */"},{"line_number":121,"context_line":"#define GET_USER_PASS_STATIC_CHALLENGE_CONCAT (1\u003c\u003c11)  /* indicates password and response should be concatenated */"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"/**"},{"line_number":124,"context_line":" * Retrieves the user credentials from various sources depending on the flags."}],"source_content_type":"text/x-csrc","patch_set":2,"id":"c1296d70_31640ce7","line":121,"in_reply_to":"25e712cb_3f39cbc9","updated":"2024-07-09 21:40:21.000000000","message":"Done","commit_id":"b90cf4cc06752b85e3b03db4c0d70824809dc205"},{"author":{"_account_id":1000009,"name":"selvanair","display_name":"Selva Nair","email":"selva.nair@gmail.com","username":"selvanair"},"change_message_id":"f463cad20de4f00ced5c8063718492d89e21cc2b","unresolved":true,"context_lines":[{"line_number":118,"context_line":"#define GET_USER_PASS_STATIC_CHALLENGE_ECHO  (1\u003c\u003c9) /* SCRV1 protocol -- echo response */"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"#define GET_USER_PASS_INLINE_CREDS (1\u003c\u003c10)  /* indicates that auth_file is actually inline creds */"},{"line_number":121,"context_line":"#define GET_USER_PASS_STATIC_CHALLENGE_CONCAT (1\u003c\u003c11)  /* indicates password and response should be concatenated */"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"/**"},{"line_number":124,"context_line":" * Retrieves the user credentials from various sources depending on the flags."}],"source_content_type":"text/x-csrc","patch_set":2,"id":"25e712cb_3f39cbc9","line":121,"in_reply_to":"49006d0b_8f0cea84","updated":"2024-07-09 13:22:02.000000000","message":"Test was submitted along with: see https://gerrit.openvpn.net/c/openvpn/+/666","commit_id":"b90cf4cc06752b85e3b03db4c0d70824809dc205"}]}