)]}'
{"id":"openvpn~665","triplet_id":"openvpn~master~I59a90446bfe73d8856516025a58a6f62cc98ab0d","project":"openvpn","branch":"master","full_branch":"refs/heads/master","topic":"static-challenge","attention_set":{},"removed_from_attention_set":{"1000009":{"account":{"_account_id":1000009,"name":"Selva Nair","display_name":"Selva Nair","email":"selva.nair@gmail.com","username":"selvanair"},"last_update":"2024-09-09 06:56:26.000000000","reason":"Change was submitted"},"1000003":{"account":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2024-09-09 06:56:26.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2024-07-10 11:35:49.000000000","reason":"removed on reply"}},"hashtags":["mailsubmitted"],"change_id":"I59a90446bfe73d8856516025a58a6f62cc98ab0d","subject":"Static-challenge concatenation option","status":"MERGED","created":"2024-06-15 02:24:48.000000000","updated":"2024-09-09 06:56:26.000000000","submitted":"2024-09-09 06:56:26.000000000","submitter":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":11,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"665-static-challenge","meta_rev_id":"193504180e05c2d9a10354a0766edda07506cb48","_number":665,"virtual_id_number":665,"owner":{"_account_id":1000009,"name":"Selva Nair","display_name":"Selva Nair","email":"selva.nair@gmail.com","username":"selvanair"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"value":0,"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-06-15 02:24:49.000000000","updated_by":{"_account_id":1000009,"name":"Selva Nair","display_name":"Selva Nair","email":"selva.nair@gmail.com","username":"selvanair"},"real_updated_by":{"_account_id":1000009,"name":"Selva Nair","display_name":"Selva Nair","email":"selva.nair@gmail.com","username":"selvanair"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2024-06-15 02:24:49.000000000","updated_by":{"_account_id":1000009,"name":"Selva Nair","display_name":"Selva Nair","email":"selva.nair@gmail.com","username":"selvanair"},"real_updated_by":{"_account_id":1000009,"name":"Selva Nair","display_name":"Selva Nair","email":"selva.nair@gmail.com","username":"selvanair"},"reviewer":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"state":"REVIEWER"},{"updated":"2024-06-15 02:24:49.000000000","updated_by":{"_account_id":1000009,"name":"Selva Nair","display_name":"Selva Nair","email":"selva.nair@gmail.com","username":"selvanair"},"real_updated_by":{"_account_id":1000009,"name":"Selva Nair","display_name":"Selva Nair","email":"selva.nair@gmail.com","username":"selvanair"},"reviewer":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2024-07-10 20:20:34.000000000","updated_by":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"real_updated_by":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"state":"CC"}],"messages":[{"id":"c8bf0c4d613d493604f5917dc8871aef2b829295","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000009,"name":"Selva Nair","display_name":"Selva Nair","email":"selva.nair@gmail.com","username":"selvanair"},"date":"2024-06-15 02:24:48.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"36850b4a3e4d616d38d9fa9e9f105147350429b6","author":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2024-06-18 11:56:44.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"f94afd0f1d01d2d70fca6c2fc0ad996c82573ee1","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000009,"name":"Selva Nair","display_name":"Selva Nair","email":"selva.nair@gmail.com","username":"selvanair"},"date":"2024-06-18 23:21:18.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"b8acbcb75aff9963c27289dcbd327faf8890e4d4","author":{"_account_id":1000009,"name":"Selva Nair","display_name":"Selva Nair","email":"selva.nair@gmail.com","username":"selvanair"},"date":"2024-06-19 01:56:33.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"42e41c11f9bd78c27cdf2df33a167d19083ce785","author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2024-07-09 12:57:25.000000000","message":"Patch Set 2: Code-Review-1\n\n(2 comments)","accounts_in_message":[],"_revision_number":2},{"id":"f463cad20de4f00ced5c8063718492d89e21cc2b","author":{"_account_id":1000009,"name":"Selva Nair","display_name":"Selva Nair","email":"selva.nair@gmail.com","username":"selvanair"},"date":"2024-07-09 13:22:02.000000000","message":"Patch Set 2:\n\n(3 comments)","accounts_in_message":[],"_revision_number":2},{"id":"f98d0cf0c812e7f81b49f433d60e7900a8d09f4a","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000009,"name":"Selva Nair","display_name":"Selva Nair","email":"selva.nair@gmail.com","username":"selvanair"},"date":"2024-07-09 21:39:30.000000000","message":"Uploaded patch set 3.\n\nOutdated Votes:\n* Code-Review-1 (copy condition: \"changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR is:MIN\")\n","accounts_in_message":[],"_revision_number":3},{"id":"6a978ec4a9cd386794f7cf0fa86e33ac83d57cdf","author":{"_account_id":1000009,"name":"Selva Nair","display_name":"Selva Nair","email":"selva.nair@gmail.com","username":"selvanair"},"date":"2024-07-09 21:40:21.000000000","message":"Patch Set 3:\n\n(2 comments)","accounts_in_message":[],"_revision_number":3},{"id":"df3a4650bd53a72e79af654b0ff608dcaa41fa0e","author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2024-07-10 11:35:49.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"c5260ce625f0fe3542c0a4bd0da48fe40a3c72e2","author":{"_account_id":1000009,"name":"Selva Nair","display_name":"Selva Nair","email":"selva.nair@gmail.com","username":"selvanair"},"date":"2024-07-10 20:08:47.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"319e11457fee0a85029db9934c61bb6f7ae7e19f","author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2024-07-10 20:20:34.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"541c398aafef3a4978de25dc4d3751d0ce580b5e","tag":"autogenerated:gerrit:setHashtag","author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2024-07-19 13:14:32.000000000","message":"Hashtag added: mailsubmitted","accounts_in_message":[],"_revision_number":3},{"id":"193504180e05c2d9a10354a0766edda07506cb48","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2024-09-09 06:56:26.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"6f6a0f362f845f042a965f797b731f8931310372","revisions":{"765ec88e549b142f64ea179f7d06e2d82b121123":{"kind":"REWORK","_number":1,"created":"2024-06-15 02:24:48.000000000","uploader":{"_account_id":1000009,"name":"Selva Nair","display_name":"Selva Nair","email":"selva.nair@gmail.com","username":"selvanair"},"ref":"refs/changes/65/665/1","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/65/665/1","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/65/665/1 \u0026\u0026 git checkout -b change-665 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/65/665/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/65/665/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/65/665/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/65/665/1","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/65/665/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"13ee7f902f18e27b981f8e440facd2e6515c6c83","subject":"Implement Windows CA template match for Crypto-API selector"}],"author":{"name":"Selva Nair","email":"selva.nair@gmail.com","date":"2024-06-09 23:25:49.000000000","tz":-240},"committer":{"name":"Selva Nair","email":"selva.nair@gmail.com","date":"2024-06-10 19:43:08.000000000","tz":-240},"subject":"Static-challenge concatentation option","message":"Static-challenge concatentation option\n\nExtend \"--static-challenge\" option to take a third\nargument (\u003d0 or 1) to specify that the password and\nresponse should be concatenated instead of using the\nSCRV1 protocol. If unspecified, it defaults to \"0\"\nmeaning that the SCRV1 protocol should be used.\n\nChange-Id: I59a90446bfe73d8856516025a58a6f62cc98ab0d\n"},"branch":"refs/heads/master"},"b90cf4cc06752b85e3b03db4c0d70824809dc205":{"kind":"REWORK","_number":2,"created":"2024-06-18 23:21:18.000000000","uploader":{"_account_id":1000009,"name":"Selva Nair","display_name":"Selva Nair","email":"selva.nair@gmail.com","username":"selvanair"},"ref":"refs/changes/65/665/2","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/65/665/2","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/65/665/2 \u0026\u0026 git checkout -b change-665 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/65/665/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/65/665/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/65/665/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/65/665/2","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/65/665/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"13ee7f902f18e27b981f8e440facd2e6515c6c83","subject":"Implement Windows CA template match for Crypto-API selector"}],"author":{"name":"Selva Nair","email":"selva.nair@gmail.com","date":"2024-06-09 23:25:49.000000000","tz":-240},"committer":{"name":"Selva Nair","email":"selva.nair@gmail.com","date":"2024-06-18 16:06:44.000000000","tz":-240},"subject":"Static-challenge concatenation option","message":"Static-challenge concatenation option\n\nExtend \"--static-challenge\" option to take a third\nargument (\u003d scrv1 or concat) to specify that the password and\nresponse should be concatenated instead of using the\nSCRV1 protocol. If unspecified, it defaults to \"scrv1\"\nmeaning that the SCRV1 protocol should be used.\n\nv2: use scrv1|concat instead of 0|1 as option argument\n    fix typos\n\nChange-Id: I59a90446bfe73d8856516025a58a6f62cc98ab0d\n"},"branch":"refs/heads/master"},"a6dabe5ba38405ecb3039b25697e043f771e4022":{"kind":"REWORK","_number":3,"created":"2024-07-09 21:39:30.000000000","uploader":{"_account_id":1000009,"name":"Selva Nair","display_name":"Selva Nair","email":"selva.nair@gmail.com","username":"selvanair"},"ref":"refs/changes/65/665/3","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/65/665/3","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/65/665/3 \u0026\u0026 git checkout -b change-665 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/65/665/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/65/665/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/65/665/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/65/665/3","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/65/665/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"f8f477139804b06183b515a529c982f524547d18","subject":"t_server_null: multiple improvements and fixes"}],"author":{"name":"Selva Nair","email":"selva.nair@gmail.com","date":"2024-06-09 23:25:49.000000000","tz":-240},"committer":{"name":"Selva Nair","email":"selva.nair@gmail.com","date":"2024-07-09 21:32:14.000000000","tz":-240},"subject":"Static-challenge concatenation option","message":"Static-challenge concatenation option\n\nExtend \"--static-challenge\" option to take a third\nargument (\u003d scrv1 or concat) to specify that the password and\nresponse should be concatenated instead of using the\nSCRV1 protocol. If unspecified, it defaults to \"scrv1\"\nmeaning that the SCRV1 protocol should be used.\n\nv2: use scrv1|concat instead of 0|1 as option argument\n    fix typos\nv3: improve and correct documentation in management-notes.txt\n\nChange-Id: I59a90446bfe73d8856516025a58a6f62cc98ab0d\n"},"branch":"refs/heads/master"},"6f6a0f362f845f042a965f797b731f8931310372":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":4,"created":"2024-09-09 06:56:26.000000000","uploader":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/65/665/4","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/65/665/4","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/65/665/4 \u0026\u0026 git checkout -b change-665 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/65/665/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/65/665/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/65/665/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/65/665/4","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/65/665/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"67124dcf317460609860a2ea7cb7a55ceed4a4ce","subject":"Initialize before use struct user_pass in ui_reader()"}],"author":{"name":"Selva Nair","email":"selva.nair@gmail.com","date":"2024-07-19 13:14:07.000000000","tz":120},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2024-09-09 06:24:44.000000000","tz":120},"subject":"Static-challenge concatenation option","message":"Static-challenge concatenation option\n\nExtend \"--static-challenge\" option to take a third\nargument (\u003d scrv1 or concat) to specify that the password and\nresponse should be concatenated instead of using the\nSCRV1 protocol. If unspecified, it defaults to \"scrv1\"\nmeaning that the SCRV1 protocol should be used.\n\nv2: use scrv1|concat instead of 0|1 as option argument\n    fix typos\nv3: improve and correct documentation in management-notes.txt\n\nChange-Id: I59a90446bfe73d8856516025a58a6f62cc98ab0d\nSigned-off-by: Selva Nair \u003cselva.nair@gmail.com\u003e\nAcked-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\nMessage-Id: \u003c20240719131407.75746-1-frank@lichtenheld.com\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg28943.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[]}
