)]}'
{"id":"openvpn~667","triplet_id":"openvpn~master~I6e08920e4cf4762b9f14a7461a29fa77df15255c","project":"openvpn","branch":"master","full_branch":"refs/heads/master","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2024-06-20 15:21:04.000000000","reason":"Change was submitted"},"1000002":{"account":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"last_update":"2024-06-20 14:42:16.000000000","reason":"\u003cGERRIT_ACCOUNT_1000002\u003e replied on the change","reason_account":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}},"1000001":{"account":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2024-06-20 15:21:04.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I6e08920e4cf4762b9f14a7461a29fa77df15255c","subject":"configure: Add -Wstrict-prototypes and -Wold-style-definition","status":"MERGED","created":"2024-06-19 11:02:56.000000000","updated":"2024-06-20 15:21:04.000000000","submitted":"2024-06-20 15:21:04.000000000","submitter":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"667","meta_rev_id":"f2e28245e1ac9b186eb581cf88076a0272425876","_number":667,"virtual_id_number":667,"owner":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"reviewers":{"REVIEWER":[{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-06-19 11:02:57.000000000","updated_by":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"real_updated_by":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2024-06-19 11:02:57.000000000","updated_by":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"real_updated_by":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2024-06-19 11:05:33.000000000","updated_by":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"real_updated_by":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"state":"REVIEWER"}],"messages":[{"id":"8b73ae3cb5e5ae3e17c6ba2aa80b4a57793b9ded","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2024-06-19 11:02:56.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"78b725f5656ffc0adff11eba0495c03d1f5e7900","author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2024-06-19 11:05:33.000000000","message":"Patch Set 1: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"0bda8f76aec34ba38e3744d0cc0fce6edce223a2","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2024-06-19 14:22:24.000000000","message":"Uploaded patch set 2.\n\nOutdated Votes:\n* Code-Review+2 (copy condition: \"changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR is:MIN\")\n","accounts_in_message":[],"_revision_number":2},{"id":"8fb2e46efc83b73a1c48de5ac60e5bd547e22779","author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2024-06-19 14:28:16.000000000","message":"Patch Set 2: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"cf291454f68558ad171ee35ebc8b533fe2523d21","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2024-06-20 14:22:47.000000000","message":"Uploaded patch set 3.\n\nOutdated Votes:\n* Code-Review+2 (copy condition: \"changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR is:MIN\")\n","accounts_in_message":[],"_revision_number":3},{"id":"37b381a5ba5e6016b960bf90f77ee7e7a0777c7a","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2024-06-20 14:29:50.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"085c3aad0f04679b4766eab61f6f049d9a71c001","author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2024-06-20 14:42:16.000000000","message":"Patch Set 4: Code-Review+2","accounts_in_message":[],"_revision_number":4},{"id":"f2e28245e1ac9b186eb581cf88076a0272425876","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2024-06-20 15:21:04.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":5}],"current_revision_number":5,"current_revision":"56355924b4945ec808500b18c714c111387697f9","revisions":{"2229fba8750dc277884f4010b95e4499b90c9c0b":{"kind":"REWORK","_number":1,"created":"2024-06-19 11:02:56.000000000","uploader":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/67/667/1","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/67/667/1","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/67/667/1 \u0026\u0026 git checkout -b change-667 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/67/667/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/67/667/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/67/667/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/67/667/1","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/67/667/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"b3a68b85a729628ca8b97f9f0c2813f795289cfc","subject":"Implement server_poll_timeout for socks"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2024-06-19 11:00:57.000000000","tz":120},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2024-06-19 11:02:28.000000000","tz":120},"subject":"configure: Add -Wstrict-prototypes and -Wold-style-definition","message":"configure: Add -Wstrict-prototypes and -Wold-style-definition\n\nThese are not covered by -Wall (nor -Wextra) but we want\nto enforce them.\n\nChange-Id: I6e08920e4cf4762b9f14a7461a29fa77df15255c\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"0a4c73d2b51cd0d81cc5cbe649a0bbaa4b72f140":{"kind":"REWORK","_number":2,"created":"2024-06-19 14:22:24.000000000","uploader":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/67/667/2","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/67/667/2","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/67/667/2 \u0026\u0026 git checkout -b change-667 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/67/667/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/67/667/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/67/667/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/67/667/2","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/67/667/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"b3a68b85a729628ca8b97f9f0c2813f795289cfc","subject":"Implement server_poll_timeout for socks"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2024-06-19 11:00:57.000000000","tz":120},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2024-06-19 14:21:58.000000000","tz":120},"subject":"configure: Add -Wstrict-prototypes and -Wold-style-definition","message":"configure: Add -Wstrict-prototypes and -Wold-style-definition\n\nThese are not covered by -Wall (nor -Wextra) but we want\nto enforce them.\n\nChange-Id: I6e08920e4cf4762b9f14a7461a29fa77df15255c\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"bf2d2cbb5fe0a236a216ffdc02e8d5cfcd36c943":{"kind":"REWORK","_number":3,"created":"2024-06-20 14:22:47.000000000","uploader":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/67/667/3","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/67/667/3","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/67/667/3 \u0026\u0026 git checkout -b change-667 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/67/667/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/67/667/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/67/667/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/67/667/3","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/67/667/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"c9f29e35cd475f18c34aa96eb5fad452210404f9","subject":"t_server_null.sh: Fix failure case"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2024-06-19 11:00:57.000000000","tz":120},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2024-06-20 14:18:48.000000000","tz":120},"subject":"configure: Add -Wstrict-prototypes and -Wold-style-definition","message":"configure: Add -Wstrict-prototypes and -Wold-style-definition\n\nThese are not covered by -Wall (nor -Wextra) but we want\nto enforce them.\n\nChange-Id: I6e08920e4cf4762b9f14a7461a29fa77df15255c\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"1685f307b3d83e15de1e9e44eca4603c0d0e7e67":{"kind":"REWORK","_number":4,"created":"2024-06-20 14:29:50.000000000","uploader":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/67/667/4","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/67/667/4","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/67/667/4 \u0026\u0026 git checkout -b change-667 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/67/667/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/67/667/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/67/667/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/67/667/4","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/67/667/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"c9f29e35cd475f18c34aa96eb5fad452210404f9","subject":"t_server_null.sh: Fix failure case"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2024-06-19 11:00:57.000000000","tz":120},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2024-06-20 14:29:43.000000000","tz":120},"subject":"configure: Add -Wstrict-prototypes and -Wold-style-definition","message":"configure: Add -Wstrict-prototypes and -Wold-style-definition\n\nThese are not covered by -Wall (nor -Wextra) but we want\nto enforce them.\n\nChange-Id: I6e08920e4cf4762b9f14a7461a29fa77df15255c\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"56355924b4945ec808500b18c714c111387697f9":{"kind":"NO_CODE_CHANGE","_number":5,"created":"2024-06-20 15:21:04.000000000","uploader":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/67/667/5","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/67/667/5","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/67/667/5 \u0026\u0026 git checkout -b change-667 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/67/667/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/67/667/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/67/667/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/67/667/5","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/67/667/5 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"c9f29e35cd475f18c34aa96eb5fad452210404f9","subject":"t_server_null.sh: Fix failure case"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2024-06-20 14:42:30.000000000","tz":120},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2024-06-20 15:01:31.000000000","tz":120},"subject":"configure: Add -Wstrict-prototypes and -Wold-style-definition","message":"configure: Add -Wstrict-prototypes and -Wold-style-definition\n\nThese are not covered by -Wall (nor -Wextra) but we want\nto enforce them.\n\nChange-Id: I6e08920e4cf4762b9f14a7461a29fa77df15255c\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\nAcked-by: Gert Doering \u003cgert@greenie.muc.de\u003e\nMessage-Id: \u003c20240620144230.19586-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg28823.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[]}
