)]}'
{"id":"openvpn~668","triplet_id":"openvpn~master~I35f7cf84e035bc793d6f0f59e46edf1a2efe0391","project":"openvpn","branch":"master","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2024-06-20 13:34:21.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2024-06-20 13:34:21.000000000","reason":"Change was submitted"},"1000038":{"account":{"_account_id":1000038,"name":"mattock","display_name":"Samuli Seppänen","email":"sasepp@proton.me","username":"mattock","status":"Community member"},"last_update":"2024-06-20 06:56:27.000000000","reason":"\u003cGERRIT_ACCOUNT_1000038\u003e replied on the change","reason_account":{"_account_id":1000038,"name":"mattock","display_name":"Samuli Seppänen","email":"sasepp@proton.me","username":"mattock","status":"Community member"}}},"hashtags":[],"change_id":"I35f7cf84e035bc793d6f0f59e46edf1a2efe0391","subject":"t_server_null.sh: Fix failure case","status":"MERGED","created":"2024-06-19 16:28:03.000000000","updated":"2024-06-20 13:34:21.000000000","submitted":"2024-06-20 13:34:21.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"668","meta_rev_id":"b6c4c38c5c501c97c023362bcdb020fc27176797","_number":668,"virtual_id_number":668,"owner":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"value":0,"_account_id":1000038,"name":"mattock","display_name":"Samuli Seppänen","email":"sasepp@proton.me","username":"mattock","status":"Community member"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"default_value":0}},"removable_reviewers":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"reviewers":{"REVIEWER":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"_account_id":1000038,"name":"mattock","display_name":"Samuli Seppänen","email":"sasepp@proton.me","username":"mattock","status":"Community member"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-06-19 16:28:03.000000000","updated_by":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2024-06-19 16:28:03.000000000","updated_by":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2024-06-19 16:28:36.000000000","updated_by":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000038,"name":"mattock","display_name":"Samuli Seppänen","email":"sasepp@proton.me","username":"mattock","status":"Community member"},"state":"REVIEWER"}],"messages":[{"id":"9bcdb79d8e405cac263e4cb21fd06c14c8109fc7","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2024-06-19 16:28:03.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"28e9afbc22c97ea10928eec029fec6212e845c78","author":{"_account_id":1000038,"name":"mattock","display_name":"Samuli Seppänen","email":"sasepp@proton.me","username":"mattock","status":"Community member"},"date":"2024-06-20 06:56:27.000000000","message":"Patch Set 1: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"b6c4c38c5c501c97c023362bcdb020fc27176797","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2024-06-20 13:34:21.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"c9f29e35cd475f18c34aa96eb5fad452210404f9","revisions":{"42540171e4bf07f487ec7c23cb2bd6cb62d2ba77":{"kind":"REWORK","_number":1,"created":"2024-06-19 16:28:03.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/68/668/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/68/668/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/68/668/1 \u0026\u0026 git checkout -b change-668 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/68/668/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/68/668/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/68/668/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/68/668/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/68/668/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"414f428fa29694090ec4c46b10a8aba419c85659","subject":"Properly handle null bytes and invalid characters in control messages"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2024-06-19 16:26:09.000000000","tz":120},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2024-06-19 16:27:49.000000000","tz":120},"subject":"t_server_null.sh: Fix failure case","message":"t_server_null.sh: Fix failure case\n\nThe changes for POSIX shell compatibility and parallel\nmake compatibility broke actually failing the test\nwhen a subtest fails.\n\nChange-Id: I35f7cf84e035bc793d6f0f59e46edf1a2efe0391\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"c9f29e35cd475f18c34aa96eb5fad452210404f9":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":2,"created":"2024-06-20 13:34:21.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/68/668/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/68/668/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/68/668/2 \u0026\u0026 git checkout -b change-668 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/68/668/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/68/668/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/68/668/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/68/668/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/68/668/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"babf312ee0486e50ff1f7db5b544afc72ff7c922","subject":"interactive.c: Improve access control for gui\u003c-\u003eservice pipe"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2024-06-20 10:37:48.000000000","tz":120},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2024-06-20 13:33:28.000000000","tz":120},"subject":"t_server_null.sh: Fix failure case","message":"t_server_null.sh: Fix failure case\n\nThe changes for POSIX shell compatibility and parallel\nmake compatibility broke actually failing the test\nwhen a subtest fails.\n\nChange-Id: I35f7cf84e035bc793d6f0f59e46edf1a2efe0391\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\nAcked-by: Samuli Seppänen \u003csamuli@openvpn.net\u003e\nMessage-Id: \u003c20240620103749.7923-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg28815.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}