)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"52ac548ef240f1a606f584eabfe30c7a216ab7da","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"4e4aba08_638d14e3","updated":"2024-06-26 09:25:01.000000000","message":"Still need to fix nbsd81 build. Otherwise looks good to me.","commit_id":"fc78ae50efdd08b058d51ee869813b6fd1ff9117"},{"author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"6d017ce98ea71f3bb18e2fd26fce9b9ca18a5622","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"0823075d_fd02c3eb","updated":"2024-07-03 14:30:03.000000000","message":"OK, so the NetBSD problem seems to be \"umask\"\n\n - when run from BB, the server processes are started (sudo openvpn...) just fine\n - the resulting PID file (and Log file) are 600\n```\n-rw-------  1 root      users       6 Jul  3 16:22 t_server_null_server-1194_udp.pid\n-rw-------  1 root      users       5 Jul  3 16:22 t_server_null_server-1195_tcp.pid\n-rw-------  1 root      users     227 Jul  3 16:24 t_server_null_server-1195_tcp.status\n-rw-------  1 root      users    1991 Jul  3 16:24 t_server_null_server-1195_tcp.log\n-rw-------  1 root      users     227 Jul  3 16:24 t_server_null_server-1194_udp.status\n-rw-------  1 root      users    1824 Jul  3 16:24 t_server_null_server-1194_udp.log\n```\n - some other element running as non-root cannot read the pid file, so assumes \"the server process must have been not started\", and neither proceeds with the client\n - since \"the server has not been started\" it\u0027s not killed either, and on the next run, the port is in use\n \nMy suggestion would be to add an `umask 022` to the script that starts the server processes (I do not feel like digging into \"why does BB set 077, when the system default is 022\", and it *will* bite someone else running from the CLI eventually)\n\nAlso, error handling, for \"there is a file and I can\u0027t read it\".","commit_id":"f0db611cf1a58dca1e605804f09fecea5b437739"},{"author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"1a1875dfd16848ca46a76980dbf713398b98fcc6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"80ecaaa5_f343ab4b","updated":"2024-07-03 14:13:57.000000000","message":"So this works on FreeBSD and OpenBSD (great), while on NetBSD it works *sometimes*, and then it fails to start servers again because the old servers are still running.\n\nWhen it does not work, the error message could use some improvement\n\n```\nmake  check-TESTS\n./t_server_null.sh: sudo /bin/kill -0 succeeded, good.\nOpenVPN test servers up: 0/       2\nOpenVPN test servers up: 0/       2\nOpenVPN test servers up: 0/       2\nOpenVPN test servers up: 0/       2\nOpenVPN test servers up: 0/       2\nOpenVPN test servers up: 0/       2\nAll clients have disconnected from all servers\nWaiting for servers to exit\ncat: ./t_server_null_server-1194_udp.pid: No such file or directory\nTerminated \n[1]   Terminated              (\"${@}\" 2\u003e\u00261; es... | tee -a \"${log_fi...\n```\n\n(like, showing a \"tail -f\" of the server logs? - which are root-owned and mode 0600, so not trivial.  Why are they 0600 anyway, is there an explicit umask call?)\n\nNot sure why the processes got stuck.  When running from the CLI the servers are properly terminated...  need to re-test from buildbot.","commit_id":"f0db611cf1a58dca1e605804f09fecea5b437739"},{"author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"16c232b26e0ea3268ca7935355995518b3a4f6c4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"532edc99_478d2d79","updated":"2024-07-03 14:16:12.000000000","message":"not `tail -f`, obviously, I was thinking about `tail -20` or so, in case the log ends up being huge","commit_id":"f0db611cf1a58dca1e605804f09fecea5b437739"}],"doc/t_server_null.rst":[{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"d4723143b373ac2a559357e7f1110c283f6bfee5","unresolved":true,"context_lines":[{"line_number":47,"context_line":"example to allow users in the *wheel* group to run commands without a password"},{"line_number":48,"context_line":"prompt::"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    permit persist keepenv :wheel"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"Technical implementation"},{"line_number":53,"context_line":"------------------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"2a63132b_5f3ac97d","line":50,"updated":"2024-06-25 13:15:18.000000000","message":"doesn\u0027t contain \"nopass\" ?","commit_id":"d771c5fe357417626c67887f274ff96a90776c68"},{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"52ac548ef240f1a606f584eabfe30c7a216ab7da","unresolved":false,"context_lines":[{"line_number":47,"context_line":"example to allow users in the *wheel* group to run commands without a password"},{"line_number":48,"context_line":"prompt::"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    permit persist keepenv :wheel"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"Technical implementation"},{"line_number":53,"context_line":"------------------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"0f4fbfc2_5a621e23","line":50,"in_reply_to":"2a63132b_5f3ac97d","updated":"2024-06-26 09:25:01.000000000","message":"Done","commit_id":"d771c5fe357417626c67887f274ff96a90776c68"}]}