)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"70bdb715ad5b61abf2d6bd5e50866f61d7d43009","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"e910b59d_7fc82249","updated":"2024-07-25 15:55:19.000000000","message":"I think this is a good change.  I had one comment about the code-in-header and making them inline, though... what do you think?","commit_id":"53d013864e68ef677736f4cd1cd404dc8fe01fe6"},{"author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"eeaa354e486e90d67d2151f389bb24c6f8ce6aad","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"6656dd2a_b0e1cb94","updated":"2024-07-26 10:40:14.000000000","message":"LGTM","commit_id":"4adbce62824ae6a776299823177951b2730d6774"}],"src/openvpn/console.h":[{"author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"70bdb715ad5b61abf2d6bd5e50866f61d7d43009","unresolved":true,"context_lines":[{"line_number":91,"context_line":" *"},{"line_number":92,"context_line":" * @return True if executing all the defined steps completed successfully"},{"line_number":93,"context_line":" */"},{"line_number":94,"context_line":"static bool"},{"line_number":95,"context_line":"query_user_exec(void)"},{"line_number":96,"context_line":"{"},{"line_number":97,"context_line":"    return query_user_exec_systemd();"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"a68c3cbb_5ae4e68e","line":94,"updated":"2024-07-25 15:55:19.000000000","message":"our normal convention seems to be \"if there is code in .h files, it\u0027s tagged as inline\".  I can see that this is not true for the existing query_user_exec() wrapper, but maybe we want to fix this as well here?","commit_id":"53d013864e68ef677736f4cd1cd404dc8fe01fe6"},{"author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"0a21b9a843a8355f12bae899caae9a8d1d99428d","unresolved":false,"context_lines":[{"line_number":91,"context_line":" *"},{"line_number":92,"context_line":" * @return True if executing all the defined steps completed successfully"},{"line_number":93,"context_line":" */"},{"line_number":94,"context_line":"static bool"},{"line_number":95,"context_line":"query_user_exec(void)"},{"line_number":96,"context_line":"{"},{"line_number":97,"context_line":"    return query_user_exec_systemd();"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"b0d2dbce_b9a19cd3","line":94,"in_reply_to":"a68c3cbb_5ae4e68e","updated":"2024-07-26 09:34:09.000000000","message":"Done","commit_id":"53d013864e68ef677736f4cd1cd404dc8fe01fe6"}]}
