)]}'
{"id":"openvpn~670","triplet_id":"openvpn~master~I379e1eb6dc57b9fe4bbdaefbd947a14326e7117a","project":"openvpn","branch":"master","full_branch":"refs/heads/master","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2024-07-26 11:57:32.000000000","reason":"Change was submitted"},"1000002":{"account":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"last_update":"2024-07-26 10:40:05.000000000","reason":"removed on reply"},"1000001":{"account":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2024-07-26 11:57:32.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I379e1eb6dc57b9fe4bbdaefbd947a14326e7117a","subject":"console_systemd: rename query_user_exec to query_user_systemd","status":"MERGED","created":"2024-06-20 16:21:22.000000000","updated":"2024-07-26 11:57:32.000000000","submitted":"2024-07-26 11:57:32.000000000","submitter":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":4,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"670","meta_rev_id":"4af52f39c1bf80ef0de993928a1113cfffedb44a","_number":670,"virtual_id_number":670,"owner":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"reviewers":{"REVIEWER":[{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-06-20 16:21:23.000000000","updated_by":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"real_updated_by":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2024-06-20 16:21:23.000000000","updated_by":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"real_updated_by":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2024-07-25 15:55:19.000000000","updated_by":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"real_updated_by":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"state":"REVIEWER"}],"messages":[{"id":"18bc58e0cf698dc006f74002aaef0c79c358f128","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2024-06-20 16:21:22.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"c472ab0172b8a21ef881f44d60ba4e66a754fb73","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2024-06-24 14:49:29.000000000","message":"Patch Set 2: Patch Set 1 was rebased","accounts_in_message":[],"_revision_number":2},{"id":"8b572a919260b423f1a890ae62a25bf14990ae02","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2024-07-05 09:28:02.000000000","message":"Patch Set 3: Patch Set 2 was rebased","accounts_in_message":[],"_revision_number":3},{"id":"70bdb715ad5b61abf2d6bd5e50866f61d7d43009","author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2024-07-25 15:55:19.000000000","message":"Patch Set 3: Code-Review+1\n\n(2 comments)","accounts_in_message":[],"_revision_number":3},{"id":"ba9c4eaa0ad89817869f160d038bbfb0f5a5b241","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2024-07-26 09:33:53.000000000","message":"Uploaded patch set 4.\n\nOutdated Votes:\n* Code-Review+1 (copy condition: \"changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR is:MIN\")\n","accounts_in_message":[],"_revision_number":4},{"id":"0a21b9a843a8355f12bae899caae9a8d1d99428d","author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2024-07-26 09:34:09.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"2bf77ca0c04cde13681f1aec6a13e4a96cce1dcc","author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2024-07-26 10:40:05.000000000","message":"Patch Set 4: Code-Review+2","accounts_in_message":[],"_revision_number":4},{"id":"eeaa354e486e90d67d2151f389bb24c6f8ce6aad","author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2024-07-26 10:40:14.000000000","message":"Patch Set 4:\n\n(1 comment)","accounts_in_message":[],"_revision_number":4},{"id":"4af52f39c1bf80ef0de993928a1113cfffedb44a","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2024-07-26 11:57:32.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":5}],"current_revision_number":5,"current_revision":"418463ad27c13f56adb5b02cfd62018b7d634ee8","revisions":{"1b37f5ae21c6845d693cb942072bb6163b452009":{"kind":"REWORK","_number":1,"created":"2024-06-20 16:21:22.000000000","uploader":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/70/670/1","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/70/670/1","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/70/670/1 \u0026\u0026 git checkout -b change-670 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/70/670/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/70/670/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/70/670/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/70/670/1","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/70/670/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"1685f307b3d83e15de1e9e44eca4603c0d0e7e67","subject":"configure: Add -Wstrict-prototypes and -Wold-style-definition"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2024-06-20 15:54:19.000000000","tz":120},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2024-06-20 15:54:19.000000000","tz":120},"subject":"console_systemd: rename query_user_exec to query_user_systemd","message":"console_systemd: rename query_user_exec to query_user_systemd\n\nThis allows us to override query_user_exec for unit\ntests more consistently without having to jump through\nweird hoops.\n\nFixes running test_pkcs11 with --enable-systemd.\n\nWhile here also fix documentation comments for\nquery_user_exec*.\n\nChange-Id: I379e1eb6dc57b9fe4bbdaefbd947a14326e7117a\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"440e89cbc5f12412f100d5a1c5e1cb543eacfcb3":{"kind":"NO_CHANGE","_number":2,"created":"2024-06-24 14:49:29.000000000","uploader":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/70/670/2","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/70/670/2","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/70/670/2 \u0026\u0026 git checkout -b change-670 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/70/670/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/70/670/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/70/670/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/70/670/2","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/70/670/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"56355924b4945ec808500b18c714c111387697f9","subject":"configure: Add -Wstrict-prototypes and -Wold-style-definition"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2024-06-20 15:54:19.000000000","tz":120},"committer":{"name":"flichtenheld","email":"frank@lichtenheld.com","date":"2024-06-24 14:49:29.000000000","tz":0},"subject":"console_systemd: rename query_user_exec to query_user_systemd","message":"console_systemd: rename query_user_exec to query_user_systemd\n\nThis allows us to override query_user_exec for unit\ntests more consistently without having to jump through\nweird hoops.\n\nFixes running test_pkcs11 with --enable-systemd.\n\nWhile here also fix documentation comments for\nquery_user_exec*.\n\nChange-Id: I379e1eb6dc57b9fe4bbdaefbd947a14326e7117a\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master","description":"Rebase"},"53d013864e68ef677736f4cd1cd404dc8fe01fe6":{"kind":"TRIVIAL_REBASE","_number":3,"created":"2024-07-05 09:28:02.000000000","uploader":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/70/670/3","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/70/670/3","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/70/670/3 \u0026\u0026 git checkout -b change-670 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/70/670/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/70/670/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/70/670/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/70/670/3","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/70/670/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"f8f477139804b06183b515a529c982f524547d18","subject":"t_server_null: multiple improvements and fixes"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2024-06-20 15:54:19.000000000","tz":120},"committer":{"name":"flichtenheld","email":"frank@lichtenheld.com","date":"2024-07-05 09:28:02.000000000","tz":0},"subject":"console_systemd: rename query_user_exec to query_user_systemd","message":"console_systemd: rename query_user_exec to query_user_systemd\n\nThis allows us to override query_user_exec for unit\ntests more consistently without having to jump through\nweird hoops.\n\nFixes running test_pkcs11 with --enable-systemd.\n\nWhile here also fix documentation comments for\nquery_user_exec*.\n\nChange-Id: I379e1eb6dc57b9fe4bbdaefbd947a14326e7117a\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master","description":"Rebase"},"4adbce62824ae6a776299823177951b2730d6774":{"kind":"REWORK","_number":4,"created":"2024-07-26 09:33:53.000000000","uploader":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/70/670/4","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/70/670/4","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/70/670/4 \u0026\u0026 git checkout -b change-670 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/70/670/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/70/670/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/70/670/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/70/670/4","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/70/670/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"8991f0d5c6c06d1e42919d1d6a0813ca1c46f8a1","subject":"add and send IV_PROTO_DNS_OPTION_V2 flag"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2024-06-20 15:54:19.000000000","tz":120},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2024-07-26 09:32:40.000000000","tz":120},"subject":"console_systemd: rename query_user_exec to query_user_systemd","message":"console_systemd: rename query_user_exec to query_user_systemd\n\nThis allows us to override query_user_exec for unit\ntests more consistently without having to jump through\nweird hoops.\n\nFixes running test_pkcs11 with --enable-systemd.\n\nWhile here also fix documentation comments for\nquery_user_exec*.\n\nChange-Id: I379e1eb6dc57b9fe4bbdaefbd947a14326e7117a\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"418463ad27c13f56adb5b02cfd62018b7d634ee8":{"kind":"NO_CODE_CHANGE","_number":5,"created":"2024-07-26 11:57:32.000000000","uploader":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/70/670/5","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/70/670/5","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/70/670/5 \u0026\u0026 git checkout -b change-670 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/70/670/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/70/670/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/70/670/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/70/670/5","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/70/670/5 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"8991f0d5c6c06d1e42919d1d6a0813ca1c46f8a1","subject":"add and send IV_PROTO_DNS_OPTION_V2 flag"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2024-07-26 10:40:32.000000000","tz":120},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2024-07-26 10:47:48.000000000","tz":120},"subject":"console_systemd: rename query_user_exec to query_user_systemd","message":"console_systemd: rename query_user_exec to query_user_systemd\n\nThis allows us to override query_user_exec for unit\ntests more consistently without having to jump through\nweird hoops.\n\nFixes running test_pkcs11 with --enable-systemd.\n\nWhile here also fix documentation comments for\nquery_user_exec*.\n\nChange-Id: I379e1eb6dc57b9fe4bbdaefbd947a14326e7117a\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\nAcked-by: Gert Doering \u003cgert@greenie.muc.de\u003e\nMessage-Id: \u003c20240726104032.2112-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg28983.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[]}
