)]}'
{"id":"openvpn~672","triplet_id":"openvpn~master~I47c992b6b73b1475cbff8a28f720cf50dc1fbe3e","project":"openvpn","branch":"master","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2024-07-17 20:01:31.000000000","reason":"Change was submitted"},"1000002":{"account":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"last_update":"2024-07-17 20:01:31.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2024-07-10 14:05:11.000000000","reason":"\u003cGERRIT_ACCOUNT_1000001\u003e replied on the change","reason_account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}}},"hashtags":["mailsubmitted"],"change_id":"I47c992b6b73b1475cbff8a28f720cf50dc1fbe3e","subject":"Allow trailing \\r and \\n in control channel message","status":"MERGED","created":"2024-07-08 10:09:24.000000000","updated":"2024-07-17 20:01:31.000000000","submitted":"2024-07-17 20:01:31.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":13,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"672","meta_rev_id":"1a25a3db95753020fd3938aad373cd12f18a4a56","_number":672,"virtual_id_number":672,"owner":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"value":0,"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-07-08 10:09:24.000000000","updated_by":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2024-07-08 10:09:24.000000000","updated_by":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"reviewer":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"state":"REVIEWER"},{"updated":"2024-07-08 19:27:55.000000000","updated_by":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"state":"REVIEWER"}],"messages":[{"id":"5db9389f014783aecd046049b3b649b96ba12133","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2024-07-08 10:09:24.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"87cb49a39e9c4dfe7f6a0f1dd4c2986d0fe26d32","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2024-07-08 11:14:41.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"f1242aa3057573b87e72992ca531eb976e7dfc5a","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2024-07-08 16:16:19.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"5264fd13b301501f749e875e1ac991de423cd26e","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2024-07-08 16:18:06.000000000","message":"Uploaded patch set 2.\n\nOutdated Votes:\n* Code-Review-1 (copy condition: \"changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR is:MIN\")\n","accounts_in_message":[],"_revision_number":2},{"id":"2724e23a183254cfd96ab68845da9ff87536a66c","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2024-07-08 16:32:44.000000000","message":"Patch Set 2: Code-Review-1\n\n(2 comments)","accounts_in_message":[],"_revision_number":2},{"id":"de828dfd46d56b68208fafe749f6ff67711b2a9c","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2024-07-08 19:27:55.000000000","message":"Patch Set 2: Code-Review-1\n\n(3 comments)","accounts_in_message":[],"_revision_number":2},{"id":"ebe3ff90dd733f24ffb36b3cc9a6abba54edc0ee","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2024-07-09 13:55:20.000000000","message":"Uploaded patch set 3.\n\nOutdated Votes:\n* Code-Review-1 (copy condition: \"changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR is:MIN\")\n","accounts_in_message":[],"_revision_number":3},{"id":"2fbf58744b4bb144f83214b82b8def9765720b17","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2024-07-09 16:13:27.000000000","message":"Patch Set 3: Code-Review-1\n\n(4 comments)","accounts_in_message":[],"_revision_number":3},{"id":"4ce80a73ef325b7ee7337d00e4385bcb82842e4c","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2024-07-10 13:50:44.000000000","message":"Uploaded patch set 4.\n\nOutdated Votes:\n* Code-Review-1 (copy condition: \"changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR is:MIN\")\n","accounts_in_message":[],"_revision_number":4},{"id":"28148c3d6bdea4f22510c8a7158361b22d348457","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2024-07-10 14:05:11.000000000","message":"Patch Set 4: Code-Review+2\n\n(2 comments)","accounts_in_message":[],"_revision_number":4},{"id":"e118bfbcd5abf41fc7fb222a620a3e86cfb24a93","tag":"autogenerated:gerrit:setHashtag","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2024-07-10 14:06:37.000000000","message":"Hashtag added: mailsubmitted","accounts_in_message":[],"_revision_number":4},{"id":"1a25a3db95753020fd3938aad373cd12f18a4a56","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2024-07-17 20:01:31.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":5}],"current_revision_number":5,"current_revision":"be31325e1dfdffbb152374985c2ae7b6644e3519","revisions":{"48703d64a7234b7cf7a1319d404f9702a7a7a4e6":{"kind":"REWORK","_number":1,"created":"2024-07-08 10:09:24.000000000","uploader":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"ref":"refs/changes/72/672/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/72/672/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/72/672/1 \u0026\u0026 git checkout -b change-672 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/72/672/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/72/672/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/72/672/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/72/672/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/72/672/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"f8f477139804b06183b515a529c982f524547d18","subject":"t_server_null: multiple improvements and fixes"}],"author":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2024-07-08 10:06:28.000000000","tz":120},"committer":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2024-07-08 10:09:11.000000000","tz":120},"subject":"Allow trailing \\r and \\n in control channel message","message":"Allow trailing \\r and \\n in control channel message\n\nWriting a reason from a script will easily end up adding extra \\r\\n characters\nat the end of the reason. Our current code pushes this to the peer. So be more\nliberal in accepting these message.\n\nCloses openvpn/openvpn#568\n\nChange-Id: I47c992b6b73b1475cbff8a28f720cf50dc1fbe3e\n"},"branch":"refs/heads/master"},"808fd564bc309430cdb4d071200d3d8791886340":{"kind":"REWORK","_number":2,"created":"2024-07-08 16:18:06.000000000","uploader":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"ref":"refs/changes/72/672/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/72/672/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/72/672/2 \u0026\u0026 git checkout -b change-672 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/72/672/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/72/672/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/72/672/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/72/672/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/72/672/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"f8f477139804b06183b515a529c982f524547d18","subject":"t_server_null: multiple improvements and fixes"}],"author":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2024-07-08 10:06:28.000000000","tz":120},"committer":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2024-07-08 16:17:56.000000000","tz":120},"subject":"Allow trailing \\r and \\n in control channel message","message":"Allow trailing \\r and \\n in control channel message\n\nWriting a reason from a script will easily end up adding extra \\r\\n characters\nat the end of the reason. Our current code pushes this to the peer. So be more\nliberal in accepting these message.\n\nCloses openvpn/openvpn#568\n\nChange-Id: I47c992b6b73b1475cbff8a28f720cf50dc1fbe3e\nSigned-off-by: Arne Schwabe \u003carne@rfc2549.org\u003e\n"},"branch":"refs/heads/master"},"0531e80da3a82f95955dace00ae811768253d43b":{"kind":"REWORK","_number":3,"created":"2024-07-09 13:55:20.000000000","uploader":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"ref":"refs/changes/72/672/3","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/72/672/3","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/72/672/3 \u0026\u0026 git checkout -b change-672 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/72/672/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/72/672/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/72/672/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/72/672/3","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/72/672/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"f8f477139804b06183b515a529c982f524547d18","subject":"t_server_null: multiple improvements and fixes"}],"author":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2024-07-08 10:06:28.000000000","tz":120},"committer":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2024-07-09 13:55:04.000000000","tz":120},"subject":"Allow trailing \\r and \\n in control channel message","message":"Allow trailing \\r and \\n in control channel message\n\nWriting a reason from a script will easily end up adding extra \\r\\n characters\nat the end of the reason. Our current code pushes this to the peer. So be more\nliberal in accepting these message.\n\nCloses openvpn/openvpn#568\n\nChange-Id: I47c992b6b73b1475cbff8a28f720cf50dc1fbe3e\nSigned-off-by: Arne Schwabe \u003carne@rfc2549.org\u003e\n"},"branch":"refs/heads/master"},"aedd9f074e69aa369b3fe4c598b028bd512a3313":{"kind":"REWORK","_number":4,"created":"2024-07-10 13:50:44.000000000","uploader":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"ref":"refs/changes/72/672/4","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/72/672/4","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/72/672/4 \u0026\u0026 git checkout -b change-672 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/72/672/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/72/672/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/72/672/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/72/672/4","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/72/672/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"f8f477139804b06183b515a529c982f524547d18","subject":"t_server_null: multiple improvements and fixes"}],"author":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2024-07-08 10:06:28.000000000","tz":120},"committer":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2024-07-10 13:50:34.000000000","tz":120},"subject":"Allow trailing \\r and \\n in control channel message","message":"Allow trailing \\r and \\n in control channel message\n\nWriting a reason from a script will easily end up adding extra \\r\\n characters\nat the end of the reason. Our current code pushes this to the peer. So be more\nliberal in accepting these message.\n\nCloses openvpn/openvpn#568\n\nChange-Id: I47c992b6b73b1475cbff8a28f720cf50dc1fbe3e\nSigned-off-by: Arne Schwabe \u003carne@rfc2549.org\u003e\n"},"branch":"refs/heads/master"},"be31325e1dfdffbb152374985c2ae7b6644e3519":{"kind":"NO_CODE_CHANGE","_number":5,"created":"2024-07-17 20:01:31.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/72/672/5","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/72/672/5","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/72/672/5 \u0026\u0026 git checkout -b change-672 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/72/672/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/72/672/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/72/672/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/72/672/5","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/72/672/5 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"f8f477139804b06183b515a529c982f524547d18","subject":"t_server_null: multiple improvements and fixes"}],"author":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2024-07-10 14:06:23.000000000","tz":120},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2024-07-17 18:55:21.000000000","tz":120},"subject":"Allow trailing \\r and \\n in control channel message","message":"Allow trailing \\r and \\n in control channel message\n\nWriting a reason from a script will easily end up adding extra \\r\\n characters\nat the end of the reason. Our current code pushes this to the peer. So be more\nliberal in accepting these message.\n\nGithub: closes OpenVPN/openvpn#568\n\nChange-Id: I47c992b6b73b1475cbff8a28f720cf50dc1fbe3e\nSigned-off-by: Arne Schwabe \u003carne@rfc2549.org\u003e\nAcked-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\nMessage-Id: \u003c20240710140623.172829-1-frank@lichtenheld.com\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg28910.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}