)]}'
{"id":"openvpn~677","triplet_id":"openvpn~master~Id1ec0c6e4c391604ec5dbb8b7122f2e47ad186d1","project":"openvpn","branch":"master","topic":"RemovedUnnecessaryRouteInstallations","attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2025-10-21 14:05:10.000000000","reason":"Vote got outdated and was removed: Code-Review-1"},"1000002":{"account":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"last_update":"2024-09-19 12:58:57.000000000","reason":"\u003cGERRIT_ACCOUNT_1000040\u003e replied on the change","reason_account":{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"}},"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2024-09-05 13:18:42.000000000","reason":"Vote got outdated and was removed: Code-Review-1"}},"removed_from_attention_set":{"1000040":{"account":{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"},"last_update":"2025-10-21 14:10:43.000000000","reason":"\u003cGERRIT_ACCOUNT_1000040\u003e replied on the change","reason_account":{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"}}},"hashtags":[],"change_id":"Id1ec0c6e4c391604ec5dbb8b7122f2e47ad186d1","subject":"route: copied \u0027gateway_needed\u0027 logic from add_route_ipv6 to add_route","status":"NEW","created":"2024-07-18 14:03:27.000000000","updated":"2025-10-21 14:10:43.000000000","submit_type":"CHERRY_PICK","submittable":false,"total_comment_count":16,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"80d22e5198c23a65689607554c550bdde861127e","_number":677,"virtual_id_number":677,"owner":{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-07-18 14:03:28.000000000","updated_by":{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2024-07-18 14:03:28.000000000","updated_by":{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"},"reviewer":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"state":"REVIEWER"},{"updated":"2024-07-18 14:03:28.000000000","updated_by":{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2024-09-19 11:10:41.000000000","updated_by":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"state":"CC"}],"messages":[{"id":"b1eeb8ece227dc826ee55b5678d6e740e9bb3c47","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"},"date":"2024-07-18 14:03:27.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"414efd94c62ca56ba43d24b6f0b252ff6aeeaebe","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2024-07-19 13:16:54.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"c97160f552f106a077c72a6cb7a087a58e0c0c7c","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"},"date":"2024-07-29 15:42:44.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.\n\nCopied Votes:\n* Code-Review-1 (copy condition: \"changekind:NO_CHANGE OR **changekind:TRIVIAL_REBASE** OR is:MIN\")\n","accounts_in_message":[],"_revision_number":2},{"id":"478131f467fb53a20e90c41c611914503284097b","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"},"date":"2024-07-30 09:24:36.000000000","message":"Uploaded patch set 3.\n\nOutdated Votes:\n* Code-Review-1 (copy condition: \"changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR is:MIN\")\n","accounts_in_message":[],"_revision_number":3},{"id":"6cb9d1c7d28837abb2664520b86ab763caca4822","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"},"date":"2024-07-30 10:07:59.000000000","message":"Uploaded patch set 4: Patch Set 3 was rebased.","accounts_in_message":[],"_revision_number":4},{"id":"5d3b4ef29785dfcb3fec67f7fd6b708c6eddd9e5","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"},"date":"2024-08-20 12:23:22.000000000","message":"Uploaded patch set 5: Patch Set 4 was rebased.","accounts_in_message":[],"_revision_number":5},{"id":"1f62b9f01746cef695dbb7dafd991a03cb60870b","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2024-09-05 10:09:53.000000000","message":"Patch Set 5: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":5},{"id":"23e55ac7226785333942ba5ac35448bdb1e8ea65","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"},"date":"2024-09-05 13:18:42.000000000","message":"Uploaded patch set 6.\n\nOutdated Votes:\n* Code-Review-1 (copy condition: \"changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR is:MIN\")\n","accounts_in_message":[],"_revision_number":6},{"id":"a561b355eeee0f699dfa38febca2c6d0482de6b9","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"},"date":"2024-09-09 15:36:52.000000000","message":"Uploaded patch set 7: Patch Set 6 was rebased.","accounts_in_message":[],"_revision_number":7},{"id":"1d141979e06482aac9244954e0d3282e6570ba91","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"},"date":"2024-09-12 19:28:59.000000000","message":"Uploaded patch set 8: Patch Set 7 was rebased.","accounts_in_message":[],"_revision_number":8},{"id":"24fe7a213ce907370bcb28f0f7e16d010caceb29","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"},"date":"2024-09-12 20:29:56.000000000","message":"Uploaded patch set 9: Patch Set 8 was rebased.","accounts_in_message":[],"_revision_number":9},{"id":"87542ce3f7b6ac520989148a01b2051e03c207e9","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2024-09-19 11:10:41.000000000","message":"Patch Set 9:\n\n(5 comments)","accounts_in_message":[],"_revision_number":9},{"id":"4718d941c57ce7fb58af1e215aa19cc5a773e25c","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"},"date":"2024-09-19 12:54:55.000000000","message":"Uploaded patch set 10.","accounts_in_message":[],"_revision_number":10},{"id":"bb033f9af539c163880678187c4a1060201cfc52","author":{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"},"date":"2024-09-19 12:58:57.000000000","message":"Patch Set 10:\n\n(5 comments)","accounts_in_message":[],"_revision_number":10},{"id":"48ce04c8728c4440f61b8b3b2b68043c767f8004","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"},"date":"2025-01-26 23:43:57.000000000","message":"Uploaded patch set 11: Patch Set 10 was rebased.","accounts_in_message":[],"_revision_number":11},{"id":"ce08f5790f9abf84718650a03c7727ccd2fa2af2","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2025-10-13 14:49:02.000000000","message":"Patch Set 11:\n\n(2 comments)","accounts_in_message":[],"_revision_number":11},{"id":"705816912e118250810bfb3faf38732caddfeb2b","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2025-10-13 14:49:09.000000000","message":"Patch Set 11: Code-Review-1","accounts_in_message":[],"_revision_number":11},{"id":"506961227184184e72aebdcc3f729f1fccfe9ba7","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"},"date":"2025-10-21 14:05:10.000000000","message":"Uploaded patch set 12.\n\nOutdated Votes:\n* Code-Review-1 (copy condition: \"changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR is:MIN\")\n","accounts_in_message":[],"_revision_number":12},{"id":"80d22e5198c23a65689607554c550bdde861127e","author":{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"},"date":"2025-10-21 14:10:43.000000000","message":"Patch Set 12:\n\n(2 comments)","accounts_in_message":[],"_revision_number":12}],"current_revision_number":12,"current_revision":"2b7ac8fdcb1e0c57e98f61bd08c9e36e26051ea2","revisions":{"575029bbf266fb7e76b30dac6b3e3e6004d40c07":{"kind":"REWORK","_number":1,"created":"2024-07-18 14:03:27.000000000","uploader":{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"},"ref":"refs/changes/77/677/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/77/677/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/77/677/1 \u0026\u0026 git checkout -b change-677 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/77/677/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/77/677/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/77/677/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/77/677/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/77/677/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"f8f477139804b06183b515a529c982f524547d18","subject":"t_server_null: multiple improvements and fixes"}],"author":{"name":"Marco Baffo","email":"marco@mandelbit.com","date":"2024-07-17 08:18:28.000000000","tz":120},"committer":{"name":"Marco Baffo","email":"marco@mandelbit.com","date":"2024-07-18 14:02:30.000000000","tz":120},"subject":"route: copied \u0027gateway_needed\u0027 logic from add_route_ipv6 to add_route","message":"route: copied \u0027gateway_needed\u0027 logic from add_route_ipv6 to add_route\n\nUnder certain circumstances it may not be necessary to pass the\ngateway when adding a new route via net_route_v4_add() API function.\nadd_route_ipv6() already accounts for some of these cases and\ntherefore this patch copies the same logic to add_route().\n\nChange-Id: Id1ec0c6e4c391604ec5dbb8b7122f2e47ad186d1\nSigned-off-by: Marco Baffo \u003cmarco@mandelbit.com\u003e\n"},"branch":"refs/heads/master"},"8477c84da11a63777aba1021f36b53f1a4098c21":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2024-07-29 15:42:44.000000000","uploader":{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"},"ref":"refs/changes/77/677/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/77/677/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/77/677/2 \u0026\u0026 git checkout -b change-677 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/77/677/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/77/677/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/77/677/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/77/677/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/77/677/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"856065b2eb37286c389550593472bf180bc5be9d","subject":"Add Ubuntu 24.04 runner to Github Actions"}],"author":{"name":"Marco Baffo","email":"marco@mandelbit.com","date":"2024-07-17 08:18:28.000000000","tz":120},"committer":{"name":"Marco Baffo","email":"marco@mandelbit.com","date":"2024-07-29 11:42:10.000000000","tz":120},"subject":"route: copied \u0027gateway_needed\u0027 logic from add_route_ipv6 to add_route","message":"route: copied \u0027gateway_needed\u0027 logic from add_route_ipv6 to add_route\n\nUnder certain circumstances it may not be necessary to pass the\ngateway when adding a new route via net_route_v4_add() API function.\nadd_route_ipv6() already accounts for some of these cases and\ntherefore this patch copies the same logic to add_route().\n\nChange-Id: Id1ec0c6e4c391604ec5dbb8b7122f2e47ad186d1\nSigned-off-by: Marco Baffo \u003cmarco@mandelbit.com\u003e\n"},"branch":"refs/heads/master"},"05938333d803d3d638764965e0590e362135470f":{"kind":"REWORK","_number":3,"created":"2024-07-30 09:24:36.000000000","uploader":{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"},"ref":"refs/changes/77/677/3","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/77/677/3","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/77/677/3 \u0026\u0026 git checkout -b change-677 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/77/677/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/77/677/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/77/677/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/77/677/3","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/77/677/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"856065b2eb37286c389550593472bf180bc5be9d","subject":"Add Ubuntu 24.04 runner to Github Actions"}],"author":{"name":"Marco Baffo","email":"marco@mandelbit.com","date":"2024-07-17 08:18:28.000000000","tz":120},"committer":{"name":"Marco Baffo","email":"marco@mandelbit.com","date":"2024-07-30 08:29:31.000000000","tz":120},"subject":"route: copied \u0027gateway_needed\u0027 logic from add_route_ipv6 to add_route","message":"route: copied \u0027gateway_needed\u0027 logic from add_route_ipv6 to add_route\n\nUnder certain circumstances it may not be necessary to pass the\ngateway when adding a new route via net_route_v4_add() API function.\nadd_route_ipv6() already accounts for some of these cases and\ntherefore this patch copies the same logic to add_route().\n\nChange-Id: Id1ec0c6e4c391604ec5dbb8b7122f2e47ad186d1\nSigned-off-by: Marco Baffo \u003cmarco@mandelbit.com\u003e\n"},"branch":"refs/heads/master"},"28157bce1ebaa56b36d64a114759f84b08a1b273":{"kind":"TRIVIAL_REBASE","_number":4,"created":"2024-07-30 10:07:59.000000000","uploader":{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"},"ref":"refs/changes/77/677/4","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/77/677/4","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/77/677/4 \u0026\u0026 git checkout -b change-677 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/77/677/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/77/677/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/77/677/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/77/677/4","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/77/677/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"418463ad27c13f56adb5b02cfd62018b7d634ee8","subject":"console_systemd: rename query_user_exec to query_user_systemd"}],"author":{"name":"Marco Baffo","email":"marco@mandelbit.com","date":"2024-07-17 08:18:28.000000000","tz":120},"committer":{"name":"Marco Baffo","email":"marco@mandelbit.com","date":"2024-07-30 09:47:55.000000000","tz":120},"subject":"route: copied \u0027gateway_needed\u0027 logic from add_route_ipv6 to add_route","message":"route: copied \u0027gateway_needed\u0027 logic from add_route_ipv6 to add_route\n\nUnder certain circumstances it may not be necessary to pass the\ngateway when adding a new route via net_route_v4_add() API function.\nadd_route_ipv6() already accounts for some of these cases and\ntherefore this patch copies the same logic to add_route().\n\nChange-Id: Id1ec0c6e4c391604ec5dbb8b7122f2e47ad186d1\nSigned-off-by: Marco Baffo \u003cmarco@mandelbit.com\u003e\n"},"branch":"refs/heads/master"},"615b37626691bdcfe20ab9b6895c32327ca86379":{"kind":"TRIVIAL_REBASE","_number":5,"created":"2024-08-20 12:23:22.000000000","uploader":{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"},"ref":"refs/changes/77/677/5","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/77/677/5","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/77/677/5 \u0026\u0026 git checkout -b change-677 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/77/677/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/77/677/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/77/677/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/77/677/5","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/77/677/5 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"233e10aeec7de02d34fa5c517b44612d38ccc00f","subject":"Implement support for AEAD tag at the end"}],"author":{"name":"Marco Baffo","email":"marco@mandelbit.com","date":"2024-07-17 08:18:28.000000000","tz":120},"committer":{"name":"Marco Baffo","email":"marco@mandelbit.com","date":"2024-08-20 07:52:26.000000000","tz":120},"subject":"route: copied \u0027gateway_needed\u0027 logic from add_route_ipv6 to add_route","message":"route: copied \u0027gateway_needed\u0027 logic from add_route_ipv6 to add_route\n\nUnder certain circumstances it may not be necessary to pass the\ngateway when adding a new route via net_route_v4_add() API function.\nadd_route_ipv6() already accounts for some of these cases and\ntherefore this patch copies the same logic to add_route().\n\nChange-Id: Id1ec0c6e4c391604ec5dbb8b7122f2e47ad186d1\nSigned-off-by: Marco Baffo \u003cmarco@mandelbit.com\u003e\n"},"branch":"refs/heads/master"},"68eafba9b0166ce631b3589d20e5d47d0b75ab2b":{"kind":"REWORK","_number":6,"created":"2024-09-05 13:18:42.000000000","uploader":{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"},"ref":"refs/changes/77/677/6","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/77/677/6","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/77/677/6 \u0026\u0026 git checkout -b change-677 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/77/677/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/77/677/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/77/677/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/77/677/6","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/77/677/6 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"418463ad27c13f56adb5b02cfd62018b7d634ee8","subject":"console_systemd: rename query_user_exec to query_user_systemd"}],"author":{"name":"Marco Baffo","email":"marco@mandelbit.com","date":"2024-07-17 08:18:28.000000000","tz":120},"committer":{"name":"Marco Baffo","email":"marco@mandelbit.com","date":"2024-09-05 13:06:57.000000000","tz":120},"subject":"route: copied \u0027gateway_needed\u0027 logic from add_route_ipv6 to add_route","message":"route: copied \u0027gateway_needed\u0027 logic from add_route_ipv6 to add_route\n\nUnder certain circumstances it may not be necessary to pass the\ngateway when adding a new route via net_route_v4_add() API function.\nadd_route_ipv6() already accounts for some of these cases and\ntherefore this patch copies the same logic to add_route().\n\nChange-Id: Id1ec0c6e4c391604ec5dbb8b7122f2e47ad186d1\nSigned-off-by: Marco Baffo \u003cmarco@mandelbit.com\u003e\n"},"branch":"refs/heads/master"},"d3fb46adb896e93166cc6be56c66d95d7eee6086":{"kind":"TRIVIAL_REBASE","_number":7,"created":"2024-09-09 15:36:52.000000000","uploader":{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"},"ref":"refs/changes/77/677/7","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/77/677/7","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/77/677/7 \u0026\u0026 git checkout -b change-677 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/77/677/7 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/77/677/7 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/77/677/7 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/77/677/7","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/77/677/7 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"32e748bd3320cd07b9e7671ee0cec95f4fd85935","subject":"Ensures all params are ready before invoking dco_set_peer()"}],"author":{"name":"Marco Baffo","email":"marco@mandelbit.com","date":"2024-07-17 08:18:28.000000000","tz":120},"committer":{"name":"Marco Baffo","email":"marco@mandelbit.com","date":"2024-09-09 15:29:53.000000000","tz":120},"subject":"route: copied \u0027gateway_needed\u0027 logic from add_route_ipv6 to add_route","message":"route: copied \u0027gateway_needed\u0027 logic from add_route_ipv6 to add_route\n\nUnder certain circumstances it may not be necessary to pass the\ngateway when adding a new route via net_route_v4_add() API function.\nadd_route_ipv6() already accounts for some of these cases and\ntherefore this patch copies the same logic to add_route().\n\nChange-Id: Id1ec0c6e4c391604ec5dbb8b7122f2e47ad186d1\nSigned-off-by: Marco Baffo \u003cmarco@mandelbit.com\u003e\n"},"branch":"refs/heads/master"},"31e2896c1789da86ff6c3bae9dae229ae05ff29a":{"kind":"TRIVIAL_REBASE","_number":8,"created":"2024-09-12 19:28:59.000000000","uploader":{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"},"ref":"refs/changes/77/677/8","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/77/677/8","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/77/677/8 \u0026\u0026 git checkout -b change-677 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/77/677/8 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/77/677/8 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/77/677/8 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/77/677/8","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/77/677/8 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"45bef145f3cc39c4c13609866f07b6cf9f8960a6","subject":"dco: mark peer as deleted from kernel after receiving CMD_DEL_PEER notification"}],"author":{"name":"Marco Baffo","email":"marco@mandelbit.com","date":"2024-07-17 08:18:28.000000000","tz":120},"committer":{"name":"Marco Baffo","email":"marco@mandelbit.com","date":"2024-09-12 19:23:13.000000000","tz":120},"subject":"route: copied \u0027gateway_needed\u0027 logic from add_route_ipv6 to add_route","message":"route: copied \u0027gateway_needed\u0027 logic from add_route_ipv6 to add_route\n\nUnder certain circumstances it may not be necessary to pass the\ngateway when adding a new route via net_route_v4_add() API function.\nadd_route_ipv6() already accounts for some of these cases and\ntherefore this patch copies the same logic to add_route().\n\nChange-Id: Id1ec0c6e4c391604ec5dbb8b7122f2e47ad186d1\nSigned-off-by: Marco Baffo \u003cmarco@mandelbit.com\u003e\n"},"branch":"refs/heads/master"},"e50c75828e92ece944a136ccfaad31a9d170d122":{"kind":"TRIVIAL_REBASE","_number":9,"created":"2024-09-12 20:29:56.000000000","uploader":{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"},"ref":"refs/changes/77/677/9","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/77/677/9","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/77/677/9 \u0026\u0026 git checkout -b change-677 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/77/677/9 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/77/677/9 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/77/677/9 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/77/677/9","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/77/677/9 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"65985905c5abc69c1ee34c4cab6fdf8b73da7f50","subject":"GHA: Enable t_server_null tests"}],"author":{"name":"Marco Baffo","email":"marco@mandelbit.com","date":"2024-07-17 08:18:28.000000000","tz":120},"committer":{"name":"Marco Baffo","email":"marco@mandelbit.com","date":"2024-09-12 20:25:48.000000000","tz":120},"subject":"route: copied \u0027gateway_needed\u0027 logic from add_route_ipv6 to add_route","message":"route: copied \u0027gateway_needed\u0027 logic from add_route_ipv6 to add_route\n\nUnder certain circumstances it may not be necessary to pass the\ngateway when adding a new route via net_route_v4_add() API function.\nadd_route_ipv6() already accounts for some of these cases and\ntherefore this patch copies the same logic to add_route().\n\nChange-Id: Id1ec0c6e4c391604ec5dbb8b7122f2e47ad186d1\nSigned-off-by: Marco Baffo \u003cmarco@mandelbit.com\u003e\n"},"branch":"refs/heads/master"},"f1b851a1de1a374ae289d70bc1e34e9af64265b1":{"kind":"REWORK","_number":10,"created":"2024-09-19 12:54:55.000000000","uploader":{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"},"ref":"refs/changes/77/677/10","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/77/677/10","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/77/677/10 \u0026\u0026 git checkout -b change-677 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/77/677/10 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/77/677/10 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/77/677/10 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/77/677/10","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/77/677/10 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"65985905c5abc69c1ee34c4cab6fdf8b73da7f50","subject":"GHA: Enable t_server_null tests"}],"author":{"name":"Marco Baffo","email":"marco@mandelbit.com","date":"2024-07-17 08:18:28.000000000","tz":120},"committer":{"name":"Marco Baffo","email":"marco@mandelbit.com","date":"2024-09-19 12:49:38.000000000","tz":120},"subject":"route: copied \u0027gateway_needed\u0027 logic from add_route_ipv6 to add_route","message":"route: copied \u0027gateway_needed\u0027 logic from add_route_ipv6 to add_route\n\nUnder certain circumstances it may not be necessary to pass the\ngateway when adding a new route via net_route_v4_add() API function.\nadd_route_ipv6() already accounts for some of these cases and\ntherefore this patch copies the same logic to add_route().\n\nChange-Id: Id1ec0c6e4c391604ec5dbb8b7122f2e47ad186d1\nSigned-off-by: Marco Baffo \u003cmarco@mandelbit.com\u003e\n"},"branch":"refs/heads/master"},"8d7f501d1b45820f4a77c49a5ee082ee0a3f1bb4":{"kind":"TRIVIAL_REBASE","_number":11,"created":"2025-01-26 23:43:57.000000000","uploader":{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"},"ref":"refs/changes/77/677/11","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/77/677/11","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/77/677/11 \u0026\u0026 git checkout -b change-677 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/77/677/11 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/77/677/11 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/77/677/11 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/77/677/11","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/77/677/11 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"2a50daf5fe6c924c8d945b3d0455c9e282cd769f","subject":"tls_crypt_v2_write_client_key_file: Fix missing-field-initializers compiler warning"}],"author":{"name":"Marco Baffo","email":"marco@mandelbit.com","date":"2024-07-17 08:18:28.000000000","tz":120},"committer":{"name":"Marco Baffo","email":"marco@mandelbit.com","date":"2025-01-26 23:19:52.000000000","tz":60},"subject":"route: copied \u0027gateway_needed\u0027 logic from add_route_ipv6 to add_route","message":"route: copied \u0027gateway_needed\u0027 logic from add_route_ipv6 to add_route\n\nUnder certain circumstances it may not be necessary to pass the\ngateway when adding a new route via net_route_v4_add() API function.\nadd_route_ipv6() already accounts for some of these cases and\ntherefore this patch copies the same logic to add_route().\n\nChange-Id: Id1ec0c6e4c391604ec5dbb8b7122f2e47ad186d1\nSigned-off-by: Marco Baffo \u003cmarco@mandelbit.com\u003e\n"},"branch":"refs/heads/master"},"2b7ac8fdcb1e0c57e98f61bd08c9e36e26051ea2":{"kind":"REWORK","_number":12,"created":"2025-10-21 14:05:10.000000000","uploader":{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"},"ref":"refs/changes/77/677/12","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/77/677/12","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/77/677/12 \u0026\u0026 git checkout -b change-677 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/77/677/12 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/77/677/12 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/77/677/12 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/77/677/12","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/77/677/12 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"3e76d8f8a475d08bcb50321e742a06c53e19d45d","subject":"dco: remove dco_read/write_bytes from dco_context_t"}],"author":{"name":"Marco Baffo","email":"marco@mandelbit.com","date":"2024-07-17 08:18:28.000000000","tz":120},"committer":{"name":"Marco Baffo","email":"marco@mandelbit.com","date":"2025-10-20 07:06:15.000000000","tz":120},"subject":"route: copied \u0027gateway_needed\u0027 logic from add_route_ipv6 to add_route","message":"route: copied \u0027gateway_needed\u0027 logic from add_route_ipv6 to add_route\n\nUnder certain circumstances it may not be necessary to pass the\ngateway when adding a new route via net_route_v4_add() API function.\nadd_route_ipv6() already accounts for some of these cases and\ntherefore this patch copies the same logic to add_route().\n\nChange-Id: Id1ec0c6e4c391604ec5dbb8b7122f2e47ad186d1\nSigned-off-by: Marco Baffo \u003cmarco@mandelbit.com\u003e\n"},"branch":"refs/heads/master"}},"requirements":[{"status":"NOT_READY","fallback_text":"All required checks must pass","type":"checks_pass"}],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"NOT_READY","labels":[{"label":"Code-Review","status":"NEED"}]},{"rule_name":"checks~ChecksSubmitRule","status":"NOT_READY","requirements":[{"status":"NOT_READY","fallback_text":"All required checks must pass","type":"checks_pass"}]}],"submit_requirements":[{"name":"Code-Review","status":"UNSATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"]}},{"name":"checks~ChecksSubmitRule","status":"UNSATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"rule:checks~ChecksSubmitRule","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["checks~ChecksSubmitRule"]}}]}