)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"0b7b7332da1d8158688125edc7fe164a0a1562a4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"4f1b0b2f_c15d76cc","updated":"2024-06-13 13:47:05.000000000","message":"Generally looks sensible. But I would vote for splitting up the TLS version check and the other changes. Feels like that would make each change clearer.","commit_id":"fb66c82b7a0cb3803099078e8518974f3580002c"},{"author":{"_account_id":1000030,"name":"Max Fillinger","email":"max@max-fillinger.net","username":"MaxF"},"change_message_id":"43368917432332876701f8db2568c5f253725161","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"449a2afe_898c0383","updated":"2024-06-13 10:46:33.000000000","message":"I could ACK this, but I don\u0027t know if I should because I collaborated with Rein on this.","commit_id":"fb66c82b7a0cb3803099078e8518974f3580002c"},{"author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"cc365d1265fdd3bb18fe4b8c8a2c8e5f30285078","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"53a46fca_bc5e1003","in_reply_to":"27a7a68f_31ea45ae","updated":"2024-06-13 19:44:42.000000000","message":"Sounds good to me. I do not think it is important in which order they need to be applied, only that the first commit doesn\u0027t break anything.","commit_id":"fb66c82b7a0cb3803099078e8518974f3580002c"},{"author":{"_account_id":1000030,"name":"Max Fillinger","email":"max@max-fillinger.net","username":"MaxF"},"change_message_id":"24b403f5e1c4855c9376ec7d887e6e169aea47b7","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"27a7a68f_31ea45ae","in_reply_to":"4f1b0b2f_c15d76cc","updated":"2024-06-13 15:43:07.000000000","message":"Splitting up these changes is difficult because the new mbedtls_ssl_protocol_version enum doesn\u0027t contain values for TLS 1.0 or 1.1 in the first place.\n\nShould we first make a commit to disable old TLS versions, and then a commit to switch to the new functions?","commit_id":"fb66c82b7a0cb3803099078e8518974f3580002c"},{"author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"a983c39ee1a1ae3877039099a7f2cd265551300e","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"050945b7_b9374ef8","in_reply_to":"53a46fca_bc5e1003","updated":"2024-06-13 19:46:59.000000000","message":"And when I say \"doesn\u0027t break anything\" I mean that like \"building\". Obviously it is fine to disable the TLS 1.0/1.1 support if that is what the commit intends to do 😎","commit_id":"fb66c82b7a0cb3803099078e8518974f3580002c"}]}
