)]}'
{"id":"openvpn~681","triplet_id":"openvpn~master~If96c2ebd2af16b18ed34820e8c0531547e2076d9","project":"openvpn","branch":"master","full_branch":"refs/heads/master","attention_set":{},"removed_from_attention_set":{"1000030":{"account":{"_account_id":1000030,"name":"Max Fillinger","email":"max@max-fillinger.net","username":"MaxF"},"last_update":"2024-06-18 12:41:52.000000000","reason":"Change was submitted"},"1000003":{"account":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2024-06-18 11:54:17.000000000","reason":"removed on reply"},"1000001":{"account":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2024-06-18 12:41:52.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"If96c2ebd2af16b18ed34820e8c0531547e2076d9","subject":"Fix MBEDTLS_DEPRECATED_REMOVED build errors","status":"MERGED","created":"2024-06-13 09:35:20.000000000","updated":"2024-06-18 12:41:52.000000000","submitted":"2024-06-18 12:41:52.000000000","submitter":{"_account_id":1000030,"name":"Max Fillinger","email":"max@max-fillinger.net","username":"MaxF"},"total_comment_count":5,"unresolved_comment_count":1,"has_review_started":true,"submission_id":"681","meta_rev_id":"d964ea9dde4439185c8db0ed4a28e4b112a16adc","_number":681,"virtual_id_number":681,"owner":{"_account_id":1000030,"name":"Max Fillinger","email":"max@max-fillinger.net","username":"MaxF"},"actions":{},"labels":{"Code-Review":{"approved":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"all":[{"value":0,"_account_id":1000030,"name":"Max Fillinger","email":"max@max-fillinger.net","username":"MaxF"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2024-06-18 12:41:52.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"value":0,"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"_account_id":1000030,"name":"Max Fillinger","email":"max@max-fillinger.net","username":"MaxF"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},{"_account_id":1000039,"name":"comododragon","email":"rein.vanbaaren@fox-it.com","username":"comododragon"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-06-13 09:35:20.000000000","updated_by":{"_account_id":1000030,"name":"Max Fillinger","email":"max@max-fillinger.net","username":"MaxF"},"real_updated_by":{"_account_id":1000030,"name":"Max Fillinger","email":"max@max-fillinger.net","username":"MaxF"},"reviewer":{"_account_id":1000039,"name":"comododragon","email":"rein.vanbaaren@fox-it.com","username":"comododragon"},"state":"CC"},{"updated":"2024-06-13 09:35:21.000000000","updated_by":{"_account_id":1000030,"name":"Max Fillinger","email":"max@max-fillinger.net","username":"MaxF"},"real_updated_by":{"_account_id":1000030,"name":"Max Fillinger","email":"max@max-fillinger.net","username":"MaxF"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2024-06-13 09:35:21.000000000","updated_by":{"_account_id":1000030,"name":"Max Fillinger","email":"max@max-fillinger.net","username":"MaxF"},"real_updated_by":{"_account_id":1000030,"name":"Max Fillinger","email":"max@max-fillinger.net","username":"MaxF"},"reviewer":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"state":"REVIEWER"},{"updated":"2024-06-13 09:35:21.000000000","updated_by":{"_account_id":1000030,"name":"Max Fillinger","email":"max@max-fillinger.net","username":"MaxF"},"real_updated_by":{"_account_id":1000030,"name":"Max Fillinger","email":"max@max-fillinger.net","username":"MaxF"},"reviewer":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"}],"messages":[{"id":"8cfefb0d498b388648a051c56b4aa31e0529d119","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000030,"name":"Max Fillinger","email":"max@max-fillinger.net","username":"MaxF"},"date":"2024-06-13 09:35:20.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"43368917432332876701f8db2568c5f253725161","author":{"_account_id":1000030,"name":"Max Fillinger","email":"max@max-fillinger.net","username":"MaxF"},"date":"2024-06-13 10:46:33.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"0b7b7332da1d8158688125edc7fe164a0a1562a4","author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2024-06-13 13:47:05.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"24b403f5e1c4855c9376ec7d887e6e169aea47b7","author":{"_account_id":1000030,"name":"Max Fillinger","email":"max@max-fillinger.net","username":"MaxF"},"date":"2024-06-13 15:43:07.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"cc365d1265fdd3bb18fe4b8c8a2c8e5f30285078","author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2024-06-13 19:44:42.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"a983c39ee1a1ae3877039099a7f2cd265551300e","author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2024-06-13 19:46:59.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"660cea6277b4d4c123406472a1f89e7b76496533","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000030,"name":"Max Fillinger","email":"max@max-fillinger.net","username":"MaxF"},"date":"2024-06-14 11:34:34.000000000","message":"Uploaded patch set 2.\n\nOutdated Votes:\n* Code-Review-1 (copy condition: \"changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR is:MIN\")\n","accounts_in_message":[],"_revision_number":2},{"id":"e80b5e5611f881810c1689be0d91e2e7776ca40b","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000030,"name":"Max Fillinger","email":"max@max-fillinger.net","username":"MaxF"},"date":"2024-06-14 12:31:23.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"dc6ed954472707fa09369d346b0715ac6087a802","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000030,"name":"Max Fillinger","email":"max@max-fillinger.net","username":"MaxF"},"date":"2024-06-14 13:14:58.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"3de915b12facf638627cb9180aea772dedf5fb89","author":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2024-06-18 11:54:17.000000000","message":"Patch Set 4: Code-Review+2","accounts_in_message":[],"_revision_number":4},{"id":"d964ea9dde4439185c8db0ed4a28e4b112a16adc","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000030,"name":"Max Fillinger","email":"max@max-fillinger.net","username":"MaxF"},"date":"2024-06-18 12:41:52.000000000","message":"Change has been successfully cherry-picked as 8ff44ad40b9b36a2f92931b7911bee253ebb35f3","accounts_in_message":[],"_revision_number":5}],"current_revision_number":5,"current_revision":"8ff44ad40b9b36a2f92931b7911bee253ebb35f3","revisions":{"fb66c82b7a0cb3803099078e8518974f3580002c":{"kind":"REWORK","_number":1,"created":"2024-06-13 09:35:20.000000000","uploader":{"_account_id":1000030,"name":"Max Fillinger","email":"max@max-fillinger.net","username":"MaxF"},"ref":"refs/changes/81/681/1","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/81/681/1","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/81/681/1 \u0026\u0026 git checkout -b change-681 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/81/681/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/81/681/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/81/681/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/81/681/1","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/81/681/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"13ee7f902f18e27b981f8e440facd2e6515c6c83","subject":"Implement Windows CA template match for Crypto-API selector"}],"author":{"name":"rein.vanbaaren","email":"rein.vanbaaren@fox-it.com","date":"2024-05-30 13:51:27.000000000","tz":120},"committer":{"name":"Max Fillinger","email":"maximilian.fillinger@foxcrypto.com","date":"2024-06-13 09:35:02.000000000","tz":120},"subject":"Fix MBEDTLS_DEPRECATED_REMOVED build errors","message":"Fix MBEDTLS_DEPRECATED_REMOVED build errors\n\nThis commit allows compiling OpenVPN with recent versions of mbed TLS\nif MBEDTLS_DEPRECATED_REMOVED is defined.\n\nAlso disables TLS 1.0 and 1.1 because these are dropped in recent\nversions of mbed TLS.\n\nChange-Id: If96c2ebd2af16b18ed34820e8c0531547e2076d9\nSigned-off-by: Max Fillinger \u003cmaximilian.fillinger@foxcrypto.com\u003e\n"},"branch":"refs/heads/master"},"9739dbe4a670ecf40c3de66dbf8dde9b3fc82cf1":{"kind":"REWORK","_number":2,"created":"2024-06-14 11:34:34.000000000","uploader":{"_account_id":1000030,"name":"Max Fillinger","email":"max@max-fillinger.net","username":"MaxF"},"ref":"refs/changes/81/681/2","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/81/681/2","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/81/681/2 \u0026\u0026 git checkout -b change-681 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/81/681/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/81/681/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/81/681/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/81/681/2","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/81/681/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"94dd46ed3ea775db3b95317c46377aaf98122b18","subject":"mbedtls: Remove support for old TLS versions"}],"author":{"name":"rein.vanbaaren","email":"rein.vanbaaren@fox-it.com","date":"2024-05-30 13:51:27.000000000","tz":120},"committer":{"name":"Max Fillinger","email":"maximilian.fillinger@foxcrypto.com","date":"2024-06-14 11:33:56.000000000","tz":120},"subject":"Fix MBEDTLS_DEPRECATED_REMOVED build errors","message":"Fix MBEDTLS_DEPRECATED_REMOVED build errors\n\nThis commit allows compiling OpenVPN with recent versions of mbed TLS\nif MBEDTLS_DEPRECATED_REMOVED is defined.\n\nChange-Id: If96c2ebd2af16b18ed34820e8c0531547e2076d9\nSigned-off-by: Max Fillinger \u003cmaximilian.fillinger@foxcrypto.com\u003e\n"},"branch":"refs/heads/master"},"4c147f2649be23fe687c04e2e1f4331ecd02ce88":{"kind":"REWORK","_number":3,"created":"2024-06-14 12:31:23.000000000","uploader":{"_account_id":1000030,"name":"Max Fillinger","email":"max@max-fillinger.net","username":"MaxF"},"ref":"refs/changes/81/681/3","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/81/681/3","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/81/681/3 \u0026\u0026 git checkout -b change-681 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/81/681/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/81/681/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/81/681/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/81/681/3","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/81/681/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"94dd46ed3ea775db3b95317c46377aaf98122b18","subject":"mbedtls: Remove support for old TLS versions"}],"author":{"name":"rein.vanbaaren","email":"rein.vanbaaren@fox-it.com","date":"2024-05-30 13:51:27.000000000","tz":120},"committer":{"name":"Max Fillinger","email":"maximilian.fillinger@foxcrypto.com","date":"2024-06-14 12:30:58.000000000","tz":120},"subject":"Fix MBEDTLS_DEPRECATED_REMOVED build errors","message":"Fix MBEDTLS_DEPRECATED_REMOVED build errors\n\nThis commit allows compiling OpenVPN with recent versions of mbed TLS\nif MBEDTLS_DEPRECATED_REMOVED is defined.\n\nChange-Id: If96c2ebd2af16b18ed34820e8c0531547e2076d9\nSigned-off-by: Max Fillinger \u003cmaximilian.fillinger@foxcrypto.com\u003e\n"},"branch":"refs/heads/master"},"8ae7ca34e0522d616330c618745fd73773bf8334":{"kind":"REWORK","_number":4,"created":"2024-06-14 13:14:58.000000000","uploader":{"_account_id":1000030,"name":"Max Fillinger","email":"max@max-fillinger.net","username":"MaxF"},"ref":"refs/changes/81/681/4","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/81/681/4","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/81/681/4 \u0026\u0026 git checkout -b change-681 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/81/681/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/81/681/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/81/681/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/81/681/4","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/81/681/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"c7e1080aaebc4bc7dabfd2861593a4d18e7e0184","subject":"mbedtls: Remove support for old TLS versions"}],"author":{"name":"rein.vanbaaren","email":"rein.vanbaaren@fox-it.com","date":"2024-05-30 13:51:27.000000000","tz":120},"committer":{"name":"Max Fillinger","email":"maximilian.fillinger@foxcrypto.com","date":"2024-06-14 13:13:53.000000000","tz":120},"subject":"Fix MBEDTLS_DEPRECATED_REMOVED build errors","message":"Fix MBEDTLS_DEPRECATED_REMOVED build errors\n\nThis commit allows compiling OpenVPN with recent versions of mbed TLS\nif MBEDTLS_DEPRECATED_REMOVED is defined.\n\nChange-Id: If96c2ebd2af16b18ed34820e8c0531547e2076d9\nSigned-off-by: Max Fillinger \u003cmaximilian.fillinger@foxcrypto.com\u003e\n"},"branch":"refs/heads/master"},"8ff44ad40b9b36a2f92931b7911bee253ebb35f3":{"kind":"NO_CODE_CHANGE","_number":5,"created":"2024-06-18 12:41:52.000000000","uploader":{"_account_id":1000030,"name":"Max Fillinger","email":"max@max-fillinger.net","username":"MaxF"},"ref":"refs/changes/81/681/5","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/81/681/5","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/81/681/5 \u0026\u0026 git checkout -b change-681 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/81/681/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/81/681/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/81/681/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/81/681/5","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/81/681/5 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"02b821daf54dc424a944929d3adc681f80c90300","subject":"mbedtls: Remove support for old TLS versions"}],"author":{"name":"rein.vanbaaren","email":"rein.vanbaaren@fox-it.com","date":"2024-05-30 13:51:27.000000000","tz":120},"committer":{"name":"MaxF","email":"max@max-fillinger.net","date":"2024-06-18 12:41:52.000000000","tz":0},"subject":"Fix MBEDTLS_DEPRECATED_REMOVED build errors","message":"Fix MBEDTLS_DEPRECATED_REMOVED build errors\n\nThis commit allows compiling OpenVPN with recent versions of mbed TLS\nif MBEDTLS_DEPRECATED_REMOVED is defined.\n\nChange-Id: If96c2ebd2af16b18ed34820e8c0531547e2076d9\nSigned-off-by: Max Fillinger \u003cmaximilian.fillinger@foxcrypto.com\u003e\nReviewed-on: http://gerrit.openvpn.net/c/openvpn/+/681\nReviewed-by: plaisthos \u003carne-openvpn@rfc2549.org\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}}]},{"rule_name":"checks~ChecksSubmitRule","status":"CLOSED"}]}
