)]}'
{"id":"openvpn~721","triplet_id":"openvpn~master~I87777e74b1fd34781e1d72c9f994eb84f39d800c","project":"openvpn","branch":"master","topic":"RemovedUnnecessaryRouteInstallations","attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2025-10-21 14:10:18.000000000","reason":"\u003cGERRIT_ACCOUNT_1000040\u003e replied on the change","reason_account":{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"}},"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2024-07-30 09:24:37.000000000","reason":"Reviewer was added"},"1000007":{"account":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"last_update":"2025-10-21 14:10:18.000000000","reason":"\u003cGERRIT_ACCOUNT_1000040\u003e replied on the change","reason_account":{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"}}},"removed_from_attention_set":{"1000040":{"account":{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"},"last_update":"2025-10-21 14:10:18.000000000","reason":"\u003cGERRIT_ACCOUNT_1000040\u003e replied on the change","reason_account":{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"}}},"hashtags":[],"change_id":"I87777e74b1fd34781e1d72c9f994eb84f39d800c","subject":"route: extended logic to omit gateway when unnecessary","status":"NEW","created":"2024-07-30 09:24:36.000000000","updated":"2025-10-21 14:10:18.000000000","submit_type":"CHERRY_PICK","submittable":false,"total_comment_count":15,"unresolved_comment_count":1,"has_review_started":true,"meta_rev_id":"94ac3cf1d06dfa9a8f59f1a8c87efea1c9849242","_number":721,"virtual_id_number":721,"owner":{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"},"actions":{},"labels":{"Code-Review":{"rejected":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"all":[{"value":-2,"date":"2025-10-21 14:05:10.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"default_value":0,"blocking":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-07-30 09:24:37.000000000","updated_by":{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2024-07-30 09:24:37.000000000","updated_by":{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"},"reviewer":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"state":"REVIEWER"},{"updated":"2024-07-30 09:24:37.000000000","updated_by":{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2025-10-14 13:16:06.000000000","updated_by":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"reviewer":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"state":"CC"}],"messages":[{"id":"269c6b66e2f7e8ed2b87c4ae4afb5fc9d074b719","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"},"date":"2024-07-30 09:24:36.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"c93ca7c9b90c6c44be710088f947478979017ffc","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"},"date":"2024-07-30 10:07:59.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.","accounts_in_message":[],"_revision_number":2},{"id":"bb3151aa039014c8586ae352f34e4b706b2755a2","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"},"date":"2024-08-20 12:23:22.000000000","message":"Uploaded patch set 3: Patch Set 2 was rebased.","accounts_in_message":[],"_revision_number":3},{"id":"d73db3e03a3c833f340d339cb38836a38fcc7696","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"},"date":"2024-09-05 13:18:42.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"162186a0cbbb770c6195f78e5d9e8b79e939d8ed","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"},"date":"2024-09-09 15:36:52.000000000","message":"Uploaded patch set 5.","accounts_in_message":[],"_revision_number":5},{"id":"9525ddb1cb6b0fbd798adf6f4f120539e900beb6","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"},"date":"2024-09-12 19:28:59.000000000","message":"Uploaded patch set 6.","accounts_in_message":[],"_revision_number":6},{"id":"95a0ed2a1a4128b968a12ae07079932ee27ad892","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"},"date":"2024-09-12 20:29:56.000000000","message":"Uploaded patch set 7: Patch Set 6 was rebased.","accounts_in_message":[],"_revision_number":7},{"id":"5581879e83cb9ef30b4af8fe12bd08a67cce48e0","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"},"date":"2024-09-19 12:54:55.000000000","message":"Uploaded patch set 8.","accounts_in_message":[],"_revision_number":8},{"id":"d514beb15a1493f39e78bf9ac849172a368301ed","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"},"date":"2024-09-19 15:31:54.000000000","message":"Uploaded patch set 9.","accounts_in_message":[],"_revision_number":9},{"id":"e1349a34fbb38a814b98ff3bf91ea54b010ac9eb","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"},"date":"2025-01-26 23:43:57.000000000","message":"Uploaded patch set 10.","accounts_in_message":[],"_revision_number":10},{"id":"a1c60683cc58cce060fe7aab744847953498c903","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"},"date":"2025-01-27 17:39:48.000000000","message":"Uploaded patch set 11.","accounts_in_message":[],"_revision_number":11},{"id":"fb0f931caece514d3dffc45e349702ae2b635a24","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2025-10-13 15:01:15.000000000","message":"Patch Set 11: Code-Review-2\n\n(7 comments)","accounts_in_message":[],"_revision_number":11},{"id":"53c0d542602b3a3b0ff5807d4327ef86f565cec1","author":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"date":"2025-10-14 13:16:06.000000000","message":"Patch Set 11:\n\n(1 comment)","accounts_in_message":[],"_revision_number":11},{"id":"95a7fb9ab0253cd530c1928e2c8078a873d19c8b","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2025-10-14 13:54:46.000000000","message":"Patch Set 11:\n\n(1 comment)","accounts_in_message":[],"_revision_number":11},{"id":"b61627a6562641cde2b4c78d367e596b0750013f","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"},"date":"2025-10-21 14:05:10.000000000","message":"Uploaded patch set 12.\n\nCopied Votes:\n* Code-Review-2 (copy condition: \"changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR **is:MIN**\")\n","accounts_in_message":[],"_revision_number":12},{"id":"94ac3cf1d06dfa9a8f59f1a8c87efea1c9849242","author":{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"},"date":"2025-10-21 14:10:18.000000000","message":"Patch Set 12:\n\n(6 comments)","accounts_in_message":[],"_revision_number":12}],"current_revision_number":12,"current_revision":"7e2a942cad3a48c8a67fbd399155ce8b19dc9db8","revisions":{"cafa48bd51ffaf181364723e75db34bb6415eabc":{"kind":"REWORK","_number":1,"created":"2024-07-30 09:24:36.000000000","uploader":{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"},"ref":"refs/changes/21/721/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/21/721/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/21/721/1 \u0026\u0026 git checkout -b change-721 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/21/721/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/21/721/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/21/721/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/21/721/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/21/721/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"05938333d803d3d638764965e0590e362135470f","subject":"route: copied \u0027gateway_needed\u0027 logic from add_route_ipv6 to add_route"}],"author":{"name":"Marco Baffo","email":"marco@mandelbit.com","date":"2024-07-30 08:59:16.000000000","tz":120},"committer":{"name":"Marco Baffo","email":"marco@mandelbit.com","date":"2024-07-30 08:59:16.000000000","tz":120},"subject":"    route: extended logic to omit gateway when unnecessary","message":"    route: extended logic to omit gateway when unnecessary\n\n    Extracted and extended the logic behind \u0027gateway_needed\u0027 both in\n    add_route() and add_route_ipv6(). Other than checking the dev-type,\n    special routes and if the gateway is on-link,\n    - set gateway_needed to true if the vpn instance is a multipoint server\n      and DCO is enabled.\n    - set gateway_needed to false if the gateway is in the vpn subnet.\n    Additionally, extended support for these checks and conditions to DARWIN\n    and BSD-based operating systems.\n\n    These changes ensure that the gateway is only included when necessary,\n    optimizing route configuration and potentially reducing redundant route entries.\n\nChange-Id: I87777e74b1fd34781e1d72c9f994eb84f39d800c\nSigned-off-by: Marco Baffo \u003cmarco@mandelbit.com\u003e\n"},"branch":"refs/heads/master"},"feb54fab6ca9e59f7393559b57f1ff359ec0cee5":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2024-07-30 10:07:59.000000000","uploader":{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"},"ref":"refs/changes/21/721/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/21/721/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/21/721/2 \u0026\u0026 git checkout -b change-721 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/21/721/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/21/721/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/21/721/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/21/721/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/21/721/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"28157bce1ebaa56b36d64a114759f84b08a1b273","subject":"route: copied \u0027gateway_needed\u0027 logic from add_route_ipv6 to add_route"}],"author":{"name":"Marco Baffo","email":"marco@mandelbit.com","date":"2024-07-30 08:59:16.000000000","tz":120},"committer":{"name":"Marco Baffo","email":"marco@mandelbit.com","date":"2024-07-30 09:47:55.000000000","tz":120},"subject":"    route: extended logic to omit gateway when unnecessary","message":"    route: extended logic to omit gateway when unnecessary\n\n    Extracted and extended the logic behind \u0027gateway_needed\u0027 both in\n    add_route() and add_route_ipv6(). Other than checking the dev-type,\n    special routes and if the gateway is on-link,\n    - set gateway_needed to true if the vpn instance is a multipoint server\n      and DCO is enabled.\n    - set gateway_needed to false if the gateway is in the vpn subnet.\n    Additionally, extended support for these checks and conditions to DARWIN\n    and BSD-based operating systems.\n\n    These changes ensure that the gateway is only included when necessary,\n    optimizing route configuration and potentially reducing redundant route entries.\n\nChange-Id: I87777e74b1fd34781e1d72c9f994eb84f39d800c\nSigned-off-by: Marco Baffo \u003cmarco@mandelbit.com\u003e\n"},"branch":"refs/heads/master"},"a569614c7cae5a77fb7cad2a92b2c459bccdfc60":{"kind":"TRIVIAL_REBASE","_number":3,"created":"2024-08-20 12:23:22.000000000","uploader":{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"},"ref":"refs/changes/21/721/3","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/21/721/3","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/21/721/3 \u0026\u0026 git checkout -b change-721 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/21/721/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/21/721/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/21/721/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/21/721/3","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/21/721/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"615b37626691bdcfe20ab9b6895c32327ca86379","subject":"route: copied \u0027gateway_needed\u0027 logic from add_route_ipv6 to add_route"}],"author":{"name":"Marco Baffo","email":"marco@mandelbit.com","date":"2024-07-30 08:59:16.000000000","tz":120},"committer":{"name":"Marco Baffo","email":"marco@mandelbit.com","date":"2024-08-20 07:52:26.000000000","tz":120},"subject":"    route: extended logic to omit gateway when unnecessary","message":"    route: extended logic to omit gateway when unnecessary\n\n    Extracted and extended the logic behind \u0027gateway_needed\u0027 both in\n    add_route() and add_route_ipv6(). Other than checking the dev-type,\n    special routes and if the gateway is on-link,\n    - set gateway_needed to true if the vpn instance is a multipoint server\n      and DCO is enabled.\n    - set gateway_needed to false if the gateway is in the vpn subnet.\n    Additionally, extended support for these checks and conditions to DARWIN\n    and BSD-based operating systems.\n\n    These changes ensure that the gateway is only included when necessary,\n    optimizing route configuration and potentially reducing redundant route entries.\n\nChange-Id: I87777e74b1fd34781e1d72c9f994eb84f39d800c\nSigned-off-by: Marco Baffo \u003cmarco@mandelbit.com\u003e\n"},"branch":"refs/heads/master"},"9276731ee3094b334967264f9305e9109095c035":{"kind":"REWORK","_number":4,"created":"2024-09-05 13:18:42.000000000","uploader":{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"},"ref":"refs/changes/21/721/4","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/21/721/4","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/21/721/4 \u0026\u0026 git checkout -b change-721 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/21/721/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/21/721/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/21/721/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/21/721/4","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/21/721/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"68eafba9b0166ce631b3589d20e5d47d0b75ab2b","subject":"route: copied \u0027gateway_needed\u0027 logic from add_route_ipv6 to add_route"}],"author":{"name":"Marco Baffo","email":"marco@mandelbit.com","date":"2024-07-30 08:59:16.000000000","tz":120},"committer":{"name":"Marco Baffo","email":"marco@mandelbit.com","date":"2024-09-05 13:10:54.000000000","tz":120},"subject":"    route: extended logic to omit gateway when unnecessary","message":"    route: extended logic to omit gateway when unnecessary\n\n    Extracted and extended the logic behind \u0027gateway_needed\u0027 both in\n    add_route() and add_route_ipv6(). Other than checking the dev-type,\n    special routes and if the gateway is on-link,\n    - set gateway_needed to true if the vpn instance is a multipoint server\n      and DCO is enabled.\n    - set gateway_needed to false if the gateway is in the vpn subnet.\n    Additionally, extended support for these checks and conditions to DARWIN\n    and BSD-based operating systems.\n\n    These changes ensure that the gateway is only included when necessary,\n    optimizing route configuration and potentially reducing redundant route entries.\n\nChange-Id: I87777e74b1fd34781e1d72c9f994eb84f39d800c\nSigned-off-by: Marco Baffo \u003cmarco@mandelbit.com\u003e\n"},"branch":"refs/heads/master"},"50059abf51647b670134f15693eda4db4a4b54f9":{"kind":"REWORK","_number":5,"created":"2024-09-09 15:36:52.000000000","uploader":{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"},"ref":"refs/changes/21/721/5","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/21/721/5","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/21/721/5 \u0026\u0026 git checkout -b change-721 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/21/721/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/21/721/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/21/721/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/21/721/5","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/21/721/5 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"d3fb46adb896e93166cc6be56c66d95d7eee6086","subject":"route: copied \u0027gateway_needed\u0027 logic from add_route_ipv6 to add_route"}],"author":{"name":"Marco Baffo","email":"marco@mandelbit.com","date":"2024-07-30 08:59:16.000000000","tz":120},"committer":{"name":"Marco Baffo","email":"marco@mandelbit.com","date":"2024-09-09 15:31:00.000000000","tz":120},"subject":"    route: extended logic to omit gateway when unnecessary","message":"    route: extended logic to omit gateway when unnecessary\n\n    Extracted and extended the logic behind \u0027gateway_needed\u0027 both in\n    add_route() and add_route_ipv6(). Other than checking the dev-type,\n    special routes and if the gateway is on-link,\n    - set gateway_needed to true if the vpn instance is a multipoint server\n      and DCO is enabled.\n    - set gateway_needed to false if the gateway is in the vpn subnet.\n    Additionally, extended support for these checks and conditions to DARWIN\n    and BSD-based operating systems.\n\n    These changes ensure that the gateway is only included when necessary,\n    optimizing route configuration and potentially reducing redundant route entries.\n\nChange-Id: I87777e74b1fd34781e1d72c9f994eb84f39d800c\nSigned-off-by: Marco Baffo \u003cmarco@mandelbit.com\u003e\n"},"branch":"refs/heads/master"},"367ecdc5a5b61e448deb99a5b5bca04fe56c4880":{"kind":"REWORK","_number":6,"created":"2024-09-12 19:28:59.000000000","uploader":{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"},"ref":"refs/changes/21/721/6","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/21/721/6","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/21/721/6 \u0026\u0026 git checkout -b change-721 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/21/721/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/21/721/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/21/721/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/21/721/6","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/21/721/6 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"31e2896c1789da86ff6c3bae9dae229ae05ff29a","subject":"route: copied \u0027gateway_needed\u0027 logic from add_route_ipv6 to add_route"}],"author":{"name":"Marco Baffo","email":"marco@mandelbit.com","date":"2024-07-30 08:59:16.000000000","tz":120},"committer":{"name":"Marco Baffo","email":"marco@mandelbit.com","date":"2024-09-12 19:24:02.000000000","tz":120},"subject":"    route: extended logic to omit gateway when unnecessary","message":"    route: extended logic to omit gateway when unnecessary\n\n    Extracted and extended the logic behind \u0027gateway_needed\u0027 both in\n    add_route() and add_route_ipv6(). Other than checking the dev-type,\n    special routes and if the gateway is on-link,\n    - set gateway_needed to true if the vpn instance is a multipoint server\n      and DCO is enabled.\n    - set gateway_needed to false if the gateway is in the vpn subnet.\n    Additionally, extended support for these checks and conditions to DARWIN\n    and BSD-based operating systems.\n\n    These changes ensure that the gateway is only included when necessary,\n    optimizing route configuration and potentially reducing redundant route entries.\n\nChange-Id: I87777e74b1fd34781e1d72c9f994eb84f39d800c\nSigned-off-by: Marco Baffo \u003cmarco@mandelbit.com\u003e\n"},"branch":"refs/heads/master"},"c128adb710edfbfa9007eb1edbd5eca49f0cdf0e":{"kind":"TRIVIAL_REBASE","_number":7,"created":"2024-09-12 20:29:56.000000000","uploader":{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"},"ref":"refs/changes/21/721/7","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/21/721/7","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/21/721/7 \u0026\u0026 git checkout -b change-721 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/21/721/7 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/21/721/7 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/21/721/7 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/21/721/7","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/21/721/7 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"e50c75828e92ece944a136ccfaad31a9d170d122","subject":"route: copied \u0027gateway_needed\u0027 logic from add_route_ipv6 to add_route"}],"author":{"name":"Marco Baffo","email":"marco@mandelbit.com","date":"2024-07-30 08:59:16.000000000","tz":120},"committer":{"name":"Marco Baffo","email":"marco@mandelbit.com","date":"2024-09-12 20:25:48.000000000","tz":120},"subject":"    route: extended logic to omit gateway when unnecessary","message":"    route: extended logic to omit gateway when unnecessary\n\n    Extracted and extended the logic behind \u0027gateway_needed\u0027 both in\n    add_route() and add_route_ipv6(). Other than checking the dev-type,\n    special routes and if the gateway is on-link,\n    - set gateway_needed to true if the vpn instance is a multipoint server\n      and DCO is enabled.\n    - set gateway_needed to false if the gateway is in the vpn subnet.\n    Additionally, extended support for these checks and conditions to DARWIN\n    and BSD-based operating systems.\n\n    These changes ensure that the gateway is only included when necessary,\n    optimizing route configuration and potentially reducing redundant route entries.\n\nChange-Id: I87777e74b1fd34781e1d72c9f994eb84f39d800c\nSigned-off-by: Marco Baffo \u003cmarco@mandelbit.com\u003e\n"},"branch":"refs/heads/master"},"d35a74d01aca37517ecf4ed797c96429fa1a476c":{"kind":"REWORK","_number":8,"created":"2024-09-19 12:54:55.000000000","uploader":{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"},"ref":"refs/changes/21/721/8","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/21/721/8","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/21/721/8 \u0026\u0026 git checkout -b change-721 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/21/721/8 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/21/721/8 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/21/721/8 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/21/721/8","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/21/721/8 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"f1b851a1de1a374ae289d70bc1e34e9af64265b1","subject":"route: copied \u0027gateway_needed\u0027 logic from add_route_ipv6 to add_route"}],"author":{"name":"Marco Baffo","email":"marco@mandelbit.com","date":"2024-07-30 08:59:16.000000000","tz":120},"committer":{"name":"Marco Baffo","email":"marco@mandelbit.com","date":"2024-09-19 12:51:49.000000000","tz":120},"subject":"    route: extended logic to omit gateway when unnecessary","message":"    route: extended logic to omit gateway when unnecessary\n\n    Extracted and extended the logic behind \u0027gateway_needed\u0027 both in\n    add_route() and add_route_ipv6(). Other than checking the dev-type,\n    special routes and if the gateway is on-link,\n    - set gateway_needed to true if the vpn instance is a multipoint server\n      and DCO is enabled.\n    - set gateway_needed to false if the gateway is in the vpn subnet.\n    Additionally, extended support for these checks and conditions to DARWIN\n    and BSD-based operating systems.\n\n    These changes ensure that the gateway is only included when necessary,\n    optimizing route configuration and potentially reducing redundant route entries.\n\nChange-Id: I87777e74b1fd34781e1d72c9f994eb84f39d800c\nSigned-off-by: Marco Baffo \u003cmarco@mandelbit.com\u003e\n"},"branch":"refs/heads/master"},"c2f3d5d1f6416137eec128af14ca2388b3dfcbe5":{"kind":"REWORK","_number":9,"created":"2024-09-19 15:31:54.000000000","uploader":{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"},"ref":"refs/changes/21/721/9","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/21/721/9","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/21/721/9 \u0026\u0026 git checkout -b change-721 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/21/721/9 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/21/721/9 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/21/721/9 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/21/721/9","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/21/721/9 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"f1b851a1de1a374ae289d70bc1e34e9af64265b1","subject":"route: copied \u0027gateway_needed\u0027 logic from add_route_ipv6 to add_route"}],"author":{"name":"Marco Baffo","email":"marco@mandelbit.com","date":"2024-07-30 08:59:16.000000000","tz":120},"committer":{"name":"Marco Baffo","email":"marco@mandelbit.com","date":"2024-09-19 15:10:05.000000000","tz":120},"subject":"    route: extended logic to omit gateway when unnecessary","message":"    route: extended logic to omit gateway when unnecessary\n\n    Extracted and extended the logic behind \u0027gateway_needed\u0027 both in\n    add_route() and add_route_ipv6(). Other than checking the dev-type,\n    special routes and if the gateway is on-link,\n    - set gateway_needed to true if the vpn instance is a multipoint server\n      and DCO is enabled.\n    - set gateway_needed to false if the gateway is in the vpn subnet.\n    Additionally, extended support for these checks and conditions to DARWIN\n    and BSD-based operating systems.\n\n    These changes ensure that the gateway is only included when necessary,\n    optimizing route configuration and potentially reducing redundant route entries.\n\nChange-Id: I87777e74b1fd34781e1d72c9f994eb84f39d800c\nSigned-off-by: Marco Baffo \u003cmarco@mandelbit.com\u003e\n"},"branch":"refs/heads/master"},"d64ab6257fe78da955ad1c7d320a54da90d8e1d6":{"kind":"REWORK","_number":10,"created":"2025-01-26 23:43:57.000000000","uploader":{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"},"ref":"refs/changes/21/721/10","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/21/721/10","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/21/721/10 \u0026\u0026 git checkout -b change-721 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/21/721/10 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/21/721/10 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/21/721/10 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/21/721/10","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/21/721/10 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"8d7f501d1b45820f4a77c49a5ee082ee0a3f1bb4","subject":"route: copied \u0027gateway_needed\u0027 logic from add_route_ipv6 to add_route"}],"author":{"name":"Marco Baffo","email":"marco@mandelbit.com","date":"2024-07-30 08:59:16.000000000","tz":120},"committer":{"name":"Marco Baffo","email":"marco@mandelbit.com","date":"2025-01-26 23:38:09.000000000","tz":60},"subject":"    route: extended logic to omit gateway when unnecessary","message":"    route: extended logic to omit gateway when unnecessary\n\n    Extracted and extended the logic behind \u0027gateway_needed\u0027 both in\n    add_route() and add_route_ipv6(). Other than checking the dev-type,\n    special routes and if the gateway is on-link,\n    - set gateway_needed to true if the vpn instance is a multipoint server\n      and DCO is enabled.\n    - set gateway_needed to false if the gateway is in the vpn subnet.\n    Additionally, extended support for these checks and conditions to DARWIN\n    and BSD-based operating systems.\n\n    These changes ensure that the gateway is only included when necessary,\n    optimizing route configuration and potentially reducing redundant route entries.\n\nChange-Id: I87777e74b1fd34781e1d72c9f994eb84f39d800c\nSigned-off-by: Marco Baffo \u003cmarco@mandelbit.com\u003e\n"},"branch":"refs/heads/master"},"0282e0a534a54534fc6b361371f920b584a1e3b5":{"kind":"REWORK","_number":11,"created":"2025-01-27 17:39:48.000000000","uploader":{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"},"ref":"refs/changes/21/721/11","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/21/721/11","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/21/721/11 \u0026\u0026 git checkout -b change-721 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/21/721/11 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/21/721/11 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/21/721/11 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/21/721/11","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/21/721/11 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"8d7f501d1b45820f4a77c49a5ee082ee0a3f1bb4","subject":"route: copied \u0027gateway_needed\u0027 logic from add_route_ipv6 to add_route"}],"author":{"name":"Marco Baffo","email":"marco@mandelbit.com","date":"2024-07-30 08:59:16.000000000","tz":120},"committer":{"name":"Marco Baffo","email":"marco@mandelbit.com","date":"2025-01-27 09:46:49.000000000","tz":60},"subject":"    route: extended logic to omit gateway when unnecessary","message":"    route: extended logic to omit gateway when unnecessary\n\n    Extracted and extended the logic behind \u0027gateway_needed\u0027 both in\n    add_route() and add_route_ipv6(). Other than checking the dev-type,\n    special routes and if the gateway is on-link,\n    - set gateway_needed to true if the vpn instance is a multipoint server\n      and DCO is enabled.\n    - set gateway_needed to false if the gateway is in the vpn subnet.\n    Additionally, extended support for these checks and conditions to DARWIN\n    and BSD-based operating systems.\n\n    These changes ensure that the gateway is only included when necessary,\n    optimizing route configuration and potentially reducing redundant route entries.\n\nChange-Id: I87777e74b1fd34781e1d72c9f994eb84f39d800c\nSigned-off-by: Marco Baffo \u003cmarco@mandelbit.com\u003e\n"},"branch":"refs/heads/master"},"7e2a942cad3a48c8a67fbd399155ce8b19dc9db8":{"kind":"REWORK","_number":12,"created":"2025-10-21 14:05:10.000000000","uploader":{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"},"ref":"refs/changes/21/721/12","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/21/721/12","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/21/721/12 \u0026\u0026 git checkout -b change-721 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/21/721/12 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/21/721/12 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/21/721/12 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/21/721/12","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/21/721/12 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"2b7ac8fdcb1e0c57e98f61bd08c9e36e26051ea2","subject":"route: copied \u0027gateway_needed\u0027 logic from add_route_ipv6 to add_route"}],"author":{"name":"Marco Baffo","email":"marco@mandelbit.com","date":"2024-07-30 08:59:16.000000000","tz":120},"committer":{"name":"Marco Baffo","email":"marco@mandelbit.com","date":"2025-10-20 14:14:57.000000000","tz":120},"subject":"route: extended logic to omit gateway when unnecessary","message":"route: extended logic to omit gateway when unnecessary\n\nExtracted and extended the logic behind gateway_needed both in\nadd_route() and add_route_ipv6(). Checking dev-type, special\nroutes, if the gateway is on-link and if the gateway is in the\nvpn subnet. Additionally, extended support for these checks and\nconditions to DARWIN and BSD-based operating systems.\n\nThese changes ensure that the gateway is only included when\nnecessary, optimizing route configuration and potentially\nreducing redundant route entries.\n\nAdditionally, Dragonfly\u0027s do_ifconfig_ipv4() code is now shared\nwith NetBSD\u0027s, rather than FreeBSD\u0027s.\n\nChange-Id: I87777e74b1fd34781e1d72c9f994eb84f39d800c\nSigned-off-by: Marco Baffo \u003cmarco@mandelbit.com\u003e\n"},"branch":"refs/heads/master"}},"requirements":[{"status":"NOT_READY","fallback_text":"All required checks must pass","type":"checks_pass"}],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"NOT_READY","labels":[{"label":"Code-Review","status":"REJECT","applied_by":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}}]},{"rule_name":"checks~ChecksSubmitRule","status":"NOT_READY","requirements":[{"status":"NOT_READY","fallback_text":"All required checks must pass","type":"checks_pass"}]}],"submit_requirements":[{"name":"Code-Review","status":"UNSATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"]}},{"name":"checks~ChecksSubmitRule","status":"UNSATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"rule:checks~ChecksSubmitRule","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["checks~ChecksSubmitRule"]}}]}