)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"533877662b876dc204243bbf8f905288bf5ab67d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"db818930_f0bb0e56","updated":"2024-08-16 10:23:27.000000000","message":"Did not do any tests, but code LGTM","commit_id":"a9d38cd6c3c2c587fa682716c56bf3856e91e726"}],"src/openvpn/dco_freebsd.c":[{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"fabf923d6d0d219a9e67f3746658d8238253db92","unresolved":true,"context_lines":[{"line_number":421,"context_line":"    nvlist_t *nvl;"},{"line_number":422,"context_line":"    int ret;"},{"line_number":423,"context_line":""},{"line_number":424,"context_line":"    msg(D_DCO_DEBUG, \"%s: slot %d, key-id %d, peer-id %d, cipher %s, co_flags %d\","},{"line_number":425,"context_line":"        __func__, slot, keyid, peerid, ciphername, co_flags);"},{"line_number":426,"context_line":""},{"line_number":427,"context_line":"    nvl \u003d nvlist_create(0);"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"a79e147a_2242a84e","line":424,"range":{"start_line":424,"start_character":26,"end_line":424,"end_character":30},"updated":"2024-08-15 12:36:37.000000000","message":"Now that you changed the type of co_flags, change to %u here.","commit_id":"6c6222d2ec1517cafc864ee77669de8d150f04c6"},{"author":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"change_message_id":"bc1adc28d20892ede45f2f8ec19e1c26218039a3","unresolved":false,"context_lines":[{"line_number":421,"context_line":"    nvlist_t *nvl;"},{"line_number":422,"context_line":"    int ret;"},{"line_number":423,"context_line":""},{"line_number":424,"context_line":"    msg(D_DCO_DEBUG, \"%s: slot %d, key-id %d, peer-id %d, cipher %s, co_flags %d\","},{"line_number":425,"context_line":"        __func__, slot, keyid, peerid, ciphername, co_flags);"},{"line_number":426,"context_line":""},{"line_number":427,"context_line":"    nvl \u003d nvlist_create(0);"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"9a9c8f46_7e8280b1","line":424,"range":{"start_line":424,"start_character":26,"end_line":424,"end_character":30},"in_reply_to":"a79e147a_2242a84e","updated":"2024-08-16 07:50:09.000000000","message":"Acknowledged","commit_id":"6c6222d2ec1517cafc864ee77669de8d150f04c6"}],"src/openvpn/dco_internal.h":[{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"0a28354817789b7db797312bda2672bae74f0e59","unresolved":true,"context_lines":[{"line_number":70,"context_line":"                dco_key_slot_t slot,"},{"line_number":71,"context_line":"                const uint8_t *encrypt_key, const uint8_t *encrypt_iv,"},{"line_number":72,"context_line":"                const uint8_t *decrypt_key, const uint8_t *decrypt_iv,"},{"line_number":73,"context_line":"                const char *ciphername, int co_flags);"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"int dco_del_key(dco_context_t *dco, unsigned int peerid, dco_key_slot_t slot);"},{"line_number":76,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":1,"id":"7e5142c3_63158acd","line":73,"updated":"2024-08-14 13:29:25.000000000","message":"crypto_options.flags is an unsigned int, so this argument should be as well.","commit_id":"c2f19403d691089ae4ca93f76ec63f29305110ba"},{"author":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"change_message_id":"6f553ff4a48f152ab736cfb4c2dcd8b914a98f58","unresolved":false,"context_lines":[{"line_number":70,"context_line":"                dco_key_slot_t slot,"},{"line_number":71,"context_line":"                const uint8_t *encrypt_key, const uint8_t *encrypt_iv,"},{"line_number":72,"context_line":"                const uint8_t *decrypt_key, const uint8_t *decrypt_iv,"},{"line_number":73,"context_line":"                const char *ciphername, int co_flags);"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"int dco_del_key(dco_context_t *dco, unsigned int peerid, dco_key_slot_t slot);"},{"line_number":76,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":1,"id":"93d63bc2_60bc96e8","line":73,"in_reply_to":"7e5142c3_63158acd","updated":"2024-08-15 12:34:02.000000000","message":"Acknowledged","commit_id":"c2f19403d691089ae4ca93f76ec63f29305110ba"}],"src/openvpn/dco_linux.c":[{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"fabf923d6d0d219a9e67f3746658d8238253db92","unresolved":true,"context_lines":[{"line_number":559,"context_line":"            const uint8_t *decrypt_key, const uint8_t *decrypt_iv,"},{"line_number":560,"context_line":"            const char *ciphername, unsigned int co_flags)"},{"line_number":561,"context_line":"{"},{"line_number":562,"context_line":"    msg(D_DCO_DEBUG, \"%s: slot %d, key-id %d, peer-id %d, cipher %s, co_flags %d\","},{"line_number":563,"context_line":"        __func__, slot, keyid, peerid, ciphername, co_flags);"},{"line_number":564,"context_line":""},{"line_number":565,"context_line":"    const size_t key_len \u003d cipher_kt_key_size(ciphername);"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"e9388cee_92854160","line":562,"range":{"start_line":562,"start_character":58,"end_line":562,"end_character":64},"updated":"2024-08-15 12:36:37.000000000","message":"%u","commit_id":"6c6222d2ec1517cafc864ee77669de8d150f04c6"},{"author":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"change_message_id":"bc1adc28d20892ede45f2f8ec19e1c26218039a3","unresolved":false,"context_lines":[{"line_number":559,"context_line":"            const uint8_t *decrypt_key, const uint8_t *decrypt_iv,"},{"line_number":560,"context_line":"            const char *ciphername, unsigned int co_flags)"},{"line_number":561,"context_line":"{"},{"line_number":562,"context_line":"    msg(D_DCO_DEBUG, \"%s: slot %d, key-id %d, peer-id %d, cipher %s, co_flags %d\","},{"line_number":563,"context_line":"        __func__, slot, keyid, peerid, ciphername, co_flags);"},{"line_number":564,"context_line":""},{"line_number":565,"context_line":"    const size_t key_len \u003d cipher_kt_key_size(ciphername);"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"247ef563_cc761d89","line":562,"range":{"start_line":562,"start_character":58,"end_line":562,"end_character":64},"in_reply_to":"e9388cee_92854160","updated":"2024-08-16 07:50:09.000000000","message":"Acknowledged","commit_id":"6c6222d2ec1517cafc864ee77669de8d150f04c6"}],"src/openvpn/dco_win.c":[{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"fabf923d6d0d219a9e67f3746658d8238253db92","unresolved":true,"context_lines":[{"line_number":337,"context_line":"            const uint8_t *decrypt_key, const uint8_t *decrypt_iv,"},{"line_number":338,"context_line":"            const char *ciphername, unsigned int co_flags)"},{"line_number":339,"context_line":"{"},{"line_number":340,"context_line":"    msg(D_DCO_DEBUG, \"%s: slot %d, key-id %d, peer-id %d, cipher %s, co_flags %d\","},{"line_number":341,"context_line":"        __func__, slot, keyid, peerid, ciphername, co_flags);"},{"line_number":342,"context_line":""},{"line_number":343,"context_line":"    const int nonce_len \u003d 8;"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"bc8d5955_1befe0c2","line":340,"range":{"start_line":340,"start_character":58,"end_line":340,"end_character":64},"updated":"2024-08-15 12:36:37.000000000","message":"%u","commit_id":"6c6222d2ec1517cafc864ee77669de8d150f04c6"},{"author":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"change_message_id":"bc1adc28d20892ede45f2f8ec19e1c26218039a3","unresolved":false,"context_lines":[{"line_number":337,"context_line":"            const uint8_t *decrypt_key, const uint8_t *decrypt_iv,"},{"line_number":338,"context_line":"            const char *ciphername, unsigned int co_flags)"},{"line_number":339,"context_line":"{"},{"line_number":340,"context_line":"    msg(D_DCO_DEBUG, \"%s: slot %d, key-id %d, peer-id %d, cipher %s, co_flags %d\","},{"line_number":341,"context_line":"        __func__, slot, keyid, peerid, ciphername, co_flags);"},{"line_number":342,"context_line":""},{"line_number":343,"context_line":"    const int nonce_len \u003d 8;"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"21a09686_6d384129","line":340,"range":{"start_line":340,"start_character":58,"end_line":340,"end_character":64},"in_reply_to":"bc8d5955_1befe0c2","updated":"2024-08-16 07:50:09.000000000","message":"Acknowledged","commit_id":"6c6222d2ec1517cafc864ee77669de8d150f04c6"}]}