)]}'
{"id":"openvpn~725","triplet_id":"openvpn~master~I2e0c50d33f8a57c023120cf348f95d34acbfcde5","project":"openvpn","branch":"master","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2025-01-23 10:22:18.000000000","reason":"Change was abandoned"},"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2024-08-16 10:23:27.000000000","reason":"\u003cGERRIT_ACCOUNT_1000001\u003e replied on the change","reason_account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}},"1000008":{"account":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"last_update":"2025-01-23 10:22:18.000000000","reason":"Change was abandoned"}},"hashtags":[],"change_id":"I2e0c50d33f8a57c023120cf348f95d34acbfcde5","subject":"dco-win: support for data_v3 features","status":"ABANDONED","created":"2024-08-13 12:00:12.000000000","updated":"2025-01-23 10:22:18.000000000","total_comment_count":9,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"7710549a570240fea390adbc3677f9c4f4dbe1d5","_number":725,"virtual_id_number":725,"owner":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"actions":{},"labels":{"Code-Review":{"approved":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"all":[{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"value":2,"date":"2024-08-16 10:23:27.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-08-13 12:00:13.000000000","updated_by":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2024-08-13 12:00:13.000000000","updated_by":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"reviewer":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"state":"REVIEWER"},{"updated":"2024-08-13 12:00:13.000000000","updated_by":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"}],"messages":[{"id":"2eefb4fe8355218e0033f8830e69863ceb906cf7","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"date":"2024-08-13 12:00:12.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"0a28354817789b7db797312bda2672bae74f0e59","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2024-08-14 13:29:25.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"295e9d26994c3a18991bff573774e5aa2819fd5c","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"date":"2024-08-15 12:33:32.000000000","message":"Uploaded patch set 2.\n\nOutdated Votes:\n* Code-Review-1 (copy condition: \"changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR is:MIN\")\n","accounts_in_message":[],"_revision_number":2},{"id":"6f553ff4a48f152ab736cfb4c2dcd8b914a98f58","author":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"date":"2024-08-15 12:34:02.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"fabf923d6d0d219a9e67f3746658d8238253db92","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2024-08-15 12:36:37.000000000","message":"Patch Set 2: Code-Review-1\n\n(3 comments)","accounts_in_message":[],"_revision_number":2},{"id":"91d9e6d99037eb6428d9d0aefb1b91f76cca9867","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"date":"2024-08-15 14:11:31.000000000","message":"Uploaded patch set 3.\n\nOutdated Votes:\n* Code-Review-1 (copy condition: \"changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR is:MIN\")\n","accounts_in_message":[],"_revision_number":3},{"id":"bc1adc28d20892ede45f2f8ec19e1c26218039a3","author":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"date":"2024-08-16 07:50:09.000000000","message":"Patch Set 3:\n\n(3 comments)","accounts_in_message":[],"_revision_number":3},{"id":"533877662b876dc204243bbf8f905288bf5ab67d","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2024-08-16 10:23:27.000000000","message":"Patch Set 3: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"7710549a570240fea390adbc3677f9c4f4dbe1d5","tag":"autogenerated:gerrit:abandon","author":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"date":"2025-01-23 10:22:18.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"a9d38cd6c3c2c587fa682716c56bf3856e91e726","revisions":{"c2f19403d691089ae4ca93f76ec63f29305110ba":{"kind":"REWORK","_number":1,"created":"2024-08-13 12:00:12.000000000","uploader":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"ref":"refs/changes/25/725/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/25/725/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/25/725/1 \u0026\u0026 git checkout -b change-725 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/25/725/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/25/725/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/25/725/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/25/725/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/25/725/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"88328c521930b24c886dfbe60b875676e673d729","subject":"Implement support for larger packet counter sizes"}],"author":{"name":"Lev Stipakov","email":"lev@openvpn.net","date":"2024-08-13 10:42:12.000000000","tz":180},"committer":{"name":"Lev Stipakov","email":"lev@openvpn.net","date":"2024-08-13 11:42:41.000000000","tz":180},"subject":"dco-win: support for data_v3 features","message":"dco-win: support for data_v3 features\n\nSince version 1.4, dco-win drivere supports data_v3 features\nsuch as:\n\n - AEAD tag at the end\n - 64bit pktid\n\nWe have to:\n\n - check in runtime if driver supports data_v3 features (we might be\n running with the older driver)\n\n - if those features are negotiated, we pass them to the driver\n as bit flags via the (newly added) NEW_KEY_V2 ioctl\n\nIntroduce NEW_KEY_V2 ioctl, which accepts a new OVPN_CRYPTO_DATA_V2\nstructure, which includes a field for bit flags for the new\ncrypto options.\n\nMake dco_supports_data_v3() implementation platform-dependend (as it\nshould be) and indicate data_v3 support by dco-win if the driver version\nis at least 1.4. Extend the Windows-specific struct dco_context and\nstore data_v3 support there so that when dco_new_key() is called, we\nknow which API to use.\n\nChange the dco internal API and pass crypto options flags to dco_new_key().\n\nChange-Id: I2e0c50d33f8a57c023120cf348f95d34acbfcde5\nSigned-off-by: Lev Stipakov \u003clev@openvpn.net\u003e\n"},"branch":"refs/heads/master"},"6c6222d2ec1517cafc864ee77669de8d150f04c6":{"kind":"REWORK","_number":2,"created":"2024-08-15 12:33:32.000000000","uploader":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"ref":"refs/changes/25/725/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/25/725/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/25/725/2 \u0026\u0026 git checkout -b change-725 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/25/725/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/25/725/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/25/725/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/25/725/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/25/725/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"3d139a9a5b74c9a4f5d0c9cf8a2eab2efbef6f75","subject":"Implement support for larger packet counter sizes"}],"author":{"name":"Lev Stipakov","email":"lev@openvpn.net","date":"2024-08-13 10:42:12.000000000","tz":180},"committer":{"name":"Lev Stipakov","email":"lev@openvpn.net","date":"2024-08-15 12:33:12.000000000","tz":180},"subject":"dco-win: support for data_v3 features","message":"dco-win: support for data_v3 features\n\nSince version 1.4, dco-win drivere supports data_v3 features\nsuch as:\n\n - AEAD tag at the end\n - 64bit pktid\n\nWe have to:\n\n - check in runtime if driver supports data_v3 features (we might be\n running with the older driver)\n\n - if those features are negotiated, we pass them to the driver\n as bit flags via the (newly added) NEW_KEY_V2 ioctl\n\nIntroduce NEW_KEY_V2 ioctl, which accepts a new OVPN_CRYPTO_DATA_V2\nstructure, which includes a field for bit flags for the new\ncrypto options.\n\nMake dco_supports_data_v3() implementation platform-dependend (as it\nshould be) and indicate data_v3 support by dco-win if the driver version\nis at least 1.4. Extend the Windows-specific struct dco_context and\nstore data_v3 support there so that when dco_new_key() is called, we\nknow which API to use.\n\nChange the dco internal API and pass crypto options flags to dco_new_key().\n\nChange-Id: I2e0c50d33f8a57c023120cf348f95d34acbfcde5\nSigned-off-by: Lev Stipakov \u003clev@openvpn.net\u003e\n"},"branch":"refs/heads/master"},"a9d38cd6c3c2c587fa682716c56bf3856e91e726":{"kind":"REWORK","_number":3,"created":"2024-08-15 14:11:31.000000000","uploader":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"ref":"refs/changes/25/725/3","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/25/725/3","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/25/725/3 \u0026\u0026 git checkout -b change-725 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/25/725/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/25/725/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/25/725/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/25/725/3","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/25/725/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"3d139a9a5b74c9a4f5d0c9cf8a2eab2efbef6f75","subject":"Implement support for larger packet counter sizes"}],"author":{"name":"Lev Stipakov","email":"lev@openvpn.net","date":"2024-08-13 10:42:12.000000000","tz":180},"committer":{"name":"Lev Stipakov","email":"lev@openvpn.net","date":"2024-08-15 14:11:19.000000000","tz":180},"subject":"dco-win: support for data_v3 features","message":"dco-win: support for data_v3 features\n\nSince version 1.4, dco-win drivere supports data_v3 features\nsuch as:\n\n - AEAD tag at the end\n - 64bit pktid\n\nWe have to:\n\n - check in runtime if driver supports data_v3 features (we might be\n running with the older driver)\n\n - if those features are negotiated, we pass them to the driver\n as bit flags via the (newly added) NEW_KEY_V2 ioctl\n\nIntroduce NEW_KEY_V2 ioctl, which accepts a new OVPN_CRYPTO_DATA_V2\nstructure, which includes a field for bit flags for the new\ncrypto options.\n\nMake dco_supports_data_v3() implementation platform-dependend (as it\nshould be) and indicate data_v3 support by dco-win if the driver version\nis at least 1.4. Extend the Windows-specific struct dco_context and\nstore data_v3 support there so that when dco_new_key() is called, we\nknow which API to use.\n\nChange the dco internal API and pass crypto options flags to dco_new_key().\n\nChange-Id: I2e0c50d33f8a57c023120cf348f95d34acbfcde5\nSigned-off-by: Lev Stipakov \u003clev@openvpn.net\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}