)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"843be20685402f956c65354f90b30af6758611f8","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"fbde4d7d_d664c577","updated":"2024-09-11 12:57:43.000000000","message":"Breaks builds with disabled DCO (e.g. macOS, old FreeBSD/Linux)","commit_id":"c3844b6a7f61645c197bc897f761c1206a7979ed"},{"author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"da91dba53ae445492633845afc824356f679a49c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e125e303_db8e7ad0","in_reply_to":"fbde4d7d_d664c577","updated":"2024-09-16 23:09:51.000000000","message":"Done","commit_id":"c3844b6a7f61645c197bc897f761c1206a7979ed"},{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"ff8f9c3dc41adc70e98b663dc162c48172ea87ad","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"5b059aca_63998fc3","updated":"2024-09-17 11:53:38.000000000","message":"Generally LGTM.","commit_id":"6e1e7d0ef9194a911a26178fca6a911e12b1c62f"},{"author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"e831de3629b8d84b84775cc860a71535846c1a53","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"acb25f92_f7ee6043","updated":"2024-09-22 20:36:44.000000000","message":"I expected more massive changes but this is really mostly straightforward renaming for the windows part, and folding the is_utun variable into the driver enum (which makes sense).  And it passes all tests including t_client on MacOS ;-)","commit_id":"7569dc4399157f0e4d68b3b5badfb1b538b74800"}],"src/openvpn/tun.c":[{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"ff8f9c3dc41adc70e98b663dc162c48172ea87ad","unresolved":true,"context_lines":[{"line_number":60,"context_line":"{"},{"line_number":61,"context_line":"    switch (driver)"},{"line_number":62,"context_line":"    {"},{"line_number":63,"context_line":"#ifdef WIN32"},{"line_number":64,"context_line":"        case WINDOWS_DRIVER_TAP_WINDOWS6:"},{"line_number":65,"context_line":"            return \"tap-windows6\";"},{"line_number":66,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":5,"id":"a1b5e9c3_9c9289a1","line":63,"updated":"2024-09-17 11:53:38.000000000","message":"Again, don\u0027t think we really need the #ifdefs here...","commit_id":"6e1e7d0ef9194a911a26178fca6a911e12b1c62f"},{"author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"18a36bbd94fad8c8c2ed9012772eed341fe0776a","unresolved":false,"context_lines":[{"line_number":60,"context_line":"{"},{"line_number":61,"context_line":"    switch (driver)"},{"line_number":62,"context_line":"    {"},{"line_number":63,"context_line":"#ifdef WIN32"},{"line_number":64,"context_line":"        case WINDOWS_DRIVER_TAP_WINDOWS6:"},{"line_number":65,"context_line":"            return \"tap-windows6\";"},{"line_number":66,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":5,"id":"a92660a1_3f1cd84d","line":63,"in_reply_to":"369450ea_d033a0b6","updated":"2024-09-18 12:47:42.000000000","message":"Done","commit_id":"6e1e7d0ef9194a911a26178fca6a911e12b1c62f"},{"author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"57b6a91ca0d4d039be0af01a2ee36e245106fba7","unresolved":true,"context_lines":[{"line_number":60,"context_line":"{"},{"line_number":61,"context_line":"    switch (driver)"},{"line_number":62,"context_line":"    {"},{"line_number":63,"context_line":"#ifdef WIN32"},{"line_number":64,"context_line":"        case WINDOWS_DRIVER_TAP_WINDOWS6:"},{"line_number":65,"context_line":"            return \"tap-windows6\";"},{"line_number":66,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":5,"id":"369450ea_d033a0b6","line":63,"in_reply_to":"a1b5e9c3_9c9289a1","updated":"2024-09-17 16:48:29.000000000","message":"DO you propose to have them always be defined?","commit_id":"6e1e7d0ef9194a911a26178fca6a911e12b1c62f"}],"src/openvpn/tun.h":[{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"ff8f9c3dc41adc70e98b663dc162c48172ea87ad","unresolved":true,"context_lines":[{"line_number":43,"context_line":"#include \"dco.h\""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"enum tun_driver_type {"},{"line_number":46,"context_line":"#ifdef WIN32"},{"line_number":47,"context_line":"    WINDOWS_DRIVER_UNSPECIFIED,"},{"line_number":48,"context_line":"    WINDOWS_DRIVER_TAP_WINDOWS6,"},{"line_number":49,"context_line":"    WINDOWS_DRIVER_WINTUN,"}],"source_content_type":"text/x-csrc","patch_set":5,"id":"053bc957_6ad67db1","line":46,"updated":"2024-09-17 11:53:38.000000000","message":"Do we really need pre-processor here? Doesn\u0027t hurt if the enum contains unused values, does it?","commit_id":"6e1e7d0ef9194a911a26178fca6a911e12b1c62f"},{"author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"57b6a91ca0d4d039be0af01a2ee36e245106fba7","unresolved":true,"context_lines":[{"line_number":43,"context_line":"#include \"dco.h\""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"enum tun_driver_type {"},{"line_number":46,"context_line":"#ifdef WIN32"},{"line_number":47,"context_line":"    WINDOWS_DRIVER_UNSPECIFIED,"},{"line_number":48,"context_line":"    WINDOWS_DRIVER_TAP_WINDOWS6,"},{"line_number":49,"context_line":"    WINDOWS_DRIVER_WINTUN,"}],"source_content_type":"text/x-csrc","patch_set":5,"id":"2be53bb0_c2ced10a","line":46,"in_reply_to":"053bc957_6ad67db1","updated":"2024-09-17 16:48:29.000000000","message":"It is different philosophies. One could argue that you catch a windows only define used out of windows only code. The other is that too many define/ifdefs are worse.","commit_id":"6e1e7d0ef9194a911a26178fca6a911e12b1c62f"},{"author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"18a36bbd94fad8c8c2ed9012772eed341fe0776a","unresolved":false,"context_lines":[{"line_number":43,"context_line":"#include \"dco.h\""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"enum tun_driver_type {"},{"line_number":46,"context_line":"#ifdef WIN32"},{"line_number":47,"context_line":"    WINDOWS_DRIVER_UNSPECIFIED,"},{"line_number":48,"context_line":"    WINDOWS_DRIVER_TAP_WINDOWS6,"},{"line_number":49,"context_line":"    WINDOWS_DRIVER_WINTUN,"}],"source_content_type":"text/x-csrc","patch_set":5,"id":"15836cff_8014e30b","line":46,"in_reply_to":"2be53bb0_c2ced10a","updated":"2024-09-18 12:47:42.000000000","message":"Done","commit_id":"6e1e7d0ef9194a911a26178fca6a911e12b1c62f"}]}