)]}'
{"id":"openvpn~740","triplet_id":"openvpn~master~I7852c06d331326c1dbab7b642254c0c00d4cebb8","project":"openvpn","branch":"master","topic":"wconversion","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2024-09-19 06:15:40.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2024-09-19 06:15:40.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I7852c06d331326c1dbab7b642254c0c00d4cebb8","subject":"socket: Change return types of link_socket_write* to ssize_t","status":"MERGED","created":"2024-09-10 12:14:10.000000000","updated":"2024-09-19 06:15:40.000000000","submitted":"2024-09-19 06:15:40.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"740-wconversion","meta_rev_id":"20a2c28a488f0fe3db894d7fc411e2cad2b72727","_number":740,"virtual_id_number":740,"owner":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"default_value":0}},"removable_reviewers":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"reviewers":{"REVIEWER":[{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-09-10 12:14:12.000000000","updated_by":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2024-09-10 12:14:12.000000000","updated_by":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2024-09-18 20:48:22.000000000","updated_by":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"state":"REVIEWER"}],"messages":[{"id":"8eaa1d3353d7c8511a3d5ef4b183521b625f83b5","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2024-09-10 12:14:10.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"38298ca6c1f3f12fedd12de9b5f3025b026cfb11","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2024-09-18 20:48:22.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"20a2c28a488f0fe3db894d7fc411e2cad2b72727","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2024-09-19 06:15:40.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"2cc77debf0221fa0cef3ea470c1328d25397d021","revisions":{"8c3b7f41f735275585937698bee28205607f7610":{"kind":"REWORK","_number":1,"created":"2024-09-10 12:14:10.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/40/740/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/40/740/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/40/740/1 \u0026\u0026 git checkout -b change-740 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/40/740/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/40/740/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/40/740/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/40/740/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/40/740/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"87896c969003273a33b43ed7778dc8babc22832e","subject":"generate_auth_token: simplify code"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2024-09-10 12:08:52.000000000","tz":120},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2024-09-10 12:12:57.000000000","tz":120},"subject":"socket: Change return types of link_socket_write* to ssize_t","message":"socket: Change return types of link_socket_write* to ssize_t\n\nThis is the actual return value of send/sendto/sendmsg.\nWe will leave it to the single caller of link_socket_write()\nto decide how to map that to the int buffer world. For now\njust cast it explicitly.\n\nChange-Id: I7852c06d331326c1dbab7b642254c0c00d4cebb8\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"2cc77debf0221fa0cef3ea470c1328d25397d021":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":2,"created":"2024-09-19 06:15:40.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/40/740/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/40/740/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/40/740/2 \u0026\u0026 git checkout -b change-740 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/40/740/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/40/740/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/40/740/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/40/740/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/40/740/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"b59620f24f5bc853e2aa92943f14abf74aa81511","subject":"configure: Review use of standard AC macros"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2024-09-18 20:48:44.000000000","tz":120},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2024-09-18 21:01:24.000000000","tz":120},"subject":"socket: Change return types of link_socket_write* to ssize_t","message":"socket: Change return types of link_socket_write* to ssize_t\n\nThis is the actual return value of send/sendto/sendmsg.\nWe will leave it to the single caller of link_socket_write()\nto decide how to map that to the int buffer world. For now\njust cast it explicitly.\n\nChange-Id: I7852c06d331326c1dbab7b642254c0c00d4cebb8\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\nAcked-by: Gert Doering \u003cgert@greenie.muc.de\u003e\nMessage-Id: \u003c20240918204844.2820-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg29323.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}