)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"b406fa53d8f34d7867dc5194f4463e58b93448bf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"fad5ffda_135ade40","updated":"2024-09-16 13:27:42.000000000","message":"I agree to the first change (no `--cipher` in config).\n\nThe second one is still warning-worthy - if someone uses `--cipher` and expects it to actually do something, it is helpful to warn why nothing happens.","commit_id":"827a1b60058922ab9ed1854d913b2270e4ac808f"},{"author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"c65b9d1c966d63209d5bc744817c0bccfd842898","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"01d77e7b_8ba44805","updated":"2024-09-16 13:31:41.000000000","message":"misclicked.  this one I do not agree to \"as is\"","commit_id":"827a1b60058922ab9ed1854d913b2270e4ac808f"},{"author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"6e1f3d00ca6c0a1c47119862644c75076fa8263c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"5a5fe8a5_f8106bd4","updated":"2024-09-20 15:45:54.000000000","message":"So as discussed today, this only scratches the top of the itch... what we want\n\n- make \"--data-ciphers\" accept something like \"default plus AES-128-CBC\", so future changes in \"default\" (adding a new supercipher, or deprecating something) will have an effect, and not get negated by having `--data-ciphers AES-128-GCM:AES-128-CBC` stuck in config files (again)\n- adjust the warning messages(2) to print the full syntax for the `--data-cipher` command to be added","commit_id":"86dfdb4772adadd207339be6437c193e242db641"},{"author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"081ee0c6909701817f5ddccbd1f20c81f89f69d8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"7c9d9248_32ff528d","updated":"2024-09-17 12:55:48.000000000","message":"discussed on IRC, pushed to https://community.openvpn.net/openvpn/wiki/CommunityMeetup2024","commit_id":"86dfdb4772adadd207339be6437c193e242db641"}],"src/openvpn/options.c":[{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"c19f7d026e59125ad90d7da4e58da2b52a0c94f5","unresolved":true,"context_lines":[{"line_number":3555,"context_line":"    else if (!o-\u003eenable_ncp_fallback"},{"line_number":3556,"context_line":"             \u0026\u0026 !tls_item_in_cipher_list(o-\u003eciphername, o-\u003encp_ciphers))"},{"line_number":3557,"context_line":"    {"},{"line_number":3558,"context_line":"        msg(D_LOW, \"DEPRECATED OPTION: --cipher set to \u0027%s\u0027 but missing in \""},{"line_number":3559,"context_line":"            \"--data-ciphers (%s). OpenVPN ignores --cipher for cipher \""},{"line_number":3560,"context_line":"            \"negotiations. \","},{"line_number":3561,"context_line":"            o-\u003eciphername, o-\u003encp_ciphers);"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"30ce7242_48e36053","line":3558,"updated":"2024-12-27 12:24:34.000000000","message":"I do not agree with this part of the patch. Since this only happens if you have a --cipher in your config I think it is fine to keep this warning. I would only reduce the other one since that is basically a warning about the recommended config.","commit_id":"86dfdb4772adadd207339be6437c193e242db641"}]}