)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"6abdccf2bd5e9ce24e23c6b3e2027c6a494c820f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"73a404bf_c71db07a","updated":"2024-09-25 11:34:44.000000000","message":"This patch does not pass the tests","commit_id":"721b4375dc4b0709d9ec9bc2d024f2602939453d"},{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"400d4f0dadb48d8306ea7d1a5193b0f058d6efa8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"ce66c561_622bdef0","updated":"2024-10-14 12:32:45.000000000","message":"resubmitted v4 with added sign-off for Giaan","commit_id":"8bed6f8c4365067b455b1fc6f4877fad2d105639"}],"src/openvpn/forward.c":[{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"6abdccf2bd5e9ce24e23c6b3e2027c6a494c820f","unresolved":true,"context_lines":[{"line_number":2051,"context_line":"    struct event_set_return esr[4];"},{"line_number":2052,"context_line":""},{"line_number":2053,"context_line":"    /* These shifts all depend on EVENT_READ and EVENT_WRITE */"},{"line_number":2054,"context_line":"    static uintptr_t socket_shift \u003d 0;   /* depends on SOCKET_READ and SOCKET_WRITE */"},{"line_number":2055,"context_line":"    static uintptr_t tun_shift \u003d 2;      /* depends on TUN_READ and TUN_WRITE */"},{"line_number":2056,"context_line":"    static uintptr_t err_shift \u003d 4;      /* depends on ES_ERROR */"},{"line_number":2057,"context_line":"#ifdef ENABLE_MANAGEMENT"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"fd14f418_905c5966","line":2054,"updated":"2024-09-25 11:34:44.000000000","message":"Why the replacement of the macros here?","commit_id":"721b4375dc4b0709d9ec9bc2d024f2602939453d"},{"author":{"_account_id":1000034,"name":"its_Giaan","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"change_message_id":"918fc2462e32ba65927603875074ad2b3e2db89e","unresolved":false,"context_lines":[{"line_number":2051,"context_line":"    struct event_set_return esr[4];"},{"line_number":2052,"context_line":""},{"line_number":2053,"context_line":"    /* These shifts all depend on EVENT_READ and EVENT_WRITE */"},{"line_number":2054,"context_line":"    static uintptr_t socket_shift \u003d 0;   /* depends on SOCKET_READ and SOCKET_WRITE */"},{"line_number":2055,"context_line":"    static uintptr_t tun_shift \u003d 2;      /* depends on TUN_READ and TUN_WRITE */"},{"line_number":2056,"context_line":"    static uintptr_t err_shift \u003d 4;      /* depends on ES_ERROR */"},{"line_number":2057,"context_line":"#ifdef ENABLE_MANAGEMENT"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"54e37e09_433ffd78","line":2054,"in_reply_to":"b8b190fc_6d65f800","updated":"2024-10-01 15:31:26.000000000","message":"Done","commit_id":"721b4375dc4b0709d9ec9bc2d024f2602939453d"},{"author":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"change_message_id":"eda0a619d3b6308c295b5c021593e5bed47ab400","unresolved":true,"context_lines":[{"line_number":2051,"context_line":"    struct event_set_return esr[4];"},{"line_number":2052,"context_line":""},{"line_number":2053,"context_line":"    /* These shifts all depend on EVENT_READ and EVENT_WRITE */"},{"line_number":2054,"context_line":"    static uintptr_t socket_shift \u003d 0;   /* depends on SOCKET_READ and SOCKET_WRITE */"},{"line_number":2055,"context_line":"    static uintptr_t tun_shift \u003d 2;      /* depends on TUN_READ and TUN_WRITE */"},{"line_number":2056,"context_line":"    static uintptr_t err_shift \u003d 4;      /* depends on ES_ERROR */"},{"line_number":2057,"context_line":"#ifdef ENABLE_MANAGEMENT"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"b8b190fc_6d65f800","line":2054,"in_reply_to":"fd14f418_905c5966","updated":"2024-09-25 12:00:52.000000000","message":"I think this patch predates the introduction of those macros.\nSo this assignments need to be changed.","commit_id":"721b4375dc4b0709d9ec9bc2d024f2602939453d"},{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"6abdccf2bd5e9ce24e23c6b3e2027c6a494c820f","unresolved":true,"context_lines":[{"line_number":2168,"context_line":"    /*"},{"line_number":2169,"context_line":"     * Configure event wait based on socket, tuntap flags."},{"line_number":2170,"context_line":"     */"},{"line_number":2171,"context_line":"    socket_set(c-\u003ec2.link_socket, c-\u003ec2.event_set, socket, (void *)\u0026socket_shift, NULL);"},{"line_number":2172,"context_line":"    tun_set(c-\u003ec1.tuntap, c-\u003ec2.event_set, tuntap, (void *)tun_shift, NULL);"},{"line_number":2173,"context_line":"#if defined(TARGET_LINUX) || defined(TARGET_FREEBSD)"},{"line_number":2174,"context_line":"    if (socket \u0026 EVENT_READ \u0026\u0026 c-\u003ec2.did_open_tun)"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"87af5a06_5a0e69af","line":2171,"range":{"start_line":2171,"start_character":0,"end_line":2171,"end_character":2},"updated":"2024-09-25 11:34:44.000000000","message":"Probably need to change here as well? This patch does not work, but the followup patch does. I assume it is because you forgot to change this here since you change it to something else in the followup patch.","commit_id":"721b4375dc4b0709d9ec9bc2d024f2602939453d"},{"author":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"change_message_id":"eda0a619d3b6308c295b5c021593e5bed47ab400","unresolved":true,"context_lines":[{"line_number":2168,"context_line":"    /*"},{"line_number":2169,"context_line":"     * Configure event wait based on socket, tuntap flags."},{"line_number":2170,"context_line":"     */"},{"line_number":2171,"context_line":"    socket_set(c-\u003ec2.link_socket, c-\u003ec2.event_set, socket, (void *)\u0026socket_shift, NULL);"},{"line_number":2172,"context_line":"    tun_set(c-\u003ec1.tuntap, c-\u003ec2.event_set, tuntap, (void *)tun_shift, NULL);"},{"line_number":2173,"context_line":"#if defined(TARGET_LINUX) || defined(TARGET_FREEBSD)"},{"line_number":2174,"context_line":"    if (socket \u0026 EVENT_READ \u0026\u0026 c-\u003ec2.did_open_tun)"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"e513c4d7_f82f90ad","line":2171,"range":{"start_line":2171,"start_character":0,"end_line":2171,"end_character":2},"in_reply_to":"87af5a06_5a0e69af","updated":"2024-09-25 12:00:52.000000000","message":"the \u0026 should not be there.","commit_id":"721b4375dc4b0709d9ec9bc2d024f2602939453d"},{"author":{"_account_id":1000034,"name":"its_Giaan","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"change_message_id":"918fc2462e32ba65927603875074ad2b3e2db89e","unresolved":false,"context_lines":[{"line_number":2168,"context_line":"    /*"},{"line_number":2169,"context_line":"     * Configure event wait based on socket, tuntap flags."},{"line_number":2170,"context_line":"     */"},{"line_number":2171,"context_line":"    socket_set(c-\u003ec2.link_socket, c-\u003ec2.event_set, socket, (void *)\u0026socket_shift, NULL);"},{"line_number":2172,"context_line":"    tun_set(c-\u003ec1.tuntap, c-\u003ec2.event_set, tuntap, (void *)tun_shift, NULL);"},{"line_number":2173,"context_line":"#if defined(TARGET_LINUX) || defined(TARGET_FREEBSD)"},{"line_number":2174,"context_line":"    if (socket \u0026 EVENT_READ \u0026\u0026 c-\u003ec2.did_open_tun)"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"5b145b31_80e33bef","line":2171,"range":{"start_line":2171,"start_character":0,"end_line":2171,"end_character":2},"in_reply_to":"e513c4d7_f82f90ad","updated":"2024-10-01 15:31:26.000000000","message":"Done","commit_id":"721b4375dc4b0709d9ec9bc2d024f2602939453d"},{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"6abdccf2bd5e9ce24e23c6b3e2027c6a494c820f","unresolved":true,"context_lines":[{"line_number":2173,"context_line":"#if defined(TARGET_LINUX) || defined(TARGET_FREEBSD)"},{"line_number":2174,"context_line":"    if (socket \u0026 EVENT_READ \u0026\u0026 c-\u003ec2.did_open_tun)"},{"line_number":2175,"context_line":"    {"},{"line_number":2176,"context_line":"        dco_event_set(\u0026c-\u003ec1.tuntap-\u003edco, c-\u003ec2.event_set, (void *)\u0026dco_shift);"},{"line_number":2177,"context_line":"    }"},{"line_number":2178,"context_line":"#endif"},{"line_number":2179,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":1,"id":"9d5f598a_d521d386","line":2176,"range":{"start_line":2176,"start_character":68,"end_line":2176,"end_character":77},"updated":"2024-09-25 11:34:44.000000000","message":"Miss here as well?","commit_id":"721b4375dc4b0709d9ec9bc2d024f2602939453d"},{"author":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"change_message_id":"eda0a619d3b6308c295b5c021593e5bed47ab400","unresolved":true,"context_lines":[{"line_number":2173,"context_line":"#if defined(TARGET_LINUX) || defined(TARGET_FREEBSD)"},{"line_number":2174,"context_line":"    if (socket \u0026 EVENT_READ \u0026\u0026 c-\u003ec2.did_open_tun)"},{"line_number":2175,"context_line":"    {"},{"line_number":2176,"context_line":"        dco_event_set(\u0026c-\u003ec1.tuntap-\u003edco, c-\u003ec2.event_set, (void *)\u0026dco_shift);"},{"line_number":2177,"context_line":"    }"},{"line_number":2178,"context_line":"#endif"},{"line_number":2179,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":1,"id":"b177699b_21cb28af","line":2176,"range":{"start_line":2176,"start_character":68,"end_line":2176,"end_character":77},"in_reply_to":"9d5f598a_d521d386","updated":"2024-09-25 12:00:52.000000000","message":"the \u0026 should not be there","commit_id":"721b4375dc4b0709d9ec9bc2d024f2602939453d"},{"author":{"_account_id":1000034,"name":"its_Giaan","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"change_message_id":"918fc2462e32ba65927603875074ad2b3e2db89e","unresolved":false,"context_lines":[{"line_number":2173,"context_line":"#if defined(TARGET_LINUX) || defined(TARGET_FREEBSD)"},{"line_number":2174,"context_line":"    if (socket \u0026 EVENT_READ \u0026\u0026 c-\u003ec2.did_open_tun)"},{"line_number":2175,"context_line":"    {"},{"line_number":2176,"context_line":"        dco_event_set(\u0026c-\u003ec1.tuntap-\u003edco, c-\u003ec2.event_set, (void *)\u0026dco_shift);"},{"line_number":2177,"context_line":"    }"},{"line_number":2178,"context_line":"#endif"},{"line_number":2179,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":1,"id":"d6e4081a_007cb7b8","line":2176,"range":{"start_line":2176,"start_character":68,"end_line":2176,"end_character":77},"in_reply_to":"b177699b_21cb28af","updated":"2024-10-01 15:31:26.000000000","message":"Done","commit_id":"721b4375dc4b0709d9ec9bc2d024f2602939453d"}]}