)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"72ee4d595e2ed8e66862be2c177473c97cb71110","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Gianmarco De Gregori \u003cgianmarco@mandelbit.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-09-23 15:39:42 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"if a local IPv6 address is provided, socket must be v6-only"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I705fd9bf9298a54560eca12e3797351f4af321a7"},{"line_number":10,"context_line":"Signed-off-by: Antonio Quartulli \u003ca@unstable.cc\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"17ec1bd2_7d7dd5bc","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":2},"updated":"2024-09-25 13:49:54.000000000","message":"Please add more details in commit message.\n\nDoes this fix a pre-existing issue? Or is this only required in context of multi-socket?","commit_id":"8eda56822802e046d5421e4eff77475e39f47170"},{"author":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"change_message_id":"c301f17497dcabd2fd30dcc1f076f87f18be5ce9","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Gianmarco De Gregori \u003cgianmarco@mandelbit.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-09-23 15:39:42 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"if a local IPv6 address is provided, socket must be v6-only"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I705fd9bf9298a54560eca12e3797351f4af321a7"},{"line_number":10,"context_line":"Signed-off-by: Antonio Quartulli \u003ca@unstable.cc\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"62c4bed4_547e83d0","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":2},"in_reply_to":"022a32f8_4e0ee3ea","updated":"2024-10-01 13:07:47.000000000","message":"The only thing that comes to my mind is that if we wanted to have a wildcard ipv6 socket (i.e. ::$port) that should be separate from a wildcard ipv4 socket, we must have this flag on when passing \u0027::\u0027 to --local, otherwise the second socket won\u0027t be able to bind.","commit_id":"8eda56822802e046d5421e4eff77475e39f47170"},{"author":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"change_message_id":"5368ab6144be4d2b8ba3b7c38376c173191d7fa7","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Gianmarco De Gregori \u003cgianmarco@mandelbit.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-09-23 15:39:42 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"if a local IPv6 address is provided, socket must be v6-only"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I705fd9bf9298a54560eca12e3797351f4af321a7"},{"line_number":10,"context_line":"Signed-off-by: Antonio Quartulli \u003ca@unstable.cc\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"022a32f8_4e0ee3ea","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":2},"in_reply_to":"17ec1bd2_7d7dd5bc","updated":"2024-10-01 13:04:17.000000000","message":"Chiming in as I am responsible for this change (implemented loooong ago).\nUnfortunately I can\u0027t recall the reason why we needed this, but I think it has to do with some \"interesting\" combination of sockets, like:\n- one on a specific ipv6\n- one on wildcard ipv4\nor something along those lines.\n\nI am unable to trigger any conflict using multiple instances right now (with master branch).\n\nWe can exclude this patch for the time being and get back to it once tests will reveal what the problem was (or when maybe my memory about this will get back)","commit_id":"8eda56822802e046d5421e4eff77475e39f47170"},{"author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"d486332984f8483159abb0d8baab3f8a8d00fbe2","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Gianmarco De Gregori \u003cgianmarco@mandelbit.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-09-23 15:39:42 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"if a local IPv6 address is provided, socket must be v6-only"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I705fd9bf9298a54560eca12e3797351f4af321a7"},{"line_number":10,"context_line":"Signed-off-by: Antonio Quartulli \u003ca@unstable.cc\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"78420fab_8b8d4fb4","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":2},"in_reply_to":"62c4bed4_547e83d0","updated":"2025-02-02 21:12:12.000000000","message":"The more I think about this, the more I find that we should cover this by documentation :-) - changing the default bind behaviour will break people\u0027s config on upgrading a server config with `local ::` or `proto udp6`, because it will stop listening to IPv4.\n\nSo what we should do is to document that `* udp6` or `::`will default to `ipv4 + ipv6`, unless `bind ipv6only` is configured - and not try to solve this in code, at least not for 2.7 when \"just one socket\" configs will be the normal case on upgrading.","commit_id":"8eda56822802e046d5421e4eff77475e39f47170"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"574ab9b2189c08080848c4fdcf0b6fe8a2eed23e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"f5c8a7f9_08e180c1","updated":"2024-10-23 20:46:36.000000000","message":"The patch looks fine, though I\u0027m not sure how we want things to be in future.  Maybe we just want to get rid of `ipv6only` completely, as that\u0027s just a hack to get dual-stack server support on OSes that support this...\n\nIndeed, postpone this a bit, and think more on \"what do we want 2.7 to behave like?\" - some multi-socket daemons do one thing, others do it differently (apache, sshd)...\n\nBut whatever it ends up being, it needs an addition to the `ipv6only` flag to `--bind` in the manpage...","commit_id":"e1f19f71338ce3ba3c689c32e2b1af64480cf91c"}],"src/openvpn/socket.c":[{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"72ee4d595e2ed8e66862be2c177473c97cb71110","unresolved":true,"context_lines":[{"line_number":1111,"context_line":"            bool v6only \u003d sock-\u003einfo.bind_ipv6_only;"},{"line_number":1112,"context_line":""},{"line_number":1113,"context_line":"            /* force binding IPv6-only if an address was specified"},{"line_number":1114,"context_line":"             * an it is a IPv6 */"},{"line_number":1115,"context_line":"            if (sock-\u003elocal_host \u0026\u0026 ai_family \u003d\u003d AF_INET6)"},{"line_number":1116,"context_line":"                v6only \u003d true;"},{"line_number":1117,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":1,"id":"1ecc789a_f41e03db","line":1114,"range":{"start_line":1114,"start_character":21,"end_line":1114,"end_character":25},"updated":"2024-09-25 13:49:54.000000000","message":"\"and\"","commit_id":"8eda56822802e046d5421e4eff77475e39f47170"},{"author":{"_account_id":1000034,"name":"its_Giaan","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"change_message_id":"a384e8edddb2b3ae938089d9fead16a30dfd916f","unresolved":false,"context_lines":[{"line_number":1111,"context_line":"            bool v6only \u003d sock-\u003einfo.bind_ipv6_only;"},{"line_number":1112,"context_line":""},{"line_number":1113,"context_line":"            /* force binding IPv6-only if an address was specified"},{"line_number":1114,"context_line":"             * an it is a IPv6 */"},{"line_number":1115,"context_line":"            if (sock-\u003elocal_host \u0026\u0026 ai_family \u003d\u003d AF_INET6)"},{"line_number":1116,"context_line":"                v6only \u003d true;"},{"line_number":1117,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":1,"id":"82bc4287_22f216c6","line":1114,"range":{"start_line":1114,"start_character":21,"end_line":1114,"end_character":25},"in_reply_to":"1ecc789a_f41e03db","updated":"2024-10-01 15:31:45.000000000","message":"Done","commit_id":"8eda56822802e046d5421e4eff77475e39f47170"}]}