)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"e35a7c7d2e0d23fe8568efe37f606a40a0afc67d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"885fad8d_3a581c63","updated":"2024-10-17 15:41:00.000000000","message":"build broken","commit_id":"5367be67a9ef306d3ac1abc01e0aab90a1e6bb0a"},{"author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"39153d9f8483bad6836055955f89ac1b4576cadf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"07752e9e_7a2071c8","updated":"2024-12-30 19:16:31.000000000","message":"I can\u0027t review this when half the patch is really `renaming of *ls to *sock`.  Please split these off to a separate patch that does the renaming, and a patch that does actual code/file structure changes.","commit_id":"f61895c9edc5c1a107becc1adfb3ddf65a0689c7"},{"author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"82763c6d4a4fd9c8e305e4e612f72815147de223","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"daaeede8_20dcb698","updated":"2025-01-23 15:54:58.000000000","message":"much better and much easier reviewed now.\n\nAs discussed on IRC, the `multi_protocol_...()` function names are slightly confusing, and I suggest to use `multi_io_...()`, which is in line with the `m-\u003emtcp` to `m-\u003em_multi_io` renaming and also the file names...","commit_id":"28b82bee67d16aa9f79525ae0b9af959000a4f21"},{"author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"08a01ee976a4d8f375e2f60b6b6c43458979390b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"9e5154ef_51ceabc4","updated":"2025-01-23 17:50:33.000000000","message":"close :-) (the code compiles and passes light tests, but there is a comment that is more confusing than helpful)","commit_id":"7236d5f1e796d1b475dde85dfb752a114b3db737"}],"src/openvpn/init.c":[{"author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"39153d9f8483bad6836055955f89ac1b4576cadf","unresolved":true,"context_lines":[{"line_number":4923,"context_line":"void"},{"line_number":4924,"context_line":"inherit_context_child(struct context *dest,"},{"line_number":4925,"context_line":"                      const struct context *src,"},{"line_number":4926,"context_line":"                      struct link_socket *sock)"},{"line_number":4927,"context_line":"{"},{"line_number":4928,"context_line":"    CLEAR(*dest);"},{"line_number":4929,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":10,"id":"9d7d20e0_b9d8d37a","line":4926,"updated":"2024-12-30 19:16:31.000000000","message":"I agree that we might want to make this uniform across the whole code - that is, change all occurences to `struct link_socket *XXX` to either `*ls` or `*sock`.\n\nBut this should not be part of a \"L\" patchset, which is hard enough to review as it is - so please make this into its own patch.","commit_id":"f61895c9edc5c1a107becc1adfb3ddf65a0689c7"},{"author":{"_account_id":1000034,"name":"Gianmarco De Gregori","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"change_message_id":"2d183f4e1711b101f869147b7032078a412fcd74","unresolved":false,"context_lines":[{"line_number":4923,"context_line":"void"},{"line_number":4924,"context_line":"inherit_context_child(struct context *dest,"},{"line_number":4925,"context_line":"                      const struct context *src,"},{"line_number":4926,"context_line":"                      struct link_socket *sock)"},{"line_number":4927,"context_line":"{"},{"line_number":4928,"context_line":"    CLEAR(*dest);"},{"line_number":4929,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":10,"id":"3cd77970_c262e6d2","line":4926,"in_reply_to":"9d7d20e0_b9d8d37a","updated":"2025-01-09 13:50:19.000000000","message":"Done","commit_id":"f61895c9edc5c1a107becc1adfb3ddf65a0689c7"}],"src/openvpn/mtcp.c":[{"author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"39153d9f8483bad6836055955f89ac1b4576cadf","unresolved":true,"context_lines":[{"line_number":162,"context_line":"}"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"struct context *"},{"line_number":165,"context_line":"multi_tcp_context(struct multi_context *m, struct multi_instance *mi)"},{"line_number":166,"context_line":"{"},{"line_number":167,"context_line":"    if (mi)"},{"line_number":168,"context_line":"    {"}],"source_content_type":"text/x-csrc","patch_set":10,"id":"36397026_667042d4","line":165,"updated":"2024-12-30 19:16:31.000000000","message":"we lost the `inline` bit here by making it a global function.  Maybe move it to mtcp.h then, and make it a `static inline` again?","commit_id":"f61895c9edc5c1a107becc1adfb3ddf65a0689c7"},{"author":{"_account_id":1000034,"name":"Gianmarco De Gregori","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"change_message_id":"2d183f4e1711b101f869147b7032078a412fcd74","unresolved":true,"context_lines":[{"line_number":162,"context_line":"}"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"struct context *"},{"line_number":165,"context_line":"multi_tcp_context(struct multi_context *m, struct multi_instance *mi)"},{"line_number":166,"context_line":"{"},{"line_number":167,"context_line":"    if (mi)"},{"line_number":168,"context_line":"    {"}],"source_content_type":"text/x-csrc","patch_set":10,"id":"8fab14f7_8836c8e6","line":165,"in_reply_to":"36397026_667042d4","updated":"2025-01-09 13:50:19.000000000","message":"made this static inline again and moved to multi_io.h where it gets used, also renamed this \u0027multi_get_context\u0027 since it\u0027s what it does.","commit_id":"f61895c9edc5c1a107becc1adfb3ddf65a0689c7"},{"author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"82763c6d4a4fd9c8e305e4e612f72815147de223","unresolved":false,"context_lines":[{"line_number":162,"context_line":"}"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"struct context *"},{"line_number":165,"context_line":"multi_tcp_context(struct multi_context *m, struct multi_instance *mi)"},{"line_number":166,"context_line":"{"},{"line_number":167,"context_line":"    if (mi)"},{"line_number":168,"context_line":"    {"}],"source_content_type":"text/x-csrc","patch_set":10,"id":"506eec5d_80c39ac0","line":165,"in_reply_to":"8fab14f7_8836c8e6","updated":"2025-01-23 15:54:58.000000000","message":"Done","commit_id":"f61895c9edc5c1a107becc1adfb3ddf65a0689c7"}],"src/openvpn/mudp.c":[{"author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"39153d9f8483bad6836055955f89ac1b4576cadf","unresolved":true,"context_lines":[{"line_number":186,"context_line":""},{"line_number":187,"context_line":"struct multi_instance *"},{"line_number":188,"context_line":"multi_get_create_instance_udp(struct multi_context *m, bool *floated,"},{"line_number":189,"context_line":"                              struct link_socket *sock)"},{"line_number":190,"context_line":"{"},{"line_number":191,"context_line":"    struct gc_arena gc \u003d gc_new();"},{"line_number":192,"context_line":"    struct mroute_addr real \u003d {0};"}],"source_content_type":"text/x-csrc","patch_set":10,"id":"436366d0_85a29dd3","line":189,"updated":"2024-12-30 19:16:31.000000000","message":"and here... without the renaming, there wouldn\u0027t be a change to `mudp.c` at all (much easier to understand)","commit_id":"f61895c9edc5c1a107becc1adfb3ddf65a0689c7"},{"author":{"_account_id":1000034,"name":"Gianmarco De Gregori","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"change_message_id":"2d183f4e1711b101f869147b7032078a412fcd74","unresolved":false,"context_lines":[{"line_number":186,"context_line":""},{"line_number":187,"context_line":"struct multi_instance *"},{"line_number":188,"context_line":"multi_get_create_instance_udp(struct multi_context *m, bool *floated,"},{"line_number":189,"context_line":"                              struct link_socket *sock)"},{"line_number":190,"context_line":"{"},{"line_number":191,"context_line":"    struct gc_arena gc \u003d gc_new();"},{"line_number":192,"context_line":"    struct mroute_addr real \u003d {0};"}],"source_content_type":"text/x-csrc","patch_set":10,"id":"8f0f41f9_ca89d73c","line":189,"in_reply_to":"436366d0_85a29dd3","updated":"2025-01-09 13:50:19.000000000","message":"Done","commit_id":"f61895c9edc5c1a107becc1adfb3ddf65a0689c7"}],"src/openvpn/mudp.h":[{"author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"39153d9f8483bad6836055955f89ac1b4576cadf","unresolved":true,"context_lines":[{"line_number":63,"context_line":" *      NULL if one did not yet exist and a new one was not created."},{"line_number":64,"context_line":" */"},{"line_number":65,"context_line":"struct multi_instance *multi_get_create_instance_udp(struct multi_context *m, bool *floated,"},{"line_number":66,"context_line":"                                                     struct link_socket *sock);"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"#endif /* ifndef MUDP_H */"}],"source_content_type":"text/x-csrc","patch_set":10,"id":"9b5c56a3_dce8eb89","line":66,"updated":"2024-12-30 19:16:31.000000000","message":"see other comment, please move pure `ls/sock` renaming to a different patch","commit_id":"f61895c9edc5c1a107becc1adfb3ddf65a0689c7"},{"author":{"_account_id":1000034,"name":"Gianmarco De Gregori","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"change_message_id":"2d183f4e1711b101f869147b7032078a412fcd74","unresolved":false,"context_lines":[{"line_number":63,"context_line":" *      NULL if one did not yet exist and a new one was not created."},{"line_number":64,"context_line":" */"},{"line_number":65,"context_line":"struct multi_instance *multi_get_create_instance_udp(struct multi_context *m, bool *floated,"},{"line_number":66,"context_line":"                                                     struct link_socket *sock);"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"#endif /* ifndef MUDP_H */"}],"source_content_type":"text/x-csrc","patch_set":10,"id":"1ee1261f_36899e3a","line":66,"in_reply_to":"9b5c56a3_dce8eb89","updated":"2025-01-09 13:50:19.000000000","message":"Done","commit_id":"f61895c9edc5c1a107becc1adfb3ddf65a0689c7"}],"src/openvpn/multi.c":[{"author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"e35a7c7d2e0d23fe8568efe37f606a40a0afc67d","unresolved":true,"context_lines":[{"line_number":774,"context_line":"        generate_prefix(mi);"},{"line_number":775,"context_line":"    }"},{"line_number":776,"context_line":""},{"line_number":777,"context_line":"    inherit_context_child(\u0026mi-\u003econtext, \u0026m-\u003etop, ls);"},{"line_number":778,"context_line":"    if (IS_SIG(\u0026mi-\u003econtext))"},{"line_number":779,"context_line":"    {"},{"line_number":780,"context_line":"        goto err;"}],"source_content_type":"text/x-csrc","patch_set":5,"id":"5daac845_5463efa8","line":777,"range":{"start_line":777,"start_character":41,"end_line":777,"end_character":42},"updated":"2024-10-17 15:41:00.000000000","message":"forgot to update reference to \"ls\"","commit_id":"5367be67a9ef306d3ac1abc01e0aab90a1e6bb0a"},{"author":{"_account_id":1000034,"name":"Gianmarco De Gregori","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"change_message_id":"22a10e9e5bcfc2df9a1e17e397bf5b01e94870f8","unresolved":false,"context_lines":[{"line_number":774,"context_line":"        generate_prefix(mi);"},{"line_number":775,"context_line":"    }"},{"line_number":776,"context_line":""},{"line_number":777,"context_line":"    inherit_context_child(\u0026mi-\u003econtext, \u0026m-\u003etop, ls);"},{"line_number":778,"context_line":"    if (IS_SIG(\u0026mi-\u003econtext))"},{"line_number":779,"context_line":"    {"},{"line_number":780,"context_line":"        goto err;"}],"source_content_type":"text/x-csrc","patch_set":5,"id":"46da0fcf_69468398","line":777,"range":{"start_line":777,"start_character":41,"end_line":777,"end_character":42},"in_reply_to":"5daac845_5463efa8","updated":"2024-10-23 12:59:07.000000000","message":"Done","commit_id":"5367be67a9ef306d3ac1abc01e0aab90a1e6bb0a"},{"author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"39153d9f8483bad6836055955f89ac1b4576cadf","unresolved":true,"context_lines":[{"line_number":751,"context_line":" */"},{"line_number":752,"context_line":"struct multi_instance *"},{"line_number":753,"context_line":"multi_create_instance(struct multi_context *m, const struct mroute_addr *real,"},{"line_number":754,"context_line":"                      struct link_socket *sock)"},{"line_number":755,"context_line":"{"},{"line_number":756,"context_line":"    struct gc_arena gc \u003d gc_new();"},{"line_number":757,"context_line":"    struct multi_instance *mi;"}],"source_content_type":"text/x-csrc","patch_set":10,"id":"76a11a87_3b464974","line":754,"updated":"2024-12-30 19:16:31.000000000","message":"another rename","commit_id":"f61895c9edc5c1a107becc1adfb3ddf65a0689c7"},{"author":{"_account_id":1000034,"name":"Gianmarco De Gregori","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"change_message_id":"2d183f4e1711b101f869147b7032078a412fcd74","unresolved":false,"context_lines":[{"line_number":751,"context_line":" */"},{"line_number":752,"context_line":"struct multi_instance *"},{"line_number":753,"context_line":"multi_create_instance(struct multi_context *m, const struct mroute_addr *real,"},{"line_number":754,"context_line":"                      struct link_socket *sock)"},{"line_number":755,"context_line":"{"},{"line_number":756,"context_line":"    struct gc_arena gc \u003d gc_new();"},{"line_number":757,"context_line":"    struct multi_instance *mi;"}],"source_content_type":"text/x-csrc","patch_set":10,"id":"d56445cb_e795fd77","line":754,"in_reply_to":"76a11a87_3b464974","updated":"2025-01-09 13:50:19.000000000","message":"Done","commit_id":"f61895c9edc5c1a107becc1adfb3ddf65a0689c7"},{"author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"39153d9f8483bad6836055955f89ac1b4576cadf","unresolved":true,"context_lines":[{"line_number":774,"context_line":"        generate_prefix(mi);"},{"line_number":775,"context_line":"    }"},{"line_number":776,"context_line":""},{"line_number":777,"context_line":"    inherit_context_child(\u0026mi-\u003econtext, \u0026m-\u003etop, sock);"},{"line_number":778,"context_line":"    if (IS_SIG(\u0026mi-\u003econtext))"},{"line_number":779,"context_line":"    {"},{"line_number":780,"context_line":"        goto err;"}],"source_content_type":"text/x-csrc","patch_set":10,"id":"0d46a452_d8aea7ce","line":777,"updated":"2024-12-30 19:16:31.000000000","message":"and this","commit_id":"f61895c9edc5c1a107becc1adfb3ddf65a0689c7"},{"author":{"_account_id":1000034,"name":"Gianmarco De Gregori","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"change_message_id":"2d183f4e1711b101f869147b7032078a412fcd74","unresolved":false,"context_lines":[{"line_number":774,"context_line":"        generate_prefix(mi);"},{"line_number":775,"context_line":"    }"},{"line_number":776,"context_line":""},{"line_number":777,"context_line":"    inherit_context_child(\u0026mi-\u003econtext, \u0026m-\u003etop, sock);"},{"line_number":778,"context_line":"    if (IS_SIG(\u0026mi-\u003econtext))"},{"line_number":779,"context_line":"    {"},{"line_number":780,"context_line":"        goto err;"}],"source_content_type":"text/x-csrc","patch_set":10,"id":"a0585c59_7f074ee2","line":777,"in_reply_to":"0d46a452_d8aea7ce","updated":"2025-01-09 13:50:19.000000000","message":"Done","commit_id":"f61895c9edc5c1a107becc1adfb3ddf65a0689c7"},{"author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"39153d9f8483bad6836055955f89ac1b4576cadf","unresolved":true,"context_lines":[{"line_number":3126,"context_line":""},{"line_number":3127,"context_line":"void"},{"line_number":3128,"context_line":"multi_process_float(struct multi_context *m, struct multi_instance *mi,"},{"line_number":3129,"context_line":"                    struct link_socket *sock)"},{"line_number":3130,"context_line":"{"},{"line_number":3131,"context_line":"    struct mroute_addr real \u003d {0};"},{"line_number":3132,"context_line":"    struct hash *hash \u003d m-\u003ehash;"}],"source_content_type":"text/x-csrc","patch_set":10,"id":"a496614d_446989b1","line":3129,"updated":"2024-12-30 19:16:31.000000000","message":"here","commit_id":"f61895c9edc5c1a107becc1adfb3ddf65a0689c7"},{"author":{"_account_id":1000034,"name":"Gianmarco De Gregori","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"change_message_id":"2d183f4e1711b101f869147b7032078a412fcd74","unresolved":false,"context_lines":[{"line_number":3126,"context_line":""},{"line_number":3127,"context_line":"void"},{"line_number":3128,"context_line":"multi_process_float(struct multi_context *m, struct multi_instance *mi,"},{"line_number":3129,"context_line":"                    struct link_socket *sock)"},{"line_number":3130,"context_line":"{"},{"line_number":3131,"context_line":"    struct mroute_addr real \u003d {0};"},{"line_number":3132,"context_line":"    struct hash *hash \u003d m-\u003ehash;"}],"source_content_type":"text/x-csrc","patch_set":10,"id":"aa433935_03f4722e","line":3129,"in_reply_to":"a496614d_446989b1","updated":"2025-01-09 13:50:19.000000000","message":"Done","commit_id":"f61895c9edc5c1a107becc1adfb3ddf65a0689c7"},{"author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"39153d9f8483bad6836055955f89ac1b4576cadf","unresolved":true,"context_lines":[{"line_number":3182,"context_line":"    mi-\u003econtext.c2.to_link_addr \u003d \u0026mi-\u003econtext.c2.from;"},{"line_number":3183,"context_line":""},{"line_number":3184,"context_line":"    /* inherit parent link_socket and link_socket_info */"},{"line_number":3185,"context_line":"    mi-\u003econtext.c2.link_sockets[0] \u003d sock;"},{"line_number":3186,"context_line":"    mi-\u003econtext.c2.link_socket_infos[0]-\u003elsa-\u003eactual \u003d m-\u003etop.c2.from;"},{"line_number":3187,"context_line":""},{"line_number":3188,"context_line":"    tls_update_remote_addr(mi-\u003econtext.c2.tls_multi, \u0026mi-\u003econtext.c2.from);"}],"source_content_type":"text/x-csrc","patch_set":10,"id":"cfe09b5a_44dfaba8","line":3185,"updated":"2024-12-30 19:16:31.000000000","message":"and there","commit_id":"f61895c9edc5c1a107becc1adfb3ddf65a0689c7"},{"author":{"_account_id":1000034,"name":"Gianmarco De Gregori","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"change_message_id":"2d183f4e1711b101f869147b7032078a412fcd74","unresolved":false,"context_lines":[{"line_number":3182,"context_line":"    mi-\u003econtext.c2.to_link_addr \u003d \u0026mi-\u003econtext.c2.from;"},{"line_number":3183,"context_line":""},{"line_number":3184,"context_line":"    /* inherit parent link_socket and link_socket_info */"},{"line_number":3185,"context_line":"    mi-\u003econtext.c2.link_sockets[0] \u003d sock;"},{"line_number":3186,"context_line":"    mi-\u003econtext.c2.link_socket_infos[0]-\u003elsa-\u003eactual \u003d m-\u003etop.c2.from;"},{"line_number":3187,"context_line":""},{"line_number":3188,"context_line":"    tls_update_remote_addr(mi-\u003econtext.c2.tls_multi, \u0026mi-\u003econtext.c2.from);"}],"source_content_type":"text/x-csrc","patch_set":10,"id":"d202b209_59ae6a8b","line":3185,"in_reply_to":"cfe09b5a_44dfaba8","updated":"2025-01-09 13:50:19.000000000","message":"Done","commit_id":"f61895c9edc5c1a107becc1adfb3ddf65a0689c7"},{"author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"39153d9f8483bad6836055955f89ac1b4576cadf","unresolved":true,"context_lines":[{"line_number":3332,"context_line":" */"},{"line_number":3333,"context_line":"bool"},{"line_number":3334,"context_line":"multi_process_incoming_link(struct multi_context *m, struct multi_instance *instance,"},{"line_number":3335,"context_line":"                            const unsigned int mpp_flags, struct link_socket *sock)"},{"line_number":3336,"context_line":"{"},{"line_number":3337,"context_line":"    struct gc_arena gc \u003d gc_new();"},{"line_number":3338,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":10,"id":"6cee5d39_c8c303fa","line":3335,"updated":"2024-12-30 19:16:31.000000000","message":"and here...","commit_id":"f61895c9edc5c1a107becc1adfb3ddf65a0689c7"},{"author":{"_account_id":1000034,"name":"Gianmarco De Gregori","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"change_message_id":"2d183f4e1711b101f869147b7032078a412fcd74","unresolved":false,"context_lines":[{"line_number":3332,"context_line":" */"},{"line_number":3333,"context_line":"bool"},{"line_number":3334,"context_line":"multi_process_incoming_link(struct multi_context *m, struct multi_instance *instance,"},{"line_number":3335,"context_line":"                            const unsigned int mpp_flags, struct link_socket *sock)"},{"line_number":3336,"context_line":"{"},{"line_number":3337,"context_line":"    struct gc_arena gc \u003d gc_new();"},{"line_number":3338,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":10,"id":"78a7791f_6b0bda67","line":3335,"in_reply_to":"6cee5d39_c8c303fa","updated":"2025-01-09 13:50:19.000000000","message":"Done","commit_id":"f61895c9edc5c1a107becc1adfb3ddf65a0689c7"},{"author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"39153d9f8483bad6836055955f89ac1b4576cadf","unresolved":true,"context_lines":[{"line_number":3353,"context_line":"#ifdef MULTI_DEBUG_EVENT_LOOP"},{"line_number":3354,"context_line":"        printf(\"TCP/UDP -\u003e TUN [%d]\\n\", BLEN(\u0026m-\u003etop.c2.buf));"},{"line_number":3355,"context_line":"#endif"},{"line_number":3356,"context_line":"        multi_set_pending(m, multi_get_create_instance_udp(m, \u0026floated, sock));"},{"line_number":3357,"context_line":"    }"},{"line_number":3358,"context_line":"    else"},{"line_number":3359,"context_line":"    {"}],"source_content_type":"text/x-csrc","patch_set":10,"id":"7fd9250d_8fe8e422","line":3356,"updated":"2024-12-30 19:16:31.000000000","message":"this gets a bit boring","commit_id":"f61895c9edc5c1a107becc1adfb3ddf65a0689c7"},{"author":{"_account_id":1000034,"name":"Gianmarco De Gregori","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"change_message_id":"2d183f4e1711b101f869147b7032078a412fcd74","unresolved":false,"context_lines":[{"line_number":3353,"context_line":"#ifdef MULTI_DEBUG_EVENT_LOOP"},{"line_number":3354,"context_line":"        printf(\"TCP/UDP -\u003e TUN [%d]\\n\", BLEN(\u0026m-\u003etop.c2.buf));"},{"line_number":3355,"context_line":"#endif"},{"line_number":3356,"context_line":"        multi_set_pending(m, multi_get_create_instance_udp(m, \u0026floated, sock));"},{"line_number":3357,"context_line":"    }"},{"line_number":3358,"context_line":"    else"},{"line_number":3359,"context_line":"    {"}],"source_content_type":"text/x-csrc","patch_set":10,"id":"4849bfa6_a38eaef1","line":3356,"in_reply_to":"7fd9250d_8fe8e422","updated":"2025-01-09 13:50:19.000000000","message":"Done","commit_id":"f61895c9edc5c1a107becc1adfb3ddf65a0689c7"}],"src/openvpn/multi.h":[{"author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"39153d9f8483bad6836055955f89ac1b4576cadf","unresolved":true,"context_lines":[{"line_number":175,"context_line":"    struct mbuf_set *mbuf;      /**\u003c Set of buffers for passing data"},{"line_number":176,"context_line":"                                 *   channel packets between VPN tunnel"},{"line_number":177,"context_line":"                                 *   instances. */"},{"line_number":178,"context_line":"    struct multi_protocol *multi_io;     /**\u003c State specific to OpenVPN using TCP"},{"line_number":179,"context_line":"                                          *   as external transport. */"},{"line_number":180,"context_line":"    struct ifconfig_pool *ifconfig_pool;"},{"line_number":181,"context_line":"    struct frequency_limit *new_connection_limiter;"}],"source_content_type":"text/x-csrc","patch_set":10,"id":"708a3ae7_1bc1f45f","line":178,"updated":"2024-12-30 19:16:31.000000000","message":"If it\u0027s still `specific to TCP` (as the comment says), why rename it to `multi_protocol`?  This is confusing.","commit_id":"f61895c9edc5c1a107becc1adfb3ddf65a0689c7"},{"author":{"_account_id":1000034,"name":"Gianmarco De Gregori","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"change_message_id":"2d183f4e1711b101f869147b7032078a412fcd74","unresolved":false,"context_lines":[{"line_number":175,"context_line":"    struct mbuf_set *mbuf;      /**\u003c Set of buffers for passing data"},{"line_number":176,"context_line":"                                 *   channel packets between VPN tunnel"},{"line_number":177,"context_line":"                                 *   instances. */"},{"line_number":178,"context_line":"    struct multi_protocol *multi_io;     /**\u003c State specific to OpenVPN using TCP"},{"line_number":179,"context_line":"                                          *   as external transport. */"},{"line_number":180,"context_line":"    struct ifconfig_pool *ifconfig_pool;"},{"line_number":181,"context_line":"    struct frequency_limit *new_connection_limiter;"}],"source_content_type":"text/x-csrc","patch_set":10,"id":"18a4cbd0_54aa4b1c","line":178,"in_reply_to":"708a3ae7_1bc1f45f","updated":"2025-01-09 13:50:19.000000000","message":"It gets used also by UDP, the comment was a leftover.","commit_id":"f61895c9edc5c1a107becc1adfb3ddf65a0689c7"},{"author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"39153d9f8483bad6836055955f89ac1b4576cadf","unresolved":true,"context_lines":[{"line_number":277,"context_line":"void multi_top_free(struct multi_context *m);"},{"line_number":278,"context_line":""},{"line_number":279,"context_line":"struct multi_instance *multi_create_instance(struct multi_context *m, const struct mroute_addr *real,"},{"line_number":280,"context_line":"                                             struct link_socket *sock);"},{"line_number":281,"context_line":""},{"line_number":282,"context_line":"void multi_close_instance(struct multi_context *m, struct multi_instance *mi, bool shutdown);"},{"line_number":283,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":10,"id":"d2d8645d_1d44dadd","line":280,"updated":"2024-12-30 19:16:31.000000000","message":"this","commit_id":"f61895c9edc5c1a107becc1adfb3ddf65a0689c7"},{"author":{"_account_id":1000034,"name":"Gianmarco De Gregori","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"change_message_id":"2d183f4e1711b101f869147b7032078a412fcd74","unresolved":false,"context_lines":[{"line_number":277,"context_line":"void multi_top_free(struct multi_context *m);"},{"line_number":278,"context_line":""},{"line_number":279,"context_line":"struct multi_instance *multi_create_instance(struct multi_context *m, const struct mroute_addr *real,"},{"line_number":280,"context_line":"                                             struct link_socket *sock);"},{"line_number":281,"context_line":""},{"line_number":282,"context_line":"void multi_close_instance(struct multi_context *m, struct multi_instance *mi, bool shutdown);"},{"line_number":283,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":10,"id":"048d18f2_978d730d","line":280,"in_reply_to":"d2d8645d_1d44dadd","updated":"2025-01-09 13:50:19.000000000","message":"Done","commit_id":"f61895c9edc5c1a107becc1adfb3ddf65a0689c7"},{"author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"39153d9f8483bad6836055955f89ac1b4576cadf","unresolved":true,"context_lines":[{"line_number":292,"context_line":" * updates hashtables in multi_context."},{"line_number":293,"context_line":" */"},{"line_number":294,"context_line":"void multi_process_float(struct multi_context *m, struct multi_instance *mi,"},{"line_number":295,"context_line":"                         struct link_socket *sock);"},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"#define MPP_PRE_SELECT             (1\u003c\u003c0)"},{"line_number":298,"context_line":"#define MPP_CONDITIONAL_PRE_SELECT (1\u003c\u003c1)"}],"source_content_type":"text/x-csrc","patch_set":10,"id":"f86883ac_ccce439c","line":295,"updated":"2024-12-30 19:16:31.000000000","message":"and that","commit_id":"f61895c9edc5c1a107becc1adfb3ddf65a0689c7"},{"author":{"_account_id":1000034,"name":"Gianmarco De Gregori","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"change_message_id":"2d183f4e1711b101f869147b7032078a412fcd74","unresolved":false,"context_lines":[{"line_number":292,"context_line":" * updates hashtables in multi_context."},{"line_number":293,"context_line":" */"},{"line_number":294,"context_line":"void multi_process_float(struct multi_context *m, struct multi_instance *mi,"},{"line_number":295,"context_line":"                         struct link_socket *sock);"},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"#define MPP_PRE_SELECT             (1\u003c\u003c0)"},{"line_number":298,"context_line":"#define MPP_CONDITIONAL_PRE_SELECT (1\u003c\u003c1)"}],"source_content_type":"text/x-csrc","patch_set":10,"id":"bd02fcba_e322ec4d","line":295,"in_reply_to":"f86883ac_ccce439c","updated":"2025-01-09 13:50:19.000000000","message":"Done","commit_id":"f61895c9edc5c1a107becc1adfb3ddf65a0689c7"},{"author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"39153d9f8483bad6836055955f89ac1b4576cadf","unresolved":true,"context_lines":[{"line_number":360,"context_line":" * @param sock           - Socket where the packet was received."},{"line_number":361,"context_line":" */"},{"line_number":362,"context_line":"bool multi_process_incoming_link(struct multi_context *m, struct multi_instance *instance, const unsigned int mpp_flags,"},{"line_number":363,"context_line":"                                 struct link_socket *sock);"},{"line_number":364,"context_line":""},{"line_number":365,"context_line":""},{"line_number":366,"context_line":"/**"}],"source_content_type":"text/x-csrc","patch_set":10,"id":"f67a320c_f48331b4","line":363,"updated":"2024-12-30 19:16:31.000000000","message":"and yet another one","commit_id":"f61895c9edc5c1a107becc1adfb3ddf65a0689c7"},{"author":{"_account_id":1000034,"name":"Gianmarco De Gregori","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"change_message_id":"2d183f4e1711b101f869147b7032078a412fcd74","unresolved":false,"context_lines":[{"line_number":360,"context_line":" * @param sock           - Socket where the packet was received."},{"line_number":361,"context_line":" */"},{"line_number":362,"context_line":"bool multi_process_incoming_link(struct multi_context *m, struct multi_instance *instance, const unsigned int mpp_flags,"},{"line_number":363,"context_line":"                                 struct link_socket *sock);"},{"line_number":364,"context_line":""},{"line_number":365,"context_line":""},{"line_number":366,"context_line":"/**"}],"source_content_type":"text/x-csrc","patch_set":10,"id":"9169a686_317e9b71","line":363,"in_reply_to":"f67a320c_f48331b4","updated":"2025-01-09 13:50:19.000000000","message":"Done","commit_id":"f61895c9edc5c1a107becc1adfb3ddf65a0689c7"},{"author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"08a01ee976a4d8f375e2f60b6b6c43458979390b","unresolved":true,"context_lines":[{"line_number":177,"context_line":"                                 *   instances. */"},{"line_number":178,"context_line":"    struct multi_io *multi_io;     /**\u003c State specific to OpenVPN using both"},{"line_number":179,"context_line":"                                    *   TCP and UDP as external"},{"line_number":180,"context_line":"                                    *   transport. */"},{"line_number":181,"context_line":"    struct ifconfig_pool *ifconfig_pool;"},{"line_number":182,"context_line":"    struct frequency_limit *new_connection_limiter;"},{"line_number":183,"context_line":"    struct initial_packet_rate_limit *initial_rate_limiter;"}],"source_content_type":"text/x-csrc","patch_set":13,"id":"d62d69ef_43444458","line":180,"updated":"2025-01-23 17:50:33.000000000","message":"getting close... but this comment does not make sense.  What is it that is stored here?  Are there other protocols but UDP and TCP?","commit_id":"7236d5f1e796d1b475dde85dfb752a114b3db737"},{"author":{"_account_id":1000034,"name":"Gianmarco De Gregori","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"change_message_id":"90361dfc8e29e9ca0abe88aa5466fbd6ebef0156","unresolved":false,"context_lines":[{"line_number":177,"context_line":"                                 *   instances. */"},{"line_number":178,"context_line":"    struct multi_io *multi_io;     /**\u003c State specific to OpenVPN using both"},{"line_number":179,"context_line":"                                    *   TCP and UDP as external"},{"line_number":180,"context_line":"                                    *   transport. */"},{"line_number":181,"context_line":"    struct ifconfig_pool *ifconfig_pool;"},{"line_number":182,"context_line":"    struct frequency_limit *new_connection_limiter;"},{"line_number":183,"context_line":"    struct initial_packet_rate_limit *initial_rate_limiter;"}],"source_content_type":"text/x-csrc","patch_set":13,"id":"abe81f56_aadfe850","line":180,"in_reply_to":"d62d69ef_43444458","updated":"2025-01-24 11:46:26.000000000","message":"Done","commit_id":"7236d5f1e796d1b475dde85dfb752a114b3db737"}]}
