)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"86f468bd2e4d26b8d52e1046f0264902589c0e50","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"58d97922_55c17ab7","updated":"2024-09-25 14:21:29.000000000","message":"Logic backwards, I think.","commit_id":"f4222becb32af105ef6278cba50944ed9f8d203c"}],"src/openvpn/ps.c":[{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"86f468bd2e4d26b8d52e1046f0264902589c0e50","unresolved":true,"context_lines":[{"line_number":234,"context_line":"        }"},{"line_number":235,"context_line":"        else"},{"line_number":236,"context_line":"        {"},{"line_number":237,"context_line":"            if (!socketpair(AF_UNIX, SOCK_DGRAM, 0, sd_null))"},{"line_number":238,"context_line":"            {"},{"line_number":239,"context_line":"                msg(M_WARN|M_ERRNO, \"PORT SHARE: socketpair failed -- unable to communicate with background process \""},{"line_number":240,"context_line":"                    \"(%d, %d)\", sd, sd_send);"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"a89388f2_ba42e06c","line":237,"updated":"2024-09-25 14:21:29.000000000","message":"Shouldn\u0027t that test for -1?","commit_id":"f4222becb32af105ef6278cba50944ed9f8d203c"},{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"8c2985af1596a7f6c11925e288302fddd5f0589f","unresolved":false,"context_lines":[{"line_number":234,"context_line":"        }"},{"line_number":235,"context_line":"        else"},{"line_number":236,"context_line":"        {"},{"line_number":237,"context_line":"            if (!socketpair(AF_UNIX, SOCK_DGRAM, 0, sd_null))"},{"line_number":238,"context_line":"            {"},{"line_number":239,"context_line":"                msg(M_WARN|M_ERRNO, \"PORT SHARE: socketpair failed -- unable to communicate with background process \""},{"line_number":240,"context_line":"                    \"(%d, %d)\", sd, sd_send);"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"b573480e_0d81a26d","line":237,"in_reply_to":"a89388f2_ba42e06c","updated":"2025-07-22 14:42:15.000000000","message":"Done","commit_id":"f4222becb32af105ef6278cba50944ed9f8d203c"},{"author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"a11a47722132dde8872bcfecafda6d6d271f7321","unresolved":true,"context_lines":[{"line_number":851,"context_line":"     * Make a socket for foreground and background processes"},{"line_number":852,"context_line":"     * to communicate."},{"line_number":853,"context_line":"     */"},{"line_number":854,"context_line":"    if (!(socketpair(PF_UNIX, SOCK_DGRAM, 0, fd) \u003d\u003d 0))"},{"line_number":855,"context_line":"    {"},{"line_number":856,"context_line":"        msg(M_WARN, \"PORT SHARE: socketpair call failed\");"},{"line_number":857,"context_line":"        goto error;"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"299616be_4ad3018f","line":854,"updated":"2024-09-26 12:58:02.000000000","message":"can we please not do double-negate-conditions for standard syscall return value checking??  `\u003d\u003d -1` or `\u003c0` is perfectly fine, according to the manpage.  My brain hurts.","commit_id":"3380ad02e678482e5dabb720403a040430afb7ab"},{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"0659d947f2fdfe0e8a86056db3b4de576c132a92","unresolved":true,"context_lines":[{"line_number":853,"context_line":"     */"},{"line_number":854,"context_line":"    if (!(socketpair(PF_UNIX, SOCK_DGRAM, 0, fd) \u003d\u003d 0))"},{"line_number":855,"context_line":"    {"},{"line_number":856,"context_line":"        msg(M_WARN, \"PORT SHARE: socketpair call failed\");"},{"line_number":857,"context_line":"        goto error;"},{"line_number":858,"context_line":"    }"},{"line_number":859,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":2,"id":"ba250b0d_b7b0eda3","line":856,"range":{"start_line":856,"start_character":26,"end_line":856,"end_character":31},"updated":"2024-09-26 12:53:54.000000000","message":"Should we add M_ERRNO here while at it?","commit_id":"3380ad02e678482e5dabb720403a040430afb7ab"}]}