)]}'
{"id":"openvpn~772","triplet_id":"openvpn~master~I9966636163c7dfa208d26f1cadbf5b81937f3a34","project":"openvpn","branch":"master","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2024-09-25 16:53:29.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2024-09-25 16:53:29.000000000","reason":"Change was submitted"}},"hashtags":["mailsubmitted"],"change_id":"I9966636163c7dfa208d26f1cadbf5b81937f3a34","subject":"Remove null check after checking for checking for did_open_tun","status":"MERGED","created":"2024-09-25 14:26:09.000000000","updated":"2024-09-25 16:53:29.000000000","submitted":"2024-09-25 16:53:29.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"772","meta_rev_id":"474adb19308c50eeb3e8ce22d3fa7ca71c9ea512","_number":772,"virtual_id_number":772,"owner":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"default_value":0}},"removable_reviewers":[{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-09-25 14:26:10.000000000","updated_by":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2024-09-25 14:26:10.000000000","updated_by":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"reviewer":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"state":"REVIEWER"},{"updated":"2024-09-25 15:10:41.000000000","updated_by":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"state":"REVIEWER"}],"messages":[{"id":"4989fde8ee7250ce728627dafcdf71bb8544e2c4","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2024-09-25 14:26:09.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"94253c21aedf6f121861a2af91d994fe98bbcfdb","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2024-09-25 15:10:41.000000000","message":"Patch Set 1: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"b746609634c7b2740e3a28c9d46c365517c73271","tag":"autogenerated:gerrit:setHashtag","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2024-09-25 16:12:33.000000000","message":"Hashtag added: mailsubmitted","accounts_in_message":[],"_revision_number":1},{"id":"474adb19308c50eeb3e8ce22d3fa7ca71c9ea512","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2024-09-25 16:53:29.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"a8cc97f94f3e7bb52270ca2acf89804093535839","revisions":{"ad12105a3318661b293fcb6b5383a95b15ad0806":{"kind":"REWORK","_number":1,"created":"2024-09-25 14:26:09.000000000","uploader":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"ref":"refs/changes/72/772/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/72/772/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/72/772/1 \u0026\u0026 git checkout -b change-772 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/72/772/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/72/772/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/72/772/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/72/772/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/72/772/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"ead7090b7e741f1a97586cbf5e29410f39733243","subject":"Fix check for struct cmsg not detecting the struct"}],"author":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2024-09-25 14:16:48.000000000","tz":120},"committer":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2024-09-25 14:16:48.000000000","tz":120},"subject":"Remove null check after checking for checking for did_open_tun","message":"Remove null check after checking for checking for did_open_tun\n\nIf we indicate that the tun device has been opened the c1.tuntap struct\nis guaranteed to be defined. This extra null check is something that\nCoverity flags as we access a do a null check after already accessing fields\nof tuntap\n\nChange-Id: I9966636163c7dfa208d26f1cadbf5b81937f3a34\n"},"branch":"refs/heads/master"},"a8cc97f94f3e7bb52270ca2acf89804093535839":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":2,"created":"2024-09-25 16:53:29.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/72/772/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/72/772/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/72/772/2 \u0026\u0026 git checkout -b change-772 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/72/772/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/72/772/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/72/772/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/72/772/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/72/772/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"f77f298979851687ab8fe3948b82cfac27c95cf8","subject":"Fix check for CMake not detecting struct cmsg"}],"author":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2024-09-25 15:11:04.000000000","tz":120},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2024-09-25 16:49:15.000000000","tz":120},"subject":"Remove null check after checking for checking for did_open_tun","message":"Remove null check after checking for checking for did_open_tun\n\nIf we indicate that the tun device has been opened the c1.tuntap struct\nis guaranteed to be defined. This extra null check is something that\nCoverity flags as we access a do a null check after already accessing fields\nof tuntap\n\nChange-Id: I9966636163c7dfa208d26f1cadbf5b81937f3a34\nSigned-off-by: Arne Schwabe \u003carne-openvpn@rfc2549.org\u003e\nAcked-by: Gert Doering \u003cgert@greenie.muc.de\u003e\nMessage-Id: \u003c20240925151104.13036-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg29447.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}