)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"906a41ad54f9cec55be1e8f620deb52e21ea1e3b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d1e1a72a_ad451fab","updated":"2024-10-04 06:45:15.000000000","message":"this does not work the way it is intended","commit_id":"358d4c5738e16b007502a8dbcefea832ddf98689"},{"author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"8d61236c3f069e12fd9170df4c584a293c78e921","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"39fd8ec7_b9b8bbde","updated":"2024-10-23 20:57:59.000000000","message":"getting close... but I really think we should error out and include diagnostics if \"kill -9\" is necessary.","commit_id":"892fcf1aedac6d82f25a81b91c5321406b12c67e"},{"author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"c84aaa274086dff947f0e594acf759039405c353","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"6e8297e5_010f4d52","updated":"2024-10-24 18:41:55.000000000","message":"It fails to see \"does the process still live?\" due to `ps -p`, see comment at the corresponding line.  Changing that to `RUN_SUDO kill -0 $SERVER_PID 2\u003e/dev/null` yields the desired result (server hacked to maliciously ignore SIGTERM 2x)\n\n```\nWaiting for servers to exit\nERROR: had to send SIGKILL to server with pid 10186!\nERROR: had to send SIGKILL to server with pid 10189!\nFAIL: t_server_null.sh\n```\n\nnow, while at it, we should actually print which server is \"10186\" and \"10189\" so it\u0027s easier to find the right log...","commit_id":"db8ef083eea6e39accf4efbdfbcc20843a3c91d2"},{"author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"e4747663a14ae8194e09814d1a54ec6475322253","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"281e13da_425a49d2","updated":"2024-10-25 09:02:19.000000000","message":"getting closer","commit_id":"17cddbdff282933251dc633940762155dc9b4760"},{"author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"5909d9d4f6b21801cdc3924781201d820918ce02","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"04c6930c_253872f0","updated":"2024-10-25 10:34:56.000000000","message":"Waiting for servers to exit\nERROR: had to send SIGKILL to server t_server_null_server-1194_udp with pid 66227!\nTail of server log:\n2024-10-25 12:33:41 127.0.0.1:57874 peer info: IV_PROTO\u003d2974\n2024-10-25 12:33:41 127.0.0.1:57874 peer info: IV_LZO_STUB\u003d1\n...\n2024-10-25 12:34:18 MPS: ignore signal\nFAIL: t_server_null.sh","commit_id":"2bd1e797de7a5566ae7f48758e53ecd9ecdc2629"}],"tests/t_server_null.sh":[{"author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"e4747663a14ae8194e09814d1a54ec6475322253","unresolved":true,"context_lines":[{"line_number":69,"context_line":"# that this script does not exit before all --dev null servers are dead and"},{"line_number":70,"context_line":"# their network interfaces are gone. Otherwise t_client.sh will fail because"},{"line_number":71,"context_line":"# pre and post ifconfig output does not match."},{"line_number":72,"context_line":"wait"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":". ./t_server_null_default.rc"},{"line_number":75,"context_line":""}],"source_content_type":"text/x-sh","patch_set":8,"id":"eede43c8_d60b792c","line":72,"updated":"2024-10-25 09:02:19.000000000","message":"remembering the pid of the t_server_null_server.sh job after launching (`server_sh_pid\u003d$!`) and then calling `wait $server_sh_pid` will nicely deliver child program exit status in `$!`, without having to dance around with an extra file that needs to be created, rc-filed, tested-for.\n\n`wait` without a pid specified does not return child return code, which is somewhat annoying.","commit_id":"17cddbdff282933251dc633940762155dc9b4760"}],"tests/t_server_null_server.sh":[{"author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"8d61236c3f069e12fd9170df4c584a293c78e921","unresolved":true,"context_lines":[{"line_number":103,"context_line":"    if [ $count -ge $maxcount ]; then"},{"line_number":104,"context_line":"        $RUN_SUDO $KILL_EXEC -9 \"${SERVER_PID}\""},{"line_number":105,"context_line":"        echo \"WARNING: had to send SIGKILL to server with pid ${SERVER_PID}!\""},{"line_number":106,"context_line":"    fi"},{"line_number":107,"context_line":"done"}],"source_content_type":"text/x-sh","patch_set":3,"id":"e8a12af1_7c789c6a","line":106,"updated":"2024-10-23 20:57:59.000000000","message":"I think we should make this a \"test fail\".  If the server needs to be hard killed, something is wrong with the server, and we should look in the (soon-persistent :-) ) logs.\n\nMaybe we could even output a \"tail -20\" or so of the logfile in this case, so failures can be investigated without logging into the machine?","commit_id":"892fcf1aedac6d82f25a81b91c5321406b12c67e"},{"author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"e4747663a14ae8194e09814d1a54ec6475322253","unresolved":false,"context_lines":[{"line_number":103,"context_line":"    if [ $count -ge $maxcount ]; then"},{"line_number":104,"context_line":"        $RUN_SUDO $KILL_EXEC -9 \"${SERVER_PID}\""},{"line_number":105,"context_line":"        echo \"WARNING: had to send SIGKILL to server with pid ${SERVER_PID}!\""},{"line_number":106,"context_line":"    fi"},{"line_number":107,"context_line":"done"}],"source_content_type":"text/x-sh","patch_set":3,"id":"ea5470ba_cd74abb4","line":106,"in_reply_to":"e8a12af1_7c789c6a","updated":"2024-10-25 09:02:19.000000000","message":"Done","commit_id":"892fcf1aedac6d82f25a81b91c5321406b12c67e"},{"author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"c84aaa274086dff947f0e594acf759039405c353","unresolved":true,"context_lines":[{"line_number":97,"context_line":"    maxcount\u003d75"},{"line_number":98,"context_line":"    while [ $count -le $maxcount ]"},{"line_number":99,"context_line":"    do"},{"line_number":100,"context_line":"        ps -p \"${SERVER_PID}\" \u003e /dev/null || break"},{"line_number":101,"context_line":"        count\u003d$(( count + 1))"},{"line_number":102,"context_line":"        sleep 0.2"},{"line_number":103,"context_line":"    done"}],"source_content_type":"text/x-sh","patch_set":5,"id":"3af78b34_8263c5b3","line":100,"updated":"2024-10-24 18:41:55.000000000","message":"this does not work on systems where root processes are not visible to normal users, like \"FreeBSD with `security.bsd.see_other_uids\u003d0`\" set.  We\u0027ve been here before - testing for \"does the process still live?\" needs to be done with `$RUN_SUDO kill -0 $SERVER_PID`","commit_id":"db8ef083eea6e39accf4efbdfbcc20843a3c91d2"},{"author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"e4747663a14ae8194e09814d1a54ec6475322253","unresolved":true,"context_lines":[{"line_number":107,"context_line":"        SERVER_NAME\u003d$(basename $PID_FILE|cut -d . -f 1)"},{"line_number":108,"context_line":"        echo \"ERROR: had to send SIGKILL to server ${SERVER_NAME} with pid ${SERVER_PID}!\""},{"line_number":109,"context_line":"        echo \"Tail of server log:\""},{"line_number":110,"context_line":"        tail -n 20 \"${t_server_null_logdir}/${SERVER_NAME}.log\""},{"line_number":111,"context_line":"        touch $SERVER_KILL_FAIL_FILE"},{"line_number":112,"context_line":"    fi"},{"line_number":113,"context_line":"done"}],"source_content_type":"text/x-sh","patch_set":8,"id":"81b60a59_9f45dafb","line":110,"updated":"2024-10-25 09:02:19.000000000","message":"this wants a `$RUN_SUDO` because root-owned logs are not readable otherwise (or we need to precreate them before openvpn startup)...\n\n```\nWaiting for servers to exit\nERROR: had to send SIGKILL to server t_server_null_server-1194_udp with pid 23977!\nTail of server log:\ntail: t_server_null-fbsd14bb.ov.greenie.net-20241025-105632/t_server_null_server-1194_udp.log: Permission denied\nERROR: had to send SIGKILL to server t_server_null_server-1195_tcp with pid 23983!\nTail of server log:\ntail: t_server_null-fbsd14bb.ov.greenie.net-20241025-105632/t_server_null_server-1195_tcp.log: Permission denied\nFAIL: t_server_null.sh\n```","commit_id":"17cddbdff282933251dc633940762155dc9b4760"},{"author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"5909d9d4f6b21801cdc3924781201d820918ce02","unresolved":false,"context_lines":[{"line_number":107,"context_line":"        SERVER_NAME\u003d$(basename $PID_FILE|cut -d . -f 1)"},{"line_number":108,"context_line":"        echo \"ERROR: had to send SIGKILL to server ${SERVER_NAME} with pid ${SERVER_PID}!\""},{"line_number":109,"context_line":"        echo \"Tail of server log:\""},{"line_number":110,"context_line":"        tail -n 20 \"${t_server_null_logdir}/${SERVER_NAME}.log\""},{"line_number":111,"context_line":"        touch $SERVER_KILL_FAIL_FILE"},{"line_number":112,"context_line":"    fi"},{"line_number":113,"context_line":"done"}],"source_content_type":"text/x-sh","patch_set":8,"id":"6fdd0172_a2fa6e00","line":110,"in_reply_to":"81b60a59_9f45dafb","updated":"2024-10-25 10:34:56.000000000","message":"Done","commit_id":"17cddbdff282933251dc633940762155dc9b4760"}]}