)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"2d25c8e4f75f446f0907e971492eb978daad81f2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"81b2344d_c3c7a99b","updated":"2024-10-04 07:06:56.000000000","message":"needs a bit of polish","commit_id":"781328842035c72a1f8db6663d1c6f4ff6478e4c"}],"tests/t_server_null_server.sh":[{"author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"2d25c8e4f75f446f0907e971492eb978daad81f2","unresolved":true,"context_lines":[{"line_number":4,"context_line":"    server_name\u003d$1"},{"line_number":5,"context_line":"    server_exec\u003d$2"},{"line_number":6,"context_line":"    server_conf\u003d$3"},{"line_number":7,"context_line":"    log\u003d\"${server_name}.log\""},{"line_number":8,"context_line":"    status\u003d\"${server_name}.status\""},{"line_number":9,"context_line":"    pid\u003d\"${server_name}.pid\""},{"line_number":10,"context_line":""}],"source_content_type":"text/x-sh","patch_set":1,"id":"186bd796_c642bb4c","line":7,"updated":"2024-10-04 07:06:56.000000000","message":"maybe just do `log\u003d\"$t_server_null_logdir/$server_name.log\"` here, to avoid having to repeat the \"logdir\" part below?","commit_id":"781328842035c72a1f8db6663d1c6f4ff6478e4c"},{"author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"2d25c8e4f75f446f0907e971492eb978daad81f2","unresolved":true,"context_lines":[{"line_number":9,"context_line":"    pid\u003d\"${server_name}.pid\""},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"    if [ -z \"${RUN_SUDO}\" ]; then"},{"line_number":12,"context_line":"        rm -f \"${status}\" \"${log}\" \"${pid}\""},{"line_number":13,"context_line":"        \"${server_exec}\" \\"},{"line_number":14,"context_line":"         $server_conf \\"},{"line_number":15,"context_line":"         --status \"${status}\" 1 \\"}],"source_content_type":"text/x-sh","patch_set":1,"id":"3986d2c5_84d97934","line":12,"updated":"2024-10-04 07:06:56.000000000","message":"I\u0027d remove this line - at least removing ${log} is not serving a useful purpose anymore, but also removing the other files is just \"needless code\" as OpenVPN will create them new anyway","commit_id":"781328842035c72a1f8db6663d1c6f4ff6478e4c"},{"author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"2d25c8e4f75f446f0907e971492eb978daad81f2","unresolved":true,"context_lines":[{"line_number":17,"context_line":"         --writepid \"${pid}\" \\"},{"line_number":18,"context_line":"         --explicit-exit-notify 3"},{"line_number":19,"context_line":"    else"},{"line_number":20,"context_line":"        $RUN_SUDO rm -f \"${status}\" \"${log}\" \"${pid}\""},{"line_number":21,"context_line":"        $RUN_SUDO \"${server_exec}\" \\"},{"line_number":22,"context_line":"                   $server_conf \\"},{"line_number":23,"context_line":"                   --status \"${status}\" 1 \\"}],"source_content_type":"text/x-sh","patch_set":1,"id":"52f6e109_1d63b541","line":20,"updated":"2024-10-04 07:06:56.000000000","message":"same here","commit_id":"781328842035c72a1f8db6663d1c6f4ff6478e4c"}]}