)]}'
{"id":"openvpn~778","triplet_id":"openvpn~master~I7a852eb5fafae3a0e85dd89ea6d4c91fcf2fab4e","project":"openvpn","branch":"master","topic":"doxygen","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2024-12-27 16:10:05.000000000","reason":"removed on reply"},"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2024-12-27 17:31:05.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I7a852eb5fafae3a0e85dd89ea6d4c91fcf2fab4e","subject":"Review doxygen warnings","status":"MERGED","created":"2024-10-10 11:46:11.000000000","updated":"2024-12-27 17:31:05.000000000","submitted":"2024-12-27 17:31:05.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"778-doxygen","meta_rev_id":"120389f1f96afeb478bdf13ed6198da5d8ca2fed","_number":778,"virtual_id_number":778,"owner":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-10-10 11:46:12.000000000","updated_by":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2024-10-10 11:46:12.000000000","updated_by":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"}],"messages":[{"id":"d63023b212bef339432d63910bce1841ddc22745","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2024-10-10 11:46:11.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"48c18c23eef76047af3437f5a80d18eaac821c00","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2024-12-27 14:20:44.000000000","message":"Patch Set 2: Patch Set 1 was rebased","accounts_in_message":[],"_revision_number":2},{"id":"fc10673b80c2b089a49790ff206365cd3b8558f0","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2024-12-27 16:10:05.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"120389f1f96afeb478bdf13ed6198da5d8ca2fed","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2024-12-27 17:31:05.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"ccdffc08f3c9e672f68755876138e1f50468575f","revisions":{"8ad28f443e16404a16e810fa6ca56b4f140069fc":{"kind":"REWORK","_number":1,"created":"2024-10-10 11:46:11.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/78/778/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/78/778/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/78/778/1 \u0026\u0026 git checkout -b change-778 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/78/778/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/78/778/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/78/778/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/78/778/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/78/778/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"5ccaa49e0323ce468b156b3fa0930f7840050387","subject":"t_client.sh: conditionally skip ifconfig+route check"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2024-10-10 11:30:51.000000000","tz":120},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2024-10-10 11:45:29.000000000","tz":120},"subject":"Review doxygen warnings","message":"Review doxygen warnings\n\nWe write doxygen comments but we do not verify them. So\nquite some errors have crept in. Trying to reduce them\nby reviewing the warnings output of doxygen and addressing\nmost of them.\n\nDid generally ignore \"The following parameter is not documented\"\nwarnings (except those caused by typos). Fixing those will\nrequire more work.\n\nUsual errors fixed:\n - Wrong usage of @file\n - Wrong spellings of @param\n - Desync between function declaration and comment\n   (usually param names)\n\nChange-Id: I7a852eb5fafae3a0e85dd89ea6d4c91fcf2fab4e\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"9b08bd9465e9bd346ed7ee87cfb9efa048671e52":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2024-12-27 14:20:44.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/78/778/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/78/778/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/78/778/2 \u0026\u0026 git checkout -b change-778 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/78/778/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/78/778/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/78/778/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/78/778/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/78/778/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"e4c68b23e26efcfa301ae4aec4f4fc65384ab9eb","subject":"Ensure that Python3 is available"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2024-10-10 11:30:51.000000000","tz":120},"committer":{"name":"flichtenheld","email":"frank@lichtenheld.com","date":"2024-12-27 14:20:44.000000000","tz":0},"subject":"Review doxygen warnings","message":"Review doxygen warnings\n\nWe write doxygen comments but we do not verify them. So\nquite some errors have crept in. Trying to reduce them\nby reviewing the warnings output of doxygen and addressing\nmost of them.\n\nDid generally ignore \"The following parameter is not documented\"\nwarnings (except those caused by typos). Fixing those will\nrequire more work.\n\nUsual errors fixed:\n - Wrong usage of @file\n - Wrong spellings of @param\n - Desync between function declaration and comment\n   (usually param names)\n\nChange-Id: I7a852eb5fafae3a0e85dd89ea6d4c91fcf2fab4e\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master","description":"Rebase"},"ccdffc08f3c9e672f68755876138e1f50468575f":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":3,"created":"2024-12-27 17:31:05.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/78/778/3","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/78/778/3","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/78/778/3 \u0026\u0026 git checkout -b change-778 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/78/778/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/78/778/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/78/778/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/78/778/3","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/78/778/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"5bbf0aa484470486fcc2f491fba81605aa8649ed","subject":"Change API of init_key_ctx to use struct key_parameters"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2024-12-27 16:16:48.000000000","tz":60},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2024-12-27 17:30:22.000000000","tz":60},"subject":"Review doxygen warnings","message":"Review doxygen warnings\n\nWe write doxygen comments but we do not verify them. So\nquite some errors have crept in. Trying to reduce them\nby reviewing the warnings output of doxygen and addressing\nmost of them.\n\nDid generally ignore \"The following parameter is not documented\"\nwarnings (except those caused by typos). Fixing those will\nrequire more work.\n\nUsual errors fixed:\n - Wrong usage of @file\n - Wrong spellings of @param\n - Desync between function declaration and comment\n   (usually param names)\n\nChange-Id: I7a852eb5fafae3a0e85dd89ea6d4c91fcf2fab4e\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\nAcked-by: Arne Schwabe \u003carne-openvpn@rfc2549.org\u003e\nMessage-Id: \u003c20241227161648.3350-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg30256.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}